[{"id":3678849,"web_url":"http://patchwork.ozlabs.org/comment/3678849/","msgid":"","list_archive_url":null,"date":"2026-04-17T17:46:35","subject":"Re: [PATCH 12/17] monitor: hmp_gva2gpa: Don't page-align\n cpu_get_phys_addr_debug() arg and return","submitter":{"id":86099,"url":"http://patchwork.ozlabs.org/api/people/86099/","name":"Dr. David Alan Gilbert","email":"dave@treblig.org"},"content":"* Peter Maydell (peter.maydell@linaro.org) wrote:\n> In hmp_gva2gpa() we currently have a workaround for not all implementations\n> of get_phys_addr_debug handling non-page-aligned addresses: we round the\n> input address from the user down to the target page boundary before the\n> call and then add the page offset back to the returned value.\n> \n> Now that we guarantee that all implementations will return the correct\n> exact physaddr for a virtual address, we can drop this handling.\n> \n> Signed-off-by: Peter Maydell \n> ---\n> monitor/hmp-cmds.c | 5 ++---\n> 1 file changed, 2 insertions(+), 3 deletions(-)\n> \n> diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c\n> index e6d8322bcc..f8380bda58 100644\n> --- a/monitor/hmp-cmds.c\n> +++ b/monitor/hmp-cmds.c\n> @@ -720,12 +720,11 @@ void hmp_gva2gpa(Monitor *mon, const QDict *qdict)\n> return;\n> }\n> \n> - gpa = cpu_get_phys_addr_debug(cs, addr & TARGET_PAGE_MASK);\n> + gpa = cpu_get_phys_addr_debug(cs, addr);\n> if (gpa == -1) {\n> monitor_printf(mon, \"Unmapped\\n\");\n> } else {\n> - monitor_printf(mon, \"gpa: 0x%\" HWADDR_PRIx \"\\n\",\n> - gpa + (addr & ~TARGET_PAGE_MASK));\n> + monitor_printf(mon, \"gpa: 0x%\" HWADDR_PRIx \"\\n\", gpa);\n\nFor HMP:\n\nAcked-by: Dr. David Alan Gilbert \n\n> }\n> }\n> \n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=treblig.org header.i=@treblig.org header.a=rsa-sha256\n header.s=bytemarkmx header.b=gU5XOU65;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fy2Qc75kLz1yDF\n\tfor ; Sat, 18 Apr 2026 03:47:35 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDnHT-0002kM-Hr; Fri, 17 Apr 2026 13:47:05 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDnHD-0002gu-Hf; Fri, 17 Apr 2026 13:46:50 -0400","from mx.treblig.org ([2a00:1098:5b::1])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDnHA-00059X-WB; Fri, 17 Apr 2026 13:46:47 -0400","from dg by mx.treblig.org with local (Exim 4.98.2)\n (envelope-from ) id 1wDnH1-000000091FN-3RaP;\n Fri, 17 Apr 2026 17:46:35 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org\n ; s=bytemarkmx;\n h=Content-Type:MIME-Version:Message-ID:Subject:From:Date:From\n :Subject; bh=oxM6wnbVcSyAC9yeVxfQnW+bPrBukYxactIiN0rJ0z0=; b=gU5XOU65gc8ZQDiZ\n wqyQAoLJPRsXnBGa3fnTCDpTwiptaRD3lUtrNla+VnSHxrhdIqe1nfpslxewD8Zgnmc3XIRET64wf\n 5HoBwW0TyGk/mu76R2+Hy8eS6CrFjuRqxrv6d8z8iiTfQEq0KQcgu1rk0WVz5DsvGvLnxqWnPhF3q\n 55CUMSkdduOSLL/ewI4ODWjS3RsqQXhSUJH89Q1KERiL/AejMVs1erMSMBprTOyzYv1AEAGIkuNcd\n EiW8+AQQNlyWh8sIyA6fLGamHtpEFgEiHy9YflFb59n34JX2/QyB6yYKA4oq8rZjak+nnKtoCT4e/\n evCFVpW1Y2tP3fUucA==;","Date":"Fri, 17 Apr 2026 17:46:35 +0000","From":"\"Dr. David Alan Gilbert\" ","To":"Peter Maydell ","Cc":"qemu-arm@nongnu.org, qemu-devel@nongnu.org, qemu-ppc@nongnu.org,\n qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, Philippe =?iso-8859-1?q?Mathi?=\n\t=?iso-8859-1?q?eu-Daud=E9?= ,\n Marcel Apfelbaum ,\n Yanan Wang , Zhao Liu ,\n Paolo Bonzini ,\n Richard Henderson , Alex =?iso-8859-1?q?Benn?=\n\t=?iso-8859-1?q?=E9e?= ,\n Alexandre Iooss , Mahmoud Mandour ,\n Peter Xu , \"Edgar E. Iglesias\" ,\n Jiaxun Yang , Nicholas Piggin ,\n Chinmay Rath , Glenn Miles ,\n Palmer Dabbelt ,\n Alistair Francis , Weiwei Li ,\n Daniel Henrique Barboza ,\n Liu Zhiwei ,\n Chao Liu , Ilya Leoshkevich ,\n David Hildenbrand ,\n Mark Cave-Ayland ,\n Artyom Tarasenko ","Subject":"Re: [PATCH 12/17] monitor: hmp_gva2gpa: Don't page-align\n cpu_get_phys_addr_debug() arg and return","Message-ID":"","References":"<20260417173105.1648172-1-peter.maydell@linaro.org>\n <20260417173105.1648172-13-peter.maydell@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","In-Reply-To":"<20260417173105.1648172-13-peter.maydell@linaro.org>","X-Chocolate":"70 percent or better cocoa solids preferably","X-Operating-System":"Linux/6.12.74+deb13+1-amd64 (x86_64)","X-Uptime":"17:45:25 up 35 days, 18:58, 3 users, load average: 0.00, 0.03,\n 0.00","User-Agent":"Mutt/2.2.13 (2024-03-09)","Received-SPF":"pass client-ip=2a00:1098:5b::1; envelope-from=dg@treblig.org;\n helo=mx.treblig.org","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-ppc@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]