[{"id":3678862,"web_url":"http://patchwork.ozlabs.org/comment/3678862/","msgid":"","list_archive_url":null,"date":"2026-04-17T18:58:12","subject":"Re: [PATCH 04/30] Change `struct gori_stmt_info` to `class\n gori_stmt_info` to align tags","submitter":{"id":91428,"url":"http://patchwork.ozlabs.org/api/people/91428/","name":"Andrew Pinski","email":"andrew.pinski@oss.qualcomm.com"},"content":"On Fri, Apr 17, 2026 at 10:27 AM Torbjörn SVENSSON\n wrote:\n>\n> Building GCC with clang gives warnings like:\n> warning: struct 'gori_stmt_info' was previously declared as a class; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Wmismatched-tags]\n>\n> gcc/ChangeLog:\n>\n> * gimple-range-gori.cc: Change `struct gori_stmt_info` to `class\n> gori_stmt_info`.\n>\n> Signed-off-by: Torbjörn SVENSSON \n> ---\n> gcc/gimple-range-gori.cc | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/gcc/gimple-range-gori.cc b/gcc/gimple-range-gori.cc\n> index 1c0a2b9f797..c355e3429b1 100644\n> --- a/gcc/gimple-range-gori.cc\n> +++ b/gcc/gimple-range-gori.cc\n> @@ -1616,7 +1616,7 @@ gori_stmt_info::gori_stmt_info (vrange &lhs, gimple *stmt, range_query *q)\n> static void\n> gori_calc_operands (vrange &lhs, gimple *stmt, ssa_cache &r, range_query *q)\n> {\n> - struct gori_stmt_info si(lhs, stmt, q);\n> + class gori_stmt_info si(lhs, stmt, q);\n\nLike for an example here:\ns/struct// is better than keeping class around.\n\n> if (!si)\n> return;\n>\n> @@ -1683,7 +1683,7 @@ bool\n> gori_name_helper (vrange &r, tree name, vrange &lhs, gimple *stmt,\n> range_query *q)\n> {\n> - struct gori_stmt_info si(lhs, stmt, q);\n> + class gori_stmt_info si(lhs, stmt, q);\n\nLikewise.\n\nThanks,\nAndrea\n\n> if (!si)\n> return false;\n>\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=QsWbt6nk;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=h29AvZvV;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=QsWbt6nk;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=h29AvZvV","sourceware.org; dmarc=none (p=none dis=none)\n header.from=oss.qualcomm.com","sourceware.org;\n spf=pass smtp.mailfrom=oss.qualcomm.com","server2.sourceware.org;\n arc=pass smtp.remote-ip=205.220.180.131"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fy41F49vtz1yDF\n\tfor ; Sat, 18 Apr 2026 04:59:12 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 9F28D4CD2002\n\tfor ; Fri, 17 Apr 2026 18:59:10 +0000 (GMT)","from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com\n [205.220.180.131])\n by sourceware.org (Postfix) with ESMTPS id 4DC3B4CD2019\n for ; Fri, 17 Apr 2026 18:58:26 +0000 (GMT)","from pps.filterd (m0279869.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63HG4X81454917\n for ; Fri, 17 Apr 2026 18:58:25 GMT","from mail-dy1-f198.google.com (mail-dy1-f198.google.com\n [74.125.82.198])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dkg88tg9m-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for ; Fri, 17 Apr 2026 18:58:25 +0000 (GMT)","by mail-dy1-f198.google.com with SMTP id\n 5a478bee46e88-2c0ba59a830so1727234eec.0\n for ; Fri, 17 Apr 2026 11:58:25 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 9F28D4CD2002","OpenDKIM Filter v2.11.0 sourceware.org 4DC3B4CD2019"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 4DC3B4CD2019","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 4DC3B4CD2019","ARC-Seal":["i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1776452306; cv=pass;\n b=O9UBVWz8nrNJUCUc16SCndmfD5ypfzTE6Rqe8DiNkaYDo5PzWSLf8TiT02JRJKlL56zuVrV1bNK0DHAHEqGZyHheOgNAcbKabNkvWy2QBwmJCjUasCqdnTYKKgM1KqNcwYKuLX16VxaelACqXcj9wCzlY+GYQkUT1ESSRJnfzDw=","i=1; a=rsa-sha256; t=1776452305; cv=none;\n d=google.com; s=arc-20240605;\n b=eaWGKue2uCTv7QymEOY09xCYgIrFvA8f+ANGcWs1HffN3lZV4N4gbEQ9SIoiY0vzWJ\n fF7gHGZd/C388tL5U5skXskAXsor4xxAiUPjwWX+cm4snGLcaridJ1ZJZcOwaoz9qTHm\n EhCFSdUpm8jlbFKVl7DvkamE34uHNNGF/th7A5pOOFSTb3AkuD6K+sH9ltPzD/jZE2GU\n bSWom+5LqG4kPAvul0wfVEpUevkIQhCCjaEE6LA8rMFhFc5BMPoRQijAENHWb0oU/BAu\n xT+2mt0dmCh47rqB2ZH5LgsVGO2e5bZNN9inJd1KrQGSZPLmmaVsgL8yVTlFy+tE+xrq\n Lwiw=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776452306; c=relaxed/simple;\n bh=t4YMgsmn2bxkYtytSkM6LjGv29IGexpbtK7Ld6wcbAo=;\n h=DKIM-Signature:DKIM-Signature:MIME-Version:From:Date:Message-ID:\n Subject:To;\n b=KhDce5ZZep0vXqtxbNmZ73gBqRQc1158mIshtj4z/BguX+Bn1yr2Sij0lLFQKedgG7HEbuM/5wNPRfomNWo7eKZFoA6CEa0NvzWtomCsurdooddR1yf4diLgIYms1q0fuUv0Z3WghSnIAIuK9H/igqp4OqA7zujIgYT5vgTAVH8=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=8ecf/gy9m9cIPe73NHBpWafKcxgQHF5mHigmB7Dhsgc=;\n fh=DG0ZxEQyojbJOuIOd/MOxKcbunKJQ5dnNBaCVPRTkp0=;\n b=N4A2EAuFOGBvJK2pffQ8wPGOJdkfU19BA2XTSM/QztbHrw56Y9v222khKca66B3tc0\n OKF/IFvxeOscLqubk5VFSfwsRQQmOVR2cwE09XVdpNQBmj1Ir3AgucDXDSQzRRz9DJF5\n X4yedf1TbWxciODwkn+5AhzbCXJhr6+l6KtH8kFDrUMjw/9Gfva31Zh7Pis/2yMCc2QS\n HF44ydpFgHr2L9VgvMQ7CmS0uuFHGViuOZds1O3nrmhD+2BvDuwYfmhnizWkBndsACBw\n 420KNyGokYKcwl80QSzgcGGyrQTAlJV2FDhYaLkQu2shcIF1II0hwjENj8AvQCwaaXMD\n p5jQ==; darn=gcc.gnu.org"],"ARC-Authentication-Results":["i=2; server2.sourceware.org","i=1; mx.google.com; arc=none"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n 8ecf/gy9m9cIPe73NHBpWafKcxgQHF5mHigmB7Dhsgc=; b=QsWbt6nkle/LdL3S\n TcfW2ZAS13prAdQavKxuOsLybosthRc5MSGTNR9oE+D8OdlFfXlXbtdx48RVLzta\n /tFPRGu+X4GiDE3fXqhks2TJeq6LklAB2gnIaJlLlrUp7gTX5IGXAN4afCAePOYq\n T5L+Zc0FCc9OW2uVdG0U3mINYO55we/QcEyn6Omd8oh8Ik5BcfWTrFD6t+kdNS9Q\n SYQ7TkCXOeZySjURESnYqVamJjRJyFtsgoCq/FXkN4izJyB7Ddbomq1qgV+v1/Yf\n zUDHJk64yTAeTBZLeOTG2BqQzdebkY1Sh0qNvypZasVK6xL0OLiswJDPquyWEbrc\n j0R0Bw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1776452305; x=1777057105; darn=gcc.gnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=8ecf/gy9m9cIPe73NHBpWafKcxgQHF5mHigmB7Dhsgc=;\n b=h29AvZvVaVE59PhfAiYne5rLU7ioUYuZKSirzmFTewYX0ln+dTiD2bkOpl5aesTi9t\n R6GdcZ5OqpVXZPV7Vpgdis7WU18m8MJmjAzwv/WAmivL0bSnphpq1KJQ2OJD3SdWtFEi\n 1B2xG+i2RzqbwN08J6kaEiuwgLQHD/085WPvKi+9yUR7dPoxSK9ILT4/iSDRLWZkXeHv\n ixMUyLJ7KldVlSkOC13ohCvD3SWxIrQ8gvEnPCWQLimTPF6wXpkMxoSxqlAXynh69L+g\n ++y5bKnyiYw5/VP9EYEScNLTEcfSckpArcsC4a1D22VbxkaCWtldTkBr0cmtohVjQqgF\n WpIw=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776452305; x=1777057105;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=8ecf/gy9m9cIPe73NHBpWafKcxgQHF5mHigmB7Dhsgc=;\n b=jksqCCmJLxrow3Mc4kWIunKIpMcmu3y03JivAjsECeUYyFLs6x+7F0U+u9hLkZD9+l\n EWwqWHu94LxNjv0uYqQD8I01oa/Ag+4W0x6qcBFX/9UPUcL09JU+cMymHgT8za0aUl0w\n wnp4/zv8Dtfl5GKkpsXHt3oMxvCW5EKoFI8rX6Nw2xS/J5idRcoVCQBLa7ATqwpw8jKA\n pCkEeXQB+6/0l3I1ZRuxAD7dP8GjjbB9mTyLj92+e/fuCaY6jH8WzLN0o9Rg7tPLXPpg\n eLxaSjlI7t8fVsW7yrcOODFed6+HdOtrgB4khkeesIB8VRIL2KzOd1NaB2uxTE2ENSwO\n xbHA==","X-Gm-Message-State":"AOJu0Yxvav1ovDknnZMczBTWiG756kzqxKLdaugBraIf9FbEOKI9iTc1\n n1xTcAER5ST/NCiXWikVfnfono6sGfJqrysm8E6YOcE8gOJbH8ql95vwvA0oKz/rzEfW/G0MSqH\n ord2xYVKHIFOoJqktjmeZ7mWs6LE77pQwwIMijrCnk0P+lc8p+qCWIciV929Mw2ypXzAi/0IeH4\n qDmJvVVonBKrqaNLFLceOgnnL2M1POi3jEELs=","X-Gm-Gg":"AeBDieuvxZE4amuqiB8E8ZorncaSjDRxCooVc8ueIkeonpj1X6Tn3kFBHLheXNRn0cZ\n UAe7tkIp+fJpKpZcxTXCDnAv3L8UnYnXspxpDDY3aeiZPunR1SZeRLVr2KQAJVNO2pK19nst07v\n uIEF4fuaoAfe/vs1AE3fwvt6/77YwZCEu+7rEvRWtq9CMb/O+n9t9xo/hpfQ/W8wI/rblXahCw4\n 6WRSD14e69zQN8=","X-Received":["by 2002:a05:7301:5784:b0:2dd:c066:c02 with SMTP id\n 5a478bee46e88-2e47a10653dmr2005953eec.22.1776452304646;\n Fri, 17 Apr 2026 11:58:24 -0700 (PDT)","by 2002:a05:7301:5784:b0:2dd:c066:c02 with SMTP id\n 5a478bee46e88-2e47a10653dmr2005938eec.22.1776452304120; Fri, 17 Apr 2026\n 11:58:24 -0700 (PDT)"],"MIME-Version":"1.0","References":"<20260417172506.1015169-2-torbjorn.svensson@foss.st.com>\n <20260417172621.1015209-1-torbjorn.svensson@foss.st.com>\n <20260417172621.1015209-4-torbjorn.svensson@foss.st.com>","In-Reply-To":"<20260417172621.1015209-4-torbjorn.svensson@foss.st.com>","From":"Andrew Pinski ","Date":"Fri, 17 Apr 2026 11:58:12 -0700","X-Gm-Features":"AQROBzBDKpfIkq1ENfEmmU5oQVAGkbPF-i2zMF2C-3OwsEAY5td4-tWBK7LgTmM","Message-ID":"\n ","Subject":"Re: [PATCH 04/30] Change `struct gori_stmt_info` to `class\n gori_stmt_info` to align tags","To":"=?utf-8?q?Torbj=C3=B6rn_SVENSSON?= ","Cc":"gcc-patches@gcc.gnu.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-Proofpoint-ORIG-GUID":"7iYoXZwGem0oVA7Tr6Wx3BPEmVyFkeB-","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDE3MDE5MCBTYWx0ZWRfX+Zeg/UusCtuN\n hoWIaZCS2KOPdNhvQxaANtjmfIkk2MQq+txdKmoogkRH32LU7W35Xkc1thgGvRIu7GzC9abY88M\n aht0Eh+4j6o0JfwaHTCz6FwJgwPle+6MTQk/w2yRyah4JEeNsWkDHvehI7YPmdBSGoPDQb/p3QM\n /Tt08jcw+G8fJhMffKs5y8b4lHBNt36gbEjOdC3di7cXkMVP7JZ8HRiq7ATFOABVKbnK2tsXge0\n l4aUfTB3HwiK3AKoZry5qpEieior+720fuN/0aitOWmYN5qlYOFckwjlzceBITVZAvt+0WbGrst\n t74FXLvgtmELNya6ViHcbOwjpCk2E5kyVsvqBoCYBndOEPVpZ162GEZjD46AJN8QEk23Dn/eJ1M\n chxIL/oR8KwNskwFnVhrVijgueTeMpbyERtA2ffkvaIos1RoRGLK8ls186kWICEtUAFD6O5IRNy\n pclueNImehFNXJNAIEw==","X-Authority-Analysis":"v=2.4 cv=X+Fi7mTe c=1 sm=1 tr=0 ts=69e282d1 cx=c_pps\n a=wEP8DlPgTf/vqF+yE6f9lg==:117 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10\n a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22\n a=_glEPmIy2e8OvE2BGh3C:22 a=8b9GpE9nAAAA:8 a=2DgTECIsw6-50ZTTicUA:9\n a=QEXdDO2ut3YA:10 a=bBxd6f-gb0O0v-kibOvt:22 a=T3LWEMljR5ZiDmsYVIUa:22","X-Proofpoint-GUID":"7iYoXZwGem0oVA7Tr6Wx3BPEmVyFkeB-","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-17_02,2026-04-17_04,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n phishscore=0 clxscore=1015 spamscore=0 impostorscore=0 lowpriorityscore=0\n bulkscore=0 priorityscore=1501 malwarescore=0 adultscore=0 suspectscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604170190","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}}]