[{"id":3678959,"web_url":"http://patchwork.ozlabs.org/comment/3678959/","msgid":"","list_archive_url":null,"date":"2026-04-18T11:16:11","subject":"Re: [PUSHED] gccrs: Add `#![no_core]` attribute to most tests: ...,\n but not in '[...].exp' test suite harness files","submitter":{"id":83476,"url":"http://patchwork.ozlabs.org/api/people/83476/","name":"Arthur Cohen","email":"arthur.cohen@embecosm.com"},"content":"Thank you Thomas, good catch!\n\nOn 4/17/26 3:29 PM, Thomas Schwinge wrote:\n> Always good to be comprehensive when mass-editing files, but the '[...].exp'\n> test suite harness files are good already without 'no_core' annotation. ;-)\n> \n> Minor fix-up for Rust-GCC/gccrs#4407\n> commit 92b6926a85e4c5eeb78d4e930dbc44130240f8bd\n> \"gccrs: Add `#![no_core]` attribute to most tests\".\n> \n> \tgcc/testsuite/\n> \t* rust/compile/macros/builtin/builtin_macro.exp: Revert previous change.\n> \t* rust/compile/macros/mbe/mbe_macro.exp: Likewise.\n> \t* rust/compile/macros/proc/proc_macro.exp: Likewise.\n> \t* rust/compile/torture/compile.exp: Likewise.\n> \t* rust/compile/xfail/xfail.exp: Likewise.\n> ---\n> gcc/testsuite/rust/compile/macros/builtin/builtin_macro.exp | 3 ---\n> gcc/testsuite/rust/compile/macros/mbe/mbe_macro.exp | 3 ---\n> gcc/testsuite/rust/compile/macros/proc/proc_macro.exp | 3 ---\n> gcc/testsuite/rust/compile/torture/compile.exp | 3 ---\n> gcc/testsuite/rust/compile/xfail/xfail.exp | 3 ---\n> 5 files changed, 15 deletions(-)\n> \n> diff --git a/gcc/testsuite/rust/compile/macros/builtin/builtin_macro.exp b/gcc/testsuite/rust/compile/macros/builtin/builtin_macro.exp\n> index c9f8054185e0..2c3be80b0146 100644\n> --- a/gcc/testsuite/rust/compile/macros/builtin/builtin_macro.exp\n> +++ b/gcc/testsuite/rust/compile/macros/builtin/builtin_macro.exp\n> @@ -1,6 +1,3 @@\n> -#![feature(no_core)]\n> -#![no_core]\n> -\n> # Copyright (C) 2021-2026 Free Software Foundation, Inc.\n> \n> # This program is free software; you can redistribute it and/or modify\n> diff --git a/gcc/testsuite/rust/compile/macros/mbe/mbe_macro.exp b/gcc/testsuite/rust/compile/macros/mbe/mbe_macro.exp\n> index c9f8054185e0..2c3be80b0146 100644\n> --- a/gcc/testsuite/rust/compile/macros/mbe/mbe_macro.exp\n> +++ b/gcc/testsuite/rust/compile/macros/mbe/mbe_macro.exp\n> @@ -1,6 +1,3 @@\n> -#![feature(no_core)]\n> -#![no_core]\n> -\n> # Copyright (C) 2021-2026 Free Software Foundation, Inc.\n> \n> # This program is free software; you can redistribute it and/or modify\n> diff --git a/gcc/testsuite/rust/compile/macros/proc/proc_macro.exp b/gcc/testsuite/rust/compile/macros/proc/proc_macro.exp\n> index c9f8054185e0..2c3be80b0146 100644\n> --- a/gcc/testsuite/rust/compile/macros/proc/proc_macro.exp\n> +++ b/gcc/testsuite/rust/compile/macros/proc/proc_macro.exp\n> @@ -1,6 +1,3 @@\n> -#![feature(no_core)]\n> -#![no_core]\n> -\n> # Copyright (C) 2021-2026 Free Software Foundation, Inc.\n> \n> # This program is free software; you can redistribute it and/or modify\n> diff --git a/gcc/testsuite/rust/compile/torture/compile.exp b/gcc/testsuite/rust/compile/torture/compile.exp\n> index 5a101ac23bd2..18ed8c039707 100644\n> --- a/gcc/testsuite/rust/compile/torture/compile.exp\n> +++ b/gcc/testsuite/rust/compile/torture/compile.exp\n> @@ -1,6 +1,3 @@\n> -#![feature(no_core)]\n> -#![no_core]\n> -\n> # Copyright (C) 2021-2026 Free Software Foundation, Inc.\n> \n> # This program is free software; you can redistribute it and/or modify\n> diff --git a/gcc/testsuite/rust/compile/xfail/xfail.exp b/gcc/testsuite/rust/compile/xfail/xfail.exp\n> index d9f6c007ae2a..ac318865794d 100644\n> --- a/gcc/testsuite/rust/compile/xfail/xfail.exp\n> +++ b/gcc/testsuite/rust/compile/xfail/xfail.exp\n> @@ -1,6 +1,3 @@\n> -#![feature(no_core)]\n> -#![no_core]\n> -\n> # Copyright (C) 2021-2026 Free Software Foundation, Inc.\n> \n> # This program is free software; you can redistribute it and/or modify","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=embecosm.com header.i=@embecosm.com header.a=rsa-sha256\n header.s=google header.b=ON6cd8v3;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=embecosm.com header.i=@embecosm.com header.a=rsa-sha256\n header.s=google header.b=ON6cd8v3","sourceware.org;\n dmarc=none (p=none dis=none) header.from=embecosm.com","sourceware.org; spf=pass smtp.mailfrom=embecosm.com","server2.sourceware.org;\n arc=none smtp.remote-ip=209.85.128.49"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fyTbT2R5Dz1yGt\n\tfor ; Sat, 18 Apr 2026 21:11:47 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id F0AF64AA51FF\n\tfor ; Sat, 18 Apr 2026 11:11:45 +0000 (GMT)","from mail-wm1-f49.google.com (mail-wm1-f49.google.com\n [209.85.128.49])\n by sourceware.org (Postfix) with ESMTPS id D0B804AA51FF\n for ; Sat, 18 Apr 2026 11:11:12 +0000 (GMT)","by mail-wm1-f49.google.com with SMTP id\n 5b1f17b1804b1-488b8bc6bc9so10175285e9.3\n for ; Sat, 18 Apr 2026 04:11:12 -0700 (PDT)","from [192.168.68.56] (176-147-231-59.abo.bbox.fr. [176.147.231.59])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fc10777csm144045045e9.8.2026.04.18.04.11.10\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Sat, 18 Apr 2026 04:11:10 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org F0AF64AA51FF","OpenDKIM Filter v2.11.0 sourceware.org D0B804AA51FF"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org D0B804AA51FF","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org D0B804AA51FF","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776510673; cv=none;\n b=pGrgLnNKZy08JzHbWqW/eEY7bkhyRXKi5smXETz077IvdaNcntLozMedXcO0oGLoGhMZ1SBA+0ogh369/2hUM5WcVTZ7Q6miyGFWXM11L6D6qJ39/ywxrDhTNYox2yrlre16sCZnkTOuYVnmPoRetFTlybKrrIoAizo0ASziRkQ=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776510673; c=relaxed/simple;\n bh=ATT1Dl0ggCqOw1ojGTY25MduFMG85P52SN4Uou5xZSk=;\n h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From;\n b=CDZ1YD1B8gdRlsAbbZxZFNSPVn3y+Fj+tRWAGOe3gr0XvG3JgZkeLsdCKASy10CgQggNe0gAriEc1ugc9R8/u2iOat5sxUuG2QG1nhKjL8eHVuv/YBXMIoO9ZBHQYSmrZE/DB73OzM2Ep/7nc7ROKY/W351ha1LXdZLzh54Vhjw=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=embecosm.com; s=google; t=1776510672; x=1777115472; darn=gcc.gnu.org;\n h=in-reply-to:autocrypt:from:content-language:references:cc:to\n :subject:user-agent:mime-version:date:message-id:from:to:cc:subject\n :date:message-id:reply-to;\n bh=ATT1Dl0ggCqOw1ojGTY25MduFMG85P52SN4Uou5xZSk=;\n b=ON6cd8v3Bcyc/fvMXL1HBkIZAtAnbkymwzSyx2BZSKFduUcEgp+1jyLm1kPnYQAb5W\n MBIt6XzcH8RMfoHw8YNtYezX54XukxRXNtaMYABuDFm+re8cO7U2syygagCDc8hwlYCY\n ZojgmKEk4wVwFZORoJp9gVwwazXF3l+mk5IlcSo/cBlLZXeKF8XZ7824L45VlwsNhhDi\n NE0++j/vkLI0rItBXAUiRv0V+jY1dA2RX2YFv4i2sb1EWu8XmAYlXrRgOqXrPSvW4p1z\n AjP15BEo3qUbjbSGrsQZN7E+zTLZHdLowLvc8xmnbEbPZ3VHQVcXSQXnKGNF+/k3d377\n +BxA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776510672; x=1777115472;\n h=in-reply-to:autocrypt:from:content-language:references:cc:to\n :subject:user-agent:mime-version:date:message-id:x-gm-gg\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=ATT1Dl0ggCqOw1ojGTY25MduFMG85P52SN4Uou5xZSk=;\n b=oL4YGAStQz4D1NPu75PvdKTPgZ84xOf3VWGf8bwjnODi3XPQhNChWb4czRB2c/+lI+\n KGRdJiia1DXoaY8jfrYz8tDy0LsN0A4y38rBA458ZazGlBf06AIj8asjXam4hiOY+FNm\n Zu+trnHU+lnw1DW8ws7sOb+dl8Ep7A/aq2jeTQq8JAD3iJsvzK1m9gZDAwfV6Fb9aK9d\n 6rCv/ghyx812JXsvuMhqKxZRZ0Bp1S28Xqi6xHpCP0/ApPp6kTAT6cB+q7vbKnBU+lnw\n vBkoRpDx8R/5hP2efSb9SEbwRccy/RcbrmLYSxafCeXrnqq7ihaN7h7zR1qN8I894/0p\n lyFA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ92yI4SSknNTU9L1MoPbxWoB6Rf4Yfod8E9FDsv+9UJPWDiAoO6Ajlx7QLQu5o/79XZUa+qIrqb/fs2Hg==@gcc.gnu.org","X-Gm-Message-State":"AOJu0YxIJia7c1lIVDVtwUK3dCLma1ycVBB9U0FQDM8j9fLhS7SrX6YK\n +yxOX9c0bHHJje4ilAHPNj38jpyrC5ix5t5geJ1ZDgBkgf7NqsvzO7wd0g/WpkKzQA==","X-Gm-Gg":"AeBDietNpgqdNmMQECQSHsvVS16h70sgMlkRGsRCxlJeg/zKDF9GsHOasbbf/jN4z40\n 14yuNbmycFjQEMdxG+o8G+F7GYywzwn7qBXs7kCqxM9kwIagEA1hi0dY9l/v2/lw5xt/SqwntBZ\n SgDu1xtPxCLKwqNtmGQpqMxy7AKfUJIp20Ckkb5z7Zu7qXWjoHQC5z6UytSYh+y46IN00RrylMB\n YyH/w62qmqAYb72rNxfKmDjEmaPX9yvdBYi+O77eXJ34M8916WCuPeayzKWJnY079zo1yyHTQvO\n o3582/YbBB8aArAwd1Mgz5r4nepKiVQ6QJ4t1NQK37XurQRL7X4ducqpDnK1+SNxSDsY3/W9pJA\n 29J265KLVpxdso1yNRuUFW1FEqAAaar6Rhdg0y5VXN1aJ3s68Rzu3x9cRhtNMdjS3hkef4IKZgC\n VDKwnlB7juNzmbU+OXYG/o/8djaKzULx5KF8QioNMJwT5JQbnfttar+O1050Jv5OBzqzR2Y6g=","X-Received":"by 2002:a05:600c:c084:b0:485:39d1:b4dd with SMTP id\n 5b1f17b1804b1-488fb74a495mr66402205e9.10.1776510671406;\n Sat, 18 Apr 2026 04:11:11 -0700 (PDT)","Message-ID":"","Date":"Sat, 18 Apr 2026 13:16:11 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PUSHED] gccrs: Add `#![no_core]` attribute to most tests: ...,\n but not in '[...].exp' test suite harness files","To":"Thomas Schwinge , gcc-patches@gcc.gnu.org,\n pierre-emmanuel.patry@embecosm.com","Cc":"gcc-rust@gcc.gnu.org","References":"<20260227170001.663690-34-arthur.cohen@embecosm.com>\n <20260417132931.337354-1-tschwinge@baylibre.com>","Content-Language":"en-US","From":"Arthur Cohen ","Autocrypt":"addr=arthur.cohen@embecosm.com; keydata=\n xsFNBGIMH/sBEAC/+yKgi+y9knsqZUNIqlF85v9Lv0lZ2jOUgFgD5R10gz8j39vIYxM/DWA8\n BGudqx/s0V3T2arTIJ9u9StA6846SD4lCmdFBUkE0ylOl9UjYrZpoNOYF85TrhwDBB8LxNzo\n pJxrQIv/WqU2pfs4+QyZuzNPWkGv1b06dDqY1hr7jUxJzAhRklGMyd6kPzr4lJUJLvIPxjQ1\n Y+NXAiLrm7n7HqXeHxGBHFwxTRKMb720fcP8pkNQKZNoZBAhNr/665yIH3fV1+D/xsjbVkow\n BJn5MG3iburNfps50fMNNkBZgzIBRjBxdyJ7iJmpZRQkdLSEf/gpWEc/vUVs8OIdqT60vuFo\n ueuQUyntFuvGWyCP/o71+eaMdG1Xx8TROJM9usU+Zz3V8GwpPSUUiAI/tDhR/ANtrrJ7jbuh\n w/9fm7HLovGniQcpN2INgY/Ema3dmU7EWnFqeGymP8R3MQY1Ge8xqlNL1KGrp45ZHp623XgH\n +IDkvy1ne7RU+WuOPxKKWGeN9LfHNGfTX3ZvFCCxlnbU6KwwoeiLBVdkY1zbgA5LPIPrPtzQ\n vSPTivQswMkCEVrqLkBYnAXGiavx8V63HltdohJMvkE0wkH3XmsTgrbtqxADlHHz7WZbBWx9\n G6OElEThcuT/H/pR9dxr83+qbkUpyIYxW3zP/kpz97oOElSyEQARAQABzShBcnRodXIgQ29o\n ZW4gPGFydGh1ci5jb2hlbkBlbWJlY29zbS5jb20+wsGOBBMBCAA4FiEEhx8wPNj7cw6CrvzG\n GzRlsEStnGUFAmIMH/sCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQGzRlsEStnGW7\n GhAApgjuTe1IRIGxhF8o2VLRYYOHugSI6tNBPpnOjRBbt/Uj5xECBLDtIx+/GR+fUSZ/wRj7\n hIpbSoClfnCwQ5/Z0055MY8T9UsCwElOPluzCNmrmRPL2snMsAhhMxDVVtX5xvF25It0qRQJ\n LVKWiJPoPsQbl3ouaQhPbr2zeIAa74BlWn03zbUJdTXcdjd8+ZBnSGntqwV/hP/g1NwZzuxh\n roOq1UafPFd3RKwcuIRUkr5JE1ymNP4R8u3GU4/gwGr9s69wIEsBohPowgYGt84ZvLZpt84y\n Ufsf9CH4OE4/+x1QGumD1b9VcIv5/vZsg7Z8EXKibb6X5TM2vtCcNAHv+0KsERZyLHXn+GOj\n PQgISzPEcxYkeGNtEnf6IhsIfZyeUe2ZiMPz48Tok9w7r0XfhMCj2SMFjbAFfsufsglDnGO7\n CRuCBXtYJYZInmf5XzaQ8FfMRPs9jZeD6SFZjFH00E1o5GLsY9le5euxLo1aLqDNqMp6I8R7\n 0rK65c7zRAnQ9CO8watmXsBMuJ0Y6Jmf/noFXn8SGVA9b7j+uumum1zToTSmPwhn83X3KwoX\n TmQ9RD1eiEBJDT9/phSTVDTqhsu8GJVzOIRVXKHxRZLZJo1pGt3YzbDlTshXAV4Ln5YsJIgy\n AuLU6vmH50QoZhuJK3xMnUaMRdxgyqZe5ACmWXXOwU0EYgwf+wEQAL5Bd4WYiqpsBgW1k/To\n zz4cThT+CueIqitD5lhTzEJ73SyrAmUiZrkSmR2Vc6G1mJEqozkmeXHjjQ8gMbz6HZBmacnJ\n hWObf1aUTHjowIsyT0hJJVag1Exq16lBUZCelNG0Jb07TnVWTi/2xHRTLsNVzTQpKnWC3OoA\n y6M9KwNp5I0hk2cJaFrMjz7/Q16kx8vOov28UcsNDhbq25W64fdEYZApNZI1sKk33tAQj4t0\n BxHtG1Hb6EwxbPmVZpL07fmLLVWe3nI5znekXq8AHlUcPGpb4EjUIsmK8+VnGF3f0cDeSupJ\n WSaHiuufc/jONsM8ZiuYJ6i9Lr8IvgeTUZMXVrjwuIDaMLn5F24dmNSheuwLukQTTiB9LKfU\n yKZzkFb8Opiqzjng+psvkECIVwk5xaZgraKtivyq+RHGrhSzkJv17QLb7rEiMjKl+20v3xCY\n l8ogR/7O/slPZMisDV5QOEZEMrWfVYZCW5UIO+vXekTweJxVzPfrkUSpzce67iyeTzzNNwPl\n FnS/6eB1+IKKAtuxEhbOokBsYf+WnY7xdLGCLyVTXdg99oXZ9AJUUJL3dy9eIggZciQSzkhf\n eKykoUDmHUAAbWTAxWLwkJ/QBku/Ay5ffRQ9ukhngdu8PsyPGwsOORNIVYbKU0hMtqU7UjOz\n hVviQufJY2C4KCp5ABEBAAHCwXYEGAEIACAWIQSHHzA82PtzDoKu/MYbNGWwRK2cZQUCYgwf\n +wIbDAAKCRAbNGWwRK2cZQJ6D/95URtl/eu1akFC1VNqdghWrOAJiL8Jgk53cXug3GXoh8qj\n DYXT7S6zC6Gyq2nqhGy5JdNmZRdhFCIqZAg2DyBY/1gJEM0yLXEhWZy8AxuUaadAuUG8erdn\n gXD2az4glSKhjAM5oxRXkWB3P9lr5I2n0Yx7tPlFusfIInV/3RKOYezPS9seoJS31hb6dvYs\n f3/RGF5Fau3+sm4urTn7zqhqBYgqBmih8sgsifXAzsJ+tO33Cd10SPZmKlKlZWxouTL4Nky6\n e2DJHX7phX1DIZBmJBIUvkK6uA7mdJ1yzQonNJq8nABtXBioO+YnP3msZPutEJzGnBjRSpJr\n 0FULqeIX5JTPqa023Kj2zvnFfqKrT6rgMUomNjQxCryix+EoBUvHcHAyWPQuYb38eV15GqcC\n jEezziKqTXPBETXkM3rq8+STsSwxn6wz6gwgC1sbj+IXUY2jGzq8fS/99uferADYXEnzKheU\n 5Q4gWv2XQ/juSJh6AuxTdlr7+5ndAmVUh8U0p47S5ErJnHt1H4pLxIoR7VM9YiIZHn833Xms\n 2QT2JVIVzL+opHU5XdoXPgd58b8Sxd2j1Fj8LevvZ4isfpr6ZHQ3S0sdOZFtg+Sdnri0Eg+Z\n g28sczMMKT0W+wb/dpZCA8p3ONJE5hWUhtUpNuhV7j8A4PBVzNHOqPWx7FJmBg==","In-Reply-To":"<20260417132931.337354-1-tschwinge@baylibre.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n protocol=\"application/pgp-signature\";\n boundary=\"------------TgSNjTGvdzLxRIoKCThfPhK0\"","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}}]