[{"id":3679173,"web_url":"http://patchwork.ozlabs.org/comment/3679173/","msgid":"<CAFLszTgVq+036_KFj2QiTgZPps53GQfsqL9P5XVcxAURBJv3-g@mail.gmail.com>","list_archive_url":null,"date":"2026-04-20T02:11:19","subject":"Re: [PATCH v4 02/14] ecdsa: initial support of ecdsa using mbedtls","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Philippe,\n\nOn 2026-04-17T13:02:04, Philippe Reynes <philippe.reynes@softathome.com> wrote:\n> ecdsa: initial support of ecdsa using mbedtls\n>\n> Adds an initial support of ecdsa verify using mbedtls.\n>\n> Signed-off-by: Philippe Reynes <philippe.reynes@softathome.com>\n>\n> include/crypto/ecdsa-uclass.h   |  15 +----\n>  include/crypto/internal/ecdsa.h |  28 ++++++++\n>  lib/mbedtls/Makefile            |   3 +\n>  lib/mbedtls/ecdsa.c             | 146 ++++++++++++++++++++++++++++++++++++++++\n>  4 files changed, 178 insertions(+), 14 deletions(-)\n\n> diff --git a/lib/mbedtls/ecdsa.c b/lib/mbedtls/ecdsa.c\n> @@ -0,0 +1,146 @@\n> +     err = mbedtls_mpi_read_binary(&Q.Y, pubkey->y, key_len);\n> +     if (err) {\n> +             log_debug(\"could not read value y of the public key (err = %d)\\n\",\n> +                       err);\n> +             err = -EINVAL;\n> +             goto out2;\n> +     }\n> +     mbedtls_mpi_lset(&Q.Z, 1);\n> +     if (err) {\n> +             log_debug(\"could not set value z of the public key (err = %d)\\n\",\n> +                       err);\n> +             err = -EINVAL;\n> +             goto out2;\n> +     }\n\nShouldn't this be:\n\n    err = mbedtls_mpi_lset(&Q.Z, 1);\n    if (err) {\n\n> diff --git a/include/crypto/internal/ecdsa.h b/include/crypto/internal/ecdsa.h\n> @@ -0,0 +1,28 @@\n> +int ecdsa_hash_verify(const struct ecdsa_public_key *pubkey,\n> +                   const void *hash, size_t hash_len,\n> +                   const void *signature, size_t sig_len);\n\nPlease can you add a kerneldoc comment documenting the parameters and\nreturn value?\n\nRegards,\nSimon","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=FKUD/0XA;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"FKUD/0XA\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzTWR48Pcz1yGt\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 20 Apr 2026 12:11:47 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 3F7688419E;\n\tMon, 20 Apr 2026 04:11:45 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 2DD6C82BF2; Mon, 20 Apr 2026 04:11:44 +0200 (CEST)","from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com\n [IPv6:2607:f8b0:4864:20::42d])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id EB31C82BF2\n for <u-boot@lists.denx.de>; Mon, 20 Apr 2026 04:11:41 +0200 (CEST)","by mail-pf1-x42d.google.com with SMTP id\n d2e1a72fcca58-82f351ca23cso1116481b3a.2\n for <u-boot@lists.denx.de>; Sun, 19 Apr 2026 19:11:41 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776651100; cv=none;\n d=google.com; s=arc-20240605;\n b=RPpeBPH6PrEqkJBu4XF70xjSQFPgE4AaJsx22a+5ZAxsT/ORnY0zy40TCer/Ad+vVW\n EmvtCE6tZLeRw/Wz6boOxazQemWLzdhWtjbwrmhiFVrcHFBPygafQ3L1zac5HPKBnBMP\n 4OU6oGjZUQZixgsQfq+w63TGMcItWM/c9rxRdkGsbwiEVl9pefKp8X0B1V7o5rXYBsdS\n yRBS+bhb/AMx3z1fD12GjTOFW49lsFc4FBCz925OWRXsAe2E3bbT10JICuRxX0q1MXNU\n 1KZF88pUzEfVQiASG7MN7/RQdYpzHsWX8UplERinrkybohpJ5Xr59lWBVjaOmK2fGtcK\n uXeg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=zJxLCUZjfbzLZDERefk8Su5xijL+PR2gcUceA2H0W7k=;\n fh=/zdyLayrje+NlQCHW/wcoE4at6j2IwcM7dkIsMB87vM=;\n b=hvI4xEYCNiWIkwezESNp3WBe/11ggdzqPKCUS7rW1f6s2X3hNHDprl6IqsR7hJcBv+\n Brq4Ji2fBPHQ9bYpEXdHJoRi1ZHz5QxsURn1PBKEPObOsUEU0PclPY4bVmQCBX/BjMKf\n KWeMg3rvgXUWr8ONhfcbcgtTQlWmNZUqyqbAOK2sYWPFTAFmfN5mKrdvqKsfuLImCqL1\n 2anv0nKV/jJEzAUd341ANa+F3cFarjZScMWlzr4vh0Rl6kY0iudOUrEf8LkR85U+A+TT\n xss/o79Ihswn4NxG4HwY8wIJHPCsOqYXo6J9ziE9Sz5xOG249ViCHoxjMxvoR7l0iQMM\n 0I5A==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776651100; x=1777255900; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=zJxLCUZjfbzLZDERefk8Su5xijL+PR2gcUceA2H0W7k=;\n b=FKUD/0XA0+mzUR1x56i8lbIidxfwcLLS8B/farAOwEgotH432UkFmp1x+zyJMSFHW2\n /ZS3UFKQoQzpy+B6oymhlsRROq4v96+F2Sh+hsyMPvQmABF1PG3FWIigPUU0dKgJM8UY\n iD+6C0ppONlrwVoStBlJR0mRUWcdEdGVzAdBE=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776651100; x=1777255900;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=zJxLCUZjfbzLZDERefk8Su5xijL+PR2gcUceA2H0W7k=;\n b=dfwYmpNC4QczZ8SrVSZWqERRwfkvcKzVPLt/877xbGyD/aUkk+6ZE2nbpdUNTcVuoo\n T1haiEa8rPil5y+6N7rELFsYKT6ww649xpjra81H3uktEw7CaXhh4EFkkys2Ok1yU22A\n FOo9baJGlT7BK1BeRL07NBJH2SyxnvDBQQJfKobn4MmWizqwYdoJoOze7PtEInxydJo5\n f5OJFEgEcs7mSG75Db20yfShC9cwKjDeqqv/+2Rkb7v0m0GoWKZOJGqxDd+iJyfqmbkt\n lKo9Lm/pfvjfltNtqGvMwIJYyTPeogzxwUkcwkaWDxwpwrAgxv0PYTrlDEiHZP3psRkj\n Fg/w==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+Py7dKXgaYaxK15haN7FEq2WUpHp0iThxW6Tp84t1G8V0QBQYawZ9s3l5Vu0Lb61r1ZjLqLNU=@lists.denx.de","X-Gm-Message-State":"AOJu0YzxPsBjvQfToipvtk7W3LHo+K7eog5SeP1+trhXRU/Zmx2bFiHz\n PZFcEJCnAUOHHCFijVCl/Jb0CbLsvLHaqs66NErbOMKpV0JsFJwDo9kckbnO70rX2/Xq0eirTbC\n RR3Cf5y1DYuIVUuAgdd6arTekRBqvcYrLfcefVHsT","X-Gm-Gg":"AeBDieukVX8vdXGYkto8uarINHYiHE5T/+apjwOAw3MrlH0cw19+NNYOunbgZvPS9Cf\n WjAXCc5OP+cjUNoAlcCs/6+fxjhubg7IBrManknScscLr+2lvoFQYl8rKcP6Ly49r+GqVCrwE2x\n S58Oy3dWSSd2c4lsDz4f/oz9vnrarS2boB+3AGUiIcqQ4X73N5z+ZIl/BlKS4PfI29zIj6SxvWr\n 6eamaP+rKes15YzZ8JrUwuifsv7T94KMkuXC1EuP6RTTS0PuMzGGg2GQUcaRhUFDY29VKSB1OKS\n 2ki5IO7qJfWzZiPwYTFw","X-Received":"by 2002:a05:6a00:2d1f:b0:82f:5e65:2e19 with SMTP id\n d2e1a72fcca58-82f8c87963bmr10890313b3a.22.1776651100488; Sun, 19 Apr 2026\n 19:11:40 -0700 (PDT)","MIME-Version":"1.0","References":"<20260417130204.49896-1-philippe.reynes@softathome.com>\n <20260417130204.49896-3-philippe.reynes@softathome.com>","In-Reply-To":"<20260417130204.49896-3-philippe.reynes@softathome.com>","From":"Simon Glass <sjg@chromium.org>","Date":"Mon, 20 Apr 2026 14:11:19 +1200","X-Gm-Features":"AQROBzCmAax1Ue1ztCqIeWIaUJjupApwK7LZY5HM_conqSuWpsAjDfhz-MrXaTI","Message-ID":"\n <CAFLszTgVq+036_KFj2QiTgZPps53GQfsqL9P5XVcxAURBJv3-g@mail.gmail.com>","Subject":"Re: [PATCH v4 02/14] ecdsa: initial support of ecdsa using mbedtls","To":"philippe.reynes@softathome.com","Cc":"marko.makela@iki.fi, jonny.green@keytechinc.com, raymondmaoca@gmail.com,\n trini@konsulko.com, simon.glass@canonical.com, u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3679467,"web_url":"http://patchwork.ozlabs.org/comment/3679467/","msgid":"<CAMDkj5zr8LoTyZECbnAznvcYPga+S1otLAoqzPnkq4bon0n+Jg@mail.gmail.com>","list_archive_url":null,"date":"2026-04-20T16:36:23","subject":"Re: [PATCH v4 02/14] ecdsa: initial support of ecdsa using mbedtls","submitter":{"id":91989,"url":"http://patchwork.ozlabs.org/api/people/91989/","name":"Raymond Mao","email":"raymondmaoca@gmail.com"},"content":"Hi Philippe,\n\nOn Fri, Apr 17, 2026 at 9:02 AM Philippe Reynes\n<philippe.reynes@softathome.com> wrote:\n>\n> Adds an initial support of ecdsa verify using mbedtls.\n>\n> Signed-off-by: Philippe Reynes <philippe.reynes@softathome.com>\n> ---\n> v2:\n> - rename sw_ecdsa.c to ecdsa.c\n> v3:\n> - rename sw_ecdsa_verify to ecdsa_hash_verify\n> - stop on first group found\n> - check signature len\n> - use debug instead of printf\n> - check function returns\n> - fix memleaks in ecdsa_hash_verify\n> v4:\n> - move struct ecdsa_public_key from ecdsa-u-class.h to internal/ecdsa.h\n> - use DIV_ROUND_UP\n> - some code cleanup\n>\n>  include/crypto/ecdsa-uclass.h   |  15 +---\n>  include/crypto/internal/ecdsa.h |  28 ++++++\n>  lib/mbedtls/Makefile            |   3 +\n>  lib/mbedtls/ecdsa.c             | 146 ++++++++++++++++++++++++++++++++\n>  4 files changed, 178 insertions(+), 14 deletions(-)\n>  create mode 100644 include/crypto/internal/ecdsa.h\n>  create mode 100644 lib/mbedtls/ecdsa.c\n>\n> diff --git a/include/crypto/ecdsa-uclass.h b/include/crypto/ecdsa-uclass.h\n> index 189843820a0..047a5eda2fc 100644\n> --- a/include/crypto/ecdsa-uclass.h\n> +++ b/include/crypto/ecdsa-uclass.h\n> @@ -4,20 +4,7 @@\n>   */\n>\n>  #include <dm/device.h>\n> -\n> -/**\n> - * struct ecdsa_public_key - ECDSA public key properties\n> - *\n> - * The struct has pointers to the (x, y) curve coordinates to an ECDSA public\n> - * key, as well as the name of the ECDSA curve. The size of the key is inferred\n> - * from the 'curve_name'\n> - */\n> -struct ecdsa_public_key {\n> -       const char *curve_name; /* Name of curve, e.g. \"prime256v1\" */\n> -       const void *x;          /* x coordinate of public key */\n> -       const void *y;          /* y coordinate of public key */\n> -       unsigned int size_bits; /* key size in bits, derived from curve name */\n> -};\n> +#include <crypto/internal/ecdsa.h>\n>\n>  struct ecdsa_ops {\n>         /**\n> diff --git a/include/crypto/internal/ecdsa.h b/include/crypto/internal/ecdsa.h\n> new file mode 100644\n> index 00000000000..bfdc137091e\n> --- /dev/null\n> +++ b/include/crypto/internal/ecdsa.h\n> @@ -0,0 +1,28 @@\n> +/* SPDX-License-Identifier: GPL-2.0+ */\n> +/*\n> + * Copyright (c) 2026, Philippe Reynes <philippe.reynes@softathome.com>\n> + */\n> +#ifndef _ECDSA_HELPER_\n> +#define _ECDSA_HELPER_\n> +\n> +#include <linux/types.h>\n> +\n> +/**\n> + * struct ecdsa_public_key - ECDSA public key properties\n> + *\n> + * The struct has pointers to the (x, y) curve coordinates to an ECDSA public\n> + * key, as well as the name of the ECDSA curve. The size of the key is inferred\n> + * from the 'curve_name'\n> + */\n> +struct ecdsa_public_key {\n> +       const char *curve_name; /* Name of curve, e.g. \"prime256v1\" */\n> +       const void *x;          /* x coordinate of public key */\n> +       const void *y;          /* y coordinate of public key */\n> +       unsigned int size_bits; /* key size in bits, derived from curve name */\n> +};\n> +\n> +int ecdsa_hash_verify(const struct ecdsa_public_key *pubkey,\n> +                     const void *hash, size_t hash_len,\n> +                     const void *signature, size_t sig_len);\n> +\n> +#endif\n> diff --git a/lib/mbedtls/Makefile b/lib/mbedtls/Makefile\n> index aa1ca6d196b..d872c0eb788 100644\n> --- a/lib/mbedtls/Makefile\n> +++ b/lib/mbedtls/Makefile\n> @@ -11,6 +11,9 @@ obj-$(CONFIG_$(PHASE_)SHA1_MBEDTLS) += sha1.o\n>  obj-$(CONFIG_$(PHASE_)SHA256_MBEDTLS) += sha256.o\n>  obj-$(CONFIG_$(PHASE_)SHA512_MBEDTLS) += sha512.o\n>\n> +# shim layer for ecdsa\n> +obj-$(CONFIG_$(PHASE_)ECDSA_MBEDTLS) += ecdsa.o\n> +\n>  # x509 libraries\n>  obj-$(CONFIG_$(PHASE_)ASYMMETRIC_PUBLIC_KEY_MBEDTLS) += \\\n>         public_key.o\n> diff --git a/lib/mbedtls/ecdsa.c b/lib/mbedtls/ecdsa.c\n> new file mode 100644\n> index 00000000000..a87b0d0e17f\n> --- /dev/null\n> +++ b/lib/mbedtls/ecdsa.c\n> @@ -0,0 +1,146 @@\n> +// SPDX-License-Identifier: GPL-2.0+\n> +/*\n> + * Copyright (C) 2026 Philippe Reynes <philippe.reynes@softathome.com>\n> + */\n> +\n> +#include <log.h>\n> +#include <linux/errno.h>\n> +#include <linux/string.h>\n> +#include <linux/types.h>\n> +\n> +#include <crypto/internal/ecdsa.h>\n> +\n> +#include \"mbedtls_options.h\" /* required to access private fields */\n> +#include <mbedtls/ecdsa.h>\n> +#include <mbedtls/ecp.h>\n> +\n> +static mbedtls_ecp_group_id ecdsa_search_group_id(const char *curve_name)\n> +{\n> +       mbedtls_ecp_group_id grp_id = MBEDTLS_ECP_DP_NONE;\n> +       const mbedtls_ecp_curve_info *info;\n> +\n> +       if (!curve_name)\n> +               goto out;\n> +\n> +       if (!strcmp(curve_name, \"prime256v1\"))\n> +               return MBEDTLS_ECP_DP_SECP256R1;\n> +\n> +       info = mbedtls_ecp_curve_list();\n> +       while (info && info->name) {\n> +               if (!strcmp(curve_name, info->name)) {\n> +                       grp_id = info->grp_id;\n> +                       break;\n> +               }\n> +               info++;\n> +       }\n> +\n> + out:\n> +       return grp_id;\n> +}\n> +\n> +int ecdsa_hash_verify(const struct ecdsa_public_key *pubkey,\n> +                     const void *hash, size_t hash_len,\n> +                     const void *signature, size_t sig_len)\n> +{\n> +       mbedtls_ecp_group_id grp_id;\n> +       mbedtls_ecp_group grp;\n> +       mbedtls_ecp_point Q;\n> +       mbedtls_mpi r, s;\n> +       int key_len;\n> +       int err = -1;\n> +\n> +       key_len = DIV_ROUND_UP(pubkey->size_bits, 8);\n> +\n> +       /* check the signature len */\n> +       if (sig_len != 2 * key_len) {\n> +               log_debug(\"sig len should be twice the key len (sig len = %zu, key len = %d)\\n\",\n> +                         sig_len, key_len);\n> +               err = -EINVAL;\n> +               goto out;\n> +       }\n> +\n> +       /* search the group */\n> +       grp_id = ecdsa_search_group_id(pubkey->curve_name);\n> +       if (grp_id == MBEDTLS_ECP_DP_NONE) {\n> +               log_debug(\"curve name %s not found\\n\", pubkey->curve_name);\n> +               err = -EINVAL;\n> +               goto out;\n> +       }\n> +\n> +       /* init and load the group */\n> +       mbedtls_ecp_group_init(&grp);\n> +       err = mbedtls_ecp_group_load(&grp, grp_id);\n> +       if (err) {\n> +               err = -EINVAL;\n> +               goto out1;\n> +       }\n> +\n> +       /* prepare the pubkey */\n> +       mbedtls_ecp_point_init(&Q);\n> +       err = mbedtls_mpi_read_binary(&Q.X, pubkey->x, key_len);\n> +       if (err) {\n> +               log_debug(\"could not read value x of the public key (err = %d)\\n\",\n> +                         err);\n> +               err = -EINVAL;\n> +               goto out2;\n> +       }\n> +       err = mbedtls_mpi_read_binary(&Q.Y, pubkey->y, key_len);\n> +       if (err) {\n> +               log_debug(\"could not read value y of the public key (err = %d)\\n\",\n> +                         err);\n> +               err = -EINVAL;\n> +               goto out2;\n> +       }\n> +       mbedtls_mpi_lset(&Q.Z, 1);\n\n'err = ' is missing.\n\nRaymond\n\n> +       if (err) {\n> +               log_debug(\"could not set value z of the public key (err = %d)\\n\",\n> +                         err);\n> +               err = -EINVAL;\n> +               goto out2;\n> +       }\n> +\n> +       /* check if the pubkey is valid */\n> +       err = mbedtls_ecp_check_pubkey(&grp, &Q);\n> +       if (err) {\n> +               log_debug(\"public key is invalid (err = %d)\\n\", err);\n> +               err = -EKEYREJECTED;\n> +               goto out2;\n> +       }\n> +\n> +       /* compute r */\n> +       mbedtls_mpi_init(&r);\n> +       err = mbedtls_mpi_read_binary(&r, signature, key_len);\n> +       if (err) {\n> +               log_debug(\"could not read value r of the signature (err = %d)\\n\",\n> +                         err);\n> +               err = -EINVAL;\n> +               goto out3;\n> +       }\n> +\n> +       /* compute s */\n> +       mbedtls_mpi_init(&s);\n> +       err = mbedtls_mpi_read_binary(&s, signature + key_len, key_len);\n> +       if (err) {\n> +               log_debug(\"could not read value s of the signature (err = %d)\\n\",\n> +                         err);\n> +               err = -EINVAL;\n> +               goto out4;\n> +       }\n> +\n> +       /* check the signature */\n> +       err = mbedtls_ecdsa_verify(&grp, hash, hash_len, &Q, &r, &s);\n> +       if (err)\n> +               err = -EINVAL;\n> +\n> + out4:\n> +       mbedtls_mpi_free(&s);\n> + out3:\n> +       mbedtls_mpi_free(&r);\n> + out2:\n> +       mbedtls_ecp_point_free(&Q);\n> + out1:\n> +       mbedtls_ecp_group_free(&grp);\n> + out:\n> +\n> +       return err;\n> +}\n> --\n> 2.43.0\n>","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=Ae5uFHNE;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.b=\"Ae5uFHNE\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=raymondmaoca@gmail.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzrjP3lkPz1yD4\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2026 02:36:41 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 6E76F84308;\n\tMon, 20 Apr 2026 18:36:39 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id C303C8430F; Mon, 20 Apr 2026 18:36:38 +0200 (CEST)","from mail-vk1-xa2d.google.com (mail-vk1-xa2d.google.com\n [IPv6:2607:f8b0:4864:20::a2d])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 7FC4884258\n for <u-boot@lists.denx.de>; Mon, 20 Apr 2026 18:36:35 +0200 (CEST)","by mail-vk1-xa2d.google.com with SMTP id\n 71dfb90a1353d-5637886c92aso1353084e0c.0\n for <u-boot@lists.denx.de>; Mon, 20 Apr 2026 09:36:35 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_GMAIL_RCVD,FREEMAIL_FROM,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=no\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776702995; cv=none;\n d=google.com; s=arc-20240605;\n b=hg/8alIvvPTGc5B1guaqxlJhfMVu6lly0CqwyFkQAYfVqbS8FqaTts8IDO5QvZfis/\n DmWidT7BCAt+BW7M2Ejzy30njBFA35h+EVm6txtqutzseWW0nZcz6h1CeFX7Mze2DkIU\n JiPCzBgSmU7D1PDUuU4b/nQV1f7aW0xN3gezh0zW+bign9wuBz8TqG2+XPHQuS/1e5Yi\n IeFaCNIMYtfYFvug/Ean2FSDJiGOfGn82z1mEyZ/dEHR/eNYzRpX5y+u77xK9Z5OXSCA\n OV3JdBEDdePcNuHTvfaPVkzluypZMjgxYhRPCldRfWaEHE1wV6pb/I9VCgEipOUB2QSK\n QMjg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=AfD5hF4YxH2eRGPB0zmQocrKyWg+4CfE/9LB80/+Emw=;\n fh=m0LWPSouLTW2Nv2lHxcgK7HjYIQ6ci0tuGAt8H2F+EM=;\n b=cJrGk77EQ0gcLzyIfeW0gVNZ9/wJ8AxnMrKiiwjpH+rl00P25y0V9szQTjB1wVCb3C\n V6cwGyFNeSWNaTArUC1k5OxNJtNZjt48o7sulxDTcwn1OUbh8VwuJZirQicWWU1QiXTc\n LpBJtFFEixYR5JT/MkiK0tqh4iYiQq0BBZV/5IH65GtuLDqMxUSx6k8UEduAhbHeLh42\n pN9QDsyRNuKXFfkm6hhzpgh4g7KFPNm+mCSIMwFHKRwXK3Jo9Y3i7o/JRHYmjffz346h\n CXKyUqEPnNbcgAiv6xJrzwyLMQ8gzmV1oLnw5nuIyLTpCbX7VpW3ubKE55YCAf/9Nl4x\n pbUw==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776702995; x=1777307795; darn=lists.denx.de;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=AfD5hF4YxH2eRGPB0zmQocrKyWg+4CfE/9LB80/+Emw=;\n b=Ae5uFHNEcE0bEYLBiUWG/tw+Q3iSZxbNZoSgUYFoadNzF4Gh67qgnCZKs7vGvYxCl9\n zYFBmtaBxc7KMDTJMyQtQkEp4ceNgIDw9LwWIj0fwTRIJg2bWxBCwqLmcF+eCTNVUYSn\n X3OHS3QfYB+dTfPt1ZZsEtQie7SuvPLOpSvz9wjVTipEk8AoaeIPRA6um+EMWoYyC65q\n F9XMncCpqoh4PcKa0DGYLW28Doxx7VymReAH+ToHhMeW7JP4WBjK2MRcfT68ogcYVD9e\n 5zkFCIOFV+lAXam4D4r6gSnIFb8GIw+OUp2dqnQdC4FW9pVD3Kez7X1wG1Zm4oli8/vx\n TbSw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776702995; x=1777307795;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=AfD5hF4YxH2eRGPB0zmQocrKyWg+4CfE/9LB80/+Emw=;\n b=Cr689uicph/ayk5vrgwI4Wnw55OP9C4EwNUaFL+Dk4OUtL4UtgMDtZDZlXGbUl+AS3\n aC2VBihgUW+7xEa+K1xoikV+TWX93oveF1khgjZX2ccDsnOSrcP4hSL+rDX2uKou3M2s\n u73jjlhOXR1run6ucoOWxNXu6Ko8VAPRI3EqG5hHTTJW7ZL4J3HPViy7yCvUflRIgbYM\n zDJdaUcdNu/FLoomZCA/IH3F/DeQNyIm7Af6B+gQqlab3hWmkBNTfXgeUA+FmVpM9Pd0\n VkHFgN/sFjzo1NkXwKxJasLRbqLsXLhYSptTse8SEs1Lc6Q4evNDj2jEQrOLiu4hn7mt\n FNvA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9DKfFX3J9rTZEs0KAYkbgt4Ho5ElH13OlOzLddcGO2F6fU28wCu9t8/RNNfcjAuyZEfU5/a4o=@lists.denx.de","X-Gm-Message-State":"AOJu0YwefKyH9TKHUQzXMZhzRKDoNvQyWp4rLZaIFsT3vxzD1LBuPE7Y\n dncWE0rZz1EowgbFab55QkhSKpbaLKLSqONW1nAXriMlaziB2A0ttVssOpJ1BZHxfaPcI8qnMVe\n 9c44EjIm6IYld29rSlZlLkJPvGWexkoL3An3s65nB2w==","X-Gm-Gg":"AeBDievCwts76vvCsAkCnHbu+n24hjTLMJDaZtszkkdxs72lMxXtUmSQi4wE56/2ECC\n X88jBnniBrhkrie1x51Ghw/yDfhNZ2hjI7INM/dI/2F0Icrsl7dQrnH64yMpdoKYySi34l+cuo6\n 4A1HgIKyE617WqRvzW6aTUsuOINx+qXqz2LKEbzzmy8vh7v2rTpBnAPdTkE+8A1kFOIYCUaXcqj\n QruFkW2fq1UkgSy79hHsEuzAIY5FkDvwrEXrec8bdXrR8Sm5qqbftNhdW2WYsfbwUPUU0hoPsbL\n 5yfDeJkJ3WlYKvw8lUU=","X-Received":"by 2002:a05:6122:3a01:b0:56e:f262:9113 with SMTP id\n 71dfb90a1353d-56fa5a31a60mr5710121e0c.14.1776702994485; Mon, 20 Apr 2026\n 09:36:34 -0700 (PDT)","MIME-Version":"1.0","References":"<20260417130204.49896-1-philippe.reynes@softathome.com>\n <20260417130204.49896-3-philippe.reynes@softathome.com>","In-Reply-To":"<20260417130204.49896-3-philippe.reynes@softathome.com>","From":"Raymond Mao <raymondmaoca@gmail.com>","Date":"Mon, 20 Apr 2026 12:36:23 -0400","X-Gm-Features":"AQROBzCAwPxLH1l17v7b0WKMNk-pK4LhU-3GOKnH7OlHFElH7Bto8CqhawlCX1k","Message-ID":"\n <CAMDkj5zr8LoTyZECbnAznvcYPga+S1otLAoqzPnkq4bon0n+Jg@mail.gmail.com>","Subject":"Re: [PATCH v4 02/14] ecdsa: initial support of ecdsa using mbedtls","To":"Philippe Reynes <philippe.reynes@softathome.com>","Cc":"marko.makela@iki.fi, jonny.green@keytechinc.com, trini@konsulko.com,\n simon.glass@canonical.com, u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]