[{"id":3679177,"web_url":"http://patchwork.ozlabs.org/comment/3679177/","msgid":"","list_archive_url":null,"date":"2026-04-20T02:11:58","subject":"Re: [PATCH v4 06/14] test: dm: ecdsa.c: clean this test as software\n ecdsa is now implemented","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Philippe,\n\nOn 2026-04-17T13:02:04, Philippe Reynes wrote:\n> test: dm: ecdsa.c: clean this test as software ecdsa is now implemented\n>\n> The test ecdsa was done when ecdsa was only supported by hardware.\n> So it wasn't possible to test ecdsa on sandbox, and there is a test\n> to check that ecdsa is not supported on sandbox.\n> Now, there is a software implementation of ecdsa. So we remove\n> this outdated test.\n>\n> Signed-off-by: Philippe Reynes \n>\n> test/dm/ecdsa.c | 104 ++++++++++++++++++++++++++++++++++++++++++++++++++------\n> 1 file changed, 94 insertions(+), 10 deletions(-)\n\n> diff --git a/test/dm/ecdsa.c b/test/dm/ecdsa.c\n> @@ -3,36 +3,120 @@\n> + struct image_sign_info info = {\n> + .checksum = image_get_checksum_algo(full_name),\n> + .crypto = image_get_crypto_algo(full_name),\n> + .fdt_blob = fdt,\n> + };\n\nIf the crypto algo name is invalid, info.crypto will be NULL - please\ncan you add ut_assertnonnull() checks for both checksum and crypto to\ncatch this earlier?\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=amL+iZJj;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"amL+iZJj\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzTXR6YVwz1yGt\n\tfor ; Mon, 20 Apr 2026 12:12:39 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id CB30C8429E;\n\tMon, 20 Apr 2026 04:12:37 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 14708842C7; Mon, 20 Apr 2026 04:12:36 +0200 (CEST)","from mail-ej1-x635.google.com (mail-ej1-x635.google.com\n [IPv6:2a00:1450:4864:20::635])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 2BE9E842A4\n for ; Mon, 20 Apr 2026 04:12:34 +0200 (CEST)","by mail-ej1-x635.google.com with SMTP id\n a640c23a62f3a-b9c3a9fe80fso312018766b.3\n for ; Sun, 19 Apr 2026 19:12:34 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776651154; cv=none;\n d=google.com; s=arc-20240605;\n b=Wm71SRz956fIrA4j5M27kzfF10FfLEVsZF9aTq/mEWxQp/oc9S//ZAT0aIXcw/L5vb\n 9tLz8lNgeyDtjQSWYavaVUAE6LI+aPe5JUVj4EHd4sR6rEsg5hN6MbM+zaXUcjkiMjaZ\n /Pn82s7qG4G2A/1yNU3p+quByhDGW46BvygDohhNzsexqmsIciXETVEWP9Y6JyPOOi4G\n LtvPxJ4lEz7LE+1zgr0213Ag7yAfK9d4zA+XqEcw6Ishx2NSc13DHzav6hRYzelHFHhI\n p1ZMnyA1IQdVylD1jZ6N3iCan5fj1pJkiEUVUPsejUlAR1I7d83KzaUXkWI2Mnic3/+H\n zMmA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=P7j+41nACDJbYHW7DcJYsdikCwjI8i03mUClhpDUJwU=;\n fh=MARMZ3uT2jMt3s6dMYOO4Y5Qg4zEZXBBhj48MXTVEAU=;\n b=O8pnWS4aqdt/rUqkTExxI3rSI6immtwJCD3BMVGwUFYO8+wG51WUbgSO/7WDcUU5iG\n C3dL7LxDGABxEl13w2eknRDv4qHq8RW88ROlepNckEjARqQc8IPMXJbKvXp9fmxMKxfB\n Qd79razylFXvhJkiArlW7B+WPGL0MaV+NwQ9IcZXVokBVXddDpyOREJE3+sXu0a7rnAf\n fP8hjOhdPpo8v2Wbni1r+vjr6fEj2/J4t/+6/z2iVi7n2RoKiinZIXKtoJHyOmNGuciF\n 09SSYWwRxFaDvoxt33Ah/iyhur7ZhN7JJe0JaL4NnOGtGkd8BNLgLvyvMiW9JPaKcqDl\n 1KOg==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776651154; x=1777255954; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=P7j+41nACDJbYHW7DcJYsdikCwjI8i03mUClhpDUJwU=;\n b=amL+iZJju1zvv15O4448UvU/+0SrhR/ZhvK/sf1SYhnLDHFSXhboxrCj7iGuPMvSmh\n jk2msevNHbADuFU5MpAuZzH0OPN4RsxjsQ+1rG/+IaVV2zLGrB/p7vOiQ8c3mctnYlAM\n ElTW9rwcpYvC/Pxh9V+q+xEtet+oHomAmlGGk=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776651154; x=1777255954;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=P7j+41nACDJbYHW7DcJYsdikCwjI8i03mUClhpDUJwU=;\n b=MvodrdyvokBjoEaqynJw8YshZOEEW16Vr+8AacoVWdcSfU2dnvTPHf6yPA5l+yMPZH\n vp/5gFFHHcjuhte2UhDb5oR7olM1inbYIKDOeJSP5Wg8BdLNSow518ItkRehKMiYme4h\n jC6YztSmto3+yF8QOqXXr82gV16a0uhyOzO9l9k40Cbl8vO1QXOY0zLNFMgVEEZUsxAO\n sYLOxEZ75o7XdKNM3tlkREVGnBjFxGZRetnbaIHYADec8ggAZF2J//auuBkxmK10nQh9\n 0VeINRZbv+fkyqV5q/SAsjQGp/at7inZUWVEzQvt+MOisRDTPQwwvAYlpvdhP7ghRpQW\n 3Lbg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/GHqQkcxqSIy4SILsqcAAeCg6Kw5UFoCv0x8Hzyo8CgvBlDamJ/aQ9slrrnBELxtiCrTngE3Q=@lists.denx.de","X-Gm-Message-State":"AOJu0YwRtIJAxe4KafRjkwCQasRPIB1hgNjU5XRaGh53AbKfgY+WblX+\n t+2F6sniO9VDY+TAnMMqX1gFfFW4Rtitvkq0FJFZRtAY3bo5qdtZSBlyTJpBPHMawSoQMb7RJ8f\n PAyaQeHKjw6s1dvQqtvDl4I+LjVApyUR+YJx1DhT/","X-Gm-Gg":"AeBDietwKywE9uViCqIr9cemu+qRvIHAu0ReL2HD25h4G31a3jhneNlnt5wWhqNybRV\n MmbHs4hnMBNz7lU2D8Q/UupJPLnAan/4Z1v4xS9KfGn/G+xg26AvcuHhsEMfD9rqXixjOTUOzBS\n Joa9uZOERebQKrcJJGG4uAE5ETpw8coFRj3NLHgNBc5XZuiYhVum8sSsxXaHGH0m32CopaBWrkS\n cTlvDK72/LBkrLj1Y4eKx+e1sSC6fdGpxlQ5Si6pFQgW9s59MpfSX7EVKtVCyvzxs/rNh6PCcMA\n INKJzT+XoEcYWR3G6m3m","X-Received":"by 2002:a17:906:9fcb:b0:ba6:42ee:75f1 with SMTP id\n a640c23a62f3a-ba642ee77b3mr225339566b.2.1776651153554; Sun, 19 Apr 2026\n 19:12:33 -0700 (PDT)","MIME-Version":"1.0","References":"<20260417130204.49896-1-philippe.reynes@softathome.com>\n <20260417130204.49896-7-philippe.reynes@softathome.com>","In-Reply-To":"<20260417130204.49896-7-philippe.reynes@softathome.com>","From":"Simon Glass ","Date":"Mon, 20 Apr 2026 14:11:58 +1200","X-Gm-Features":"AQROBzC2vS-a0qWqUu-O39Pm-4b5BJv55DaS36MbPhr6eafjb9XdLNZ0f1dFJfE","Message-ID":"\n ","Subject":"Re: [PATCH v4 06/14] test: dm: ecdsa.c: clean this test as software\n ecdsa is now implemented","To":"philippe.reynes@softathome.com","Cc":"marko.makela@iki.fi, jonny.green@keytechinc.com, raymondmaoca@gmail.com,\n trini@konsulko.com, simon.glass@canonical.com, u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]