[{"id":3679180,"web_url":"http://patchwork.ozlabs.org/comment/3679180/","msgid":"","list_archive_url":null,"date":"2026-04-20T02:12:36","subject":"Re: [PATCH v4 11/14] boot: pre-load: add support of ecdsa","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Philippe,\n\nOn 2026-04-17T13:02:04, Philippe Reynes wrote:\n> boot: pre-load: add support of ecdsa\n>\n> Right now, u-boot can only boot image with a\n> pre-load header with rsa. We add the support\n> of ecdsa.\n>\n> Signed-off-by: Philippe Reynes \n>\n> boot/image-pre-load.c | 56 +++++++++++++++++++++++++++++++++++++++++----------\n> 1 file changed, 45 insertions(+), 11 deletions(-)\n\n> diff --git a/boot/image-pre-load.c b/boot/image-pre-load.c\n> @@ -70,6 +70,17 @@ static int image_pre_load_sig_setup(struct image_sig_info *info)\n> +static int is_ecdsa(struct crypto_algo *crypto)\n> +{\n> + int ret = 0;\n> +\n> + if (crypto && !strncmp(crypto->name, \"ecdsa\", strlen(\"ecdsa\")))\n> + ret = 1;\n> +\n> + return ret;\n> +}\n\nThis could be simplified to:\n\n static bool is_ecdsa(struct crypto_algo *crypto)\n {\n return crypto && !strncmp(crypto->name, \"ecdsa\", 5);\n }\n\n> diff --git a/boot/image-pre-load.c b/boot/image-pre-load.c\n> @@ -155,6 +185,10 @@ static int image_pre_load_sig_setup(struct image_sig_info *info)\n> + info->sig_info.crypto = image_get_crypto_algo(info->sig_info.name);\n> + info->sig_info.key = info->key;\n> + info->sig_info.keylen = info->key_len;\n> + if (is_ecdsa(crypto)) {\n\nYou already have the crypto pointer from the earlier\nimage_get_crypto_algo() call. Please can you reuse it here instead of\ncalling image_get_crypto_algo() again:\n\n info->sig_info.crypto = crypto;\n\nReviewed-by: Simon Glass \n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=nwMFSmL4;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"nwMFSmL4\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzTXx3rCRz1yGt\n\tfor ; Mon, 20 Apr 2026 12:13:05 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 962B5842D2;\n\tMon, 20 Apr 2026 04:12:59 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 55C7A842E0; Mon, 20 Apr 2026 04:12:58 +0200 (CEST)","from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com\n [IPv6:2a00:1450:4864:20::62d])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 6E700842CD\n for ; Mon, 20 Apr 2026 04:12:56 +0200 (CEST)","by mail-ej1-x62d.google.com with SMTP id\n a640c23a62f3a-b9358bc9c50so329516966b.1\n for ; Sun, 19 Apr 2026 19:12:56 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776651176; cv=none;\n d=google.com; s=arc-20240605;\n b=fa1XH6NkX2MjC8mzVLxsENSd3qEeTysiJRFReMy/p1HFSJn1utvn1k568T/dSf6Atv\n LxntrbDGNm47ic5vnjBooiYssT7rmJMakFuodqFBPgaZEUzMfWUFfcntP/DOKkzQNIuQ\n /TRc5aq9Tw2mCNQidO30tQlAzktEtMyVImtGadcsBfJoLef01K3i2n06i2fC3CkyG5/P\n w5JyaAl/n51ouIzU4D81n75Shdny3OIcf2KFWj0EPGOVfO+h43EyJRaTklZCHG2sZw37\n QmjH0J+YJkYBkyVqHckNivsJ/Kr5cKHE5EOH0iKfgy+9MWoKX/oyo4NHYYg5rnxr1ojF\n dpzw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=fp9SO0vKvUXZSO9DYWDG+v6onI45//FrPNbH6KQVKes=;\n fh=xWxtB0DwqTFpqqP3MO1e2qb9SRLKs49A/2aBCeif3yQ=;\n b=LYckRVwCZ5s4C/CwDnwG1ZWfIhrcbnwmBHG32BO6E9plFts1bi4xKc80wBezXpj7+J\n bWNIA7LkYfA5AhXvEJLNCHl5/zX6KH2QlxxqOkckp7iN0UedwX8mGjvgWYAU03sRg5Gp\n nrruOdhrmHftcvkj3yxEudbXi7GiqQFDeV9rh/qjbtvUud2yMPk9JAZbsP1amUa/lJew\n ck71vrzFG7xqUcWTqsGlVc4icZMF2hLH1Lpi11i+ZvwdkGVbWEv7tU7hYefe+OTpKovf\n W4Qu0fpJveAG7VuaFMr0yYFA8EQ/1fp97Iw9IgHoGX5by54PI4cmnINHqmezEEvyciZd\n 6SXA==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776651176; x=1777255976; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=fp9SO0vKvUXZSO9DYWDG+v6onI45//FrPNbH6KQVKes=;\n b=nwMFSmL4bxnKfDdthWQCpD9sl2ddlSlFcEfgVa4eeG2xmf0nLk8eMPRMy4U+spkUd+\n 7pmg6RC3CkXkdSahdcJjOfmK48cE3J/QBmF2m2itvLoeDugUXgDPJu+07kXvUz4vKzJ5\n 7caVXqjd8gMbwSS0IEBzPPKJ0B2RIBTBTO9Us=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776651176; x=1777255976;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=fp9SO0vKvUXZSO9DYWDG+v6onI45//FrPNbH6KQVKes=;\n b=phYZIlUJ6Z9VH7U0wYUv8o28rqwLEwwjMOk/KIER8pUodVniQtETeqNNbVKFeoysZy\n HuVYmhGwYUz6HakVPgP81ZhPSqo6vQ3OaXoC4hGt8tbJ+Xk08aoB5obnKBStSdZ6dd6k\n rJI8QaUg/XxXNu9tFHnoXi/dzAjYNYwKvxcdE4hy33T8OaX4DU2AqbrSRdN0+77v26tA\n jA4M5IlJtR+if530xon2n0xxW7NS+LzqZGOb+s91UVE7QNekwoN9xROCGEfhkFxs2JJf\n v1lprX3QAgPty70+h67nFA72G0TSwkTuG1jflusMdmypTXpnqca5kOFdQaFyGJYle+WH\n 3ZnA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8wYPIx05Mp+tG35o1R1CEgzo43kyYnEb7ML0+6UinpO+N+kWUJBe+aHbSfv7Fp47VpG0XQVpU=@lists.denx.de","X-Gm-Message-State":"AOJu0YwbambkH06YWZIDegX3mu1TNESH8uNlW4BqOS3zqAUFzWbWLehD\n U5G8pXzKzSLiUMaGTP7D4VTp1rgLxwZE5fd6Fb30yOXKmltvaMP7aFxvjyNVXbGK2Fe0fBnXgvj\n yZ+sz0qLSk1NvJ/AlJmYgNJyUSszNoFBHPBMwutonZGQ43EnPYHZA+B7f","X-Gm-Gg":"AeBDieum32/2ichIVM2aV1ngR9I1IghXD+fv6sO6wMtVZMLf69YRbQpPaRop4uvlWt3\n pGdKHm/QxkjbdLUPizjXkNJRIk4NIFkPAlHLkGQ9mfYAT1NXLD6UPB+x646yXeyeqUdhANQjDa5\n PHx5FP7gXu3SP0/SvMkiEuKdeteXed9X2/sHW81dDmpTwWp77mHJag7STJ9U3lG88TG8mBESGw/\n prOagHuM261pf5SandSRarCNpLM7Ge4UM+sxsxzGb4CmEmLqc5IrTulhLuDD+CQFU0SWcHuyVqt\n tD+hH4Hs2pXLvxqcDbmksFuZP2HG7Ts=","X-Received":"by 2002:a17:907:2d8f:b0:ba5:f23e:70e2 with SMTP id\n a640c23a62f3a-ba5f24dcdb0mr241600166b.44.1776651175818; Sun, 19 Apr 2026\n 19:12:55 -0700 (PDT)","MIME-Version":"1.0","References":"<20260417130204.49896-1-philippe.reynes@softathome.com>\n <20260417130204.49896-12-philippe.reynes@softathome.com>","In-Reply-To":"<20260417130204.49896-12-philippe.reynes@softathome.com>","From":"Simon Glass ","Date":"Mon, 20 Apr 2026 14:12:36 +1200","X-Gm-Features":"AQROBzCh4CjIeYLL7ZEk6NU6cFqgP4G-xgucYAIoqOZ4rTgY4Ed_viOlnwKueB8","Message-ID":"\n ","Subject":"Re: [PATCH v4 11/14] boot: pre-load: add support of ecdsa","To":"philippe.reynes@softathome.com","Cc":"marko.makela@iki.fi, jonny.green@keytechinc.com, raymondmaoca@gmail.com,\n trini@konsulko.com, simon.glass@canonical.com, u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]