[{"id":3679187,"web_url":"http://patchwork.ozlabs.org/comment/3679187/","msgid":"","list_archive_url":null,"date":"2026-04-20T02:50:29","subject":"Re: [RESEND v4 02/14] mach-sc5xx: Remove update commands from default\n environment","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Caleb,\n\nOn 2026-04-16T15:19:35, Caleb Ethridge wrote:\n> mach-sc5xx: Remove update commands from default environment\n>\n> Remove the update_spi family of commands from the U-boot\n> environment. These commands are not standard in U-boot,\n> and boot media programming has moved to Linux, so the\n> commands can be safely removed.\n>\n> Signed-off-by: Caleb Ethridge \n>\n> board/adi/sc573-ezkit/sc573-ezkit.env | 2 -\n> board/adi/sc584-ezkit/sc584-ezkit.env | 2 -\n> board/adi/sc589-ezkit/sc589-ezkit.env | 2 -\n> board/adi/sc589-mini/sc589-mini.env | 2 -\n> board/adi/sc594-som-ezkit/sc594-som-ezkit.env | 2 -\n> board/adi/sc594-som-ezlite/sc594-som-ezlite.env | 2 -\n> board/adi/sc598-som-ezkit/sc598-som-ezkit.env | 2 -\n> board/adi/sc598-som-ezlite/sc598-som-ezlite.env | 2 -\n> configs/sc573-ezkit_defconfig | 2 -\n> configs/sc584-ezkit_defconfig | 2 -\n> configs/sc589-ezkit_defconfig | 2 -\n> configs/sc589-mini_defconfig | 2 -\n> include/env/adi/adi_boot.env | 53 -------------------------\n> 13 files changed, 77 deletions(-)\n\n> diff --git a/include/env/adi/adi_boot.env b/include/env/adi/adi_boot.env\n> @@ -1,9 +1,7 @@\n> /*\n> * A target board needs to set these variables for the commands below to work:\n> *\n> - * - adi_stage2_offset, the location of stage2-boot.ldr on the SPI flash\n> * - adi_image_offset, location of the fitImage on the SPI flash\n> - * - adi_rfs_offset, location of the RFS on the SPI flash\n> * - loadaddr, where you want to load things\n> * - jffs2file, name of the jffs2 file for update, ex adsp-sc5xx-tiny-adsp-sc573.jffs2\n\nThe comment mentions jffs2file as still required. Patch 10 removes\njffs2file from all boards. Please can you also update this comment in\nthat patch.\n\nBTW, CONFIG_SC5XX_UBOOT_OFFSET, CONFIG_SC5XX_FITIMAGE_OFFSET, and\nCONFIG_SC5XX_ROOTFS_OFFSET are left orphaned in Kconfig after this\nseries. You may want to add a patch to clean those up.\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=bhZ/Ds5D;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"bhZ/Ds5D\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzVNX0Grsz1yCv\n\tfor ; Mon, 20 Apr 2026 12:50:52 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 229AF84181;\n\tMon, 20 Apr 2026 04:50:49 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id E02908419E; Mon, 20 Apr 2026 04:50:47 +0200 (CEST)","from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com\n [IPv6:2607:f8b0:4864:20::52a])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id A57DC839D9\n for ; Mon, 20 Apr 2026 04:50:45 +0200 (CEST)","by mail-pg1-x52a.google.com with SMTP id\n 41be03b00d2f7-c736261ee8dso790739a12.1\n for ; Sun, 19 Apr 2026 19:50:45 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776653444; cv=none;\n d=google.com; s=arc-20240605;\n b=Gbj/1zhOT0BvM8y1Mh70F6YjmOGHC0QpFdpjPpq073SPHNiGjfxy0Dqt7tcFETZmAr\n /sm1g+ji8NepDh67LIbc9RQeP9aHTNG9Ip4gzCigBq63XWszt8xg13K4CiRehISi5L6T\n 0VPogw9HV9e5JYmQfx2yA4zQUZFcJvGihtGo1n/tKnMdBSIx1nrNtgpDE04zwdJNhMzI\n qbhILkTgci62KXDHfvY69gAz/yS1CYWxgmd+jBzmzYBEZaLWrr4t56fL447FG4wyrFpf\n OrbSTuirqJ3fLK0oBze4+NF6KBEsc4bFK9FhPwIOPLVhnM5w5x4Y2U7eaXvM/CRJRGVv\n Eb/g==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=/gu4edmqze7fbFb1bNAVi6FLzmMwCgAp0jCIv6XXoPo=;\n fh=bAhO/2+dJLNIuyiSCWCsiQQck7gcMCfIwltRjKz8q4g=;\n b=e77RV8uY/VSmBbm38C/Xt8g71QlXZQelnH96B56TTsdnK/0vRGm/JDiLvIPNlrNyCk\n 9bSlQurdLTU8zgmQy68GUVgAfEMg42GwA+pmfurypJgRPUqe2XNZQTdxYU6vzXj5kGO2\n iT0DeWf6t76FaVYIFbDET+5tdDqEYoBAYYvGkeoVc04EwO1Pfm5wlKJulPk44QieBoPm\n gnf/cGZLlti2fguSuwDc2QcLQLk+PzgNyAxiyon5GffPyy1YO9IqyeelXVFTvBgsl22l\n hBE+6ZYu3Mz4zTGdDgvHEWdKxpPJmMEidxtY0SyRDsH/B99dw6Fvqnqc+9baqLDQIb7q\n vFUQ==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776653444; x=1777258244; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=/gu4edmqze7fbFb1bNAVi6FLzmMwCgAp0jCIv6XXoPo=;\n b=bhZ/Ds5DR13TU25IHnLdpnh5GpFyZEzNH2XN6YIgWDId8W9H/CcIU6V1bWB9QZFluv\n WyiPu5BlweSuaoOQaPCxlY4BPzWrbaV8kMyMLPLMojrJGIrV7Xm2hnDTKuViz3Hbziiu\n k4t7TW1jniDC5G6e7qvESW5bGp3q9/1sXRYfU=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776653444; x=1777258244;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=/gu4edmqze7fbFb1bNAVi6FLzmMwCgAp0jCIv6XXoPo=;\n b=fbxcuEP2tyj4ovrAF3N8YRCyFg8wV7PF+zD3p9bXNxQ/KRhIHM5DoPZ3PdCNYJQ+Vc\n GJjUy8NzEzTjgHDPL7pDEfz2XBCOcwAYx9MagPAe3xw0iHG/pQGni23DIXSU+fjcFhqB\n nQzt5rUsSB9vzACzumXrxJt/3wZvFFlka7t90bgjNMaGsTANTx2rb419BzzMBOFib/1l\n U/2pXS2z+D2AB3aGqiik/pHTUXjM8vks8+1xywdCJq77gkZC6UYFi1ZZHzNjsM8Y1clS\n 0qZE4Q3b+BxKbM8n1IpNEyelZwHKkI/rtRo6ahf8h1XsCgIcMJ27DQNxZbd+jShDBM2r\n vKMA==","X-Gm-Message-State":"AOJu0YzbjLgRWuYP8jP1cVEBqEDuo1UU+UyUNaFid3cv+9Q08iLCuJfs\n /20L94X6EwYAv/CBf/bGm3JFHOQzgKB1lfLIRWvCRgLVJO9yr23d5PouK7WmmEYOfak9/n7zlCf\n ZSHmMi8S85l7gs51ygXPBazpfUwl7SPOqt0Znp97Quao7mr8KHRuQRw==","X-Gm-Gg":"AeBDiesAiEOvh+guZMGS3bowuc4XLZy0MrKTZ612UT0bszLaL8xpA5rNlWoqFCtGQwy\n bxF+GtQT/YLnB9p+1gcyUpXRuagreKDbp0ylAELBAQQFcueF5iGd93Enq3+QAw+R89oQ60AS+r1\n sTKrsa6FJTMBRGrlVRqWDmT8DN/bLqEnR5jUSsSUxcC0NtpNFzTlRHY4cMxnWjR7ztxRoZjawkv\n YQikbHmdRixD/ImvnNoa4DKOoQqYnrb72mnC9te85+wlIEHtWfUENYDqdDSTqzlbRThTZ/z6YEw\n jCH8UWKqqL5v79/RcEAB","X-Received":"by 2002:a17:902:d590:b0:2b0:608d:d8a8 with SMTP id\n d9443c01a7336-2b5f9e8e4a9mr116383255ad.1.1776653444172; Sun, 19 Apr 2026\n 19:50:44 -0700 (PDT)","MIME-Version":"1.0","References":"\n ","In-Reply-To":"\n ","From":"Simon Glass ","Date":"Mon, 20 Apr 2026 14:50:29 +1200","X-Gm-Features":"AQROBzDJGuB2QA6SDkTfT88eILhSxrKl9gTlTAiMlune3hTZwHAJbzP0BuRZnSs","Message-ID":"\n ","Subject":"Re: [RESEND v4 02/14] mach-sc5xx: Remove update commands from default\n environment","To":"jcethrid@gmail.com","Cc":"u-boot@lists.denx.de, malysagreg@gmail.com, trini@konsulko.com,\n linux@analog.com, philip@philipmolloy.com,\n Caleb Ethridge ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3679937,"web_url":"http://patchwork.ozlabs.org/comment/3679937/","msgid":"<20260421142553.4157-1-jcethrid@gmail.com>","list_archive_url":null,"date":"2026-04-21T14:25:53","subject":"Re: [RESEND v4 02/14] mach-sc5xx: Remove update commands from default\n environment","submitter":{"id":92590,"url":"http://patchwork.ozlabs.org/api/people/92590/","name":"Caleb Ethridge","email":"jcethrid@gmail.com"},"content":"Hi Simon,\n\nThis comment is updated in the ubifs patch to remove the reference\nto the jffs2file. I will also update the commit message for that patch in \nthe next version as you mentioned in your reply to the ubifs patch.\n\nThanks,\n\nCaleb Ethridge","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=JklCfbs/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.b=\"JklCfbs/\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=jcethrid@gmail.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0Qqt71vfz1yCv\n\tfor ; Wed, 22 Apr 2026 01:14:18 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 50C3484337;\n\tTue, 21 Apr 2026 17:12:22 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id CEF4783FFA; Tue, 21 Apr 2026 16:26:03 +0200 (CEST)","from mail-qt1-x841.google.com (mail-qt1-x841.google.com\n [IPv6:2607:f8b0:4864:20::841])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 1091F83BC4\n for ; Tue, 21 Apr 2026 16:25:57 +0200 (CEST)","by mail-qt1-x841.google.com with SMTP id\n d75a77b69052e-50fb4a7d704so5828391cf.1\n for ; Tue, 21 Apr 2026 07:25:57 -0700 (PDT)","from cethr-l01.localdomain ([136.56.120.109])\n by smtp.gmail.com with ESMTPSA id\n d75a77b69052e-50e3945ae5bsm112398661cf.23.2026.04.21.07.25.54\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 21 Apr 2026 07:25:55 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_GMAIL_RCVD,FREEMAIL_FROM,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=no\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776781556; x=1777386356; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=U744R8zHaoK63i8566XE1JZFmuQ6DBRrKMnjLH9pZUg=;\n b=JklCfbs/681mUeSrcdob/QgpDLVPuX/BCeRGJsaLD2o9jo5zUy04sdbkU98rIgI8AP\n vpljabkCl3c7+m9RFEhb04ikUn5JhK1aHLn8KF1MiHpjLcwgmZJaVxAeAYCxX2fwgSo8\n M6BtcbTcuMlpJoe3W/QbdrOMSFIm49b2EHNrcsf2QtSGzJGYzTHDYc2YvFIPiuQ8IMxP\n CE3Ed58xnKeJA+Z9e/dqxztMurjSG8RwzH4S2ZEkTtmaGiBqUXW67w+fwkBbD/jJ+AOq\n T1uLFTeqLw199hVqQN97yQghAMZ14nrabX+t1ctC64H7jujCazHZP8mr4fzFI7f5IWb8\n 0qrg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776781556; x=1777386356;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=U744R8zHaoK63i8566XE1JZFmuQ6DBRrKMnjLH9pZUg=;\n b=Aq7WneGzY/uxv45tO+ZUbVuQI5qJE1beYLzKWrqLf/cC1u6F/XLy8rm0SFSifWZoyM\n 5/5AxKDGUlYiN6En/Oh1r6aWeWqywAATVPpultHrlmHd5d4dRFIkUf3UV0OfNLi6/eFe\n nHIcZBE09uXI5AktxZmq9XStwnUCu4SfUbF2F2OVwXtGScD099a4qW7d+SYlczqmIBCu\n Ey4xIbGQIH2u99cvZ7q3NYwtOLVYRwoEIaTy076YUf266SyCrGso/2Nn41TmuVSpQt4h\n Ot/neagaa31OYqDn0hq5PvwWZazFmjtmaNW4WD0c5y/6NnEuKCGo389bJ4Y0WAKiXyyl\n o+xQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+Z91O6CLpKmR1JaAb15hxV9tVyUtiTwbKGrMMx/7XWkhI/vbUpYPI+VC0/2Yw2FQWiEqguZms=@lists.denx.de","X-Gm-Message-State":"AOJu0YxwFrw3gnH6CRetuZvINfNDy+4vRSu6GvSihBOQvZsTJwkCDFSJ\n HDRfAwCoJbN0nq5xgfeAae/1sY7zryhQkHpXNGTIX45FAoeWoXvrGD6iLz1i6ZRg","X-Gm-Gg":"AeBDietjzVxrFCEfiuxmsS5B7eSB5xPflQ+W49r78Z7OwvayZnAO0yFcgsF6uLeY+/Y\n x0eh8soopPKLr3u42G3W1FnuIRfL6ZQlu6nOP/xZ8skQsY34zlRFwyWFzL3vzPEjVt8j5LqD+CK\n EOe+hLDHZ+eyz5iOfk0xzHrQXxpm8++TLgDb9cLC/eo/9Qoi0UaAZt7z2lFXbqJBQ1q+XRG+Jdw\n ifU9AGUzmNvyicIE74sv1y8eGdBBRWlsjMqegFAl+x7SVvf9MkXN5AvSvhytSq8AEozpqo5VT5Y\n xG/kvodHXyxxJcha6EEHz01RuZgQXisShngFsh55Y/mYmOa0tLhA1ROXJX2ZYh6YMJ3+tJxoVKO\n j5d+rsUV/DJBqZs4ephFKL1LXXPXhoDTHKUEZlmtEGAl0n73FirGa01q439lsnacbW5OZ0YWkkG\n cpCEsm+rWu2dACqF0kIK6UvRe9JwmxJhRJ4ODwynXcXnKTvk5XBaj5I0Q=","X-Received":"by 2002:a05:622a:1208:b0:509:44c3:5ffa with SMTP id\n d75a77b69052e-50e36c69265mr255146621cf.52.1776781555773;\n Tue, 21 Apr 2026 07:25:55 -0700 (PDT)","From":"Caleb Ethridge ","To":"sjg@chromium.org","Cc":"caleb.ethridge@analog.com, jcethrid@gmail.com, linux@analog.com,\n malysagreg@gmail.com, philip@philipmolloy.com, trini@konsulko.com,\n u-boot@lists.denx.de","Subject":"Re: [RESEND v4 02/14] mach-sc5xx: Remove update commands from default\n environment","Date":"Tue, 21 Apr 2026 10:25:53 -0400","Message-Id":"<20260421142553.4157-1-jcethrid@gmail.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"\n ","References":"\n ","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Approved-At":"Tue, 21 Apr 2026 17:12:16 +0200","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]