[{"id":3679088,"web_url":"http://patchwork.ozlabs.org/comment/3679088/","msgid":"<874il7axqt.fsf@igel.home>","list_archive_url":null,"date":"2026-04-19T13:24:58","subject":"Re: [committed] libstdc++: Add comments to non-obvious parts of\n std::print internals","submitter":{"id":2170,"url":"http://patchwork.ozlabs.org/api/people/2170/","name":"Andreas Schwab","email":"schwab@linux-m68k.org"},"content":"On Apr 17 2026, Jonathan Wakely wrote:\n\n> diff --git a/libstdc++-v3/include/bits/print.h b/libstdc++-v3/include/bits/print.h\n> index 67a5a1729135..ab3ff9996126 100644\n> --- a/libstdc++-v3/include/bits/print.h\n> +++ b/libstdc++-v3/include/bits/print.h\n> @@ -58,7 +58,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n> \n> namespace __format\n> {\n> -#if _GLIBCXX_USE_STDIO_LOCKING && _GLIBCXX_USE_GLIBC_STDIO_EXT\n> +#if _GLIBCXX_USE_STDIO_LOCKING && _GLIBCXX_USE_GLBC_STDIO_EXT\n\nThat's surely not intented.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n spf=temperror (SPF Temporary Error: DNS Timeout) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org; dmarc=none (p=none dis=none)\n header.from=linux-m68k.org","sourceware.org; spf=pass smtp.mailfrom=nefkom.net","server2.sourceware.org;\n arc=none smtp.remote-ip=212.18.0.10"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fz8Wg4mRDz1yGt\n\tfor ; Sun, 19 Apr 2026 23:25:30 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 879CB4C318B0\n\tfor ; Sun, 19 Apr 2026 13:25:28 +0000 (GMT)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10])\n by sourceware.org (Postfix) with ESMTPS id 9D8154BA23E0;\n Sun, 19 Apr 2026 13:25:01 +0000 (GMT)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10])\n by mail-out.m-online.net (Postfix) with ESMTP id 4fz8Vg6V9pz1sG89;\n Sun, 19 Apr 2026 15:24:59 +0200 (CEST)","from frontend03.mail.m-online.net (unknown [192.168.6.182])\n by mail-out.m-online.net (Postfix) with ESMTP id 4fz8Vg4Srbz1sG7Y;\n Sun, 19 Apr 2026 15:24:59 +0200 (CEST)","from localhost (dynscan3.mnet-online.de [192.168.6.87])\n by mail.m-online.net (Postfix) with ESMTP id 4fz8Vg2hrBz1qqlR;\n Sun, 19 Apr 2026 15:24:59 +0200 (CEST)","from mail.mnet-online.de ([192.168.6.182])\n by localhost (dynscan3.mail.m-online.net [192.168.6.87]) (amavis, port 10024)\n with ESMTP id KvGs_SihusHS; Sun, 19 Apr 2026 15:24:58 +0200 (CEST)","from igel.home (aftr-82-135-83-10.dynamic.mnet-online.de\n [82.135.83.10])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mail.mnet-online.de (Postfix) with ESMTPSA;\n Sun, 19 Apr 2026 15:24:58 +0200 (CEST)","by igel.home (Postfix, from userid 1000)\n id 81FD62C16E2; Sun, 19 Apr 2026 15:24:58 +0200 (CEST)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 879CB4C318B0","OpenDKIM Filter v2.11.0 sourceware.org 9D8154BA23E0"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 9D8154BA23E0","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 9D8154BA23E0","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776605101; cv=none;\n b=SI1MxTlgNS1PNWKhw4GjpekaWgN6j9V9QTLCg8SxLUmiR1FEjZF2qg4/msDfYrYusm2WAMxxwG9Bgj3QzsKTZJTDmV4HrNwlKgiSaLRGSeWXwT91J5LDnNxTk6u1npIxBr+UMT510fFj2ir4YRTEU8fMEBCWTZtZN6brWNTTybQ=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776605101; c=relaxed/simple;\n bh=zp2qK2J4xi2mqLz16XjsFg5UQbmOWEOASC1E+jeEZPs=;\n h=From:To:Subject:Date:Message-ID:MIME-Version;\n b=BLjUJJpJ3EXYcfS3r3sPaDkfxhWC7s1XAV4EPL4TiD5gzdGX8bxFM1nQzlbrwfhbF5Ev0PKm4/2AQ5j6cPCN8cTR9f3IMPxpojIQQsQ4R74SFM2rf4dI0GYEi1YgaUVPnIN0Tk5wAQ1mwjxnwdDH6PzFtI1QuTFHd5QsUKsGc3k=","ARC-Authentication-Results":"i=1; server2.sourceware.org","X-Virus-Scanned":"amavis at mnet-online.de","X-Auth-Info":"wd7vLJW8NeQyuWe1IPXMMjJBPZoyLCPIwZpRLCTD+7GzffoeU5uBR4pLgjT42zGq","From":"Andreas Schwab ","To":"Jonathan Wakely ","Cc":"libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org","Subject":"Re: [committed] libstdc++: Add comments to non-obvious parts of\n std::print internals","In-Reply-To":"<20260417124727.324242-1-jwakely@redhat.com> (Jonathan Wakely's\n message of \"Fri, 17 Apr 2026 13:47:16 +0100\")","References":"<20260417124727.324242-1-jwakely@redhat.com>","Date":"Sun, 19 Apr 2026 15:24:58 +0200","Message-ID":"<874il7axqt.fsf@igel.home>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","Content-Type":"text/plain","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}},{"id":3679105,"web_url":"http://patchwork.ozlabs.org/comment/3679105/","msgid":"","list_archive_url":null,"date":"2026-04-19T15:36:08","subject":"Re: [committed] libstdc++: Add comments to non-obvious parts of\n std::print internals","submitter":{"id":4329,"url":"http://patchwork.ozlabs.org/api/people/4329/","name":"Jonathan Wakely","email":"jwakely.gcc@gmail.com"},"content":"On Sun, 19 Apr 2026, 14:25 Andreas Schwab, wrote:\n\n> On Apr 17 2026, Jonathan Wakely wrote:\n>\n> > diff --git a/libstdc++-v3/include/bits/print.h\n> b/libstdc++-v3/include/bits/print.h\n> > index 67a5a1729135..ab3ff9996126 100644\n> > --- a/libstdc++-v3/include/bits/print.h\n> > +++ b/libstdc++-v3/include/bits/print.h\n> > @@ -58,7 +58,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n> >\n> > namespace __format\n> > {\n> > -#if _GLIBCXX_USE_STDIO_LOCKING && _GLIBCXX_USE_GLIBC_STDIO_EXT\n> > +#if _GLIBCXX_USE_STDIO_LOCKING && _GLIBCXX_USE_GLBC_STDIO_EXT\n>\n> That's surely not intented.\n>\n\nIndeed! Somebody else pointed it out and I have a fix ready to commit\n\n\n\n> --\n> Andreas Schwab, schwab@linux-m68k.org\n> GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1\n> \"And now for something completely different.\"\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=Hy23y7yG;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=Hy23y7yG","sourceware.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","sourceware.org; spf=pass smtp.mailfrom=gmail.com","server2.sourceware.org;\n arc=pass smtp.remote-ip=209.85.167.53"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzCRN1Pl3z1yGs\n\tfor ; Mon, 20 Apr 2026 01:37:18 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id D644A4AADCF7\n\tfor ; Sun, 19 Apr 2026 15:37:16 +0000 (GMT)","from mail-lf1-f53.google.com (mail-lf1-f53.google.com\n [209.85.167.53])\n by sourceware.org (Postfix) with ESMTPS id 0C2284C900E9\n for ; Sun, 19 Apr 2026 15:36:22 +0000 (GMT)","by mail-lf1-f53.google.com with SMTP id\n 2adb3069b0e04-5a415fd6bceso2473001e87.1\n for ; Sun, 19 Apr 2026 08:36:21 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org D644A4AADCF7","OpenDKIM Filter v2.11.0 sourceware.org 0C2284C900E9"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 0C2284C900E9","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 0C2284C900E9","ARC-Seal":["i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1776612982; cv=pass;\n b=O3Qf2GCeC+2LXGS9rhy7fdpPMxDBuxhgcwTl4QZROOhDFhttrcCQO3QxNtVmkaeKF9Por7absvLJICSS/GbEzKROWlMENCaVj+eHUehZEV1c+JbLuoowPWp7Mqk/gdFW3GeynPlkLNeRRRtOUnimliG8cTSYvqjkDXInHlM87T0=","i=1; a=rsa-sha256; t=1776612980; cv=none;\n d=google.com; s=arc-20240605;\n b=BfTX8VKFs8LOXgNQZhJXNGeAxOGFxGRMFRwA0Oe9ox2ACSnJ8z2mss92dWF2UguPb9\n o8sVqtzzQNTm8R+WFQvMQC0Lhdxd74RmI1t7PGMcbvSWzGFkpMA3l6bejiGjPFD2J8Ja\n xbmcNsytD1sap7l91f+Yv9+w8KIYM+AKWTt3h1helXuBpy879CocwnizDOqyQJKQzzm5\n YQZY9i8yJqYd+15JAwRXiU7ZGEVJykph5z14qS2fRuL9q9Vk5G63QcCm8f2+SA/Ms2tF\n WR2ml5elyANmptp2yxCbGjnxUcLbAdR8KgZJW1O3k5O14JFmmJPelRLXquSC604AsPvs\n C1Jg=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776612982; c=relaxed/simple;\n bh=pFHX/dx5CiCkWbnBVytHmXJowjpduOBrukAUPeMGNgg=;\n h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To;\n b=VF5jQSvMxWzAgxzXwvZ2tJ8JcpS9d/pyLnNaGgVTvBDqdp/Y/TfLGP+GpPRvshiDmwXy6/cllJzAkYOUe9xEZVz7lLNp2FjSCH87VPT64l9+7Na09cbgRVgIgzGzQwiRx96t5qP57SPox/y2plPE8D4d5PSgo/XYvWgsd7Rc9tY=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=K+ZJfXfjoVcE08culeCWSOsuUDbYMkevAK02DXJPHcw=;\n fh=Bjwv8jOP51MhoeLAYC4Cod/tPTbYzlhDvkNLuBuAD50=;\n b=VoroqN1Te7SbN5U5+lXqBMRaZ7W2kDJZJB89VOcLmR78NDDguINX2A7Vwjg87ktdDq\n 1j66xo1aaRcamww6crFqnQ2Z+rvuNBaFHjiWjMYMofu3CXaYFwKATMEW4JH8Iwi8ZHJ/\n NjcHUl2lj2dWXdYyUKVtfj1fyJOsb2lOuAB9u5M7kMggEXO+CSWs+ZNILndJHvDQJHYo\n Bn8xRETxvn2jBdK4eRFIIq/I4fK040zRpD3VlGENmz8mOzBvHP8Lym+GBuOfqLjUaxL9\n sHvsLmA0VP3q2bHAUUlAOYnbpewuDGNb9ekiS/EmFE+LCHTqGBwtMvqQgTQmGLrI1thN\n 0yhw==; darn=gcc.gnu.org"],"ARC-Authentication-Results":["i=2; server2.sourceware.org","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776612980; x=1777217780; darn=gcc.gnu.org;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=K+ZJfXfjoVcE08culeCWSOsuUDbYMkevAK02DXJPHcw=;\n b=Hy23y7yGjfDlD7zPJqwer5mN4uZPYHEbji+jFjj+naGvQAMmxTwcwg2sqLYer4SthM\n AIRwF5bZmFOTL/z0+s5O+KUj9PI2v0pZApk0GyW8mEDzKUQUdNwfqwt+y0QFQsqMqoYn\n q4Vo/m4k5dOhBjGJID3fIWrPRjpdJOfS/vdCTTDSrChGCq7/1DI8ETb/LR/8E0AkvIzD\n 9h2WfUXgcdpm8R7ddacEMGxYuh1/0KUAZv9HIxhUwEdIOAu6sAdEpTy8RZ46ihdaQwiU\n L8c3hkcZlNBtLxcugsWWqB3cgIhzev6JUtIHomedLHVVKX9Rn9Mi324bE4T9mGubp82u\n 6akQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776612980; x=1777217780;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=K+ZJfXfjoVcE08culeCWSOsuUDbYMkevAK02DXJPHcw=;\n b=EWCGfWHY6NC5H+HU4k5f2KKRLfMYmAAS/RwlzNohNKFP5ZkZMdxCHHBNRFfdxusAZW\n 9WmFwYmI5wnXhmMVteYbw+2y14AJLYjhhRMrqoVdAoynJgTpKz0fKnZNsyfOMeRLE7Y2\n sPFeNH3+XHoYxiwwkXkq7GhC8+GhV5S/WQNU9MH9fnnJK2v3ismlP/GARRDuxqXL4uqB\n qY6qoZGOyZRkq+vH8VzTzhVfck23P6m1tO7+jTUEkEqAOLV83htisfUloWup8KOUiHKN\n PJM9tiu+mwSs+9e3lt/h6kxO7IXIwC65f/hgXIkHj+nbMYgLEibVLhXWbUnesrgh3c1y\n lWEw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9wamiGmCs/5UZgwja1EyUInh/fZY0D9Ub6/C6OiypnSIhoZ8tIkrsQoXBIJZtwxuglTQlOj5vJ9rJpBw==@gcc.gnu.org","X-Gm-Message-State":"AOJu0YwITz99JFHyxxm2iADgSjj54WFaLFgeNeo5i+7+LyUVg1EVbH1G\n 7vYud8r9FKQu1Kj5uwcoVGKMpb8Xxjenq9mUiV4aFG1kHWYp1WtBgYB0NeYKMnmo9j+57ZMf95W\n pQXyScblU01rdsurL9SH1Io3eIWJMFvM=","X-Gm-Gg":"AeBDiet5MFZL37Z9rY/nxdWj20NZeL7y96WRVActTao8KK06HlMC3Ryh8+DuRmz0iP9\n K+S3sX6/iN5NLfqkT9G2ZEylw2HPuxDwr3rvLV+kuekeoWfitDMB42ySZ/dUhyXAF3tQ5exJxeD\n B1AXFgZ2pDqCrIikrHdF9Cpsq7dJJ4O74xwVmZP4zP40RT5tPaQpVW9Ru/19jaVYoEq/+rmaeal\n qGrjOdPKD7QJfM+eunHUwxi49f3pQaFxm7/CeHR+p30yW/LuhGGjxWtUiKYKcRZ72Qo2bKISu98\n b1CvqypX47lVgEF59v5p0kTCgYaqpa9lqrj0UasAYsa6J/VqvgJWbhPhXLz4M5szv1cWZRpqUj2\n lWyM=","X-Received":"by 2002:a05:6512:3502:b0:5a1:3d08:cfab with SMTP id\n 2adb3069b0e04-5a4172a9d81mr3058874e87.23.1776612980210; Sun, 19 Apr 2026\n 08:36:20 -0700 (PDT)","MIME-Version":"1.0","References":"<20260417124727.324242-1-jwakely@redhat.com>\n <874il7axqt.fsf@igel.home>","In-Reply-To":"<874il7axqt.fsf@igel.home>","From":"Jonathan Wakely ","Date":"Sun, 19 Apr 2026 16:36:08 +0100","X-Gm-Features":"AQROBzCS8-F_7VUou-3rk3lLd7eYdM2hK2EH4xsHQYVrg9cFoVBHbuLDw_DteWo","Message-ID":"\n ","Subject":"Re: [committed] libstdc++: Add comments to non-obvious parts of\n std::print internals","To":"Andreas Schwab ","Cc":"Jonathan Wakely , \"libstdc++\" ,\n gcc-patches ","Content-Type":"multipart/alternative; boundary=\"00000000000096c032064fd1f185\"","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}}]