[{"id":3678836,"web_url":"http://patchwork.ozlabs.org/comment/3678836/","msgid":"<87tst9pm18.fsf@draig.linaro.org>","list_archive_url":null,"date":"2026-04-17T16:52:03","subject":"Re: [PATCH v2] hw/display: don't accidentally autofree existing\n virgl resources","submitter":{"id":39532,"url":"http://patchwork.ozlabs.org/api/people/39532/","name":"Alex Bennée","email":"alex.bennee@linaro.org"},"content":"Alex Bennée writes:\n\n> While sanity checking a create blob operation the use of the auto\n> freed res variable could lead to inadvertently freeing an existing\n> blob.\n>\n> Avoid this by in-lining the virtio_gpu_virgl_find_resource() check as\n> the value is not needed anyway.\n>\n> While at it add a comment to the end and use g_steal_pointer to make\n> it clearer the object lifetime exceeds the function bounds if we pass\n> all the checks.\n\nQueued to virtio-gpu/next, thanks.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=EGsaJzhO;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fy1C83cy2z1yDF\n\tfor ; Sat, 18 Apr 2026 02:52:35 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDmQM-0007vd-Ih; Fri, 17 Apr 2026 12:52:10 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDmQK-0007v2-Hr\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 12:52:08 -0400","from mail-wm1-x334.google.com ([2a00:1450:4864:20::334])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wDmQJ-0006xy-58\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 12:52:08 -0400","by mail-wm1-x334.google.com with SMTP id\n 5b1f17b1804b1-488971db0fdso9790475e9.0\n for ; Fri, 17 Apr 2026 09:52:06 -0700 (PDT)","from draig.lan ([185.124.0.195]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fb735d3dsm46695775e9.2.2026.04.17.09.52.04\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 17 Apr 2026 09:52:04 -0700 (PDT)","from draig (localhost [IPv6:::1])\n by draig.lan (Postfix) with ESMTP id E48865F94F;\n Fri, 17 Apr 2026 17:52:03 +0100 (BST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776444725; x=1777049525; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:user-agent\n :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=YT9gS9On7LLenSSPLX9dnx/7rlBrHnGqh5jdqZ3EM24=;\n b=EGsaJzhOj+jVWA2QbGGtx/bpA3vtU/cZLz378UHDjdNIirYJmnXAMX/1OoiaZOlKbe\n xzSPycIlqd3xA/zmvjmmaPBXADyKZwNN/XuUOvqDwGytaUQGL8TpS5k7rG+SoCeOkcGH\n i1vm98JSWEC+XsOMgRpkDZQ1rNRtee0LyWIHC9kG1q05ac7cWuEX7XXMJTzctNBFGJlg\n d9iWou2R7OfUWMK97TBWNYA4ZSJCbqudESII3HFObYC/imnTLQkNw9oQ4WAlZGJFn7Po\n YCB+4OFP3/RCy4RjT2KiH50EG4pb8QWmPWTwXkcuh3rxclrLG/Ho2LFPHjwGsrFxpGnG\n zepw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776444725; x=1777049525;\n h=content-transfer-encoding:mime-version:message-id:date:user-agent\n :references:in-reply-to:subject:cc:to:from:x-gm-gg\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=YT9gS9On7LLenSSPLX9dnx/7rlBrHnGqh5jdqZ3EM24=;\n b=aNdEGLyBSVBMWhZgodh4qfLP9iMlsZXty3mhJdz9XQ64LlEm78ifAQeu8Ju8oacD7n\n FHIruZCvoGgYzYVWXJmftQl23GJ0J1bcyhtdl85tr3Uxp6gxEhuPj5ALsJMw9m6f9GyV\n ZXZjEUIohq/smpHjzgcazhLm9Zt2HBDuyQA1Z6vtpGHIGAMRBExTSqX/YxUxl1K+ltKw\n rvEOdAmOO5uCY4mL6eFRG2eQzkDRem0k5xeGQ1hyPgUzTcMtYXlBDEM2jxW3BR8C9FB/\n JP6gEClLHB/oMBYsffiZevkbw47F7+DgfmPTRO9uHew9E4Inouhjq8nh3WPCZEAkfzpO\n MHFw==","X-Gm-Message-State":"AOJu0YzKvTBcQMRc23Kk7L5sE6VkhORQuf3zqjjOsnEyD/YUeu/U81bZ\n Al+z0fGwPDlij7veC9HPKFr4aFqkPeER9gJOju6TMF55VNaoqj70sAyJbI3ZajeRTxY=","X-Gm-Gg":"AeBDies06skXdvZFdfR6DZzn6ypFs0TSLKaLTnhAg4ToSdEYJLlEFwXn/mkAw+kpY5p\n 8M7EtCdhO4wtE0brzFXK8auLxHYWuR2bgtbLaerHze9S/iVQkMxa/s50nAyjB4ifm+6wrsl3Pnt\n hFHt18eZ0LeZvlhAI6BNIhVgkp5/yzIMABHiWgVpZhomGqHBm6rxYHA0le38icasndVOKyXb8Nb\n GsEOp6i397jb+RflcfrOMjRih01N9GOw69ymU4i+xaTqlsPbhmulctUvwPofKA7hq6lJZTWgQOQ\n go3OJyzngV0B3MnbAmWgelw3RON8TNnSuA4dDc/WZkcdQVDE4WD/a6DJtJEoD8cRFPRoognw/po\n q6PHyii/vmR6Sa615YYMma1UBlLPQqjshcCV+kLVX862OH+rgiMy2Pq7Amraxs7AV/eUDnwPth8\n oKQ32xo9ZjhsMUXzg6DGqteM4270AnbkbKk/0cm6kjbWW+","X-Received":"by 2002:a05:600c:3150:b0:488:9fb7:376d with SMTP id\n 5b1f17b1804b1-488fb792ce4mr54451805e9.28.1776444725338;\n Fri, 17 Apr 2026 09:52:05 -0700 (PDT)","From":"=?utf-8?q?Alex_Benn=C3=A9e?= ","To":"qemu-devel@nongnu.org","Cc":"Manos Pitsidianakis ,\n qemu-stable@nongnu.org, \"Michael S. Tsirkin\" , Akihiko\n Odaki , Dmitry Osipenko\n ","Subject":"Re: [PATCH v2] hw/display: don't accidentally autofree existing\n virgl resources","In-Reply-To":"<20260417122703.845442-1-alex.bennee@linaro.org> (\"Alex\n\t=?utf-8?b?QmVubsOpZSIncw==?= message of \"Fri, 17 Apr 2026 13:27:03 +0100\")","References":"<20260417122703.845442-1-alex.bennee@linaro.org>","User-Agent":"mu4e 1.14.1-pre2; emacs 30.1","Date":"Fri, 17 Apr 2026 17:52:03 +0100","Message-ID":"<87tst9pm18.fsf@draig.linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","Received-SPF":"pass client-ip=2a00:1450:4864:20::334;\n envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x334.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]