[{"id":3678733,"web_url":"http://patchwork.ozlabs.org/comment/3678733/","msgid":"<20260417132649.3984-1-linuxtestproject.agent@gmail.com>","list_archive_url":null,"date":"2026-04-17T13:26:49","subject":"Re: [LTP] mremap07.c: New test for mremap() with MREMAP_DONTUNMAP","submitter":{"id":93132,"url":"http://patchwork.ozlabs.org/api/people/93132/","name":null,"email":"linuxtestproject.agent@gmail.com"},"content":"Hi Wei,\n\nOn 2026-04-17, Wei Gao wrote:\n> mremap07.c: New test for mremap() with MREMAP_DONTUNMAP\n\n> +static void *fault_handler_thread(void *arg LTP_ATTRIBUTE_UNUSED)\n> +{\n> +\tstruct uffd_msg msg;\n> +\tstruct uffdio_copy uffdio_copy;\n> +\n> +\tTST_CHECKPOINT_WAIT(0);\n> +\n> +\tstruct pollfd pollfd;\n> +\n> +\tint nready = poll(&pollfd, 1, -1);\n\nNit: declare all variables at the top of the block, before any statements\n(struct pollfd and int nready should move above TST_CHECKPOINT_WAIT(0)).\n\n[...]\n\nReviewed-by: LTP AI Reviewer \n\n---\nNote:\n\nOur agent completed the review of the patch. The full review can be\nfound at: \n\nThe agent can sometimes produce false positives although often its\nfindings are genuine. If you find issues with the review, please\ncomment this email or ignore the suggestions.\n\nRegards,\nLTP AI Reviewer","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=N9Te93XV;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxwdw0dsBz1yD3\n\tfor ; Fri, 17 Apr 2026 23:27:00 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id A0C0D3E2730\n\tfor ; Fri, 17 Apr 2026 15:26:57 +0200 (CEST)","from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [217.194.8.2])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 3C5213E1B53\n for ; Fri, 17 Apr 2026 15:26:54 +0200 (CEST)","from mail-dl1-x1242.google.com (mail-dl1-x1242.google.com\n [IPv6:2607:f8b0:4864:20::1242])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-2.smtp.seeweb.it (Postfix) with ESMTPS id BD050600631\n for ; Fri, 17 Apr 2026 15:26:53 +0200 (CEST)","by mail-dl1-x1242.google.com with SMTP id\n a92af1059eb24-12c555f886dso587144c88.0\n for ; Fri, 17 Apr 2026 06:26:53 -0700 (PDT)","from\n runnervmeorf1.amq2aokpdqoubhi1rrhh5bwnsg.yx.internal.cloudapp.net\n ([128.24.160.246]) by smtp.gmail.com with ESMTPSA id\n a92af1059eb24-12c749dc86bsm2690078c88.8.2026.04.17.06.26.51\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 17 Apr 2026 06:26:51 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776432412; x=1777037212; darn=lists.linux.it;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=5RdRbN8Br8awMWc9RsDeLspQLyqD6+eMJYgu9h1qO20=;\n b=N9Te93XV7DBGjrdtTH/X8mbEL47p4Am+XPyqloGgv6Ym0RM5afq8g1N6ZPsKQDs/DG\n 5/lbwRdknojvajbNfq92+nnTgmDsvd2jmyHil2CKkYUO0OKASZ8ZPE9yKYrH4/tmfj1Y\n 2N8TDr1JcUUJyinSwMCaXdTTDMUfcSsstepHHD4u/AmFK+q8JizLNXxi6YLLeFfQbcDc\n +SILPKByFNhWD3JYtpNxr0v76yYsQqbesdHm6mWIYl6fL8w55SsiDTfqlf184M/crzQP\n mXZmEO8APUUhsOzzb/2bGVTPOyBjyTlXWWa704PgJaOEY8WgkDKRvIZIBrFXWHGKq+8j\n lozg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776432412; x=1777037212;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=5RdRbN8Br8awMWc9RsDeLspQLyqD6+eMJYgu9h1qO20=;\n b=aoHM3nKC3Ii+o+GUhNAaNwy123QZp4hWpIuiQtIDXSeRlkkWKW/2g1zh6XGdakrHSV\n DMJMq9pR5mnMZe+H6cZWU+Dz64QIDs+lzOhy/FpsfxwD/6lHVeuJKvSayrsACc4jqmFi\n T65RENMsrlRvrQTK/A25unOARXhf57lyRtFU0Mb0vT496hqHvbIXCJRWJtVG0D9zgdpU\n 1tRZDzuc55w2HI8libqn12812fpcEDSdd+IngQ8x+zIfLAzyrCGZYr8QLhgD3KFHSwMv\n I3TBicrjduS+W3AOidItiI9a5bghyUpUt3hfVX60cqtCNoJQKzbtKmjeBr1FN903kbYr\n 6JXQ==","X-Gm-Message-State":"AOJu0YzeZt5gMFcoghRHCpYFGUK3tyU3SKRumMYymrRFb2y1RT1wEvjd\n S62d2h/JGtpioJU4L/CPLE4DqJsacw1p2ayTlHOHol06ux0hKRI5t5bo/NN17HwYfFuzmA==","X-Gm-Gg":"AeBDieskpnSWHHIuegf9uDL+wKQRUt+wzO37H/wkzxY7FmGBSMIHRXWiQ18Z7ftBn+a\n VhZvIG31ZuJbI5T+/l4zzASNMge+fRzaGCSINOvtI4RAkb4WFzodguayWwSYAlUSKwSh6xEvLAK\n omKTfTzW7m0EITuYsGHtp3hnNOwN3UcKj6pb31djK7EGorvHCENuyO8UZlFkU+4ShObKrEGMKSe\n RFofUUH2C3HOtPvwZ+BSzbmQbcY38aEM7ZVlPb1fU3EF4Xu09Rn5wgHMCjFjMW1pyAVqLqt/mcz\n 9ZyhENZZTB2/85nvxRl7qu11LmHRlZNP3TrV5scGFs8IFGMW1d5RaRP+PNLEqJ+OS88ZRm4nXBg\n sPRMGEsahOJCyDApglrwy1K1MMXYTgFBJLrC8KEOZaJKP7TXXGkSbK07y4PzRs7IN9TEniUS7nE\n QRGNHpu7NoWEbIHWsrXaFPw/jwmRv1ngPVC9DZppT891QkiuYc7H+v9+9UDsjihA0xEz4mrASFH\n Qnf/ZtwyJhxtSLAjq9IGjPkHHuoN8BiX/i9tYJz/wCgl6uM4Jw=","X-Received":"by 2002:a05:7022:6889:b0:11b:1c7e:27d0 with SMTP id\n a92af1059eb24-12c73e28127mr1570840c88.0.1776432411871;\n Fri, 17 Apr 2026 06:26:51 -0700 (PDT)","From":"linuxtestproject.agent@gmail.com","To":"Wei Gao ","Date":"Fri, 17 Apr 2026 13:26:49 +0000","Message-ID":"<20260417132649.3984-1-linuxtestproject.agent@gmail.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260417122804.23890-1-wegao@suse.com>","References":"<20260417122804.23890-1-wegao@suse.com>","MIME-Version":"1.0","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,DMARC_PASS,FREEMAIL_FROM,SPF_HELO_NONE,\n SPF_PASS shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-2.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-2.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] mremap07.c: New test for mremap() with MREMAP_DONTUNMAP","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it, LTP AI Reviewer ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}},{"id":3679045,"web_url":"http://patchwork.ozlabs.org/comment/3679045/","msgid":"","list_archive_url":null,"date":"2026-04-19T01:22:04","subject":"Re: [LTP] mremap07.c: New test for mremap() with MREMAP_DONTUNMAP","submitter":{"id":85577,"url":"http://patchwork.ozlabs.org/api/people/85577/","name":"Wei Gao","email":"wegao@suse.com"},"content":"On Fri, Apr 17, 2026 at 01:26:49PM +0000, linuxtestproject.agent@gmail.com wrote:\n> Hi Wei,\n> \n> On 2026-04-17, Wei Gao wrote:\n> > mremap07.c: New test for mremap() with MREMAP_DONTUNMAP\n> \n> > +static void *fault_handler_thread(void *arg LTP_ATTRIBUTE_UNUSED)\n> > +{\n> > +\tstruct uffd_msg msg;\n> > +\tstruct uffdio_copy uffdio_copy;\n> > +\n> > +\tTST_CHECKPOINT_WAIT(0);\n> > +\n> > +\tstruct pollfd pollfd;\n> > +\n> > +\tint nready = poll(&pollfd, 1, -1);\n> \n> Nit: declare all variables at the top of the block, before any statements\n> (struct pollfd and int nready should move above TST_CHECKPOINT_WAIT(0)).\nUnless the LTP project strictly mandates a \"declarations at the top\" policy for tests, \nI would prefer to keep the current implementation.\n> \n> [...]\n> \n> Reviewed-by: LTP AI Reviewer \n> \n> ---\n> Note:\n> \n> Our agent completed the review of the patch. The full review can be\n> found at: \n> \n> The agent can sometimes produce false positives although often its\n> findings are genuine. If you find issues with the review, please\n> comment this email or ignore the suggestions.\n> \n> Regards,\n> LTP AI Reviewer","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=lists.linux.it header.i=@lists.linux.it\n header.a=rsa-sha256 header.s=picard header.b=X5gQZQIB;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256\n header.s=google header.b=R6IkS2pi;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fyrSw2tC4z1yDF\n\tfor ; Sun, 19 Apr 2026 11:22:21 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 2F4EA3E4ABA\n\tfor ; Sun, 19 Apr 2026 03:22:12 +0200 (CEST)","from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [217.194.8.5])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 7D0BD3CE729\n for ; Sun, 19 Apr 2026 03:22:07 +0200 (CEST)","from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com\n [IPv6:2a00:1450:4864:20::32e])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-5.smtp.seeweb.it (Postfix) with ESMTPS id ACF7E600783\n for ; Sun, 19 Apr 2026 03:22:06 +0200 (CEST)","by mail-wm1-x32e.google.com with SMTP id\n 5b1f17b1804b1-488b0e1b870so27787755e9.2\n for ; Sat, 18 Apr 2026 18:22:06 -0700 (PDT)","from autotest-wegao.qe.prg2.suse.org\n ([2a07:de40:b240:0:2ad6:ed42:2ad6:ed42])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4cb13a0sm17309350f8f.8.2026.04.18.18.22.05\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 18 Apr 2026 18:22:05 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=lists.linux.it;\n i=@lists.linux.it; q=dns/txt; s=picard; t=1776561732; h=date : to :\n message-id : references : mime-version : in-reply-to : subject :\n list-id : list-unsubscribe : list-archive : list-post : list-help :\n list-subscribe : from : reply-to : cc : content-type :\n content-transfer-encoding : sender : from;\n bh=vCmrNmT8QUiezaMbf9WbZ8izyJwQBxJO0nxnp2UkiWs=;\n b=X5gQZQIB7K/tlFzLHNGgOUmfklrD1LnKCRhpA1+jOY3KA239ttvM4v+eJCxZEq0XVJmy0\n t9d0H5ILKf9PNmQREAVMpjIgG8smTaf1NSSRT5arfkSgxaqFkpp+KAKTRW1HjhCWDkbqNsX\n F/NLHwmL68j2v/Levrim7as+4MiTFbY=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=suse.com; s=google; t=1776561726; x=1777166526; darn=lists.linux.it;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=pHOAB2sghkKBJvbhsfPKVMhflz3+vyGHwRaM93tzwtE=;\n b=R6IkS2piFodPwss5Lh/iGmIWzbhFBiMa64QWlTFyygy/THPPEEfbdY+8XFP2vs6xwn\n M6dmVUAXIyKcOikvxx48PI4pkpRee3+/DLtGsa4r73ItXuN2RkIrwznAeoF4Pfoj04mX\n oEkJN/3iqHhlvWfNyxe6QCexJpBIrn6/loAUVOcYw15HjZjgX+sUOjTcbBVG5TTZVuNV\n 2xRm4TRHN7VOBc7OnJFdOHkAr7tt4HVxrC6wKSVRbeb12LnphiwRyrhoD5buHV6cAp5u\n 5VgsTtbp3abUy6grDjRjMGHJZhHPW6/UX+cbYPoig85TctIiFRFTtrsDMUb/tlEP/Q0B\n ZHCA=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776561726; x=1777166526;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=pHOAB2sghkKBJvbhsfPKVMhflz3+vyGHwRaM93tzwtE=;\n b=AQnlIb/n0zl+RIFJLMv0pNbLkhjBBgFG2qq9fDV/wJux0tXraft7m/3vUFJYYQ7xhY\n mdacUdp1/CcGW5U/U+TzEkETeorXfE29FoVCIiil/0boVhIQq4V98lqtpmHaIJHs6moe\n 1RynkS8gnAOuFNjtkY6txzMD1xfSecKzdcbwt3BVCBP6yoI3hogUpQIkt++Ndm5sHaRE\n Bu8rpNEJMGethj6gXJ35d296J5DN9JtdSN7/73AqRcfuW43ZPmxhi+mT7wH/CEbTCn5B\n aFK928IsF6iNpV2IXf1vGiTTGUduMLvOjRSJP2e2VxsCE9aExvrGwkP4pQmZJa5VM1AF\n srYA==","X-Gm-Message-State":"AOJu0YxZ/zdkc9SJ+XT2Ng5X8IB1zTp6AIU67eRfRlWAXRBcwVkP25kf\n jiaq3HRiIglEkXaAsx7b1qxRBtLEwPnlHUql9UbGtMnvUadZpMVgBD04FpYf6QL8QQ==","X-Gm-Gg":"AeBDieuoEXnd24QoFP1QLH/lr9VPfQrk6FGVY2bYot33sPsh9aKKaiGEXAWSmrGP1Zx\n WILaTmdlvmOKxuesmU2bUcG0pnuhFD9kzFQhMLQwWunLjEB2+nX7ZYH+6/BIeSt+IqTgpuGa/Lv\n xFxx/Q3ej8AZYlQfJEinJK8MgwL/7ODw0Iw3YD00mh1QIvNVvd69RcJeHlxaByFCWRTqXOrCrCb\n LP01bamhkrLgEcmIFJb55z+uuejv4kQ3WSuIE347MRRHkjRNYckSLRel10nlmaPTrEG1TXgBGqC\n DJN4K+rDXyaz8yfqrlEdATTAJX6yhjBMdHLbbF8bH/UzO6mmEPC+ArNOvCritYkLaKtHTPgmx5y\n Nt/Wk/ozVeuJeCshsyESMoqJdLz/bs8lrd+emHPebhX3cZHVijHd1acQyhvg/3qNvgxsYMQTiP6\n Udmb65kCGaC13odUc72VRj60Mvqi004UljqsCE5OSXIIdUuO+YjC8=","X-Received":"by 2002:a05:600c:8488:b0:488:a882:c7 with SMTP id\n 5b1f17b1804b1-488fb77b575mr120134495e9.25.1776561726052;\n Sat, 18 Apr 2026 18:22:06 -0700 (PDT)","Date":"Sun, 19 Apr 2026 01:22:04 +0000","To":"linuxtestproject.agent@gmail.com","Message-ID":"","References":"<20260417122804.23890-1-wegao@suse.com>\n <20260417132649.3984-1-linuxtestproject.agent@gmail.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20260417132649.3984-1-linuxtestproject.agent@gmail.com>","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-5.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-5.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] mremap07.c: New test for mremap() with MREMAP_DONTUNMAP","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Wei Gao via ltp ","Reply-To":"Wei Gao ","Cc":"ltp@lists.linux.it, LTP AI Reviewer ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}},{"id":3679347,"web_url":"http://patchwork.ozlabs.org/comment/3679347/","msgid":"","list_archive_url":null,"date":"2026-04-20T10:12:19","subject":"Re: [LTP] [PATCH v8] mremap07.c: New test for mremap() with\n MREMAP_DONTUNMAP","submitter":{"id":74427,"url":"http://patchwork.ozlabs.org/api/people/74427/","name":"Li Wang","email":"wangli.ahau@gmail.com"},"content":"Hi Wei,\n\nThis is an excellent test design, but still few places need\nrefactoring in my opinion.\n\nWei Gao via ltp wrote:\n\n> --- a/configure.ac\n> +++ b/configure.ac\n> @@ -46,6 +46,7 @@ AC_CHECK_DECLS([MADV_MERGEABLE],,,[#include ])\n> AC_CHECK_DECLS([NFTA_CHAIN_ID, NFTA_VERDICT_CHAIN_ID],,,[#include ])\n> AC_CHECK_DECLS([PR_CAPBSET_DROP, PR_CAPBSET_READ],,,[#include ])\n> AC_CHECK_DECLS([SEM_STAT_ANY],,,[#include ])\n> +AC_CHECK_DECLS([MREMAP_DONTUNMAP],,,[#include ])\n\nI didn't go through all the previous discussion, but can we define\nMREMAP_DONTUNMAP in the lapi/mmap.h then remove the .min_kver\nand TST_TEST_TCONF?\n\n> +++ b/testcases/kernel/syscalls/mremap/mremap07.c\n...\n\n> +#define _GNU_SOURCE\n> +#include \n> +#include \n> +#include \n> +\n> +#include \"tst_test.h\"\n> +#include \"tst_safe_pthread.h\"\n> +#include \"lapi/userfaultfd.h\"\n> +#include \"config.h\"\n> +\n> +#if HAVE_DECL_MREMAP_DONTUNMAP\n> +\n> +static int page_size;\n> +static int uffd = -1;\n\n> +static char *fault_addr;\n> +static char *new_remap_addr;\n\nThe two variables are not clear enough, I would suggest using\nold_addr, new_addr directly.\n\n> +static const char *test_string = \"Hello, world! This is a test string that fills up a page.\";\n\nWe can just define in macro:\n\n #define TEST_STRING_A \"ABCD\"\n #define TEST_STRING_B \"EFGH\"\n\n\n> +static void setup(void)\n> +{\n> + page_size = getpagesize();\n> + struct uffdio_api uffdio_api;\n> + struct uffdio_register uffdio_register;\n> +\n> + uffd = SAFE_USERFAULTFD(O_CLOEXEC | O_NONBLOCK, true);\n> +\n> + uffdio_api.api = UFFD_API;\n> + uffdio_api.features = 0;\n> + SAFE_IOCTL(uffd, UFFDIO_API, &uffdio_api);\n> +\n> + fault_addr = SAFE_MMAP(NULL, page_size,\n> + PROT_READ | PROT_WRITE, MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);\n\nWhen we need indentation it's best to format it via \"=\" (if you use vim:).\nAnd make the newline start from the first \"(\" position in a function.\n\n> +\n> + tst_res(TINFO, \"Original mapping created at %p\", (void *)fault_addr);\n> +\n> + strcpy(fault_addr, \"ABCD\");\n> +\n> + uffdio_register.range.start = (unsigned long)fault_addr;\n> + uffdio_register.range.len = page_size;\n> + uffdio_register.mode = UFFDIO_REGISTER_MODE_MISSING;\n> + SAFE_IOCTL(uffd, UFFDIO_REGISTER, &uffdio_register);\n> +}\n> +\n...\n> +static void run(void)\n> +{\n> + pthread_t handler_thread;\n> +\n> + SAFE_PTHREAD_CREATE(&handler_thread, NULL,\n> + fault_handler_thread, NULL);\n> +\n> + new_remap_addr = mremap(fault_addr, page_size, page_size,\n> + MREMAP_DONTUNMAP | MREMAP_MAYMOVE, NULL);\n> +\n> + if (new_remap_addr == MAP_FAILED)\n> + tst_brk(TBROK | TERRNO, \"mremap failed\");\n> +\n> + tst_res(TINFO, \"New mapping created at %p\", (void *)new_remap_addr);\n> +\n\nI strongly suggest verifying content of thenew_addr right after the\npage migration\nto ensure the PTEs were moved correctly without data loss.\n\n TST_EXP_EQ_STR(new_addr, \"ABCD\");\n\n> + strcpy(new_remap_addr, test_string);\n> +\n> + TST_CHECKPOINT_WAKE(0);\n> +\n> + tst_res(TINFO, \"Main thread accessing old address %p to trigger fault\",\n> + (void *)fault_addr);\n> +\n> + (void)*(volatile char *)fault_addr;\n> +\n> + SAFE_PTHREAD_JOIN(handler_thread, NULL);\n> +\n> + TST_EXP_EQ_STR(fault_addr, test_string);\n> +\n> + SAFE_MUNMAP(new_remap_addr, page_size);\n\nAdd strcpy(old_addr, TEST_STRING_A); to support -i N.\n\nBelow is a diff version base on your patch:\n\n--- a/testcases/kernel/syscalls/mremap/mremap07.c\n+++ b/testcases/kernel/syscalls/mremap/mremap07.c\n@@ -25,10 +25,11 @@\n\n static int page_size;\n static int uffd = -1;\n-static char *fault_addr;\n-static char *new_remap_addr;\n+static char *old_addr;\n+static char *new_addr;\n\n-static const char *test_string = \"Hello, world! This is a test string\nthat fills up a page.\";\n+#define TEST_STRING_A \"ABCD\"\n+#define TEST_STRING_B \"EFGH\"\n\n static void *fault_handler_thread(void *arg LTP_ATTRIBUTE_UNUSED)\n {\n@@ -55,13 +56,13 @@ static void *fault_handler_thread(void *arg\nLTP_ATTRIBUTE_UNUSED)\n if (msg.event != UFFD_EVENT_PAGEFAULT)\n tst_brk(TBROK, \"Received unexpected UFFD_EVENT: %d\", msg.event);\n\n- if ((char *)msg.arg.pagefault.address != fault_addr)\n+ if ((char *)msg.arg.pagefault.address != old_addr)\n tst_brk(TBROK, \"Page fault on unexpected address: %p\",\n(void *)msg.arg.pagefault.address);\n\n tst_res(TINFO, \"Userfaultfd handler caught a page fault at\n%p\", (void *)msg.arg.pagefault.address);\n\n- uffdio_copy.src = (unsigned long)new_remap_addr;\n- uffdio_copy.dst = (unsigned long)fault_addr;\n+ uffdio_copy.src = (unsigned long)new_addr;\n+ uffdio_copy.dst = (unsigned long)old_addr;\n uffdio_copy.len = page_size;\n uffdio_copy.mode = 0;\n uffdio_copy.copy = 0;\n@@ -74,24 +75,26 @@ static void *fault_handler_thread(void *arg\nLTP_ATTRIBUTE_UNUSED)\n\n static void setup(void)\n {\n- page_size = getpagesize();\n struct uffdio_api uffdio_api;\n struct uffdio_register uffdio_register;\n\n+ page_size = getpagesize();\n uffd = SAFE_USERFAULTFD(O_CLOEXEC | O_NONBLOCK, true);\n\n uffdio_api.api = UFFD_API;\n uffdio_api.features = 0;\n SAFE_IOCTL(uffd, UFFDIO_API, &uffdio_api);\n\n- fault_addr = SAFE_MMAP(NULL, page_size,\n- PROT_READ | PROT_WRITE, MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);\n+ old_addr = SAFE_MMAP(NULL, page_size,\n+ PROT_READ | PROT_WRITE,\n+ MAP_PRIVATE | MAP_ANONYMOUS,\n+ -1, 0);\n\n- tst_res(TINFO, \"Original mapping created at %p\", (void *)fault_addr);\n+ tst_res(TINFO, \"Original mapping created at %p\", (void *)old_addr);\n\n- strcpy(fault_addr, \"ABCD\");\n+ strcpy(old_addr, TEST_STRING_A);\n\n- uffdio_register.range.start = (unsigned long)fault_addr;\n+ uffdio_register.range.start = (unsigned long)old_addr;\n uffdio_register.range.len = page_size;\n uffdio_register.mode = UFFDIO_REGISTER_MODE_MISSING;\n SAFE_IOCTL(uffd, UFFDIO_REGISTER, &uffdio_register);\n@@ -99,11 +102,11 @@ static void setup(void)\n\n static void cleanup(void)\n {\n- if (new_remap_addr && new_remap_addr != MAP_FAILED)\n- SAFE_MUNMAP(new_remap_addr, page_size);\n+ if (new_addr && new_addr != MAP_FAILED)\n+ SAFE_MUNMAP(new_addr, page_size);\n\n- if (fault_addr && fault_addr != MAP_FAILED)\n- SAFE_MUNMAP(fault_addr, page_size);\n+ if (old_addr && old_addr != MAP_FAILED)\n+ SAFE_MUNMAP(old_addr, page_size);\n\n if (uffd != -1)\n SAFE_CLOSE(uffd);\n@@ -111,34 +114,36 @@ static void cleanup(void)\n\n static void run(void)\n {\n+ new_addr = NULL;\n pthread_t handler_thread;\n\n SAFE_PTHREAD_CREATE(&handler_thread, NULL,\n- fault_handler_thread, NULL);\n+ fault_handler_thread, NULL);\n\n- new_remap_addr = mremap(fault_addr, page_size, page_size,\n- MREMAP_DONTUNMAP | MREMAP_MAYMOVE, NULL);\n+ new_addr = mremap(old_addr, page_size, page_size,\n+ MREMAP_DONTUNMAP | MREMAP_MAYMOVE, NULL);\n\n- if (new_remap_addr == MAP_FAILED)\n+ if (new_addr == MAP_FAILED)\n tst_brk(TBROK | TERRNO, \"mremap failed\");\n\n- tst_res(TINFO, \"New mapping created at %p\", (void *)new_remap_addr);\n+ tst_res(TINFO, \"New mapping created at %p\", (void *)new_addr);\n\n- strcpy(new_remap_addr, test_string);\n+ TST_EXP_EQ_STR(new_addr, TEST_STRING_A);\n+ strcpy(new_addr, TEST_STRING_B);\n\n TST_CHECKPOINT_WAKE(0);\n\n tst_res(TINFO, \"Main thread accessing old address %p to trigger fault\",\n- (void *)fault_addr);\n+ (void *)old_addr);\n\n- (void)*(volatile char *)fault_addr;\n+ (void)*(volatile char *)old_addr;\n\n SAFE_PTHREAD_JOIN(handler_thread, NULL);\n\n- TST_EXP_EQ_STR(fault_addr, test_string);\n+ TST_EXP_EQ_STR(old_addr, TEST_STRING_B);\n\n- SAFE_MUNMAP(new_remap_addr, page_size);\n- new_remap_addr = NULL;\n+ SAFE_MUNMAP(new_addr, page_size);\n+ strcpy(old_addr, TEST_STRING_A);\n }\n\n static struct tst_test test = {","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=cCLfit6e;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzhBN5VtHz1yHr\n\tfor ; Mon, 20 Apr 2026 20:12:44 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 3ABE23E2DB3\n\tfor ; Mon, 20 Apr 2026 12:12:37 +0200 (CEST)","from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [217.194.8.2])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id AE9D63E264F\n for ; Mon, 20 Apr 2026 12:12:33 +0200 (CEST)","from mail-qt1-x82b.google.com (mail-qt1-x82b.google.com\n [IPv6:2607:f8b0:4864:20::82b])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-2.smtp.seeweb.it (Postfix) with ESMTPS id A85756008FA\n for ; Mon, 20 Apr 2026 12:12:32 +0200 (CEST)","by mail-qt1-x82b.google.com with SMTP id\n d75a77b69052e-50baafd6c4aso34028231cf.1\n for ; Mon, 20 Apr 2026 03:12:32 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1776679951; cv=none;\n d=google.com; s=arc-20240605;\n b=frMDrGekkWo5yCgBxbKPsTvpDkIpgb1QdsQZiAyaRGRJ1OtkxcPigiVqSryIFjCV4b\n 0K39HtobJEG8a4wFH5ZDeeFiWBoUWQJF4HgBc8hLfX8myPBnoAgclehEdBPvZKcg/kmt\n GYC14v8wpAAZsxBGlC/M6vYLmLIcvHxA27NfvWRGUhSrNTUDKa5ChCoxqYnYzQo/eLLL\n WXfPkXGS1bDSDcV6KvTVOh99Es7KbrLlNUZIAD9j6bMGdEEMFey11S++ungqEJkK3yVt\n KUTfNvqsEmHZRGwMnvFXdsEBcS1h8Fi7gJblxCdr500jmGSC406JihzhjbTQ9ggc1W4q\n dPYw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=1/4AZflGvZJsf1IN92T9ukMNX/2xjBErC1z/zar7mGk=;\n fh=zX7aXG63M/MDaAeMtz74XL/j2pKIuI298owFH4lsNpM=;\n b=h5DsJTjZtyFfyDoUSLOViN320VDoQkqGdxu8TuHutCGGruonfFvTx38fiGBEINc3+p\n jFDilCwHEsVq/0tawKePhURekOdbhXSWsouBoW0f/3cCPFHLLlvYH1To3zeZNzDmAaXe\n zvAE6XhpYbEet8GYwvr+U8Kv9xf+SAURFfu0o3EEjqVSAXOL1llnIWDkqiCyXIxW94QT\n 9KTqN+wVGbgDddnj+mGl5lveb9MpMJEtjRItmf9NvosrHKGwsFk9fVeMuVFxMxHD+fUb\n i0A92xRqrUZVXfxRo3JWqABeLiCP/Hj/WroyXiGKWGD1z+oFmsOTsK4OMulcHdEv7Z6T\n OwoA==; darn=lists.linux.it","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776679951; x=1777284751; darn=lists.linux.it;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=1/4AZflGvZJsf1IN92T9ukMNX/2xjBErC1z/zar7mGk=;\n b=cCLfit6eul5cyq9VButLQNNtxf24wPvKFxKXcHGHZEEoXexOE0DNBu4I3xcOkiZ64J\n ZbeD6EH4C6+b3Kpo0ATwb9N4jDryt1YrcfRILfDKp0IFGcrRXzbeEr5EWzNLBLHUfJ+x\n av2ntg+RwStGmFR+o7r0UO4z3CT3essQSraFLbVjwY9+lkkaCWnIfOsYikgVabxNlnWS\n wBaGyZWAoCcCIL+wqOC9JKAK916pTkv/oIhwsRIACa6KzoPAQ2Sju5SpG3lppR1DC+Jb\n OQsnDq3t4bfQmhY9sivKKUJi3umexRTe3sYbhbJ3+pYG3YMArU0L3aq8Myd8krxBFshd\n qn9g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776679951; x=1777284751;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=1/4AZflGvZJsf1IN92T9ukMNX/2xjBErC1z/zar7mGk=;\n b=fYTGbixET5Tnmhzt/LvEbPIytbeog6/FGAalfRExtUUNUZTqOJI7RYSKb8Q37+hmqM\n 9iTCs6+D1ZdE7o9ZBK4ZYBR3eAujwHutsPtXZ5wcpLVgsemAz4uV238lBPWUn1QY32rL\n cBOXWfqBgbgzfC9KKcy8wAZwF9a2cKJnYv5T+dKGPgBf/KqJghQJ8PkCURqVmX/icOBr\n 95POjj+0+fVOOI/CRPBoDHch4S9bFknExvfTK73+JfXPgcRsFaSPcM9zcVMBxs1ygZJq\n L1iyY3cS+EOSFsF7aSBTYx+IAL3e8qwGW0XILM1HrT1+OacL7vg+GcErdcjZwvTQmDAw\n VE9Q==","X-Gm-Message-State":"AOJu0YytnFmINdx2Sy+bBcmA7NyXSSYGK/t0lJ7bWG5b176Q9LiJrp6c\n Gcgz6c0n6H5qJa2+OFN75G6TXZ6b06e+X7GJaQUWSOOO4YCUuInPm5A2m8HEWpAoRG1Msa6UxkN\n 3uYgHD7Q7rhYf4jiuSLDJdRp2tqTo66fDKhY=","X-Gm-Gg":"AeBDieu5oBkw4MvslhuPBPeJhsv5QoKcq3W9S7qwnAngjnRQYTp6be9oElNYC9bN4nl\n uzzDy2tPgoMjylsz78htvcLhc1SAtYbFaWc7DfGVY7eDeqNiEbExL918LuvHrSl8actefhJSH2N\n Ien4Qpbyt2KyAJ37DRS4uHWXfRpdHxUnf+0+sZxKItb1jXX14Ha+BXqXLrgPB1qYOJFeXiiGFXQ\n BGeIpctE0AUEEr3kfevijga9IwdDss1adCzlqdzv2vapmCzvRMB39BaKK8RVVmnx3QHOv/LT3J2\n Bii3xqsRfrPWO50C","X-Received":"by 2002:a05:622a:2449:b0:50e:6399:eed4 with SMTP id\n d75a77b69052e-50e6399f879mr21092061cf.27.1776679951318; Mon, 20 Apr 2026\n 03:12:31 -0700 (PDT)","MIME-Version":"1.0","References":"<20260417065332.23663-1-wegao@suse.com>\n <20260417122804.23890-1-wegao@suse.com>","In-Reply-To":"<20260417122804.23890-1-wegao@suse.com>","From":"Li Wang ","Date":"Mon, 20 Apr 2026 18:12:19 +0800","X-Gm-Features":"AQROBzCJoUsswJZ0mNlknzEZucMYUoKm7F-7nCwLCeVV32N8R2S4gRqzE-FKmoA","Message-ID":"\n ","To":"Wei Gao ","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,DMARC_PASS,FREEMAIL_FROM,SPF_HELO_NONE,\n SPF_PASS shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-2.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-2.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] [PATCH v8] mremap07.c: New test for mremap() with\n MREMAP_DONTUNMAP","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}},{"id":3679728,"web_url":"http://patchwork.ozlabs.org/comment/3679728/","msgid":"","list_archive_url":null,"date":"2026-04-21T08:20:57","subject":"Re: [LTP] [PATCH v8] mremap07.c: New test for mremap() with\n MREMAP_DONTUNMAP","submitter":{"id":85577,"url":"http://patchwork.ozlabs.org/api/people/85577/","name":"Wei Gao","email":"wegao@suse.com"},"content":"On Mon, Apr 20, 2026 at 06:12:19PM +0800, Li Wang wrote:\n> Hi Wei,\n> \n> This is an excellent test design, but still few places need\n> refactoring in my opinion.\n> \n> Wei Gao via ltp wrote:\n> \n> > --- a/configure.ac\n> > +++ b/configure.ac\n> > @@ -46,6 +46,7 @@ AC_CHECK_DECLS([MADV_MERGEABLE],,,[#include ])\n> > AC_CHECK_DECLS([NFTA_CHAIN_ID, NFTA_VERDICT_CHAIN_ID],,,[#include ])\n> > AC_CHECK_DECLS([PR_CAPBSET_DROP, PR_CAPBSET_READ],,,[#include ])\n> > AC_CHECK_DECLS([SEM_STAT_ANY],,,[#include ])\n> > +AC_CHECK_DECLS([MREMAP_DONTUNMAP],,,[#include ])\n> \n> I didn't go through all the previous discussion, but can we define\n> MREMAP_DONTUNMAP in the lapi/mmap.h then remove the .min_kver\n> and TST_TEST_TCONF?\n\nTo handle older kernels without using .min_kver and TST_TEST_TCONF, \nwe'd need to implement extra logic. Would it look something like the following?\n\n-\tif (new_remap_addr == MAP_FAILED)\n+\tif (new_remap_addr == MAP_FAILED) {\n+\t\tif (errno == EINVAL)\n+\t\t\ttst_brk(TCONF | TERRNO, \"mremap() with MREMAP_DONTUNMAP not supported\");\n+\n \t\ttst_brk(TBROK | TERRNO, \"mremap failed\");\n+\t}\n\nTest on old kernel if not using .min_kver/TST_TEST_TCONF?.\n\nsusetest:~/ltp/testcases/kernel/syscalls/mremap # uname -r\n4.12.14-122.231-default\nsusetest:~/ltp/testcases/kernel/syscalls/mremap # ./mremap07 \ntst_kconfig.c:90: TINFO: Parsing kernel config '/proc/config.gz'\ntst_tmpdir.c:309: TINFO: Using /tmp/LTP_mreVVHzVk as tmpdir (btrfs filesystem)\ntst_test.c:2059: TINFO: LTP version: 20260130-147-g19c9b694c\ntst_test.c:2062: TINFO: Tested kernel: 4.12.14-122.231-default #1 SMP Wed Oct 2 17:30:21 UTC 2024 (5f0ddca) x86_64\ntst_kconfig.c:90: TINFO: Parsing kernel config '/proc/config.gz'\ntst_kconfig.c:714: TINFO: CONFIG_FAULT_INJECTION kernel option detected which might slow the execution\ntst_test.c:1889: TINFO: Overall timeout per run is 0h 02m 00s\nmremap07.c:88: TINFO: Original mapping created at 0x7f19f2edb000\nmremap07.c:121: TBROK: mremap failed: EINVAL (22)","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=lists.linux.it header.i=@lists.linux.it\n header.a=rsa-sha256 header.s=picard header.b=lHhE+N8M;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256\n header.s=google header.b=YaqbOV4b;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0Fg86j4wz1yCv\n\tfor ; Tue, 21 Apr 2026 18:21:08 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 796AC3E25AB\n\tfor ; Tue, 21 Apr 2026 10:21:05 +0200 (CEST)","from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [217.194.8.6])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 2C0473E10D0\n for ; Tue, 21 Apr 2026 10:21:00 +0200 (CEST)","from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com\n [IPv6:2a00:1450:4864:20::42d])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 61D161400B6B\n for ; Tue, 21 Apr 2026 10:21:00 +0200 (CEST)","by mail-wr1-x42d.google.com with SMTP id\n ffacd0b85a97d-43d7213b6ebso2614595f8f.3\n for ; Tue, 21 Apr 2026 01:21:00 -0700 (PDT)","from autotest-wegao.qe.prg2.suse.org\n ([2a07:de40:b240:0:2ad6:ed42:2ad6:ed42])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4e4d525sm34179425f8f.31.2026.04.21.01.20.59\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 21 Apr 2026 01:20:59 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=lists.linux.it;\n i=@lists.linux.it; q=dns/txt; s=picard; t=1776759665; h=date : to :\n message-id : references : mime-version : in-reply-to : subject :\n list-id : list-unsubscribe : list-archive : list-post : list-help :\n list-subscribe : from : reply-to : cc : content-type :\n content-transfer-encoding : sender : from;\n bh=J6CRzOCJqTAbP0Oqi4YHpu19loU7GqIkfIHGbSsmhHs=;\n b=lHhE+N8MUwLl0f7jd5SLXROb98vhgsJhhEGoxIRory00Fc/JSE9s7BD15FZmdu2LwltRQ\n DjEtZfPlYVox+p/D5LGmQ6DrU5EPBgRKYPxBif4WrOMtoWzFcnc2pV/NYNpIVT3T5XBPxql\n 8BSmV2V7HN8mcEIVEV5clQIL3Fp3w38=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=suse.com; s=google; t=1776759660; x=1777364460; darn=lists.linux.it;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=wD615jqOCE0iG6VdVsrkLTZV06B6auGBhRE5+PruOFs=;\n b=YaqbOV4bPdueWcR86MV2ez78x8o7etzqAbHSefd9HMJQ19FLkzqgvp6Vi43kpVWyg1\n EdVxCa9FcU38ZrjEQhKQCIBlFjRAPZOI9oqjy7Qa+jcO6HQLrPeYN7Tqe57SYPrH6DUW\n QjfQvQ1J+E1ij/KDn63HuFzeZuWD7Q2BUPizh3KoKim3aaqJvfGmZ4XtUi2h9BOFV9gG\n qUSGDkC87t7A07OXWd1NjLpoFftH9UNiH6KPQOtKNyTTsTr/HboRpip1FXxOOsbRj90Y\n /eHa86y/FORWX+FTR/JdW+2bcGRtTZu/ktpCnmypf59M3ZYEC5RwpDnPlyM7d5OJU62c\n WNeQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776759660; x=1777364460;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=wD615jqOCE0iG6VdVsrkLTZV06B6auGBhRE5+PruOFs=;\n b=FAz/0Lp3VOb6OIQzA0BqXhmlBsbY635P4IjBwB8BUFmfOgWB9k///dKYvF4057Tbx7\n oV+8wUSfnK3whWfJeGPRx+LvJKZmEqb+MqvS0cpK5Lp5E7mab76BjIy/IQ17wKeJ232D\n QrJ4rDxKUy+XozT9wsgCYKVs7Zdb5pyawPuqdzJciKmlA2u5ofHYephqL9uU7tmw6jNx\n uqf75L8VPd5zahCLo4hvIg7mci81tg6eVooD2Y1tQETvdYVaLHqBfVcjtCL38LS5Bn9s\n X+UBepIRt9ranUwz25uqp53W/8AoPwepr03c1DfoBY7BtV/x/VmulVIr/qcbpqZkuPi9\n B2NQ==","X-Gm-Message-State":"AOJu0YzCXClmFajhP1PQXirjo4gNEwkisz7Zt6kynH92Y0c7amtshJzD\n KaNiFAjDLw7SIkTspLBcAkFGE23gIIJCEH/VhOg96PvtOrZJu4sr+aBA5l379JpETfcreg3+tGB\n 6VH0=","X-Gm-Gg":"AeBDieuMljWrBoyGu2ykPtsAHDAFnzppZfgkkXks999IIU/zTEKFpQpdjXHi6i4Q9YP\n SfKe1SzWmzWp5B0FUzmE+TtxlmZW/7lB8NV7iBpsQw4qgT0vSVPLlfMlLVobRN8H7qFHJ+mR3yg\n wNlt6GMzC6dGvfiqZXglWSG1V8XxyZo2DNvxn3s9VHjWvltQI/hnt8wjNAOUYYhN8N+8MKNv9XQ\n Laj3lCjYXiT6rGJMEMuUQnEsZjEJ77nYL0RKX+YUPEamIsH1KHm8E+SDydC0N/g0hNVNGjeo2kX\n 3FV3E3gKLtVvQJvhF91nSZRaRXoy1NGe/8qXPEc8hMV+T1K/SDDbEInKfbg54RiQdSmTdrwZ8u9\n OU8/ZWsO3w/MjxbJHoI9VZPBaVZYeY+pbWlxl9jZH2+0SSrhFpf3Mxaze30z4ttsekBnTxLI+Tm\n jpQc28ZB9eiABbatNv0qA+ZJnSODKW1qVgbu2Sjd6veSy1ELUXB3I=","X-Received":"by 2002:a05:6000:2888:b0:43d:7b90:fa21 with SMTP id\n ffacd0b85a97d-43fe3dcaefamr26739955f8f.12.1776759659694;\n Tue, 21 Apr 2026 01:20:59 -0700 (PDT)","Date":"Tue, 21 Apr 2026 08:20:57 +0000","To":"Li Wang ","Message-ID":"","References":"<20260417065332.23663-1-wegao@suse.com>\n <20260417122804.23890-1-wegao@suse.com>\n ","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"\n ","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-6.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-6.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] [PATCH v8] mremap07.c: New test for mremap() with\n MREMAP_DONTUNMAP","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Wei Gao via ltp ","Reply-To":"Wei Gao ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}},{"id":3679757,"web_url":"http://patchwork.ozlabs.org/comment/3679757/","msgid":"","list_archive_url":null,"date":"2026-04-21T09:11:00","subject":"Re: [LTP] [PATCH v8] mremap07.c: New test for mremap() with\n MREMAP_DONTUNMAP","submitter":{"id":74427,"url":"http://patchwork.ozlabs.org/api/people/74427/","name":"Li Wang","email":"wangli.ahau@gmail.com"},"content":"Wei Gao wrote:\n\n> On Mon, Apr 20, 2026 at 06:12:19PM +0800, Li Wang wrote:\n> > Hi Wei,\n> >\n> > This is an excellent test design, but still few places need\n> > refactoring in my opinion.\n> >\n> > Wei Gao via ltp wrote:\n> >\n> > > --- a/configure.ac\n> > > +++ b/configure.ac\n> > > @@ -46,6 +46,7 @@ AC_CHECK_DECLS([MADV_MERGEABLE],,,[#include ])\n> > > AC_CHECK_DECLS([NFTA_CHAIN_ID, NFTA_VERDICT_CHAIN_ID],,,[#include ])\n> > > AC_CHECK_DECLS([PR_CAPBSET_DROP, PR_CAPBSET_READ],,,[#include ])\n> > > AC_CHECK_DECLS([SEM_STAT_ANY],,,[#include ])\n> > > +AC_CHECK_DECLS([MREMAP_DONTUNMAP],,,[#include ])\n> >\n> > I didn't go through all the previous discussion, but can we define\n> > MREMAP_DONTUNMAP in the lapi/mmap.h then remove the .min_kver\n> > and TST_TEST_TCONF?\n>\n> To handle older kernels without using .min_kver and TST_TEST_TCONF,\n> we'd need to implement extra logic. Would it look something like the following?\n>\n> - if (new_remap_addr == MAP_FAILED)\n> + if (new_remap_addr == MAP_FAILED) {\n> + if (errno == EINVAL)\n> + tst_brk(TCONF | TERRNO, \"mremap() with MREMAP_DONTUNMAP not supported\");\n> +\n> tst_brk(TBROK | TERRNO, \"mremap failed\");\n> + }\n\nYes, that's usually how it should be. Could you post the complete code\nsnippet verifying this function?\n\nReference what you did in the past:\n b697cf0bd4ea275053288f18c093551e99571ea0","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=oGTryIh8;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0Gn44Qnnz1yGs\n\tfor ; Tue, 21 Apr 2026 19:11:20 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 48BB33E2D8E\n\tfor ; Tue, 21 Apr 2026 11:11:18 +0200 (CEST)","from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::5])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 2DE723CACCA\n for ; Tue, 21 Apr 2026 11:11:15 +0200 (CEST)","from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com\n [IPv6:2607:f8b0:4864:20::f32])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-5.smtp.seeweb.it (Postfix) with ESMTPS id 767A7600CE6\n for ; Tue, 21 Apr 2026 11:11:13 +0200 (CEST)","by mail-qv1-xf32.google.com with SMTP id\n 6a1803df08f44-8a068db9989so45585126d6.0\n for ; Tue, 21 Apr 2026 02:11:13 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1776762672; cv=none;\n d=google.com; s=arc-20240605;\n b=CWNy62GT66kQMkgmXoMHglhweh9fufRP3f2fg4k5UQ6Q9HXwHHm9R01nHRuneRXmuz\n Xy7YZodVj0btlsAETISjqLe8gRVqHMVef7gIqPpfgb17yXEajF3CIA/N25G1skpRU1SF\n Xpi49KFAKt7LXvy3KWd1IStdSZwAac/zWuhHrOUgYqb7SWq9PpexOQ4O7agBIDl3jyDY\n CKhtTRzFI3hHpOnjoRAj5+u64AJO73zm0Jd9nu5kNyjoiuYImGOceKLiFnYKcXM1xrhe\n Hr5lquKgM1/aoaQD+gXqP56+iuiHfmw9+ZShAARYDu6m/wrVZ0ffSynscRW4zK/pEpXZ\n eUzA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=gRvPjbCl/s+fOVCxuOfSZ6DrXzW44ufxKzxfL4ZFTik=;\n fh=zX7aXG63M/MDaAeMtz74XL/j2pKIuI298owFH4lsNpM=;\n b=PSd3hX1M5beHqXAR3Kee14CRyVlk8YQZPLsc4xuhjXLg6KOenFJjqqeCQbyltyCOwG\n K7lS/g61pTVWWeD2+icfHtElyJOd+QIDyBBxMPW4aRrKW+oVf1gRoVpfnCsqVpkMEKg1\n rGJIVbGExVQ2AvBBjDaBa3m/oK7jv3ouiGZZXDn6LamMszzG9HHmzOtJbxKrL0Lo2QSx\n FlP6c3jL/MXXV/yFTiaz04LLi30Aw5WnH2Pza+CWm0O9tGtlj40V+tG5FGS4WOcSd3ux\n nJm0xUAiYWIxuA8gKoL2gzF+aLJb7n/85xcQ9cIKDI3nkzii9pqW37UbTe+GBeNr6K9Y\n KPDA==; darn=lists.linux.it","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776762672; x=1777367472; darn=lists.linux.it;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=gRvPjbCl/s+fOVCxuOfSZ6DrXzW44ufxKzxfL4ZFTik=;\n b=oGTryIh8NXTGWPIaXbzj67v8L4FyEYzfex8rPYTvFJtvKCme1IhMSbWCkfzBpvZENe\n g2olEmhN1ixI9VaxrIs6p6lReqrrkQhC3CF65i9rAXG0OAbglRA0PB+jcoE7OF6RIUA3\n O/xG2sWNSygNMFPNg9rv8x/HYYWXmxORDIeUnWSM+XudgyPBnTSZCTEteq/ej08uGyox\n dhTxnMEOeCirCW7UbxPcaa4eR0fb0JySbJNnXm7nPu1tg+0u5Eo/9qPRnrojjgktFXet\n 34z1TfEolxgKJ3WXQCIQevLrB3mBSCE0gtA7KtJHUVhpnQiBKLAeXuCcipDOAezygUAi\n IhUQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776762672; x=1777367472;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=gRvPjbCl/s+fOVCxuOfSZ6DrXzW44ufxKzxfL4ZFTik=;\n b=WyIttv13+HodgC0Kh/glEk0mwkIrp62/4WK1vTmTQ/b+rrtJnBfTaMM9KbvsCnKJjJ\n qOIv8scY/IXo275ZmuP6hahC3diun5r1efO0TS9dn7QoaB3Pkp7sUlGH3djrrMTkdBqU\n Yh+zUA03g5ISpGYDDmFeGjQFEKMWCpibTNfkE97WRwyaQAu+XV9J6Wsr1MNyDHMbaEBM\n mbhwJBwt+upD8SWy2Pf+Fjb0ufMsQLMYAMJoHJn/Ul3XYuvzFx45LKnfzKZcoGdbMIRT\n SvbOjFaaMvw2AUskVHpVjpTHACZG8U/RtKENofAwVPYb6NqyPHsGbxSSR5MGIUSMrZCz\n HOvw==","X-Gm-Message-State":"AOJu0YxS3U7GWuqW08/DBjko1ckAApKwkwz+u7c7zmbqvfOg5VS0KG9N\n CbZ0C0lyyzhu4M7Qk/ip4rqGmjOc/D9a0Abx8f/Os5wW7SMSS/DUHbDSLfm2rvq/hTaAA1Wqho7\n V9FoXmPzsAmHMHo3hNoqB3ZgtPOV9WQ==","X-Gm-Gg":"AeBDietIc4RGM7PKD3vb1f8NyL5M2v6p6UV15W//4qwdQUcp6sJDXj15VSKPQbXmit9\n E6AkbuH3+qzsW8P9iHwTbpAKcRJkiw4a2wFD/ChAxbTeAVjAc+GC8OEbizmUQbXfWy7O2ba4Vab\n jNJDfpFultd66lUTTeJPVpSuwob1YEGUi0mnhbS3QS9ZZNE1bEYO+3L2s/0s3aVIAq0lWd+BkUh\n bOl8jMs/xsUl5wjN6LK+GbL9BLSIpLRoUTUL0g3S44Q1XcT2YbzRsTjrtLe5yelrCdzcqImp5Ig\n edup/jwJMZ9loqguqg==","X-Received":"by 2002:a05:6214:2524:b0:89c:c713:ae57 with SMTP id\n 6a1803df08f44-8b02872dcbbmr242093166d6.19.1776762672173; Tue, 21 Apr 2026\n 02:11:12 -0700 (PDT)","MIME-Version":"1.0","References":"<20260417065332.23663-1-wegao@suse.com>\n <20260417122804.23890-1-wegao@suse.com>\n \n ","In-Reply-To":"","From":"Li Wang ","Date":"Tue, 21 Apr 2026 17:11:00 +0800","X-Gm-Features":"AQROBzBeCXbkkvekucziXPUtRZY2mdbjDMVhCjvhxsXeq_aDJapDwiPsI5As6pg","Message-ID":"\n ","To":"Wei Gao ","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS\n shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-5.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-5.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] [PATCH v8] mremap07.c: New test for mremap() with\n MREMAP_DONTUNMAP","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]