[{"id":3679211,"web_url":"http://patchwork.ozlabs.org/comment/3679211/","msgid":"<CAFLszTirJnE2Guyz541ebivyWWDeawT+nxLGO=-FWTefH4X2QQ@mail.gmail.com>","list_archive_url":null,"date":"2026-04-20T04:06:51","subject":"Re: [PATCH v3 6/7] doc: document mkimage fatfs type and Qualcomm\n multi-DTB","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Aswin,\n\nOn 2026-04-17T12:09:44, Aswin Murugan <aswin.murugan@oss.qualcomm.com> wrote:\n> doc: document mkimage fatfs type and Qualcomm multi-DTB\n>\n> Update doc/mkimage.1 to document the new fatfs image type,\n> the --fat-* long options, a fatfs entry in the CONFIGURATION\n> section, and two usage examples.\n>\n> Add doc/board/qualcomm/multi_dtb.rst describing the\n> Qualcomm FIT-based multi-DTB packaging workflow for\n> Snapdragon platforms. The document covers:\n> - FIT ITS configuration and compatible string matching\n> - QCOM metadata binary format and identifier properties\n> - Guidelines for adding new socver/boardrev entries\n> - Step-by-step image creation using mkimage -T fatfs\n>\n> Update doc/board/qualcomm/index.rst to include the new\n> multi_dtb page in the toctree.\n>\n> Signed-off-by: Aswin Murugan <aswin.murugan@oss.qualcomm.com>\n>\n> doc/board/qualcomm/index.rst     |   1 +\n>  doc/board/qualcomm/multi_dtb.rst | 352 +++++++++++++++++++++++++++++++++++++++\n>  doc/mkimage.1                    | 103 ++++++++++++\n>  3 files changed, 456 insertions(+)\n\n> diff --git a/doc/board/qualcomm/multi_dtb.rst b/doc/board/qualcomm/multi_dtb.rst\n> @@ -0,0 +1,352 @@\n> +       cp -rap <u-boot build dir>/dts/upstream/src/arm64/qcom/*.dtb* \\\n> +               fit_image/arch/arm64/boot/dts/qcom/\n\nThe text above refers to \"Qualcomm Linux Kernel Tree\" but the\nplaceholder says \"u-boot build dir\". Please change this to reference\nthe kernel build directory.\n\n> diff --git a/doc/board/qualcomm/multi_dtb.rst b/doc/board/qualcomm/multi_dtb.rst\n> @@ -0,0 +1,352 @@\n> +1. **Install required tools**::\n> +\n> +       sudo apt-get install device-tree-compiler u-boot-tools mtools\n\nStep 6 notes that dosfstools is also required for mkfs.vfat - please\nadd dosfstools to this install command.\n\n> diff --git a/doc/board/qualcomm/multi_dtb.rst b/doc/board/qualcomm/multi_dtb.rst\n> @@ -0,0 +1,352 @@\n> +6. **Pack the FIT image into a FAT partition image using mkimage**\n> +\n> +   The `mkimage tool supports creating FAT filesystem images directly via\n> +   the fatfs image type.\n> +\n> +       mkimage -T fatfs -d out/ fitimage.bin \\\n\nThis code block is missing the RST literal-block marker, i.e. the text\nbefore it should end with ::\n\n> diff --git a/doc/mkimage.1 b/doc/mkimage.1\n> @@ -903,10 +984,32 @@ of data storage.\n> +.BR mkfs.vfat (8),\n> +.BR mcopy (1),\n\nThe SEE ALSO entries should be in alphabetical order. Please swap\nthese two lines so mcopy comes before mkfs.vfat\n\nRegards,\nSimon","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=MBfCh5X2;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"MBfCh5X2\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzX572ws7z1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 20 Apr 2026 14:07:39 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id E020C842C2;\n\tMon, 20 Apr 2026 06:07:27 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id BFBAD842E0; Mon, 20 Apr 2026 06:07:26 +0200 (CEST)","from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com\n [IPv6:2a00:1450:4864:20::62e])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id D15E080087\n for <u-boot@lists.denx.de>; Mon, 20 Apr 2026 06:07:24 +0200 (CEST)","by mail-ej1-x62e.google.com with SMTP id\n a640c23a62f3a-ba388bc0a9dso464827266b.1\n for <u-boot@lists.denx.de>; Sun, 19 Apr 2026 21:07:24 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776658044; cv=none;\n d=google.com; s=arc-20240605;\n b=ALk6nl1rUiK1KTeavHtIqvQhufl1ACC5HlKqAu+38aXtr1SHMAxIS5s8EmT9GCXiLn\n 8QcF8n7dVXOHZ/NkiASDA7TNmbgjIbtRRMadZoHhj5IjF2PfhWjMGa/t76OFoUUXJ0UH\n NVG+BO8gZlFHdMZvzjKjRe6hWuXFClAxLdRjvVy4rpsbDUEnnhVbak9UQT3WPUkygpbg\n 6ItfP7HbesMuoD5n4CdsVjwhePvIOroq69Icv7VQV86tB4w7ZXTYBOtbt27x6LwG1EBJ\n PUI8WO10kwwb5Ne14cfeGy9ChKCOYUvxJkuuJe09IbYMkkG/+2Nvf4jY/db8zrJ6Tytx\n +Gxw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=ZM2Y3vQV04VyNsa4aTJBhLZ+YrYrTSd5u0Kmjct01As=;\n fh=KKR1m3rWr3Epw/ElaWa8fzDqDpgvAcH+LAnEOwNkDfI=;\n b=JnC0vO7BIubIr8E71kzGh82tMfAy5aOzywD6BrPIJQg9oo0MNpRrcD5AvlkW5QOWyD\n DBEHDg5i/krVnPHML7Y1DBb7d/2557nAT5HAd47rVPTj6EQTHLWe8LTlr4g8kU3FA8Bf\n AKDXu+UC/2bdMdqpEQ7kudHrTr5Uv1CDztRI2L9R88Ugi1Plg8ZAl9Dnx6tGq/5kvvoy\n uSgfICDSfBwaCJL4SsH9gqpc3vWH2rxDQ3GOHV3qtU/Uz3DE/Ss9c1E/g2y8TDgvCB0R\n qXBOuytkZ8Wgo0cswVvpkSd1Pv2UMnU8CGXsiRvZj6l+volSzqhJEjY70FBv5dAwYSGH\n MwnQ==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776658044; x=1777262844; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=ZM2Y3vQV04VyNsa4aTJBhLZ+YrYrTSd5u0Kmjct01As=;\n b=MBfCh5X2GcRHTCjr7HvQoUTNT8dufdlSPcSFM8IddlEeQ8wCvCbriL33OdIjBV5Xmd\n 16Xc02ALpr+mEt1rOkq+YlgS1BP9g5kh1VYEa9M9hxqIzfxh865WmOZz2HAJLl2C4p+R\n 4nbqLNzdadRlAHn+KYVTUwSISNSkYiX/CIg3M=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776658044; x=1777262844;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=ZM2Y3vQV04VyNsa4aTJBhLZ+YrYrTSd5u0Kmjct01As=;\n b=SlfgtRFFwN1DB7VSbAlVueaXdR/YxKq+b82n9a6mrgHJVA64abeue35FYyUvdgorTu\n 9VWWFFATOSmWbDUrykk4l9SllNKg/CIFs3o9Od55jaPGsMJ/7C/MLZdjvVQ7DOT0rjQL\n gSdL1eFmpH4f++0nA/za47EpPNnfh5bwZQh0D20zImQcCiotF2V5T5VGtlaYcZRQ0f9L\n 5kKNwqUd3Q/pxe5ROZu+7+RsUTdUsjs1uMD5+zFVlH8+3I/paNQVYmUdyrYgOb0mKtMQ\n s67ehXaqSLWCw9jBvRKDdwUa8DDoyN3BVTklr9d6wnCzFne1UYI1mpvUUwtWYZqBDnT3\n xFfg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9a7hgs7tBW8C3dKi71lO4J1JaLY3VywmiVJYf9waDkCNZH/mXsCGycjqyAzIpyE9IbJH79Fl4=@lists.denx.de","X-Gm-Message-State":"AOJu0YzPQrC48+2dNg6wpDcuA3R8Z0qMKJJw2W/aDDoVFQ1buqBgnxyo\n kkV1Bsh8Y5uv4X/sQca+pcJOeNZFfuvI0uxEbT50xl85coiDWBM2J13XwLDGo4SbC+XLpQfisOl\n KDde7lEPXWUGwKIqIN4gi9Ls3JZ0uX0ycth0Xt22p","X-Gm-Gg":"AeBDiesxhWRR7ZZZDGjdz8GMYoI153c5mt30tkNWJAwKUlKR9qZHZOCzCW8zm1rqaoN\n pBrxRCoca4v/70tpZtOBAVjPT1Z7HUoUYevxo/XwJcw7Icv9YaYj7yFGr2cW7+X926LcO2xpuO0\n W7CI5O3Au2sIS7ah7LH+AN9pQlBwbm8MuGZZXIoTdwkFJyJ580arz1AZ6lDEKIZIAv5FEhaLJsX\n gxK481Icw7PPVyjEOZxZRFW9dW4kTaIqP+iE3UeEQkYGpbGjbbht2WpC+XTzem4RfDiimSItNQW\n /Jhx7eZ1xZkEhf8MjtGC","X-Received":"by 2002:a17:907:e107:b0:ba3:cc7a:622b with SMTP id\n a640c23a62f3a-ba41aa130edmr391759366b.31.1776658044328; Sun, 19 Apr 2026\n 21:07:24 -0700 (PDT)","MIME-Version":"1.0","References":"<20260417120951.3454249-1-aswin.murugan@oss.qualcomm.com>\n <20260417120951.3454249-7-aswin.murugan@oss.qualcomm.com>","In-Reply-To":"<20260417120951.3454249-7-aswin.murugan@oss.qualcomm.com>","From":"Simon Glass <sjg@chromium.org>","Date":"Mon, 20 Apr 2026 16:06:51 +1200","X-Gm-Features":"AQROBzATgJXOfGjaOtATLZxI8JbGLDfmtQlqtQEOXROP9qmpcgioaq9szxQjeJU","Message-ID":"\n <CAFLszTirJnE2Guyz541ebivyWWDeawT+nxLGO=-FWTefH4X2QQ@mail.gmail.com>","Subject":"Re: [PATCH v3 6/7] doc: document mkimage fatfs type and Qualcomm\n multi-DTB","To":"aswin.murugan@oss.qualcomm.com","Cc":"trini@konsulko.com, casey.connolly@linaro.org, neil.armstrong@linaro.org,\n sumit.garg@kernel.org, sughosh.ganu@arm.com, ilias.apalodimas@linaro.org,\n gchan9527@gmail.com, mchitale@ventanamicro.com, maximmosk4@gmail.com,\n jonas@kwiboo.se, marek.vasut@mailbox.org, quentin.schulz@cherry.de,\n peng.fan@nxp.com, sajattack@postmarketos.org,\n balaji.selvanathan@oss.qualcomm.com, wolfgang.wallner@at.abb.com,\n e@freeshell.de, yangshiji66@outlook.com, jan.kiszka@siemens.com,\n funderscore@postmarketos.org, hs@nabladev.com, kory.maincent@bootlin.com,\n jj251510319013@gmail.com, carlos.lopezr4096@gmail.com, u-boot-qcom@groups.io,\n u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]