[{"id":3679206,"web_url":"http://patchwork.ozlabs.org/comment/3679206/","msgid":"","list_archive_url":null,"date":"2026-04-20T04:06:37","subject":"Re: [PATCH v3 1/7] mach-snapdragon: Add generic SMEM cache\n infrastructure","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Aswin,\n\nOn 2026-04-17T12:09:44, Aswin Murugan wrote:\n> mach-snapdragon: Add generic SMEM cache infrastructure\n>\n> Add cached access functions for commonly used SMEM data to reduce\n> redundant SMEM lookups across the boot process.\n>\n> This patch introduces three generic caching functions:\n> - qcom_get_smem_device(): Cached SMEM device access\n> - qcom_get_socinfo(): Cached socinfo structure access\n> - qcom_get_ram_partitions(): Cached RAM partition table access\n>\n> The implementation includes new header files for data structures:\n> - include/soc/qcom/socinfo.h: Added socinfo header from Linux [1]\n> Provides socinfo structure definitions for SoC identification\n> and hardware parameters\n> - arch/arm/mach-snapdragon/rampart.h: Provides RAM partition table\n> structures for memory layout information\n>\n> The caching mechanism initializes SMEM data on first access and\n> returns cached pointers on subsequent calls, avoiding expensive\n> SMEM lookups during boot. This infrastructure is designed to be\n> [...]\n>\n> arch/arm/mach-snapdragon/board.c | 95 +++++++++++++++\n> arch/arm/mach-snapdragon/qcom-priv.h | 24 ++++\n> arch/arm/mach-snapdragon/rampart.h | 225 +++++++++++++++++++++++++++++++++++\n> include/soc/qcom/socinfo.h | 114 ++++++++++++++++++\n> 4 files changed, 458 insertions(+)\n\n> diff --git a/arch/arm/mach-snapdragon/rampart.h b/arch/arm/mach-snapdragon/rampart.h\n> @@ -0,0 +1,225 @@\n> +// SPDX-License-Identifier: GPL-2.0\n> +/*\n> + * RAM partition table definitions\n> + *\n> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.\n> + *\n> + */\n> +\n> +#define SMEM_USABLE_RAM_PARTITION_TABLE 402\n\nThis header should have an include guard.\n\n> diff --git a/arch/arm/mach-snapdragon/board.c b/arch/arm/mach-snapdragon/board.c\n> @@ -749,3 +761,86 @@ void enable_caches(void)\n> +/**\n> + * qcom_get_smem_device() - Get cached SMEM device\n> + *\n> + * This function provides cached access to the SMEM device.\n> + * On first call, it initializes the SMEM device.\n> + * Subsequent calls return the cached pointer.\n> + *\n> + * Return: Pointer to SMEM device on success, NULL on failure\n> + */\n> +struct udevice *qcom_get_smem_device(void)\n> +{\n> + struct udevice *dev;\n> +\n> + if (uclass_first_device_err(UCLASS_SMEM, &dev)) {\n> + log_err(\"Failed to get SMEM device\\n\");\n> + return NULL;\n> + }\n> +\n> + return dev;\n> +}\n\nCan you update the commit message and function documentation since\nthis does not cache anything.\n\nReviewed-by: Simon Glass \n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=KpzBfWQ9;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"KpzBfWQ9\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzX4L6yDKz1yCv\n\tfor ; Mon, 20 Apr 2026 14:06:58 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 8AC8680433;\n\tMon, 20 Apr 2026 06:06:55 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id D706983693; Mon, 20 Apr 2026 06:06:53 +0200 (CEST)","from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com\n [IPv6:2a00:1450:4864:20::62e])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 9ED7880087\n for ; Mon, 20 Apr 2026 06:06:51 +0200 (CEST)","by mail-ej1-x62e.google.com with SMTP id\n a640c23a62f3a-ba8472c1613so33179566b.0\n for ; Sun, 19 Apr 2026 21:06:51 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776658011; cv=none;\n d=google.com; s=arc-20240605;\n b=eQ7qmZ11O6iMeqwBuUgBLIxw2lfIMJzOfolY9jKr9im6Mrbh1t8Wqyztr2MshGmvld\n jDd9SRBmbi1yG0xvUldqi98oQaRe/7+Mh4e9VfP8jMweETwEpSKk8kFhEMzBpMnbI6gs\n ouyJg0iIDu5coE1vSLUtocT5kr+j5Wt2nLKQ5qrXiHbuXRUH3O+34ZFfI+gd+fqNuFFy\n 6MFn1tLALXXcPis6fkXE+qYfFm06kDp+Sg7+pE19XfS1uhKSWw+WY5c8OdsPhWWw/cA1\n zt1msuaTRqX+zazIkaFOIkrBMeKuORC/RteaRGB4VxlDTYWwQjsh23m9FD95L3zPiBjH\n NhAg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=MQyD3OcJb77qFTYgVnQpQDoJcHeMYMXISq4rAStoDoY=;\n fh=BXL3Ebep6U/SPcdT8S12cNLOXJzhmXLerCkJOhu/iKU=;\n b=PmhPM/xDd8CnbkvHR7leTLeVjNoX/kkiwGfeyQbM5amGSZHLUXUxJnzwScV3XKZHrk\n Ys3MoGsG0nEquvpyRUZI7oC+kLEMMzsyK1knIj6B2eNS9ITsDr14xakgLL2LVWLEB3A9\n EJpQ7bnoC0M/wxSzOFjZEJFW9AUMeiVX2UV+PyyNn+5lJU4TOoE8AyKg091r0BMENooe\n AEuXlB1sPKYGhC6ztUYXePnfms3Q5di7miXZjHD0zO/GVsKQaiQTvCfYgdOUrS90ovc9\n +Gc8YDtg0wpynYfoISFQBqkV0iYruYBrX3TDK6qAiUP5w7nLVotL3CqlkH3Nzg7AyH0c\n yTqg==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776658011; x=1777262811; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=MQyD3OcJb77qFTYgVnQpQDoJcHeMYMXISq4rAStoDoY=;\n b=KpzBfWQ9Uk7NDRXsmkyVsfUd3acbGYJg3JaV8O3XIrM7IsV16iIfPmC16jtum+px5s\n T5JSRUyRtdMer0DDe4QjH5SLBz3IL6ppzy9jz9ZI4w1pjy2/5jQD5y8+66BxtNY2E/w0\n pfi8ZtXGibtB1l7vipZhBkwFQuezdUVQzBubI=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776658011; x=1777262811;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=MQyD3OcJb77qFTYgVnQpQDoJcHeMYMXISq4rAStoDoY=;\n b=IQrdAtfIHPlhJDsBt0NrlghCnhYQof+nj8ekKbZEWDUz8n7SVyP4UxmblsD0OhZnah\n Q2rp/OcI69ihCThEA44ymm0Nvtdj7vwOn/328/cWfdf9nzQMS/XiaCVJyA0A1RxSm9tJ\n LlQ/w23MzinESxKLcb7UB/nUfEng3fHFlX5BI19R2QDfFn3t7DiwKiCc0gJyI62Jn4xa\n 45EeWFbeUgykzycks41t0GK/CHiCGIITT/lW6TgC8dDOaYTxiA5IZ+/CUHBRGDOoNGak\n Cr3f6JGV3s8RO1WJn6asbq7Q8xRZf5gBGgSulP8rsEzqrnTqzLL5gUYlpR6ZtVYog2nf\n C53w==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/R5rEHFfiDV2wnwBEuY+lryqZQl3Y6sDxg+rrJiXBf0n4ElE20ORMRLxF/opjS1vcj3cvKoJw=@lists.denx.de","X-Gm-Message-State":"AOJu0YyGxVv8vjOwa34kmVHheqUZdjINt5LQ4houmydeZlyYK0y9xbWK\n Sy174q0lwCKe75Nc2C9Y5gzsEGAWtLYSiLvg4irX+JIhSze71x01ooD958OWSHBleMflzNH8zpv\n VJ2pMWLepS+8+ZqEeiA5FeUEzBhSKMKjTW8JyCbQL","X-Gm-Gg":"AeBDievtqvx7o+P/8CqzsK2KvYmuP3TmKFHxW6qNQ30YsY3wQ4yAqgVpOqlDP4ZEMd9\n toHf7gLXN8CXtALn4B9RLtyZ4XoNh5empKTXz0La9KeYFQudzsOezk/W2/sn4OaUrmyppM8YwYj\n V6weAEB+0DmtbSzYsG92DZNszTMIKEttF+Ne5IGN4Q9biUaX1vtTMNUMBcph3dyy8H2uyZ84doK\n /Nykp5Tq2Lm4y8WUZjumjheDkNsVaG2TEScvLuVohydKnqbDD3+8RV1VBrU8kcEuGNeUe4whJXI\n oE55sMZmLVfeiZ/5FfGogKVFa2zIH34=","X-Received":"by 2002:a17:906:fe45:b0:ba5:7cce:979f with SMTP id\n a640c23a62f3a-ba57cce99dbmr296401766b.40.1776658010626; Sun, 19 Apr 2026\n 21:06:50 -0700 (PDT)","MIME-Version":"1.0","References":"<20260417120951.3454249-1-aswin.murugan@oss.qualcomm.com>\n <20260417120951.3454249-2-aswin.murugan@oss.qualcomm.com>","In-Reply-To":"<20260417120951.3454249-2-aswin.murugan@oss.qualcomm.com>","From":"Simon Glass ","Date":"Mon, 20 Apr 2026 16:06:37 +1200","X-Gm-Features":"AQROBzCBDrRZAD21QgUwXdjbTqUTprEHzzogRTxyoZ9O244IbUTNhIdjKy-jOUw","Message-ID":"\n ","Subject":"Re: [PATCH v3 1/7] mach-snapdragon: Add generic SMEM cache\n infrastructure","To":"aswin.murugan@oss.qualcomm.com","Cc":"trini@konsulko.com, casey.connolly@linaro.org, neil.armstrong@linaro.org,\n sumit.garg@kernel.org, sughosh.ganu@arm.com, ilias.apalodimas@linaro.org,\n gchan9527@gmail.com, mchitale@ventanamicro.com, maximmosk4@gmail.com,\n jonas@kwiboo.se, marek.vasut@mailbox.org, quentin.schulz@cherry.de,\n peng.fan@nxp.com, sajattack@postmarketos.org,\n balaji.selvanathan@oss.qualcomm.com, wolfgang.wallner@at.abb.com,\n e@freeshell.de, yangshiji66@outlook.com, jan.kiszka@siemens.com,\n funderscore@postmarketos.org, hs@nabladev.com, kory.maincent@bootlin.com,\n jj251510319013@gmail.com, carlos.lopezr4096@gmail.com, u-boot-qcom@groups.io,\n u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]