[{"id":3678921,"web_url":"http://patchwork.ozlabs.org/comment/3678921/","msgid":"<05c44df1-d26a-4715-8e2a-d3f4f1de12fd@linaro.org>","list_archive_url":null,"date":"2026-04-18T00:11:26","subject":"Re: [PATCH v2 3/4] target/arm/ptw.c: Add GDI spaces to the granule\n protection case","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/17/26 21:02, Jim MacArthur wrote:\n> System Agent, Non-secure Protected and two other GPI field encodings.\n> \n> These are explicitly denied access for any processing element when\n> the relevant GPCCR bit is set, and reserved values when the relevant\n> GPCCR bit is zero.\n> \n> Signed-off-by: Jim MacArthur \n> ---\n> target/arm/ptw.c | 20 ++++++++++++++++++++\n> 1 file changed, 20 insertions(+)\n\nReviewed-by: Richard Henderson \n\n\nr~\n\n> \n> diff --git a/target/arm/ptw.c b/target/arm/ptw.c\n> index 7b993bb5b3..316e201cfe 100644\n> --- a/target/arm/ptw.c\n> +++ b/target/arm/ptw.c\n> @@ -510,6 +510,26 @@ bool arm_granule_protection_check(ARMGranuleProtectionConfig config,\n> break;\n> case 0b1111: /* all access */\n> return true;\n> + case 0b0100: /* system agent only */\n> + if (FIELD_EX64(gpccr, GPCCR, SA) == 0) {\n> + goto fault_walk;\n> + }\n> + break;\n> + case 0b0101: /* non-secure protected */\n> + if (FIELD_EX64(gpccr, GPCCR, NSP) == 0) {\n> + goto fault_walk;\n> + }\n> + break;\n> + case 0b0110: /* reserved if NA6==0, otherwise no access */\n> + if (FIELD_EX64(gpccr, GPCCR, NA6) == 0) {\n> + goto fault_walk;\n> + }\n> + break;\n> + case 0b0111: /* reserved if NA7==0, otherwise no access */\n> + if (FIELD_EX64(gpccr, GPCCR, NA7) == 0) {\n> + goto fault_walk;\n> + }\n> + break;\n> case 0b1000: /* secure */\n> if (!config.support_sel2) {\n> goto fault_walk;\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=y2LXAV/9;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fyBy62gklz1yGt\n\tfor ; Sat, 18 Apr 2026 10:11:58 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDtHf-0001Ic-OK; Fri, 17 Apr 2026 20:11:39 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDtHe-0001IF-7l\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 20:11:38 -0400","from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wDtHc-0006Zz-Oy\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 20:11:37 -0400","by mail-pj1-x102a.google.com with SMTP id\n 98e67ed59e1d1-358e3cc5e7eso755674a91.0\n for ; Fri, 17 Apr 2026 17:11:36 -0700 (PDT)","from ?IPV6:2401:d002:dc0f:2100:742f:8dfc:5be0:dc23?\n (bg30dhzyct7sk57q2zln.ip6.superloop.au.\n [2401:d002:dc0f:2100:742f:8dfc:5be0:dc23])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-36141868906sm3225291a91.3.2026.04.17.17.11.32\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 17 Apr 2026 17:11:34 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776471095; x=1777075895; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=FmytiLro6yCbwNxhPk8tXSejQttcBTkk3ZF22/FW1oA=;\n b=y2LXAV/9pfb0O0qED3DLoNu1YcqvIQfYwJTS6E+cJv9TNP/wleB5bZ/BWycVv6dKAs\n PKRYDa7MMNpWAba5UdxKgA76MBbi+hR9xvoysESsJXh8uZ7OV1MAdF7y8F/X10sJMc72\n 219wf0+7TP4yznJajKUYWdRKTDYT8sUtcfY3X3O2rdNyPVx30J3nt6QnlDA1n5mmxoce\n +B/M/hTGqM68saXVyZhBzuD9gwrkY4SRi4J1VeUOOwg6UqwyQCm+Pzv6tHWBATGzS6BH\n 7a+poZU0+e8RjTYqNxY5Kuysp33mnsKGO279HrcZB+MbE23XDxl2vMp+zUDtpwNzQGZ4\n U4Ig==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776471095; x=1777075895;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=FmytiLro6yCbwNxhPk8tXSejQttcBTkk3ZF22/FW1oA=;\n b=nsfg1docNXhW6dMr8FdTeKtXt7nWO74itRbMNYXyUtoXaUij+CglNNtTKjDBpPSbf4\n Hv7ce/vCAnMuS/27g48PtTqb5Ch92Oe5WMQ8gnJIT0RslSgSs0Fx1z/+TXu487VBJn8G\n vozt2gRHojW4Z4rsYREc1bD2oEmJo0C4QmHFogz5qg3hL0CFdA28f3MnuGAy45fCr/7O\n BjCQroH6L5BiolTOh9uX5jFXUdzHvx4WDpYWeALskSccPwDXK5pypacMcih1lDLtMdBS\n mJqGORivEb3n6fZC6hcGRwMIG/eT+nYLUblRq8Xecve3Uxf2uR+wpBLJbJtVrv2wiF+x\n ueFg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/Wom9mO31b1X5CgcSOC9glIMmMsrPwk/TFHXjMYqQ+4lVcz6J9eHMmOybY//TUeIhBe38Z0V6a0QDX@nongnu.org","X-Gm-Message-State":"AOJu0YzR5Z9SXL3vP4vSwSsZq4mcaZ42VP7JjPDEwFYpQeYXE4pc8LWt\n Bh03tExPh3PEb9WRRdVheGZs3z+oD1zqLZf7xR9RM98MA3ilknBwpVzJOcn/9/WmXFg=","X-Gm-Gg":"AeBDiess0PEVMrRWKKc/BqTDrnNMkHZV7ip/RFimeqTQtlarguNIduY5geFn0yFr6gd\n jH/amHk+k5F/I8bABKlKZWkdvak5SBzE86UlAeDmJ+CVSBvo1mjrDzTNmbtXIf2D/q8eVzpCvgi\n sHUiifx5g5o+GcO8c6/zbBKHB2qXwMuV9nl8KHb45f3OsLU5OZOZxIwbOYP8RpNAX2aih6b7J+z\n 4ytFZXKwuESbmLn7RkDpEVHkbN3xLcp3JnHhBVKc94qn0BGWosphi8QyZGhzUPEjD0wrZtmrZgJ\n nsbFu+MT8y4oHkoGyRuNmMwCJpBUhOOt7eqSOgkwlYTvNxQ7D44nZyvk+S64giMiOw+dycwVBAL\n xl26BkZl/VcdZ9uiIYRWwD1Aw/amhmcL47h4+bNJ3AptZpNaXgM0Ml+PIKVCFAY4CnuZ/AnpfoM\n DPVoTcnovXxPgDBwE1RGTsIHIgtiRN8PjuwhGi33UhAmQqnqbi4XBXNY6Sdd+WpnP9N9Y9esmoB\n pvCYxnd722Yg/wlqOb9WdGXEymiGgGbA6TW6vJF3JlTCyrgULmgGH9TuMtKOMlHiQ==","X-Received":"by 2002:a17:90b:3c0f:b0:359:855f:ff96 with SMTP id\n 98e67ed59e1d1-3614048b2f5mr4638489a91.17.1776471095026;\n Fri, 17 Apr 2026 17:11:35 -0700 (PDT)","Message-ID":"<05c44df1-d26a-4715-8e2a-d3f4f1de12fd@linaro.org>","Date":"Sat, 18 Apr 2026 10:11:26 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 3/4] target/arm/ptw.c: Add GDI spaces to the granule\n protection case","To":"Jim MacArthur , qemu-devel@nongnu.org","Cc":"Peter Maydell , qemu-arm@nongnu.org","References":"<20260417-jmac-feat_rme_gdi-v2-0-7cf5131aeb60@linaro.org>\n <20260417-jmac-feat_rme_gdi-v2-3-7cf5131aeb60@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260417-jmac-feat_rme_gdi-v2-3-7cf5131aeb60@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::102a;\n envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102a.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]