[{"id":3678737,"web_url":"http://patchwork.ozlabs.org/comment/3678737/","msgid":"","list_archive_url":null,"date":"2026-04-17T13:36:46","subject":"Re: [PATCH v4 4/7] hw/sd/sdhci: Don't use bounce buffer for ADMA","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 17/4/26 11:51, Christian Speich wrote:\n> Currently, ADMA will temporarily store data into a local bounce buffer\n> when transferring it. This will produce unneeded copies of the data and\n> limit us to the bounce buffer size for each step.\n> \n> This patch now maps the requested DMA address and passes this buffer\n> directly to sdbus_{read,write}_data. This allows to pass much larger\n> buffers down to increase the performance. sdbus_{read,write}_data is\n> already able to handle arbitrary length and alignments, so we do not\n> need to ensure this.\n> \n> Signed-off-by: Christian Speich \n> ---\n> hw/sd/sdhci.c | 102 +++++++++++++++++++++++++++++++---------------------------\n> 1 file changed, 55 insertions(+), 47 deletions(-)\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=IBiz05T3;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxwt04VzPz1yDF\n\tfor ; Fri, 17 Apr 2026 23:37:27 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDjNM-0006xp-Mg; Fri, 17 Apr 2026 09:36:52 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wDjNL-0006xZ-MR\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 09:36:51 -0400","from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wDjNK-0003oL-8n\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 09:36:51 -0400","by mail-wm1-x32a.google.com with SMTP id\n 5b1f17b1804b1-488b150559bso5748265e9.1\n for ; Fri, 17 Apr 2026 06:36:49 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4cc09b1sm4877983f8f.9.2026.04.17.06.36.46\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 17 Apr 2026 06:36:47 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776433008; x=1777037808; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=mShtuxJaJqzrioPkBLtonDyEYnArQLDycE8usXmr4qU=;\n b=IBiz05T3gMUIhW7BpW0KwQTUhdV5w4YAJV0XqEAVAZfkUuW8GtkYlJRkjKhS5EE9ld\n +EBmwpjRZXP6bq7JfU9+ac6Q3XuEyo6c1Oc3Xhkc9xT4nHTSOssfD8xzRm1yPy2FaowM\n tXT6PLfEtZPaPWZXAnNgkARdobNO2GEFRHEhcwD9xPQbMo13Z+gjHvJd/JydMUyfjyYx\n XJ4dxbFbZO8WLplbg4wyb6MrmzNRCt2yGjBs1k6FcWSm/njGB3JUNvsCaRZr2MQEGmMv\n xSmCkxb4g0pg0gPmpJEf+BDn4K0oQ76DIhPGm1sxhpnOzZJFp8Z7VQNNzN3LV90zeBxc\n qnzQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776433008; x=1777037808;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=mShtuxJaJqzrioPkBLtonDyEYnArQLDycE8usXmr4qU=;\n b=AzQgmYC9LQhiWa0Gfj3Je5rBbdfCC8Eg4BlPWIFdrq0GuEpjGFjURw3C7x9ZNQJISm\n foR2qjR7Ow6J4uSmKzOAiBp86P56DKEAoB5KmUcb6TUUi/hpHQ7YPnaQDeBfpdiZCwqm\n b/qONPxsJrFt7MZyc9xyth5/Iz9zHTkdh66CY4WWZx+H4XI6xAGgGfbK9eY6fakPnkX8\n 5kj0pS8+GmUXjPbxK1TCQ+Q7sczNV1heHJc7lCWKjmKRcG4De7ZUZx04x82hDxKtUbtk\n I5uKIaLXnGYczaiLeBDw6bVDdGKTBD1M2CQ1FIOh/zEjOzEzH2bkgpfLbMLh5Bj0tk1m\n PCVw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/5Nibqjb7aY1BjviA9qF+DxnW6BiNocfnrtsdDTW2D8PgMTimg0aUFqLbawczLkooolQ6deJfttjeo@nongnu.org","X-Gm-Message-State":"AOJu0YxqiL68k22/VbP7/UYi3kFn+X1+Il60QjxJwndLPlKlXzCQS5tx\n Ew3nTJhYT0HGN/BCwmuN0iTnqPXy4N7k9NxxMnylv5QxBweXwTJdSUFZzO4zF0KdYcs=","X-Gm-Gg":"AeBDietcoXykCAwuWgcVatT33WU1MkrmNRqSmL+DutMQgo73NOV40ula1tD8/CwMuk3\n kLMUtjKykmmCCcS56OephPhNinR+5BtMXA/zDa7i/dPaeSmMNzyc01FBLXu0SMDQ3cujvdif5f3\n BumMjyGbpfFUTy7AZqCVDrq+YjkoWg9lJglu12cRYUBpg4HryX/T363PdZbtc5o/F8BNtdx8p1L\n ri3eSHbGWhwY2zfywe8PTxMc5Q17S57Yoac18QzJ80sMIRzfmIUkrppF+gtoSVME7XfpNglfjLE\n CqdDQeiXUUT0LSmMwkTod+bIlzIPiIyn9twUjmcR7zEHXXrLhiDA+vEp7Pwe1d4AvP3EiRvfRPi\n x1aDh74wxmgTELwzReU7Otey4xGUgMEQtPfqTy8pzQcbVbqTSu3tEPu7tVMPomacFgvlK2OikRN\n RwWwyUr+CB7Oy+P84AzpoR2NNA/dIA2H8JykoGSu2JCnkJZ2w4yJYNvff8dqmqWzxM2IyVZwwkM\n ZK7","X-Received":"by 2002:adf:fe8b:0:b0:43f:e414:1bed with SMTP id\n ffacd0b85a97d-43fe4141c7bmr2851040f8f.0.1776433008207;\n Fri, 17 Apr 2026 06:36:48 -0700 (PDT)","Message-ID":"","Date":"Fri, 17 Apr 2026 15:36:46 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v4 4/7] hw/sd/sdhci: Don't use bounce buffer for ADMA","Content-Language":"en-US","To":"Christian Speich , qemu-devel@nongnu.org","Cc":"Bin Meng , qemu-block@nongnu.org,\n Marcel Apfelbaum ,\n Yanan Wang , Zhao Liu ","References":"<20260417-sdcard-performance-b4-v4-0-119e66be10c2@avm.de>\n <20260417-sdcard-performance-b4-v4-4-119e66be10c2@avm.de>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260417-sdcard-performance-b4-v4-4-119e66be10c2@avm.de>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32a;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32a.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]