[{"id":3678695,"web_url":"http://patchwork.ozlabs.org/comment/3678695/","msgid":"<93c4ecbf-2a46-437f-bbc6-24faa4170142@linaro.org>","list_archive_url":null,"date":"2026-04-17T12:15:00","subject":"Re: [PATCH v4 7/7] hw/sd: Update trace events for buf+len data","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 17/4/26 11:51, Christian Speich wrote:\n> After switching sdbuf and sdcard over to use buf+len instead of single\n> byte operation, the trace events need to be updated.\n> \n> This patch updates sdbus_{read,write} and sdcard_write_data to output the\n> buffer that is worked on.\n> \n> sdcard_read_data is left unchanged, as it did not print the read byte\n> before anyways.\n> \n> Signed-off-by: Christian Speich \n> ---\n> hw/sd/core.c | 27 +++++++++++++++++++++++++--\n> hw/sd/sd.c | 19 +++++++++++++++----\n> hw/sd/trace-events | 6 +++---\n> 3 files changed, 43 insertions(+), 9 deletions(-)\n\nThanks!\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=kdjqwGHd;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxv3V52xlz1yCv\n\tfor ; Fri, 17 Apr 2026 22:15:34 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDi6E-0008Eh-Nu; Fri, 17 Apr 2026 08:15:06 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wDi6D-0008EV-Vg\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 08:15:06 -0400","from mail-wm1-x336.google.com ([2a00:1450:4864:20::336])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wDi6C-0000VP-BM\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 08:15:05 -0400","by mail-wm1-x336.google.com with SMTP id\n 5b1f17b1804b1-488c2690057so6213375e9.0\n for ; Fri, 17 Apr 2026 05:15:03 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fb7ac6aasm15659555e9.25.2026.04.17.05.15.01\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 17 Apr 2026 05:15:01 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776428103; x=1777032903; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=MHzyBJIYkM0m+T1utJFmm9KC9vWVVMjXr4jnfo3Grqk=;\n b=kdjqwGHd00SmZR7CYKtKFUwtD3caENZiJmZSQjcFVy+o37gOzJ0tRX8N0fM1z6R1LD\n Y/mn2FySeN3fF0DogeOTf7ys8dCoSLxEV2ybWBX7ENI2SEmD3jUhlsKzuvQOZA14Z11s\n C7BZtcTdLKDFwghNahgfkfB5X7n/Y9sFGB5kkCz4Mt7jR3yuipKB7EbbuGjZKHNeiUkn\n 36SCcVw6PaUo3Fsj16Oc06X8HIdlrc3lURW1l7NIfAbswtes0qj+0c7cM1HRPEj6McY/\n WOuJmri0Jeod6iWmhguND7HAwCFCnyW48k5cNVGidjs6dDtj+VAh6K4mC6ETcHDgFQga\n jP5Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776428103; x=1777032903;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=MHzyBJIYkM0m+T1utJFmm9KC9vWVVMjXr4jnfo3Grqk=;\n b=NDLwRVhHNMEBlRnbMIEnS7gPnmoE1DgTC4vIFqOmtvOGluApsV/LRpAkiBQYQJwIF5\n xOPRY60DTMd0xznxes3pSko+ZiezNzc8CHwl3Yn68uNiT/VhhFX3R81sefGJgE//LaiL\n seurO1plMO6bafKHpwMYhNWEEyCMom+jb1T4udAoM/InKtqOOf8P22oprCfdotblYJY3\n ughyBdmHN0/G1zKPl+UmnC8eaolgYNraLIVpHgcSU3XEWwuizjU1HIZk+1mYOK61l/5H\n +DOtwODYzAw5j6tK+m8hGw3sVtq0YCVY/CR/5M/9HZvlHgjn1WAi/BctKSIU7ePbVfNe\n 81Qg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8duOL4h2e7irp5dP1U6tD3eNJpFqmmEezcryyodcyykdIDvBXxhPGcQLiN56FmJFaF+xtYM+d+bnzQ@nongnu.org","X-Gm-Message-State":"AOJu0Yx9Mj/gqjBC0qDNbunH8xJAL2yvMcwvA2Zvc5VwZJQxm1tQ7IOK\n Lw9aX2hCsscBHpWXCInjGy5nUecmfMK4pAgJXF3LD91Q4WbJ1L0t3BMYon4/5Ewg/mg=","X-Gm-Gg":"AeBDietSg4FKdVSygrxElouYf1Z6ojN+kc1MCk4quWMNz50Hrrq715J/bN9r7vLyP9o\n Bn+q0QOZVepDFygwRwXmdZXRQYhtC48TGgn88g2TB26pq4qOSoq2sbxvTFUdc5BNFndD0u2o9iA\n t1G9e03ZFOKXuZlXHecrPk/marS/mfzFAwr/fqB1seZn68NJfsODkYpk9fdNGZ6CQ7hqu072auJ\n qUD++OVRKHJ9ij241BA8sGMShngF3dquGzMkuw86mI6QoQOWk3B149Na3L/UZ3UjFaB9vW+NYsp\n bYyaz8wKHI9uG2IWR6pfcJbVNO+wL+jmbmru7TIHxvrXirt3J3Br5GHhuQlfoGAZzDl4IAmPEG8\n LKSxbNaXhgTqbSSw3qhauHCjNQ2L9EUNkXBEhkeLPfOPmMDJPsyQOqcelCKVV1nzNP4RAH4pnik\n RyrIa5NGBw1gZAkFCkCH+uIsLoff/Wew/totO8gpSjYbOZ+V0yA0MZe8i4C6GNgIOwcdQrznCXi\n 6TL","X-Received":"by 2002:a05:600c:48a3:b0:488:caed:5ccf with SMTP id\n 5b1f17b1804b1-488fb8d1865mr18551555e9.16.1776428102473;\n Fri, 17 Apr 2026 05:15:02 -0700 (PDT)","Message-ID":"<93c4ecbf-2a46-437f-bbc6-24faa4170142@linaro.org>","Date":"Fri, 17 Apr 2026 14:15:00 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v4 7/7] hw/sd: Update trace events for buf+len data","Content-Language":"en-US","To":"Christian Speich , qemu-devel@nongnu.org","Cc":"Bin Meng , qemu-block@nongnu.org,\n Marcel Apfelbaum ,\n Yanan Wang , Zhao Liu ","References":"<20260417-sdcard-performance-b4-v4-0-119e66be10c2@avm.de>\n <20260417-sdcard-performance-b4-v4-7-119e66be10c2@avm.de>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260417-sdcard-performance-b4-v4-7-119e66be10c2@avm.de>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::336;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]