[{"id":3678638,"web_url":"http://patchwork.ozlabs.org/comment/3678638/","msgid":"<87fr4tsxgd.fsf@draig.linaro.org>","list_archive_url":null,"date":"2026-04-17T10:17:06","subject":"Re: [PATCH] hw/arm, hw/ppc: Remove unnecessary audio.h includes\n from board code","submitter":{"id":39532,"url":"http://patchwork.ozlabs.org/api/people/39532/","name":"Alex Bennée","email":"alex.bennee@linaro.org"},"content":"Peter Maydell writes:\n\n> Some boards (mostly arm, but also ppc/prep) include audio.h, but they\n> don't need anything from it. Drop the unnecessary include lines.\n>\n> These seem to have been introduced with commits 2b16397264a8e,\n> b8ab0303de, which added the machine-default audiodev handling, but as\n> far as I can tell they were unecessary right from the start, as the\n> machine_add_audiodev_property() function has always been in boards.h.\n>\n> Signed-off-by: Peter Maydell \n\nReviewed-by: Alex Bennée ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=fDm/VjDN;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxrRL02ntz1yD3\n\tfor ; Fri, 17 Apr 2026 20:17:32 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDgGA-0007hs-3H; Fri, 17 Apr 2026 06:17:14 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDgG8-0007hK-L8\n for qemu-ppc@nongnu.org; Fri, 17 Apr 2026 06:17:12 -0400","from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wDgG6-0001Y1-9j\n for qemu-ppc@nongnu.org; Fri, 17 Apr 2026 06:17:12 -0400","by mail-wm1-x32f.google.com with SMTP id\n 5b1f17b1804b1-482f454be5bso15621555e9.0\n for ; Fri, 17 Apr 2026 03:17:09 -0700 (PDT)","from draig.lan ([185.124.0.195]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fc16f784sm29200475e9.1.2026.04.17.03.17.06\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 17 Apr 2026 03:17:07 -0700 (PDT)","from draig (localhost [IPv6:::1])\n by draig.lan (Postfix) with ESMTP id 4A04B5F94F;\n Fri, 17 Apr 2026 11:17:06 +0100 (BST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776421028; x=1777025828; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:user-agent\n :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=a1Au4VXp5HGXPE7mfkFPmEAGjjhqXU7oh6A12OK6f/o=;\n b=fDm/VjDNMjpvf5Ue7gf43NKb+kuV7uyiSgTDBlsntgfok6SqsXqnnNEZqMUcgtMLNI\n 1EGrhOALEsuG9yXU5M/NREGOUddtw4iLPM7ABCCFjnLWROn9cfzDCo7d7syhc+iF4bAf\n R4MrJgULuOmYNHeOcmj2iKMQEkvsWbfYo+vL8SffyAjxg8186ejzwt2tofev7JGO1gd6\n Rl7PE0vov9LK6O8KujfDe0Xre2y4L94AtweFuSsAtNAD+XI2DfBZN+OFXXFOCCXjxcuc\n hz487p3V2w2FTll2f1Q/PLWWj6T5cTKxi6On1tm0p/6MTCBUEsqXjn2iKaUGbUBgAxF/\n F3OA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776421028; x=1777025828;\n h=content-transfer-encoding:mime-version:message-id:date:user-agent\n :references:in-reply-to:subject:cc:to:from:x-gm-gg\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=a1Au4VXp5HGXPE7mfkFPmEAGjjhqXU7oh6A12OK6f/o=;\n b=geIsiDbZXpesgLsbQFfIw6xOOQ4KjEosRofUOChZdc0bu7d7XBcH7nZCwC0d4HKFW6\n v6fMLr6u830/BH2T68N72GzowkKjq/md1cjnPP5VU+lM23sMty8HeHo38M34XBGmfPD1\n Ns/GCuv3TKxf1nO8/ljzxA4dHlgizCIWNnSL6ueRquNx2Pq/MrVgbiS6lE5TYHyYMRmQ\n 3C7jZqM4g1UyKa1mSE4zfp2v3ho774k/n/jvaZE8KTaaXZe6E15CjdLHEGV4btTJKtZN\n ggOuwACT17bJvRfKkDkElIyT/SsOR+krmIR1FmPMpX8GUVyQtLnBrrw/JSuMaMSeCJ1X\n 86Bg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8RSAiLGc81n/uKRVtmLd3QGqOuz9lfea2ie4QMsZQNBciloSKB0G8hkoM9wF8HmayLk6rLu4+nGw==@nongnu.org","X-Gm-Message-State":"AOJu0YxvrV8Sfhec0EJ2aeyoeOucWX1eNny7Ch9UpKdnHAet6tNDBpI1\n O51SEh9hnYfW4AvE5euYQSZfteEZe79MMHRv3SFBTaxZp+sW5ChbrKc0ymMxQltRqYo=","X-Gm-Gg":"AeBDievZXKYe0SzuELpOUaZ0kLWYknKepGfD+0JjPOc86Nn5TC6ZnEvZto8er1rJ/id\n 4bvc0MF77Y/ZsOZ+qFHiXll4MsZXjZenTm6hj3XHbS7h3tLjm+gJoaB3XgnVHuSVM0vAQvWy1H1\n r9lTq6WNA9DL4uIKFgkKjEDmiQQ6H8Pk2wDlZq28huoq/NaHsK/GXF8mRMMei2H03McdAWyqgeF\n /PXOEK8bGwdW5l+X8UF2P1EleXvTDxDOnq+7kOK+ra1mYIx2dFedXa2vQrkhwu0dQlA8Yqv4keQ\n DW+Wk77drbSMuxZz/KbMtcZGXcbBZq9LzZMfeEHNtDjB+BgRepetKTsTEEYnX76L/CZP1pyTEAW\n cJDSTt2PVEcJqhgIv/SssiUNYcMJZwodTjBO19/fk1Jg+J9qbG7zVGB5d1PJqJE/2eUG0jZgzdR\n bEgKJLHKa1slwUcJ63SHl7zk55ESlKu32m5g==","X-Received":"by 2002:a05:600c:c09c:b0:485:3989:b3e4 with SMTP id\n 5b1f17b1804b1-488fb88c647mr20342775e9.6.1776421027680;\n Fri, 17 Apr 2026 03:17:07 -0700 (PDT)","From":"=?utf-8?q?Alex_Benn=C3=A9e?= ","To":"Peter Maydell ","Cc":"qemu-arm@nongnu.org, qemu-devel@nongnu.org, qemu-ppc@nongnu.org,\n\t=?utf-8?b?SGVydsOp?= Poussineau ","Subject":"Re: [PATCH] hw/arm, hw/ppc: Remove unnecessary audio.h includes\n from board code","In-Reply-To":"<20260417093805.1076954-1-peter.maydell@linaro.org> (Peter\n Maydell's message of \"Fri, 17 Apr 2026 10:38:05 +0100\")","References":"<20260417093805.1076954-1-peter.maydell@linaro.org>","User-Agent":"mu4e 1.14.1-pre2; emacs 30.1","Date":"Fri, 17 Apr 2026 11:17:06 +0100","Message-ID":"<87fr4tsxgd.fsf@draig.linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","Received-SPF":"pass client-ip=2a00:1450:4864:20::32f;\n envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32f.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-ppc@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]