[{"id":3678541,"web_url":"http://patchwork.ozlabs.org/comment/3678541/","msgid":"<20260417075538.3930-1-linuxtestproject.agent@gmail.com>","list_archive_url":null,"date":"2026-04-17T07:55:38","subject":"Re: [LTP] mremap07.c: New test for mremap() with MREMAP_DONTUNMAP","submitter":{"id":93132,"url":"http://patchwork.ozlabs.org/api/people/93132/","name":null,"email":"linuxtestproject.agent@gmail.com"},"content":"Hi Wei,\n\nOn 2026-04-17, Wei Gao wrote:\n> mremap07.c: New test for mremap() with MREMAP_DONTUNMAP\n\n> Fixes: https://github.com/linux-test-project/ltp/issues/1168\n\nUse Closes: for GitHub issue references. Fixes: is reserved for commit\nSHA references in the form: Fixes: (\"\").\n\n[...]\n\n> +static void cleanup(void)\n> +{\n> +\tif (new_remap_addr && new_remap_addr != MAP_FAILED)\n> +\t\tSAFE_MUNMAP(new_remap_addr, page_size);\n> +\n> +\tif (fault_addr && fault_addr != MAP_FAILED)\n> +\t\tSAFE_MUNMAP(fault_addr, page_size);\n> +\n> +\tif (uffd != -1)\n> +\t\tSAFE_CLOSE(uffd);\n> +}\n\nSAFE_MUNMAP does not clear the pointer. If setup() fails on a subsequent\niteration before SAFE_MMAP reassigns fault_addr, cleanup() will\ndouble-munmap the stale pointer. Add fault_addr = NULL; after the\nSAFE_MUNMAP call.\n\n---\nNote:\n\nOur agent completed the review of the patch. The full review can be\nfound at: https://github.com/linux-test-project/ltp-agent/actions/runs/24554018117\n\nThe agent can sometimes produce false positives although often its\nfindings are genuine. If you find issues with the review, please\ncomment this email or ignore the suggestions.\n\nRegards,\nLTP AI Reviewer","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=HRzkXm42;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxnHm2lKlz1yGt\n\tfor ; Fri, 17 Apr 2026 17:55:48 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 34DB83E268F\n\tfor ; Fri, 17 Apr 2026 09:55:45 +0200 (CEST)","from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id ED42A3CC8C5\n for ; Fri, 17 Apr 2026 09:55:41 +0200 (CEST)","from mail-qt1-x843.google.com (mail-qt1-x843.google.com\n [IPv6:2607:f8b0:4864:20::843])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-4.smtp.seeweb.it (Postfix) with ESMTPS id 69E321000A82\n for ; Fri, 17 Apr 2026 09:55:41 +0200 (CEST)","by mail-qt1-x843.google.com with SMTP id\n d75a77b69052e-506a6cf8242so3442701cf.1\n for ; Fri, 17 Apr 2026 00:55:41 -0700 (PDT)","from\n runnervm35a4x.floazsvxcilefmrd5phyrjbtph.ex.internal.cloudapp.net\n ([64.236.201.40]) by smtp.gmail.com with ESMTPSA id\n d75a77b69052e-50e39449e36sm7847821cf.21.2026.04.17.00.55.39\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 17 Apr 2026 00:55:39 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776412540; x=1777017340; darn=lists.linux.it;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=qziBpt43Hkw6fUOpLvN8ORDl40mDuSxWcfD/5unEWOI=;\n b=HRzkXm42ArCGUNuXyWCA7UvWrcjZjnOvwXPMay1G0ptAfQyUMmIupoZ5CioojxFAS9\n UL9bh9+eHFwgSWTZp1r9ZdoaNxizsL/4h1Y3d2KIAnHPtVQQr/Agn4L9pkvZpXHH4jkA\n riqdPyIQwkotG2R9+m8Ct0UsEvJs+fkmUBzoBATxqXI0HCj0vAYFP/sej0k4bJS8wt9K\n rNBZQqbI1KZZJ16IHFto9rpMI5JQ6+f2X9OKFkDDEtweE6Z1d1LJ8mae7JN5wtxI+3Ar\n Pg+8LaRaHYQbJGw2bf04M5QrGKvVVt/os3lWzEx8QJMAhPPiyypjFSdsSunDZKQ/wbsb\n UwgQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776412540; x=1777017340;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=qziBpt43Hkw6fUOpLvN8ORDl40mDuSxWcfD/5unEWOI=;\n b=ikCS+4mBS22XV597R1P60Y26cMNdMhdNfzwiKqs84GHcuVWG9vPbRUNtk0eoTGkRhJ\n Zn/PjqKt03FFInXHT/5BKiYiY77Ydn4+6BQOnzwhZ4FncEeLWD5YFTk51fTiOfchz3vC\n zU+EECTHcuJzpFFiZdtUqX0PkTt18SduL2XCPh1CfDUHc+Jb8jgLxCiqpohNvqNhTSta\n eaitk15o1Ee2WzNaB/arHnifKGjangPjkq27zdnhnmYZPQ9VwmFurlmtwT5+leErlh/E\n +E0EqHNF6y8Re2LtMEaP+AhauwmXC92RVa7dIuMoeoPGcSZRFTZWQDceUvYrg2AECtcV\n 9MaQ==","X-Gm-Message-State":"AOJu0Ywh5TvHgFX/Gmb/XArzly7Siyl14KQnYbelsXIzGFfO5lO2xXr2\n TwNUT8ZrlmMPf6Dtpgst93QeP7JgeZuvccbU0nI2P/8pVIxr11A03exO","X-Gm-Gg":"AeBDievx2UVFpktXuSUD8C27q3cTlzl9KX5x45gx9UJ38Xvjx13si1eyYr6AjKELK1O\n qae+pyj6/8KynbJ08puuJJVS3+EuM5lvmsNuKI8cvAX23EbJfN9n7dkeptoW2yE2hfuu9v2RniI\n zSko57K42jUx78pSG5IgFPKz3OuFgb+6umhtaJQZVs6ikJvo40FLpWoCrybm1+HoQ4qU32Z/F1c\n 4XgZgqTCMbJerPdQ2Qb4lvI8BdVH67jYf6EAQdxi8ineLuX3aXWLRpdTakn0Wwn0vuJJgO7l15p\n udGopgbljKuqvbWstHUFAyZPzqwSacNFijRx8WvFyUi5Wdx05vJZM9UrpKtJ+V2hSk2ZqzUQjg4\n 6ehE1pAfBjxeZWOB7WeZpaZXI1GMeTRKIzCQ1utm6J4L51hXGawBtwqr8Cf9l6bMV/Q7Mfi42jc\n /VdMQnx04al1ivIKZDvEv92eH2KT4G8GmvwRKo1nNY4uNWewknl2eGy2Pxqc0DrD+4smSHYEnDq\n caqcR6BLukNMxqLvoky8wrmL0fHb9XJ8b4euNhf75KmAQeppg==","X-Received":"by 2002:ac8:5892:0:b0:509:3cd:b22f with SMTP id\n d75a77b69052e-50e36b41242mr26519531cf.23.1776412540111;\n Fri, 17 Apr 2026 00:55:40 -0700 (PDT)","From":"linuxtestproject.agent@gmail.com","To":"Wei Gao ","Date":"Fri, 17 Apr 2026 07:55:38 +0000","Message-ID":"<20260417075538.3930-1-linuxtestproject.agent@gmail.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260417065332.23663-1-wegao@suse.com>","References":"<20260417065332.23663-1-wegao@suse.com>","MIME-Version":"1.0","X-Spam-Status":"No, score=1.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,FORGED_GMAIL_RCVD,FREEMAIL_FROM,\n SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Level":"*","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-4.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-4.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] mremap07.c: New test for mremap() with MREMAP_DONTUNMAP","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}},{"id":3678545,"web_url":"http://patchwork.ozlabs.org/comment/3678545/","msgid":"<69e1e898.5d0a0220.3d12d2.9738@mx.google.com>","list_archive_url":null,"date":"2026-04-17T08:00:23","subject":"Re: [LTP] mremap07.c: New test for mremap() with MREMAP_DONTUNMAP","submitter":{"id":82886,"url":"http://patchwork.ozlabs.org/api/people/82886/","name":"Andrea Cervesato","email":"andrea.cervesato@suse.com"},"content":"> SAFE_MUNMAP does not clear the pointer. If setup() fails on a subsequent\n> iteration before SAFE_MMAP reassigns fault_addr, cleanup() will\n> double-munmap the stale pointer. Add fault_addr = NULL; after the\n> SAFE_MUNMAP call.\n\nThe SAFE_MUNMAP() call already set the pointer to NULL, it didn't catch\nthis error. I will fix it in the agent config.\n\n--\nAndrea Cervesato\nSUSE QE Automation Engineer Linux\nandrea.cervesato@suse.com","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=lists.linux.it header.i=@lists.linux.it\n header.a=rsa-sha256 header.s=picard header.b=OsPrGyr0;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256\n header.s=google header.b=VBuYi5qm;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=213.254.12.146; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [213.254.12.146])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxnPF0JQqz1yD3\n\tfor ; Fri, 17 Apr 2026 18:00:32 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id DA4953E1BBF\n\tfor ; Fri, 17 Apr 2026 10:00:29 +0200 (CEST)","from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [217.194.8.2])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 2EF443E1BBF\n for ; Fri, 17 Apr 2026 10:00:25 +0200 (CEST)","from mail-wm1-x330.google.com (mail-wm1-x330.google.com\n [IPv6:2a00:1450:4864:20::330])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-2.smtp.seeweb.it (Postfix) with ESMTPS id 2DE2D6000E9\n for ; Fri, 17 Apr 2026 10:00:25 +0200 (CEST)","by mail-wm1-x330.google.com with SMTP id\n 5b1f17b1804b1-488b0e1b870so5954305e9.2\n for ; Fri, 17 Apr 2026 01:00:25 -0700 (PDT)","from localhost.localdomain\n (p200300ef2f4fc9009ff26ae1d4042002.dip0.t-ipconnect.de.\n [2003:ef:2f4f:c900:9ff2:6ae1:d404:2002])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4e3a381sm2850858f8f.21.2026.04.17.01.00.23\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 17 Apr 2026 01:00:24 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=lists.linux.it;\n i=@lists.linux.it; q=dns/txt; s=picard; t=1776412829; h=message-id :\n to : in-reply-to : date : subject : list-id : list-unsubscribe :\n list-archive : list-post : list-help : list-subscribe : from :\n reply-to : cc : mime-version : content-type :\n content-transfer-encoding : sender : from;\n bh=ILZ9wj+Rmk6IPGxdjHv4AODtsKeDfhvBUR4ZZ3u07ms=;\n b=OsPrGyr0q47XykrKig8wpVvTRoIJ1EinQPwLFEfvgB7cmiX3AWZc14rdj4nnBah3QPGq3\n xSCKY4I3w/TuaqblGzrRQl5/PO4GOVCrAlhfHwPgcgNejc6gSlxv3POir+BtaPEDIMT8D38\n VclXqFs9xb/ZkxUhAZAQjmaBD3NZ2s4=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=suse.com; s=google; t=1776412824; x=1777017624; darn=lists.linux.it;\n h=date:content-transfer-encoding:subject:in-reply-to:cc:to:from\n :message-id:from:to:cc:subject:date:message-id:reply-to;\n bh=ut61kuNUHwId5Tj7dpMD0FjalvGSlLRlHK1kyJ5AFJI=;\n b=VBuYi5qm49pa95K8FDB9VDorYtU+sVKeZkDP0LZnBcwyBmnLfy5OJkRZ146vGzobKn\n jN4mxB+DtYnDG04rtaO+aWZiHQhnVPIz/vldPL3JHomOq5GkUmsL8rHCA3TUKOjEtrD2\n 9cehm6MNoOOp6lunj234szb6gsmwBr4TmjXmS/9aqAXhVsbA6TH6IXYF+66iSyXeIi9i\n ZuKxTKxOg4q9QICggfpaw/myQw3JDc4gqHJd0kOrALK4+x7MaXb0YV6jaEofenJJdi9h\n 6A+oOgPuZheu5i6AsPrPQst4eBmYyx08IN/Kn6W0HqpSxgMmlhGLl5h2ycetwKIdYy89\n eKFA=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776412824; x=1777017624;\n h=date:content-transfer-encoding:subject:in-reply-to:cc:to:from\n :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=ut61kuNUHwId5Tj7dpMD0FjalvGSlLRlHK1kyJ5AFJI=;\n b=MHiqnTZ8evjZhRKkENbYLYVM6+78c8kvhO8aQU52NyggUcY6JKO+TqbwRP5Odm9mcm\n XeOVyzJyrbrbD0XaIUV/MmT8qEVmbAj2h/guqxbJ3OZGlRf48DOAW/v76sw4jenoGy53\n fS5ddSJ5IYcpYOkc+x0KwdpuuGq2+nm+nXAN6G7+LLoNXwPmZFDyvj1tg3QoYoyaxtMY\n okCPG2zPcasTgvw3ajiB1XSuSpxjlS585fWtBdbRLHQQULRUHUWE0zmcX75qeWOFbD8Y\n eW8JdobhFyjpxnN08f2svZ8BOMqhyJq7guINXBfcHBOeejke+HA7UW/FC7QqUXfP3xbi\n 2Hdg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/FAHXZ5VNcGhAkKDRXvK/rUORDKek055oLh/kUrJ4gff+I3wAg8Rr/bflrtekT3lVGfrE=@lists.linux.it","X-Gm-Message-State":"AOJu0YwwYX1F9TPjhiAEMxfTIyqI5PPze0aM03HUDQVEq76S8leTvszd\n rMkItgCjD+mK2DbdRXx7x6861bsXp/0pqk4ARqX6NT7YveBjiOXqwSn4DTT2z2b/7IHUHKVvF3A\n KAFzitZE=","X-Gm-Gg":"AeBDieuS3Lr2Bje5iySMCwfj1TinblawJjI+NKEE8x64D/I9wRYaDF5uit00NSqLN7J\n 3vjNsAJQF0yOINZjz1lPFBCEYS1+U/0/UnDTLQv+8n/gePZeE/+3I3aEJae025Dkmxqp6dgZTh4\n v2Tt01+hZxgLw00Dtg49ix1boCdeHMmZXKE38fE+6Vd+V4l3RQRRbspU1AYZ749Ic/5hQP2F3c8\n dIpSK7WwIPY8QUb9sNyg5NQhbIwPjPKZWj5yyqbtyXyO+GQj76Za3F6D53KSjO2hpo0vsDFbDue\n hWcIbZ30ur8w8VxXa79Ww4qGbKqWRi9hkfrkkTKRSv3YJyuU338xRofTSgHncQb2mlpLPxr+JJu\n 72IcIiALDf7fa511A3E0OWmj6gP2zc4zFH/WhruG3IgrBe3dFnRQlFOADM9/vuVylhDAVba3And\n uelID21Cdi1jF3PebBnAmtDeJ6UretuPhju5SFb7nRIfxByWqrItrBH7oTRC+lp+370VGr7tig9\n ALtgl3GpEwUGQWm9oTkojSXq0CJ2iypm0A/+mDSlV+bTA==","X-Received":"by 2002:a05:6000:18a6:b0:43d:1bf6:30f3 with SMTP id\n ffacd0b85a97d-43fe3dc117amr2478678f8f.14.1776412824380;\n Fri, 17 Apr 2026 01:00:24 -0700 (PDT)","Message-ID":"<69e1e898.5d0a0220.3d12d2.9738@mx.google.com>","To":"linuxtestproject.agent@gmail.com","In-Reply-To":"<20260417075538.3930-1-linuxtestproject.agent@gmail.com>","Date":"Fri, 17 Apr 2026 08:00:23 +0000","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,DMARC_PASS,SPF_HELO_NONE,SPF_PASS\n shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-2.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-2.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] mremap07.c: New test for mremap() with MREMAP_DONTUNMAP","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Andrea Cervesato via ltp ","Reply-To":"Andrea Cervesato ","Cc":"ltp@lists.linux.it","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]