[{"id":3679448,"web_url":"http://patchwork.ozlabs.org/comment/3679448/","msgid":"<20260420155730.GU280379@horms.kernel.org>","list_archive_url":null,"date":"2026-04-20T15:57:30","subject":"Re: [Intel-wired-lan] [PATCH iwl-net 4/4] ice: report EIPE checksum\n errors to the OS on E830","submitter":{"id":82748,"url":"http://patchwork.ozlabs.org/api/people/82748/","name":"Simon Horman","email":"horms@kernel.org"},"content":"On Fri, Apr 17, 2026 at 08:29:54AM +0200, Aleksandr Loktionov wrote:\n> From: Jan Glaza \n> \n> For E830 adapters the hardware-reported EIPE (Ethernet Inline IPsec\n> Engine) error is a reliable indication that a received packet failed\n> decryption and has a bad checksum. Route EIPE errors through the\n> generic checksum error path on E830 so the error is visible via\n> standard ethtool statistics (rx_csum_bad).\n> \n> On previous devices (E810, E82X) the EIPE flag can be spuriously set\n> on encapsulated packets with inner L2 padding, so those adapters only\n> increment the driver-private hw_rx_eipe_error counter without routing\n> through the checksum error path.\n> \n> Fixes: 0ca6755f3cc2 (\"ice: Add a new counter for Rx EIPE errors\")\n> Signed-off-by: Jan Glaza \n> Signed-off-by: Aleksandr Loktionov \n\nReviewed-by: Simon Horman \n\n\nSashiko has provided review of this patch. However, I don't believe any of\nthe issues flagged there should block progress of this patch.\n\nYou may wish to look over that review for possible follow-up activity.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=eVd/xmaq;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzqrM3fPKz1yCv\n\tfor ; Tue, 21 Apr 2026 01:57:39 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id F187D4110C;\n\tMon, 20 Apr 2026 15:57:37 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id HNLpnLaAeLiO; Mon, 20 Apr 2026 15:57:37 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 3D93941108;\n\tMon, 20 Apr 2026 15:57:37 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id 1DBC5259\n for ; Mon, 20 Apr 2026 15:57:36 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 0FC2041108\n for ; Mon, 20 Apr 2026 15:57:36 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 4AoHE4Qa9wvV for ;\n Mon, 20 Apr 2026 15:57:35 +0000 (UTC)","from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 1330641106\n for ; Mon, 20 Apr 2026 15:57:34 +0000 (UTC)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n by tor.source.kernel.org (Postfix) with ESMTP id 27A9060018;\n Mon, 20 Apr 2026 15:57:34 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 9779FC19425;\n Mon, 20 Apr 2026 15:57:32 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 3D93941108","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 1330641106"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776700657;\n\tbh=P/79gT7dj6HzvOUAAPSktmmF+ojncQq5DL4C3Q6KGLY=;\n\th=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=eVd/xmaq0jnf92eRxRAI7pCzaePUcJPaNcFcKk6srLAemLwCagCOVLFxZpAl1WrOK\n\t Ay2wTZFhhgzR+Fv8+ueHo7toUxhUUsRY+G0pmligAWaTtouqKlDC503Wc9JKEwtg7k\n\t u9QznXJ08UeGe/RNB+h6viqhYf7rSPt/LIYCbMH0yBff+ulFTVZdkdYGWjFEJqPXsO\n\t S/mHnyLCDlYWxuJtIPbg4Fz8w/iMz+VF+mhNqByH8qx9QiisGmJY6roUCl6U+Ub08m\n\t GXMKxz1Vex+5xfc8NuVUdA27LW2PBxoW0Q2UEjiG8NMN8lrwH6D3MoAvU1tKLHMkS5\n\t b7BzYEGh2V9Rg==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=172.105.4.254;\n helo=tor.source.kernel.org; envelope-from=horms@kernel.org;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 1330641106","Date":"Mon, 20 Apr 2026 16:57:30 +0100","From":"Simon Horman ","To":"Aleksandr Loktionov ","Cc":"intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n netdev@vger.kernel.org, Jan Glaza ","Message-ID":"<20260420155730.GU280379@horms.kernel.org>","References":"<20260417062954.1241900-1-aleksandr.loktionov@intel.com>\n <20260417062954.1241900-5-aleksandr.loktionov@intel.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260417062954.1241900-5-aleksandr.loktionov@intel.com>","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=kernel.org; s=k20201202; t=1776700653;\n bh=9kaDUMXd2oMfRaP3QQwYLw5F7z3HDregtskDo9ehssk=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=XP/7zmZw7AEY7/PBkP7ZebSPGwPPDqOQIula7+yGLD2O1a0vVRn/SbytenZ13ZDxC\n S00nXp7JkJWV+QyirYsELy0jOhSt+ri5etoanqLR+PAMu6/pvrojaslkfRsJbNm3Va\n xrnntP1tfQB+imr5ubaPOYAiIyzYg8890R2Ye1w7qj4sIlAie/ONQTEbz8VV9PRiZt\n TVFkM999d74HEsJFpJBNuc/PSoPrabeg1855Q6MJ9tdTVpoC5kj/xAE6Gqy8dVoCQP\n RuATEOzqwhG3ED6aydqRQXG35Kzqqk3Qc6NEwRvdOBcHYcRtC43kN4GSiBSkdPbKNA\n dF8d4eEW1qqxw==","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=kernel.org","smtp4.osuosl.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.a=rsa-sha256 header.s=k20201202 header.b=XP/7zmZw"],"Subject":"Re: [Intel-wired-lan] [PATCH iwl-net 4/4] ice: report EIPE checksum\n errors to the OS on E830","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]