[{"id":3679446,"web_url":"http://patchwork.ozlabs.org/comment/3679446/","msgid":"<20260420155604.576318-1-horms@kernel.org>","list_archive_url":null,"date":"2026-04-20T15:56:04","subject":"Re: [Intel-wired-lan] [PATCH iwl-net 3/4] ice: support RDMA on\n 4+-port E830 devices","submitter":{"id":82748,"url":"http://patchwork.ozlabs.org/api/people/82748/","name":"Simon Horman","email":"horms@kernel.org"},"content":"From: 'Simon Horman' \n\nThis is an AI-generated review of your patch. The human sending this\nemail has considered the AI review valid, or at least plausible.\nFull review at: https://sashiko.dev\n---\nice: support RDMA on 4+-port E830 devices\n\nThis patch narrows the RDMA capability check to keep RDMA enabled for E830\ndevices configured with more than 4 ports, as they do not share the\nlimitations of E810 and E82X devices.\n\n> diff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c\n> --- a/drivers/net/ethernet/intel/ice/ice_common.c\n> +++ b/drivers/net/ethernet/intel/ice/ice_common.c\n> @@ -2509,7 +2509,7 @@ ice_recalc_port_limited_caps(struct ice_hw *hw, struct ice_hw_common_caps *caps)\n> \t\tcaps->maxtc = 4;\n> \t\tice_debug(hw, ICE_DBG_INIT, \"reducing maxtc to %d (based on #ports)\\n\",\n> \t\t\t caps->maxtc);\n> -\t\tif (caps->rdma) {\n> +\t\tif (caps->rdma && hw->mac_type != ICE_MAC_E830) {\n> \t\t\tice_debug(hw, ICE_DBG_INIT, \"forcing RDMA off\\n\");\n> \t\t\tcaps->rdma = 0;\n> \t\t}\n\nDoes this leave the diagnostic message further down out of sync with the\nnew condition?\n\nIf the device is an E830 with more than 4 ports, RDMA remains enabled, but\nbecause the dev_info() call just below this block is evaluated for all\ndevices with more than 4 ports:\n\nice_recalc_port_limited_caps() {\n\tif (hw->dev_caps.num_funcs > 4) {\n\t\t...\n\t\tif (caps->rdma && hw->mac_type != ICE_MAC_E830) {\n\t\t\tice_debug(hw, ICE_DBG_INIT, \"forcing RDMA off\\n\");\n\t\t\tcaps->rdma = 0;\n\t\t}\n\n\t\t/* print message only when processing device capabilities\n\t\t * during initialization.\n\t\t */\n\t\tif (caps == &hw->dev_caps.common_cap)\n\t\t\tdev_info(ice_hw_to_dev(hw), \"RDMA functionality is not available with the current device configuration.\\n\");\n\t}\n}\n\nCould this cause confusion by logging a warning about RDMA being disabled\nwhen it is actually active?","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=eNY7gZ6k;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzqq05YRZz1yCv\n\tfor ; Tue, 21 Apr 2026 01:56:28 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 2A72D8291C;\n\tMon, 20 Apr 2026 15:56:27 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 3tNF1yFfu8B0; Mon, 20 Apr 2026 15:56:26 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 713708291D;\n\tMon, 20 Apr 2026 15:56:26 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n by lists1.osuosl.org (Postfix) with ESMTP id 74421355\n for ; Mon, 20 Apr 2026 15:56:25 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 661C96105F\n for ; Mon, 20 Apr 2026 15:56:25 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 1dxKefuiJRzB for ;\n Mon, 20 Apr 2026 15:56:24 +0000 (UTC)","from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 9887E60ABB\n for ; Mon, 20 Apr 2026 15:56:24 +0000 (UTC)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n by tor.source.kernel.org (Postfix) with ESMTP id 952E260018;\n Mon, 20 Apr 2026 15:56:23 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id E37D6C19425;\n Mon, 20 Apr 2026 15:56:21 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org 713708291D","OpenDKIM Filter v2.11.0 smtp3.osuosl.org 9887E60ABB"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776700586;\n\tbh=QtC6e8MpcAXtuF9Y3/YJXdsJokgg6hm3QJ4Wa2lKWIc=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=eNY7gZ6kwPQTxzdUJOB4Yvr+ZlnEEaw3H6SzfD+g89GM4wbdy/9jg3UNhtfdeL2aa\n\t Y3C6arHPqDgAtoi8O9KBEvE6MlPqv97LQkYwdwpi4wg7Zn93QEdPLGFJvstk/lgREf\n\t 0UWSOLcNzA7p6ns/Ua6mzAFsqA+Qd/3zi/uhjAlibD+pleuw6hR0SgAcYvzWBybyd6\n\t MWNquSqgf6QHGr9XW287s3TIyaadIvCT5S0RKmecA74I43pgjcsviUndxjTKdI94tP\n\t vOhn8t21zN4UudJKCfB8ASbN9t2DstjlmY7oQdsfLH8CzIRsn+wKrO3t3Kb6t2EVIW\n\t VZEc6zKe5042w==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=172.105.4.254;\n helo=tor.source.kernel.org; envelope-from=horms@kernel.org;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org 9887E60ABB","From":"Simon Horman ","To":"aleksandr.loktionov@intel.com","Cc":"'Simon Horman' , intel-wired-lan@lists.osuosl.org,\n anthony.l.nguyen@intel.com, netdev@vger.kernel.org, jan.glaza@intel.com","Date":"Mon, 20 Apr 2026 16:56:04 +0100","Message-ID":"<20260420155604.576318-1-horms@kernel.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260417062954.1241900-4-aleksandr.loktionov@intel.com>","References":"<20260417062954.1241900-4-aleksandr.loktionov@intel.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=kernel.org; s=k20201202; t=1776700583;\n bh=9Qgqeri4ieAdo6+5MWuNmYIp4MCTl3DLSaPutxRqWfM=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=ksmEw8KYLFBEBK2tCdF7SXGEKmpxM7ZICe3lhvRKln9sXBeFa2xWxzLFjbC5vrc13\n /WbPEX4nslhLuPVukFOPgxQiWh5raYTvk3f+21U1GLBrIyhe+B05EMYDrgo1N3hrlQ\n JkYk+tUCAhA29Y6fn8UCJiw6xLCidkOv6vXTr3p9XGs1J6vmnh2AjGXW8LEiyFjZaT\n uHuqXIP4CqZtieutBJ7lO/MyogE32IXEa7NFgXQ+L4jZmJp5bqONbZdibB471R6oGv\n k1fOEYGPzteio9nK9ycuEf7mAZiYKqr5YhQWPlrUY7n+YBqvp6ELPuvez97WFtyOfI\n j8qUoiy9mbmMA==","X-Mailman-Original-Authentication-Results":["smtp3.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=kernel.org","smtp3.osuosl.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.a=rsa-sha256 header.s=k20201202 header.b=ksmEw8KY"],"Subject":"Re: [Intel-wired-lan] [PATCH iwl-net 3/4] ice: support RDMA on\n 4+-port E830 devices","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]