[{"id":3679441,"web_url":"http://patchwork.ozlabs.org/comment/3679441/","msgid":"<20260420154010.GS280379@horms.kernel.org>","list_archive_url":null,"date":"2026-04-20T15:40:10","subject":"Re: [Intel-wired-lan] [PATCH iwl-net 1/4] ice: fix asymmetric pause\n negotiation reporting in ethtool","submitter":{"id":82748,"url":"http://patchwork.ozlabs.org/api/people/82748/","name":"Simon Horman","email":"horms@kernel.org"},"content":"On Fri, Apr 17, 2026 at 08:29:51AM +0200, Aleksandr Loktionov wrote:\n> From: Tomasz Lichwala \n> \n> Add Asym_Pause to the supported link modes so that asymmetric pause\n> negotiation is properly reported via ethtool. Without Asym_Pause in\n> the supported modes, 'ethtool -a' incorrectly shows 'RX/TX negotiated: off'\n> for asymmetric pause configurations, even when pause is properly\n> negotiated and functional at the hardware level.\n> \n> Fixes: 5a056cd7ead2 (\"ice: add lp_advertising flow control support\")\n> Signed-off-by: Tomasz Lichwala \n> Signed-off-by: Aleksandr Loktionov \n\nReviewed-by: Simon Horman ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=0bSaJyzD;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzqSS3GY8z1yCv\n\tfor ; Tue, 21 Apr 2026 01:40:24 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 0F8D46105F;\n\tMon, 20 Apr 2026 15:40:22 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id wOuQDjkFbp6F; Mon, 20 Apr 2026 15:40:20 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 282EE60B8C;\n\tMon, 20 Apr 2026 15:40:20 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id 13C95355\n for ; Mon, 20 Apr 2026 15:40:18 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id EE14740264\n for ; Mon, 20 Apr 2026 15:40:17 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id SqT484a9C0gI for ;\n Mon, 20 Apr 2026 15:40:17 +0000 (UTC)","from tor.source.kernel.org (tor.source.kernel.org\n [IPv6:2600:3c04:e001:324:0:1991:8:25])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 547E84008F\n for ; Mon, 20 Apr 2026 15:40:17 +0000 (UTC)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n by tor.source.kernel.org (Postfix) with ESMTP id 005E66014C;\n Mon, 20 Apr 2026 15:40:15 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 7DC70C19425;\n Mon, 20 Apr 2026 15:40:13 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org 282EE60B8C","OpenDKIM Filter v2.11.0 smtp2.osuosl.org 547E84008F"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776699620;\n\tbh=AwWGCLg5m9jJxZZUZx6xcaS6cxwUChMl+AUEEoDSjFY=;\n\th=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=0bSaJyzD6lMHnPrK22M5eQhw8FRmhBWzlwlAebs9tj2iX8Ij/DrggVUtHCvq/48iO\n\t CGk3uFGY+0fxl9Vug78HZ4BxxczIDLw75iNRyFI4AuTwdXueihNN3LnGvTbElrmWAc\n\t 4zrX4RoMTwm1bVXGq0/T7/cgkcDmALZVLsngtlOAvZzmzC31th83IwsLn/9qMePhka\n\t HbR2OCHWHmqVPVn7fW/vaqcy3WGRPRsktGUKiYXPfZqyHoDnhkV08QVQc2UnKKGk0G\n\t kpmqckPbKWnYxoTkythoqPQ4XfpUg+xnc/U0Iln6TShBe77fNUQSPNuD78bgob9dvG\n\t I9BwS4mBBH5Kw==","Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org;\n envelope-from=horms@kernel.org; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org 547E84008F","Date":"Mon, 20 Apr 2026 16:40:10 +0100","From":"Simon Horman ","To":"Aleksandr Loktionov ","Cc":"intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n netdev@vger.kernel.org, Tomasz Lichwala ","Message-ID":"<20260420154010.GS280379@horms.kernel.org>","References":"<20260417062954.1241900-1-aleksandr.loktionov@intel.com>\n <20260417062954.1241900-2-aleksandr.loktionov@intel.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260417062954.1241900-2-aleksandr.loktionov@intel.com>","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=kernel.org; s=k20201202; t=1776699614;\n bh=+DeC3NJ9949CsEjMNzlTZbIE2sxqoybq0YGyXABSEXc=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=sx9PmYZBn+xekVj3wilMLpVG2kR/QHchoIukIJWWhTK6RklK+XBbfbhtzfDxtFW3c\n kAtYRDQQyBR+iLTk3yGSPjjlVkzjTndg/4EfQ9TrskYptv/GHvoSoJl7awGTdZ4L3P\n M3gSFU5zLYAN87YyriBPUjkrf0uVNcwon/fm8A3PQ1ZrpUeHmzIR+2EkuPKO4s3JBA\n IG0VuX3sZNqLQDMOdjw9oDUecCANPYV6uxOFcP6sn/v6QYpFOXqs9HaGFQf2NV6dWM\n v35u2GWBfLOUJj8edot6n5JW6jvmT2qW/7kAkm5hAPZmcI9ioAp/XGWWW37RwHS7TE\n E5Vm/5tuasWGQ==","X-Mailman-Original-Authentication-Results":["smtp2.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=kernel.org","smtp2.osuosl.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.a=rsa-sha256 header.s=k20201202 header.b=sx9PmYZB"],"Subject":"Re: [Intel-wired-lan] [PATCH iwl-net 1/4] ice: fix asymmetric pause\n negotiation reporting in ethtool","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]