[{"id":3679605,"web_url":"http://patchwork.ozlabs.org/comment/3679605/","msgid":"<9cb892a4-1be2-40ac-9893-94e892d7a14c@linaro.org>","list_archive_url":null,"date":"2026-04-20T21:18:50","subject":"Re: [PATCH v6 3/4] target/mips: Inline translator_ld[uw,l,q]() calls","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/17/26 14:26, Philippe Mathieu-Daudé wrote:\n> In preparation of removing the translator_ld[uw,l,q]() methods,\n> inline them for the MIPS target, expanding MO_TE by a runtime\n> check on mo_endian(ctx).\n> \n> Mechanical change using the following Coccinelle 'spatch' script:\n> \n> @@\n> expression env, db, pc;\n> @@\n> (\n> - translator_lduw(env, db, pc)\n> + translator_lduw_end(env, db, pc, mo_endian(ctx))\n> |\n> - translator_ldl(env, db, pc)\n> + translator_ldl_end(env, db, pc, mo_endian(ctx))\n> |\n> - translator_ldq(env, db, pc)\n> + translator_ldq_end(env, db, pc, mo_endian(ctx))\n> )\n> \n> Signed-off-by: Philippe Mathieu-Daudé\n> ---\n> target/mips/tcg/translate.c | 12 ++++++++----\n> target/mips/tcg/micromips_translate.c.inc | 2 +-\n> target/mips/tcg/mips16e_translate.c.inc | 6 ++++--\n> target/mips/tcg/nanomips_translate.c.inc | 5 +++--\n> 4 files changed, 16 insertions(+), 9 deletions(-)\n\nReviewed-by: Richard Henderson \n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=ZBdmfvNZ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzyzP3f8Xz1yD8\n\tfor ; Tue, 21 Apr 2026 07:19:13 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wEw1F-000372-S9; Mon, 20 Apr 2026 17:19:02 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wEw1C-00036g-KR\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 17:18:58 -0400","from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wEw1B-0006oP-4J\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 17:18:58 -0400","by mail-pl1-x635.google.com with SMTP id\n d9443c01a7336-2b458ca2296so24225565ad.0\n for ; Mon, 20 Apr 2026 14:18:56 -0700 (PDT)","from [192.168.10.140] ([180.233.125.15])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b5fab0cf3bsm131740865ad.44.2026.04.20.14.18.52\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Mon, 20 Apr 2026 14:18:55 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776719935; x=1777324735; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=mvEnfNqLyAHB16KxO3uiO/XNfMNLhXNtEc+pzVjik8M=;\n b=ZBdmfvNZJlR7NqLfVpaTlslkaYV3e8Ck3rA5/CvhGawdkcrJuBrZtHPyiP9KscabAm\n mpyyWehfYtvAnHaD8EXiI9Krx3Sdqtmq4UUyRwB/QieB271cifmZJ35cxczfDJ52H7R3\n 1csih3c+SM1VZ+H4BmSMh3IahW2nDYLsecu+ZvbqonBRDVAScmxhIMpOzusfKD0j2st8\n 7gVg+wQ4tlGu8c6Qb3/tbK+F0ZQOO5PDzpki2TifgIsWt5lgJ5jX7mJOwySi+LcSst2o\n yfirJwGqoZa75KRIGHQ1HiLADAq8eFmYCPANWje/u2p19cEUv6GceuzkprDBU51G+snB\n iAyQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776719935; x=1777324735;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=mvEnfNqLyAHB16KxO3uiO/XNfMNLhXNtEc+pzVjik8M=;\n b=pYLJF/LosnTRWy379tlBFXXXbZEAjrI7WzW6aaZOCH7nYMBYb3a4N5SZcdjGPjyyNV\n pmwCB//xzfMzuYomyDd3NYpF8O6NUEysJyHEITPWhBC+PwZdkgX6Hdy3xhd+isAoNlc6\n Usp9FkbP/rpvNKurGD0bIm3f1ntC+3Xz9Q2EqRxCLuOgSsNcGXZ/a4IG3L1TNTAi+JVO\n XFWDLCeAygObzerW360W17m2GPf6tjRO0oqWo1+Yw3HstGRbBfiAgcNxUzqVvXLLbGex\n xT0ahy4QaZlg6Nld+hIG9G4X4ahPrvBSDZv5xPl0onynQRUMYiXNkwMnMgqIbZdq1B1P\n WtcA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9v1J/HXAL0+8aIDBut5qak8a6RdzLnW8w7Msj7l2lyvOxrtP7FzmKrDY69kmE5fpZkTuMxWS2RIrYy@nongnu.org","X-Gm-Message-State":"AOJu0YztwRki60hIW2L3miA7ZdSc2fnPeNK8hCcM2YowlwrUIGm6FmZG\n xegxcOtFY6iaY5i+N+s3W7ZdVxJB6/bFXkYrPyGFqey2j4z8aVI9zWu04fUWSrsAZ9M=","X-Gm-Gg":"AeBDietZhJxchWxMsy1RDa/mfuFrQzYXoQqWE//rsHLO9+772KOBRuLPXPxfQQZNL+3\n oqvEZh/zffvNjo6cIcsrrFIYaQh1BxX/z15YCGKyayf9vGF2+4sSbj+K4203nG+gYb4RM7o9WWO\n qcagHt7bDl01F6vvH0qk0ONtRnAthxIBvoc9WupQT/WSoIA+zrAzsxuAfUihmFmOUzNVkAZZ5FU\n 0ejvCFsJbgbOq7FfYnjB/AZ7vi5wmwzHPOhEVzEpcL20qHSMTWCCSIPD9Gm93NMzkGGOfj4KaC2\n +khED+g6UJRD0rvhVHfY6HJV75dugdRXzViWGkmgmW08sgLR7foJWLXolSztu9+y6Fjz+5NV8YE\n n9f9mREfrYmZdtBzLDrBwvoWFh54fV8AVN2gkJ/8YdzS9jcbQbv+ZO+B9EXcPpOuhvo6CFjUMHk\n S5oLCVIm0642ESIBYArVjXVlMtywe9pl8HdqYCCuc9mkdKhmWjTr+y","X-Received":"by 2002:a17:902:ea12:b0:2b0:6e4a:32d0 with SMTP id\n d9443c01a7336-2b5f9fbbdacmr156229635ad.35.1776719935472;\n Mon, 20 Apr 2026 14:18:55 -0700 (PDT)","Message-ID":"<9cb892a4-1be2-40ac-9893-94e892d7a14c@linaro.org>","Date":"Tue, 21 Apr 2026 07:18:50 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v6 3/4] target/mips: Inline translator_ld[uw,l,q]() calls","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","Cc":"Jiaxun Yang ,\n Aleksandar Rikalo , Aurelien Jarno ","References":"<20260417042620.35329-1-philmd@linaro.org>\n <20260417042620.35329-4-philmd@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260417042620.35329-4-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::635;\n envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x635.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]