[{"id":3678931,"web_url":"http://patchwork.ozlabs.org/comment/3678931/","msgid":"","list_archive_url":null,"date":"2026-04-18T00:47:28","subject":"Re: [PATCH 3/3] env: ubi: add support to create environment volume if\n it does not exist","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Weijie,\n\nOn 2026-04-17T02:35:14, Weijie Gao wrote:\n> env: ubi: add support to create environment volume if it does not exist\n>\n> Add an option to allow environment volume being auto created if not\n> exist.\n>\n> Signed-off-by: Weijie Gao \n>\n> env/Kconfig | 6 ++++++\n> env/ubi.c | 20 ++++++++++++++++++++\n> 2 files changed, 26 insertions(+)\n\nCould you beef up the Kconfig help text for ENV_UBI_VOLUME_CREATE -\ne.g. mention when users might want to enable this, such as on first\nboot of a fresh device where the UBI partition exists but no volumes\nhave been created yet.\n\n> diff --git a/env/ubi.c b/env/ubi.c\n> @@ -105,6 +105,18 @@ static int env_ubi_save(void)\n> +int __weak env_ubi_volume_create(const char *volume)\n> +{\n> + struct ubi_volume *vol;\n> +\n> + vol = ubi_find_volume((char *)volume);\n\nDoes this function need to be weak?\n\nubi_find_volume() prints \"Volume %s not found!\" when the volume does\nnot exist. Since the whole point of this function is to handle missing\nvolumes, this message will appear every time auto-creation is used.\nPlease can you either add a quiet variant of ubi_find_volume(), or\nsuppress the message here?\n\n> diff --git a/env/ubi.c b/env/ubi.c\n> @@ -134,6 +146,11 @@ static int env_ubi_load(void)\n> + if (IS_ENABLED(CONFIG_ENV_UBI_VOLUME_CREATE)) {\n> + env_ubi_volume_create(CONFIG_ENV_UBI_VOLUME);\n> + env_ubi_volume_create(CONFIG_ENV_UBI_VOLUME_REDUND);\n> + }\n\nThe return value from env_ubi_volume_create() is not checked. If\nvolume creation fails (e.g. no space left), the subsequent\nubi_volume_read() will also fail, but the error message will not\nindicate the underlying problem. Please can you check the return value\nand print an appropriate message if creation fails?\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=T+JIMEOP;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"T+JIMEOP\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fyCln1FZdz1yGt\n\tfor ; Sat, 18 Apr 2026 10:48:05 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id A73C583FF5;\n\tSat, 18 Apr 2026 02:47:47 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id BF6F98405A; Sat, 18 Apr 2026 02:47:45 +0200 (CEST)","from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com\n [IPv6:2a00:1450:4864:20::62a])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 9F436839D9\n for ; Sat, 18 Apr 2026 02:47:41 +0200 (CEST)","by mail-ej1-x62a.google.com with SMTP id\n a640c23a62f3a-b8d7f22d405so218239166b.0\n for ; Fri, 17 Apr 2026 17:47:41 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776473261; cv=none;\n d=google.com; s=arc-20240605;\n b=jkv7yMBCKJj9bXzsZTqt8d29/VO3BuvjPYPoqit5/AGmBW6byVFB9/3cimGCoxgLHl\n bVvTmc/55V5maHErmCvCsaJfGacedgjBn2drMWdYTsMudNCM82fWVhwEGvb8sFhwITSE\n HUtwxI2Ww23OmopWU1FhT3agpY8QS+atfUdh5HhtLNqF+SCBnHuIzicIZSuoxiIKZ/5E\n 6V6cyw/Bh0yFtilkFAL/jpjLPNvAbmXHpN2klgL1ytssAgYzurggFPwNa/ySh0JmjqqC\n LubHKEuVE9nOt3CM5xamwyjtiVhNq0BNi2pU/1nBvaQ12P+uAPkXWN3PtEw+RNGIytSE\n Dolg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=jrtBJ3WqVlEc9M9sm4W/o/UD7yQBZiEwt3l5bSu2agY=;\n fh=fJAGB8LvxCJalDRE+ziaXIW21+gD5jSCb0B1QEwHsvE=;\n b=ZzKixpUQooVRW9P2u+ESswhInWr1TEIYT/DzuONUXcnHKY6N/yFVupdy00RM0hmwWK\n RQTnGhxz9w+q8AIZ6/9776BgTX3e5YC2NaDqy2TfeOFS76o9dpY8hsOcbIISPpD+6ias\n XxXigTv78jjZ74O0ItIpDWxrELc4VZhU2GU6Zve/PyQjkq2Q8tHb2Sdt/xDcjVyiBmvT\n 7ojKVNTJOMCIOYgPq1rOz2gZrRLbjnole4m7LpFz4ptaBp0fknTpQ+kdYS7NMuMQKOG2\n ZnxbPOGUFPrqteXORU/Zhr3YvdVFHmNCdsTX8gNLsaan/f9ihpFPd6/Qdk5hf0fGgfW8\n pTVQ==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776473261; x=1777078061; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=jrtBJ3WqVlEc9M9sm4W/o/UD7yQBZiEwt3l5bSu2agY=;\n b=T+JIMEOP0kldhRwYNilx6nXLzN/dEN+5XiLpTmKRYmwu+UjgfTLAI02Ep4/2IpF7RM\n bULc72JRblperlyt5wn4SCJ35lKqNNURjF4mHDEyfngAephtyQ/FBjmjpf2S6x+ymf4W\n ZK87swpNcOJEdzQ3wL1/+bX1yoJGPbm4ideBk=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776473261; x=1777078061;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=jrtBJ3WqVlEc9M9sm4W/o/UD7yQBZiEwt3l5bSu2agY=;\n b=AATcHlbnq9PEQYyePY3ldLA3Yt+8YQ5tXGrv1bBx4ls+lZ6sej+lF1SHmh+qEReQra\n JC2xFzVRJf3gBx5g80Ac+XXPlY294qFXmJbT/Ul6BjDF2T5CirABE3+EEapU7fqAcGqa\n sEUGMW0VwkczdNK7L1M89K9ExK1OaZpIr8ZrrdsUXO5BlD1D6ZiHl6/bJUFrnnLzkkLH\n shdUkjdtHfCsY8v0sHODSG1RS5O7ACDYdf9TsgtmME/ikyXZabl9dbkOYAbuD73BzRsQ\n wqGNhAh4XctzmktAD3LlULy4Kn6kIjwzApDKnm5zgkXFiuu0GMFOBwo3+0ATZvflaSIS\n /GbA==","X-Gm-Message-State":"AOJu0Yx5DLTKQJ3rf+RtPdEFdBZja0AmEjFXPPsgpDGU3E0hCye9h6qP\n T8orJ2USBOjxkWmgXGnMo2qbYoji5uItPO4RwKuwVfapLOrgLlziWcEzXNGrhP1PFfJ7ZeBrIVs\n zsjtoLrZW+2KFtivcFZ9Ptfm+l9VNrOr3szjgc3Pjh07gtZyFqkhsUg==","X-Gm-Gg":"AeBDietAo39PNbl8K2GxbkjijykmEo6zt/sdpzqoQJ7dotUsOPiWE0Ynqj0oS/9YpmU\n 7YalY0/U6y6CSjlqffTmOAdb1RM5jAX8cFLqQ2PO7KSHEX+DKrCh6URiR0gwrxo3MmkRnfCSMhL\n TyVcgiWna3Uqb8/09bmZTR+pN0pW+ZvGBDJhzlbCn6aC6F+5Lc6pSkRaQP5OVTAPuR0JRRMebKF\n RFrQDBnl4D0FO9WBVwZD2bqg1T/Nj04fqSKSHjAP7ETvhVPcjfi9lFfMd9NijwmKdmLOQ6CMPYK\n nuFQyhZ9l9pUZtxlNMtr","X-Received":"by 2002:a17:907:6e8d:b0:b9d:9a98:e664 with SMTP id\n a640c23a62f3a-ba41945a155mr304487366b.18.1776473261073; Fri, 17 Apr 2026\n 17:47:41 -0700 (PDT)","MIME-Version":"1.0","References":"\n ","In-Reply-To":"\n ","From":"Simon Glass ","Date":"Sat, 18 Apr 2026 12:47:28 +1200","X-Gm-Features":"AQROBzBtDQo8EZHIYhM3PJhLV5X6dy33aMmStnpIKPLHl4Z1Lo5yzSyKS35rm0I","Message-ID":"\n ","Subject":"Re: [PATCH 3/3] env: ubi: add support to create environment volume if\n it does not exist","To":"weijie.gao@mediatek.com","Cc":"u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3679269,"web_url":"http://patchwork.ozlabs.org/comment/3679269/","msgid":"<20fe278b75a677602e54bb7dcb7318df91180d94.camel@mediatek.com>","list_archive_url":null,"date":"2026-04-20T07:27:52","subject":"Re: [PATCH 3/3] env: ubi: add support to create environment volume\n if it does not exist","submitter":{"id":75269,"url":"http://patchwork.ozlabs.org/api/people/75269/","name":"Weijie Gao","email":"weijie.gao@mediatek.com"},"content":"On Sat, 2026-04-18 at 12:47 +1200, Simon Glass wrote:\n> Hi Weijie,\n> \n> On 2026-04-17T02:35:14, Weijie Gao wrote:\n> > env: ubi: add support to create environment volume if it does not\n> > exist\n> > \n> > Add an option to allow environment volume being auto created if not\n> > exist.\n> > \n> > Signed-off-by: Weijie Gao \n> > \n> > env/Kconfig | 6 ++++++\n> > env/ubi.c | 20 ++++++++++++++++++++\n> > 2 files changed, 26 insertions(+)\n> \n> Could you beef up the Kconfig help text for ENV_UBI_VOLUME_CREATE -\n> e.g. mention when users might want to enable this, such as on first\n> boot of a fresh device where the UBI partition exists but no volumes\n> have been created yet.\n\nOK.\n\n> \n> > diff --git a/env/ubi.c b/env/ubi.c\n> > @@ -105,6 +105,18 @@ static int env_ubi_save(void)\n> > +int __weak env_ubi_volume_create(const char *volume)\n> > +{\n> > + struct ubi_volume *vol;\n> > +\n> > + vol = ubi_find_volume((char *)volume);\n> \n> Does this function need to be weak?\n\nIs unnecessary at all. I added in my early test.\n\n> \n> ubi_find_volume() prints \"Volume %s not found!\" when the volume does\n> not exist. Since the whole point of this function is to handle\n> missing\n> volumes, this message will appear every time auto-creation is used.\n> Please can you either add a quiet variant of ubi_find_volume(), or\n> suppress the message here?\n\nAs I replied in 2/3, I'll move these messages into the main command\nfunction.\n\n> \n> > diff --git a/env/ubi.c b/env/ubi.c\n> > @@ -134,6 +146,11 @@ static int env_ubi_load(void)\n> > + if (IS_ENABLED(CONFIG_ENV_UBI_VOLUME_CREATE)) {\n> > + env_ubi_volume_create(CONFIG_ENV_UBI_VOLUME);\n> > + env_ubi_volume_create(CONFIG_ENV_UBI_VOLUME_REDUND);\n> > + }\n> \n> The return value from env_ubi_volume_create() is not checked. If\n> volume creation fails (e.g. no space left), the subsequent\n> ubi_volume_read() will also fail, but the error message will not\n> indicate the underlying problem. Please can you check the return\n> value\n> and print an appropriate message if creation fails?\n\nOK.\n\n> \n> Regards,\n> Simon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=mediatek.com header.i=@mediatek.com header.a=rsa-sha256\n header.s=dk header.b=Es0TDCD6;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=mediatek.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=mediatek.com header.i=@mediatek.com\n header.b=\"Es0TDCD6\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=pass (p=quarantine dis=none)\n header.from=mediatek.com","phobos.denx.de;\n spf=pass smtp.mailfrom=weijie.gao@mediatek.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzcXN6N4Qz1yGs\n\tfor ; Mon, 20 Apr 2026 17:28:04 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 008C7839D5;\n\tMon, 20 Apr 2026 09:28:01 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id D9621840D8; Mon, 20 Apr 2026 09:28:00 +0200 (CEST)","from mailgw01.mediatek.com (unknown [60.244.123.138])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 82D6C83693\n for ; Mon, 20 Apr 2026 09:27:58 +0200 (CEST)","from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by\n mailgw01.mediatek.com (envelope-from )\n (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256)\n with ESMTP id 1395537116; Mon, 20 Apr 2026 15:27:54 +0800","from mtkmbs11n2.mediatek.inc (172.21.101.187) by\n mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.29; Mon, 20 Apr 2026 15:27:53 +0800","from mcddlt001.gcn.mediatek.inc (10.19.240.15) by\n mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id\n 15.2.2562.29 via Frontend Transport; Mon, 20 Apr 2026 15:27:52 +0800"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS,\n UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.2","X-UUID":["72594b2a3c8a11f1ae70033691e9ac7d-20260420","72594b2a3c8a11f1ae70033691e9ac7d-20260420"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n d=mediatek.com;\n s=dk;\n h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID;\n bh=w/1w0cTJe4vsuIHX8JHyM281JV23OvrQbAds8p42Z7o=;\n b=Es0TDCD6alhlHv44zOFhMD3cHro0eetTAbhfXGnUn6AoxZA7DwD9w8rqhGmDVZJD6ONw8AId0u90NiPGLVGMFFcokOQJiWnofTSqcJp33H5eBH5wysVeDi7HGL54HiRb0yiAFFizoZNKihezlFSmtaPck78EUhwn6e/eteRekhE=;","X-CID-P-RULE":"Release_Ham","X-CID-O-INFO":"VERSION:1.3.12, REQID:746b6dd0-3aca-498b-9ee3-86b8f15f0499,\n IP:0,\n U\n RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION:\n release,TS:0","X-CID-META":"VersionHash:e7bac3a, CLOUDID:2c742295-f8ef-4ca8-bea0-143568f9ca1d,\n B\n ulkID:nil,BulkQuantity:0,Recheck:0,SF:80|81|82|83|102|836|865|888|898,TC:-\n 5,Content:0|15|50,EDM:-3,IP:nil,URL:0,File:130,RT:0,Bulk:nil,QS:nil,BEC:-1\n ,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0","X-CID-BVR":"2,SSN|SDN","X-CID-BAS":"2,SSN|SDN,0,_","X-CID-FACTOR":"TF_CID_SPAM_SNR","X-CID-RHF":"D41D8CD98F00B204E9800998ECF8427E","Message-ID":"<20fe278b75a677602e54bb7dcb7318df91180d94.camel@mediatek.com>","Subject":"Re: [PATCH 3/3] env: ubi: add support to create environment volume\n if it does not exist","From":"Weijie Gao ","To":"Simon Glass ","CC":"","Date":"Mon, 20 Apr 2026 15:27:52 +0800","In-Reply-To":"\n ","References":"\n \n ","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.28.5-0ubuntu0.18.04.2 ","MIME-Version":"1.0","Content-Transfer-Encoding":"7bit","X-MTK":"N","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]