[{"id":3678930,"web_url":"http://patchwork.ozlabs.org/comment/3678930/","msgid":"<CAFLszThHeX97x6Ebc_7TZiRs3ez2MC05Kf0ir+yo9=09NHThHg@mail.gmail.com>","list_archive_url":null,"date":"2026-04-18T00:47:23","subject":"Re: [PATCH 2/3] cmd: ubi: allow creating volume with all free spaces\n in ubi_create_vol","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Weijie,\n\nOn 2026-04-17T02:35:14, Weijie Gao <weijie.gao@mediatek.com> wrote:\n> cmd: ubi: allow creating volume with all free spaces in ubi_create_vol\n>\n> Although the ubi command itself supports creating volume with all\n> free spaces, the api ubi_create_vol() does not.\n>\n> Since negative size in invalid, this patch replaces negative size\n\nis invalid\n\n> with all free space size in ubi_create_vol().\n>\n> Signed-off-by: Weijie Gao <weijie.gao@mediatek.com>\n>\n> cmd/ubi.c | 6 +++++-\n>  1 file changed, 5 insertions(+), 1 deletion(-)\n\n> diff --git a/cmd/ubi.c b/cmd/ubi.c\n> @@ -226,7 +226,11 @@ int ubi_create_vol(char *volume, int64_t size, int dynamic, int vol_id,\n> +     if (size < 0)\n> +             req.bytes = ubi->avail_pebs * ubi->leb_size;\n> +     else\n> +             req.bytes = size;\n\nWhen size is negative, the printf() below still prints the original\nnegative size rather than the computed req.bytes\n\nRegards,\nSimon","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=iy2ttz/P;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"iy2ttz/P\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fyClV6KsHz1yGt\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 18 Apr 2026 10:47:50 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id DAD888425F;\n\tSat, 18 Apr 2026 02:47:42 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id C432784246; Sat, 18 Apr 2026 02:47:40 +0200 (CEST)","from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com\n [IPv6:2a00:1450:4864:20::62e])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 87C42839D9\n for <u-boot@lists.denx.de>; Sat, 18 Apr 2026 02:47:38 +0200 (CEST)","by mail-ej1-x62e.google.com with SMTP id\n a640c23a62f3a-b980785a0bfso193811866b.3\n for <u-boot@lists.denx.de>; Fri, 17 Apr 2026 17:47:38 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776473258; cv=none;\n d=google.com; s=arc-20240605;\n b=N9FfCXd92tIC2vbnlyuizT2bcJILALUE6ychiAVS4FPGqJVzv26wguRKYlPXzfd2Ty\n sxQwRiL1hrsRm0qOEWCNBX7tYy610Fk2L4V2CHGOYYzAtD/9JqwSqRwyfi8ne83ZDFp+\n ws9NeOrUquh7SKnZ6xZGlMb74gyeJcU8uRIFGxeaedahXTd3CIQ/+ifyZYGc5Topk7jH\n gYQn28PVyUNaCZSQqD9Xcq8B8/bs2gZtjZo5kYt23DVFL9P29i0fqy26ZSAo/bNBEapD\n BaG5a9+NhMuHF7CpLDoIedyR2hZkfV9KdO65i7q2Ow9TSAxpzXGycryQsoi3hVS7Tjzs\n YJSA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=F/R3jq7ipvNVR3A0Dr/AQ/sGYunVJnbkGbxyV4RwEjg=;\n fh=fJAGB8LvxCJalDRE+ziaXIW21+gD5jSCb0B1QEwHsvE=;\n b=RDPztLUYDv4ns9LYAE6TvPrZl8mzgH/grhUCig+zlReUtc60kOa+rlHsdUyEYYJysF\n 1E5nqiWGmXJuvXR3QGACXy6A3q0lW6QEcK1RUaFTXuIELbHjEdQ3ree5dkkx97XeU6MN\n /VGL2j4IuCEPCmBYXLnYyOe6i5l/4Zuq8q10bT3sVapZG8pxoH+az9nzSCS7SNGTCIJt\n qvR52fY3FId2k6sDZ9UhBVhUS4RNPqpD/QGiHgObieIIBd6k+P0tC7puRgHYUGDTDG30\n 9i1cE+aKYm//StwAh0Q4NHmRROjDuknev1zdAJENjVCDE8FIMUrmL92PZhjyhi3u3+U7\n p0xQ==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776473258; x=1777078058; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=F/R3jq7ipvNVR3A0Dr/AQ/sGYunVJnbkGbxyV4RwEjg=;\n b=iy2ttz/PlhqzFgB27xLjUo37016k4lLZDRKZL+rK+AsjfnTbKXj0RuUVnSNMMBNwsk\n yclBX0rdwIehJ595tD1ta2Vmwlz8RCqwqu/Ir4h4kfg9x4BIi143++6VpafIy8QC+NtW\n A2ziJMapyqbaUCYDDIWoLXQmJzeR+GbQW2Iaw=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776473258; x=1777078058;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=F/R3jq7ipvNVR3A0Dr/AQ/sGYunVJnbkGbxyV4RwEjg=;\n b=G0bOXz60PXSxdsLBs/CDg5WI6zP+c7WXB6Gy0gg0LLSkGn9RcGmxJUUX3j7OL4eh8e\n 1yOIHpr3Y0N7oVuPp/fDexrVCvkgb2zaFtfxsPYDUaYNZuePjXLnPMWaxhNNN6e01xGO\n AA5fytPONtcSgxxpKn6I3kdoJ1P5M4BnIZ+eEIkmtaOwGD8iicEuuxn0bE/7j585XOsp\n wp0/1tRTRWXcxSBDkQIwdhnoW7zmh84sHGUk/qIKirIYfbBpctt0ctkV4w2ZmG6jf6tI\n Quximo6L3fZoZkXB4Ulpohm+yvnqV67oXjnkaxolCkmOWYZxkDL8SlRQyf3qhQXKc5Sm\n SiBg==","X-Gm-Message-State":"AOJu0YwkXmPb96hOT8uzHWc5GzhSbyeCEJiJI2JMHfIOtnnzUOIQttN+\n uVCj5w9/FLPGIq7Tt1a6jQFQ5iWRQnnP+jwJ3UIZ0Pl4G7PSoMEmdlH25eeUlrgi6FVOftHFn9E\n IEC0V8z12AYiSjV6xqXuxO1g3OicOKbivalfDpMUh","X-Gm-Gg":"AeBDievla+qQMymuyzUVVKPAAPqGQWDo347uKOQM7w+Jfp+3P/mxIZNrD9hA5E+j0bR\n UfysRLBT19jM9TDdqv0ksp5b403HTiUf8GBaFXXUDasrcxMUghejec09Kl2YH8JGxuqyQQy5yEa\n 8pxImOANOJgIIzPaqCAlm8Q3/3WAK9zIE3jUEqbZKw7iW++sebIyfE839KnuA5A2IlgYBeWe8Ug\n /g8tye7ZYknofBSluOf8s3o1Kl70n7Nzx7ikyAsH0CIAGr/2enf7OEwEo4chnRW2r8ypndYgzyO\n MJnL3zjVcHsq50+70/uX","X-Received":"by 2002:a17:906:59a8:b0:b9d:c34f:2a2b with SMTP id\n a640c23a62f3a-ba41b3dffb6mr195594066b.40.1776473257903; Fri, 17 Apr 2026\n 17:47:37 -0700 (PDT)","MIME-Version":"1.0","References":"<cover.1776392312.git.weijie.gao@mediatek.com>\n <17d1fc9a1ecdd0a5d54907b8816ef62793387a42.1776392312.git.weijie.gao@mediatek.com>","In-Reply-To":"\n <17d1fc9a1ecdd0a5d54907b8816ef62793387a42.1776392312.git.weijie.gao@mediatek.com>","From":"Simon Glass <sjg@chromium.org>","Date":"Sat, 18 Apr 2026 12:47:23 +1200","X-Gm-Features":"AQROBzCsCIhnOAcKcWDXyg9eHpfiPyzTuSj25HQWOiW_bEoSlSCyUpkAVDDlhXs","Message-ID":"\n <CAFLszThHeX97x6Ebc_7TZiRs3ez2MC05Kf0ir+yo9=09NHThHg@mail.gmail.com>","Subject":"Re: [PATCH 2/3] cmd: ubi: allow creating volume with all free spaces\n in ubi_create_vol","To":"weijie.gao@mediatek.com","Cc":"u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3679265,"web_url":"http://patchwork.ozlabs.org/comment/3679265/","msgid":"<1219110f4621405d5312a7376d35d1bc6638618f.camel@mediatek.com>","list_archive_url":null,"date":"2026-04-20T07:25:12","subject":"Re: [PATCH 2/3] cmd: ubi: allow creating volume with all free\n spaces in ubi_create_vol","submitter":{"id":75269,"url":"http://patchwork.ozlabs.org/api/people/75269/","name":"Weijie Gao","email":"weijie.gao@mediatek.com"},"content":"On Sat, 2026-04-18 at 12:47 +1200, Simon Glass wrote:\n> Hi Weijie,\n> \n> On 2026-04-17T02:35:14, Weijie Gao <weijie.gao@mediatek.com> wrote:\n> > cmd: ubi: allow creating volume with all free spaces in\n> > ubi_create_vol\n> > \n> > Although the ubi command itself supports creating volume with all\n> > free spaces, the api ubi_create_vol() does not.\n> > \n> > Since negative size in invalid, this patch replaces negative size\n> \n> is invalid\n> \n> > with all free space size in ubi_create_vol().\n> > \n> > Signed-off-by: Weijie Gao <weijie.gao@mediatek.com>\n> > \n> > cmd/ubi.c | 6 +++++-\n> >  1 file changed, 5 insertions(+), 1 deletion(-)\n> > diff --git a/cmd/ubi.c b/cmd/ubi.c\n> > @@ -226,7 +226,11 @@ int ubi_create_vol(char *volume, int64_t size,\n> > int dynamic, int vol_id,\n> > +     if (size < 0)\n> > +             req.bytes = ubi->avail_pebs * ubi->leb_size;\n> > +     else\n> > +             req.bytes = size;\n> \n> When size is negative, the printf() below still prints the original\n> negative size rather than the computed req.bytes\n\nOK. As you mentioned in patch 3/3, I think maybe we can move these\nprintf logs to the command's main function to avoid logs being printed\nevery time these API functions are called.\n\n> \n> Regards,\n> Simon","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=mediatek.com header.i=@mediatek.com header.a=rsa-sha256\n header.s=dk header.b=dmwxSkV6;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=mediatek.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=mediatek.com header.i=@mediatek.com\n header.b=\"dmwxSkV6\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=pass (p=quarantine dis=none)\n header.from=mediatek.com","phobos.denx.de;\n spf=pass smtp.mailfrom=weijie.gao@mediatek.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzcTY0Tbvz1yD4\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 20 Apr 2026 17:25:37 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 63FFD84181;\n\tMon, 20 Apr 2026 09:25:34 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id F10DE84198; Mon, 20 Apr 2026 09:25:32 +0200 (CEST)","from mailgw02.mediatek.com (unknown [210.61.82.184])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 39F16840D8\n for <u-boot@lists.denx.de>; Mon, 20 Apr 2026 09:25:20 +0200 (CEST)","from mtkmbs13n2.mediatek.inc [(172.21.101.108)] by\n mailgw02.mediatek.com (envelope-from <weijie.gao@mediatek.com>)\n (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256)\n with ESMTP id 1989494496; Mon, 20 Apr 2026 15:25:13 +0800","from mtkmbs11n2.mediatek.inc (172.21.101.187) by\n mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.29; Mon, 20 Apr 2026 15:25:12 +0800","from mcddlt001.gcn.mediatek.inc (10.19.240.15) by\n mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id\n 15.2.2562.29 via Frontend Transport; Mon, 20 Apr 2026 15:25:12 +0800"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS,\n UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.2","X-UUID":["127078963c8a11f19a16598d5ca7f8ec-20260420","127078963c8a11f19a16598d5ca7f8ec-20260420"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n d=mediatek.com;\n s=dk;\n h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID;\n bh=WYvpR1loXY2DcU+xA3u3q9xaQyz00G3T3FuuS4oGVag=;\n b=dmwxSkV6pmiLDOrQHyl2L0idUo2r7PJrYyvPv5ZEi0iNuS51mzBTJh+wQ9Fw+KywNJGBR2D4WUZzWW3dHwo8h7c+PE4LQHkiwxpdcf5iNsw/VKtvOWPtva5me8+9tS4TgqTlv1zlH6DXmb1CS3f3i/pG8gEhDTO3FyCf3K/QI3w=;","X-CID-P-RULE":"Release_Ham","X-CID-O-INFO":"VERSION:1.3.12, REQID:5e55d03d-9187-496a-805f-b1e1b4530e7b,\n IP:0,\n U\n RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION:\n release,TS:0","X-CID-META":"VersionHash:e7bac3a, CLOUDID:c5189f8f-6df4-4a3d-a7a4-fbdc42d669ce,\n B\n ulkID:nil,BulkQuantity:0,Recheck:0,SF:80|81|82|83|102|836|865|888|898,TC:-\n 5,Content:0|15|50,EDM:-3,IP:nil,URL:0,File:130,RT:0,Bulk:nil,QS:nil,BEC:-1\n ,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0","X-CID-BVR":"2,SSN|SDN","X-CID-BAS":"2,SSN|SDN,0,_","X-CID-FACTOR":"TF_CID_SPAM_SNR","X-CID-RHF":"D41D8CD98F00B204E9800998ECF8427E","Message-ID":"<1219110f4621405d5312a7376d35d1bc6638618f.camel@mediatek.com>","Subject":"Re: [PATCH 2/3] cmd: ubi: allow creating volume with all free\n spaces in ubi_create_vol","From":"Weijie Gao <weijie.gao@mediatek.com>","To":"Simon Glass <sjg@chromium.org>","CC":"<u-boot@lists.denx.de>","Date":"Mon, 20 Apr 2026 15:25:12 +0800","In-Reply-To":"\n <CAFLszThHeX97x6Ebc_7TZiRs3ez2MC05Kf0ir+yo9=09NHThHg@mail.gmail.com>","References":"<cover.1776392312.git.weijie.gao@mediatek.com>\n <17d1fc9a1ecdd0a5d54907b8816ef62793387a42.1776392312.git.weijie.gao@mediatek.com>\n <CAFLszThHeX97x6Ebc_7TZiRs3ez2MC05Kf0ir+yo9=09NHThHg@mail.gmail.com>","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.28.5-0ubuntu0.18.04.2 ","MIME-Version":"1.0","Content-Transfer-Encoding":"7bit","X-MTK":"N","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3679546,"web_url":"http://patchwork.ozlabs.org/comment/3679546/","msgid":"<CAFLszTgWtDYuuscRheT0T8w5bUcbSrRU=7UBWgnGmZxCczp6ow@mail.gmail.com>","list_archive_url":null,"date":"2026-04-20T19:32:18","subject":"Re: [PATCH 2/3] cmd: ubi: allow creating volume with all free spaces\n in ubi_create_vol","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Weijie,\n\nOn Mon, 20 Apr 2026 at 19:25, Weijie Gao <weijie.gao@mediatek.com> wrote:\n>\n> On Sat, 2026-04-18 at 12:47 +1200, Simon Glass wrote:\n> > Hi Weijie,\n> >\n> > On 2026-04-17T02:35:14, Weijie Gao <weijie.gao@mediatek.com> wrote:\n> > > cmd: ubi: allow creating volume with all free spaces in\n> > > ubi_create_vol\n> > >\n> > > Although the ubi command itself supports creating volume with all\n> > > free spaces, the api ubi_create_vol() does not.\n> > >\n> > > Since negative size in invalid, this patch replaces negative size\n> >\n> > is invalid\n> >\n> > > with all free space size in ubi_create_vol().\n> > >\n> > > Signed-off-by: Weijie Gao <weijie.gao@mediatek.com>\n> > >\n> > > cmd/ubi.c | 6 +++++-\n> > >  1 file changed, 5 insertions(+), 1 deletion(-)\n> > > diff --git a/cmd/ubi.c b/cmd/ubi.c\n> > > @@ -226,7 +226,11 @@ int ubi_create_vol(char *volume, int64_t size,\n> > > int dynamic, int vol_id,\n> > > +     if (size < 0)\n> > > +             req.bytes = ubi->avail_pebs * ubi->leb_size;\n> > > +     else\n> > > +             req.bytes = size;\n> >\n> > When size is negative, the printf() below still prints the original\n> > negative size rather than the computed req.bytes\n>\n> OK. As you mentioned in patch 3/3, I think maybe we can move these\n> printf logs to the command's main function to avoid logs being printed\n> every time these API functions are called.\n\nYes, good idea.\n\nRegards,\nSimon","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=jm5fp4O3;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"jm5fp4O3\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzwcX4PWSz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2026 05:32:44 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 65EDC84374;\n\tMon, 20 Apr 2026 21:32:36 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 4A40184347; Mon, 20 Apr 2026 21:32:35 +0200 (CEST)","from mail-ej1-x634.google.com (mail-ej1-x634.google.com\n [IPv6:2a00:1450:4864:20::634])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 2E34284347\n for <u-boot@lists.denx.de>; Mon, 20 Apr 2026 21:32:33 +0200 (CEST)","by mail-ej1-x634.google.com with SMTP id\n a640c23a62f3a-ba36357195bso395483666b.0\n for <u-boot@lists.denx.de>; Mon, 20 Apr 2026 12:32:33 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776713553; cv=none;\n d=google.com; s=arc-20240605;\n b=PJtJvSBxmUe/B9Axig+DwM4wSlDjeZXNkPKBAhJcAVTRkrvDCUs90vMiX3We0Dv3v9\n CE4EIvq7Do5IXfaKkPGPL48iZGRwLda15bCLpYqSqz8PMAJ0nYACO9BpxFdD0Srb5Uqp\n 1UVWlhoa1+y0cWA+DLeiwunBlb55zqT7La7H5qvgdNCLJ0jZ972NO4ef7u0kCTpiXD5h\n +OVBu9Wp350xNRMiIXol3bisaFbszBPlu0zGNLsUuJHj0SjEugx14ci8hxy6CdOSQ+E0\n IJZ61f5guzvKhTOeYaqzT4BHSJEPUIs4THrh57KPVCLLewfZI/AlqLqq2k9rM7WPEpUK\n /RDg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=nlDIVAiw/n1Q0/t0IVX+Wa+MF6T4VeU6akn34nNkNwU=;\n fh=QQJE3IaAeunPHumA5bQT00HUdZQapHaeCUQ1zQOCaEg=;\n b=Oas8ftjGXGk1wk0fJCLLTyMS8OUo8UMjRXX734GZJCmRta+NF7dif8kfz+RS8kB09W\n yUlJ7vxzaeHHuXCcla4V26SCoIar1nYQoWoOciNxgQU+AxVJ4sMu5nMdiSJuqUZAD7mK\n Mxohr9sjYexNYJXu+pqMWjMafLdp0kVvxtIvG+WgBCfO2b4dJaZ+6vSyqqSAba6l3DeQ\n 9tPzgd5ydNDwxVrUt+N4ggAjnV3G79wX85Z4lgvoYyppTILeDfvQiQaqfpcxwKC4SZqK\n vLtfwjmIn771fPrYFJBxL4WjgllgYor4LgVIN22iXy2GPmb8hlCFkigFRaiSFI7VnE1h\n lX8g==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776713553; x=1777318353; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=nlDIVAiw/n1Q0/t0IVX+Wa+MF6T4VeU6akn34nNkNwU=;\n b=jm5fp4O33zWt0nnxR6QmmneyjbgzJ4jTuGI3b9Qky2/Wr7PGED/V3D9BOAomOZ9IQL\n PTnHLRIEd0q7aiRWkasTxBXmo5prSx02oBbjBEFU+X+eJQFd48DbH8c3aID7Jw8YRVQM\n PDzSxRlhuQG7idbFSxUui4vk1kHScNBL22iVU=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776713553; x=1777318353;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=nlDIVAiw/n1Q0/t0IVX+Wa+MF6T4VeU6akn34nNkNwU=;\n b=OMm9BO8qnUWyAfGBuizypRiQSC1PRYGwAGHYgix02FeQvNIz0WQMZbifOLiYdBXRNR\n 2ZQ52HTYktzC5vjcPhkaGiJKHdmBns2z0+uluKxSUa5rjBpHRnv9TjpmHgnqA0GdRElS\n Jo54FeTra7zepxKzzJ1FPP8fQTgxNx+NkKr5xKwvyrw2i5YrBXyt4Mu/aWDMihJYELJj\n Raot2HCEDzWZt9BgVsZr17m61Rm0hLcVDYDZmBLTFYHshvwEmeos5kBKEpbNzdnhwAl5\n KDKrI+Eb84XPOmvLx2Ioj8HWX09+jkFoiUnEXUKGr6A7RvdRIPEm7jyfP/nDeZeK5biS\n LlrQ==","X-Gm-Message-State":"AOJu0YwymhlCkze0Ujrz9/Wd+EEFQbWnUNuAsa+RRNUJYEj5oI2dHf7+\n MgA+//16cnfiCVzeMI/Fsbeg+JFQy7pus5wQogjBUX47qKA+p8i3Fi3KBznCVoG6GibvbEgftN8\n DpJd4w7PfpDJTMaLDgPaU9gYJAiFEcMt5AxD98Xptqm30uK58MGk6UA==","X-Gm-Gg":"AeBDieu5O7K1qEaspnKTf7uYvZcc3s0YEJQpeby8TxGBaJ/bdXLtdJo2ruecZ5q1TFf\n 1A7cFaVZ4r8qRM2njqJqmMfsFhGryg+8E3D7KOlSHIrKVb7fYcU1MpYSiLlRMmIs8QNzDjoqX1Q\n +toeK88Scu3vSynbhkSrsDBzOzgU6zCrpO2if6SqxXnyYfS+tplF2d7FaUFcD+l0kBXGEG+8lpj\n 9GWL/ljloNfQb42QJRJBoDx3AuQIf3cJ5cL8c9ANS3Gzp/H55JQQEr4J7h5EtQx6CWmIsU76B4r\n ztanMG5VnlgPkNFkA8sJ","X-Received":"by 2002:a17:907:a604:b0:b96:eee1:bb66 with SMTP id\n a640c23a62f3a-ba41829279amr652324466b.10.1776713552565; Mon, 20 Apr 2026\n 12:32:32 -0700 (PDT)","MIME-Version":"1.0","References":"<cover.1776392312.git.weijie.gao@mediatek.com>\n <17d1fc9a1ecdd0a5d54907b8816ef62793387a42.1776392312.git.weijie.gao@mediatek.com>\n <CAFLszThHeX97x6Ebc_7TZiRs3ez2MC05Kf0ir+yo9=09NHThHg@mail.gmail.com>\n <1219110f4621405d5312a7376d35d1bc6638618f.camel@mediatek.com>","In-Reply-To":"<1219110f4621405d5312a7376d35d1bc6638618f.camel@mediatek.com>","From":"Simon Glass <sjg@chromium.org>","Date":"Tue, 21 Apr 2026 07:32:18 +1200","X-Gm-Features":"AQROBzBxIs7dU5ceP1sMkd4xVgljQfTFBKMnpP5mf5zljcV0nrNHp6pb9GfCZiM","Message-ID":"\n <CAFLszTgWtDYuuscRheT0T8w5bUcbSrRU=7UBWgnGmZxCczp6ow@mail.gmail.com>","Subject":"Re: [PATCH 2/3] cmd: ubi: allow creating volume with all free spaces\n in ubi_create_vol","To":"Weijie Gao <weijie.gao@mediatek.com>","Cc":"u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]