[{"id":3678929,"web_url":"http://patchwork.ozlabs.org/comment/3678929/","msgid":"<CAFLszTiVYt0ShOO83nT7UqZSW4Z0ZpP3goooOkeNOTwYGq60nw@mail.gmail.com>","list_archive_url":null,"date":"2026-04-18T00:47:18","subject":"Re: [PATCH 1/3] cmd: ubi: expose more APIs to public","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Weijie,\n\nOn 2026-04-17T02:35:14, Weijie Gao <weijie.gao@mediatek.com> wrote:\n> cmd: ubi: expose more APIs to public\n>\n> Export ubi_detach/ubi_create_vol/ubi_find_volume/ubi_remove_vol to\n> public for better ubi manipulation used by other modules.\n>\n> Signed-off-by: Weijie Gao <weijie.gao@mediatek.com>\n>\n> cmd/ubi.c           | 10 +++++-----\n>  include/ubi_uboot.h |  5 +++++\n>  2 files changed, 10 insertions(+), 5 deletions(-)\n\n> diff --git a/include/ubi_uboot.h b/include/ubi_uboot.h\n> @@ -47,9 +47,14 @@\n> +extern int ubi_create_vol(char *volume, int64_t size, int dynamic, int vol_id,\n> +                       bool skipcheck);\n> +extern struct ubi_volume *ubi_find_volume(char *volume);\n> +extern int ubi_remove_vol(char *volume);\n\nThe volume parameter should be const char * since these functions do\nnot modify the string. In patch 3/3, env_ubi_volume_create() receives\na const char * and has to cast away const when calling these\nfunctions. Please can you fix the signatures in both cmd/ubi.c and\nubi_uboot.h to take const char *volume.\n\nRegards,\nSimon","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=dGb27lug;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"dGb27lug\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fyClM6HVwz1yGt\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 18 Apr 2026 10:47:43 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 199F1841C2;\n\tSat, 18 Apr 2026 02:47:39 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 284C48405A; Sat, 18 Apr 2026 02:47:38 +0200 (CEST)","from mail-ej1-x634.google.com (mail-ej1-x634.google.com\n [IPv6:2a00:1450:4864:20::634])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id E6CFA839D9\n for <u-boot@lists.denx.de>; Sat, 18 Apr 2026 02:47:34 +0200 (CEST)","by mail-ej1-x634.google.com with SMTP id\n a640c23a62f3a-b9825ba7f9dso344114866b.0\n for <u-boot@lists.denx.de>; Fri, 17 Apr 2026 17:47:34 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776473254; cv=none;\n d=google.com; s=arc-20240605;\n b=H4AQ51gr8u6vfP7UXJj6/mVywDFYD2W9dlHfU52uZxzX0aNBhEtNXEmnatp+J9xYw4\n tWycT29mHa40Mo8iOm7DX/uWyYyMWOWuhVtRZTEAD1OttaeBiTl4Dl5QlLeOhq+nrIcU\n /iHtufQzkZ0tLRTcXgTPlKwDZoUX/Cy+YoAIQ9nSusiz8Xc7NESwGC57AMIdgH2ew21C\n iZsQxZmUdfzymxO1NQFHDCvEaRziLDea4J6zJfkaBz12x8rXVTDdbTOrNhyaDSil3RWk\n OfuPfHgnh4rXXHGy2HRZliwhvdfuU6/RGSrZba0lz6dt/x5THlVu9VJwAChNpNlNY/s5\n 60CQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=H3RBr22v1p0d4OmqYaNWv/xkwL1sWWPdvZbXWrWCTR8=;\n fh=fJAGB8LvxCJalDRE+ziaXIW21+gD5jSCb0B1QEwHsvE=;\n b=iEUKGvxgjOjiDFpXRgJk/3p7c21dFFG4uMBdMszH0rQnXBjc3HqgrHkns67yk8w9k5\n RZKWdou1osBbr1lZnf2+sNrltBpR/8vCXqhIaV7yARqLpd98kzkEcrYEq31fERWKg1ba\n GwRRKsYRCv00QfA2wEeFkxL8/lxFF0SGTSadD9lFB/GlrMbE5XoWfDcL6iIIGZzOOhfQ\n pSu893sXae7kMIbR+JmOI4JJ4wt7DHy0erwZn+PjYsBaqpL+KUxmKIqR7DpxsGK5wcmV\n t5enSPtduPlIDHFuMsx+kJT0ozi7GBfJdsblddQy1WNkqNMm8UwbEiqUXchT2FvcHOxs\n RcQQ==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776473254; x=1777078054; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=H3RBr22v1p0d4OmqYaNWv/xkwL1sWWPdvZbXWrWCTR8=;\n b=dGb27lugWDHtuP3LYEi2+9b0jgwBadb2wZyfc/oCuES0ZxHgoO+UP8/H1lOKQAZ/7L\n LtDtwyT/aTwe7QMtJruOC1IyvSIsSQtk8vG/xvTbsggfyuimuiYVSkyRMjyarX5qbXrC\n LvR4b5Fjyz77HAWhR59IJQp6uH7BOuV51mLl4=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776473254; x=1777078054;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=H3RBr22v1p0d4OmqYaNWv/xkwL1sWWPdvZbXWrWCTR8=;\n b=oh8R91Ssv5fpZ2qfvEEAAGyJko3LnblEAeb3AhbwmQ34980psmk1p7gvUadaIw+Vjn\n o/3K2t8ePmMxg0fhM4P/4G4bVWL+yrze6ROHIsvsjzPvYgqv4P9sw4Z62x0TKnuHAp20\n ufIuYM4dm7KJscjNqe77n/cwbtn1k0K32IvAHbrhxmP5TrakRVx4MEd6jNzZGhXzAfhd\n 38XHzwmwPRV48TUnBX/2TGdGKsIRft/hgAR7Gf0zfyvhGSd2C3DLGbE8LgdhOJeAaC0m\n MbH3AnNx7NVPLHlm6gOEB17cNmOjoGzQXZBkV4mteIHM+zs+cLvqomahUeUCSMGdHVjj\n cZ/w==","X-Gm-Message-State":"AOJu0YzucJY1WOPslHJg20YxO7iP3Y2f/uAC+R8AAjfjZueKh5ZhELQS\n c7LTuy6GbV8H7lkoUZmNvHz6hLJu5zR9rYiimGmatzMZRcYAehCEd+MuItnmnJzP17zC2tp3kyw\n rksBxk5DZS85C1+/yhY5mAbIKQWSHvTVE6uM03eMB","X-Gm-Gg":"AeBDietx+AyBQVnUjV+YJHRWvE4lmJnlGdF6Iep76HWwW4BVqaxOq/n9UPL19vz7Ssy\n ZRBEXr1fo8kkJ5i8ao/b1h0+WyDQEwR+CKopQ5cXi9W66suBw2xeZ/5+pMh6jicXbjpf+xFZv1n\n SrVEgDQ8ieQTJqJjC+8lcqTGs9wllXwdt+ReGiIQHfmj/WHR+bk6nys/1bkUqpd1k8UIjt8rd9R\n DQ70xzZ8M4rqsJ0K/odMF89Q2RXjgT1PQGjbtDc8jd5Zv9Xr/wtTcBfkY+eTZ7BW1PhZ7d97WYB\n AIAtkEts/KZfOl/H2USc","X-Received":"by 2002:a17:907:d8f:b0:ba3:5e81:7a88 with SMTP id\n a640c23a62f3a-ba42063bcdfmr252104566b.11.1776473254036; Fri, 17 Apr 2026\n 17:47:34 -0700 (PDT)","MIME-Version":"1.0","References":"<cover.1776392312.git.weijie.gao@mediatek.com>\n <f0024175a615b0217cb3f2181d7957a9f59b9ec8.1776392312.git.weijie.gao@mediatek.com>","In-Reply-To":"\n <f0024175a615b0217cb3f2181d7957a9f59b9ec8.1776392312.git.weijie.gao@mediatek.com>","From":"Simon Glass <sjg@chromium.org>","Date":"Sat, 18 Apr 2026 12:47:18 +1200","X-Gm-Features":"AQROBzAZlcrO1UY0VdsnxgC-Z_4CpwYpGVkak65UBGvkmBprjpzu9X87kkoyCVo","Message-ID":"\n <CAFLszTiVYt0ShOO83nT7UqZSW4Z0ZpP3goooOkeNOTwYGq60nw@mail.gmail.com>","Subject":"Re: [PATCH 1/3] cmd: ubi: expose more APIs to public","To":"weijie.gao@mediatek.com","Cc":"u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3679257,"web_url":"http://patchwork.ozlabs.org/comment/3679257/","msgid":"<7a5fd195af42407ad79de05235beabff083b94b3.camel@mediatek.com>","list_archive_url":null,"date":"2026-04-20T07:18:56","subject":"Re: [PATCH 1/3] cmd: ubi: expose more APIs to public","submitter":{"id":75269,"url":"http://patchwork.ozlabs.org/api/people/75269/","name":"Weijie Gao","email":"weijie.gao@mediatek.com"},"content":"On Sat, 2026-04-18 at 12:47 +1200, Simon Glass wrote:\n> Hi Weijie,\n> \n> On 2026-04-17T02:35:14, Weijie Gao <weijie.gao@mediatek.com> wrote:\n> > cmd: ubi: expose more APIs to public\n> > \n> > Export ubi_detach/ubi_create_vol/ubi_find_volume/ubi_remove_vol to\n> > public for better ubi manipulation used by other modules.\n> > \n> > Signed-off-by: Weijie Gao <weijie.gao@mediatek.com>\n> > \n> > cmd/ubi.c           | 10 +++++-----\n> >  include/ubi_uboot.h |  5 +++++\n> >  2 files changed, 10 insertions(+), 5 deletions(-)\n> > diff --git a/include/ubi_uboot.h b/include/ubi_uboot.h\n> > @@ -47,9 +47,14 @@\n> > +extern int ubi_create_vol(char *volume, int64_t size, int dynamic,\n> > int vol_id,\n> > +                       bool skipcheck);\n> > +extern struct ubi_volume *ubi_find_volume(char *volume);\n> > +extern int ubi_remove_vol(char *volume);\n> \n> The volume parameter should be const char * since these functions do\n> not modify the string. In patch 3/3, env_ubi_volume_create() receives\n> a const char * and has to cast away const when calling these\n> functions. Please can you fix the signatures in both cmd/ubi.c and\n> ubi_uboot.h to take const char *volume.\n\nOK. We need another patch to change all existing functions with char *\nto const char *.\n\n> \n> Regards,\n> Simon","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=mediatek.com header.i=@mediatek.com header.a=rsa-sha256\n header.s=dk header.b=N4GiJqLD;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=mediatek.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=mediatek.com header.i=@mediatek.com\n header.b=\"N4GiJqLD\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=pass (p=quarantine dis=none)\n header.from=mediatek.com","phobos.denx.de;\n spf=pass smtp.mailfrom=weijie.gao@mediatek.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzcL907Ydz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 20 Apr 2026 17:19:12 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 52D1783693;\n\tMon, 20 Apr 2026 09:19:10 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 12446839D5; Mon, 20 Apr 2026 09:19:09 +0200 (CEST)","from mailgw02.mediatek.com (unknown [210.61.82.184])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 2F42A805D7\n for <u-boot@lists.denx.de>; Mon, 20 Apr 2026 09:19:04 +0200 (CEST)","from mtkmbs10n2.mediatek.inc [(172.21.101.183)] by\n mailgw02.mediatek.com (envelope-from <weijie.gao@mediatek.com>)\n (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256)\n with ESMTP id 739357487; Mon, 20 Apr 2026 15:18:57 +0800","from mtkmbs11n2.mediatek.inc (172.21.101.187) by\n mtkmbs13n2.mediatek.inc (172.21.101.108) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.29; Mon, 20 Apr 2026 15:18:56 +0800","from mcddlt001.gcn.mediatek.inc (10.19.240.15) by\n mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id\n 15.2.2562.29 via Frontend Transport; Mon, 20 Apr 2026 15:18:56 +0800"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS,\n UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.2","X-UUID":["3252a2f23c8911f19a16598d5ca7f8ec-20260420","3252a2f23c8911f19a16598d5ca7f8ec-20260420"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n d=mediatek.com;\n s=dk;\n h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID;\n bh=W6Gy10LtZV0oYL0wh/ms1059Tu/V2x9ew1HjCPcX3ms=;\n b=N4GiJqLDbjK7HW5+hrJ0yEO47BnBT1AMdAmnhr61D3sJKtzv9p6vRGA//6sJLqbgR7Y7vMU3h7TwT2FZxMkedRAhnipC0QVV6AwQsZp51HP9py7o+u6qr5gvPL8BC16rnjUFP3EarzkhuHaaTgN5dbI80YB6XA6minKvSqfdfh4=;","X-CID-P-RULE":"Release_Ham","X-CID-O-INFO":"VERSION:1.3.12, REQID:e896877c-fcbe-4920-a77e-8c997bf6f2cd,\n IP:0,\n U\n RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION:\n release,TS:0","X-CID-META":"VersionHash:e7bac3a, CLOUDID:23059f8f-6df4-4a3d-a7a4-fbdc42d669ce,\n B\n ulkID:nil,BulkQuantity:0,Recheck:0,SF:80|81|82|83|102|836|865|888|898,TC:-\n 5,Content:0|15|50,EDM:-3,IP:nil,URL:0,File:130,RT:0,Bulk:nil,QS:nil,BEC:-1\n ,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0","X-CID-BVR":"2,SSN|SDN","X-CID-BAS":"2,SSN|SDN,0,_","X-CID-FACTOR":"TF_CID_SPAM_SNR","X-CID-RHF":"D41D8CD98F00B204E9800998ECF8427E","Message-ID":"<7a5fd195af42407ad79de05235beabff083b94b3.camel@mediatek.com>","Subject":"Re: [PATCH 1/3] cmd: ubi: expose more APIs to public","From":"Weijie Gao <weijie.gao@mediatek.com>","To":"Simon Glass <sjg@chromium.org>","CC":"<u-boot@lists.denx.de>","Date":"Mon, 20 Apr 2026 15:18:56 +0800","In-Reply-To":"\n <CAFLszTiVYt0ShOO83nT7UqZSW4Z0ZpP3goooOkeNOTwYGq60nw@mail.gmail.com>","References":"<cover.1776392312.git.weijie.gao@mediatek.com>\n <f0024175a615b0217cb3f2181d7957a9f59b9ec8.1776392312.git.weijie.gao@mediatek.com>\n <CAFLszTiVYt0ShOO83nT7UqZSW4Z0ZpP3goooOkeNOTwYGq60nw@mail.gmail.com>","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.28.5-0ubuntu0.18.04.2 ","MIME-Version":"1.0","Content-Transfer-Encoding":"7bit","X-MTK":"N","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3679545,"web_url":"http://patchwork.ozlabs.org/comment/3679545/","msgid":"<CAFLszTgMDj4+MuvUZuu8AcPStt8ZArkYFFn4PXNnV5sMSqEnsw@mail.gmail.com>","list_archive_url":null,"date":"2026-04-20T19:32:15","subject":"Re: [PATCH 1/3] cmd: ubi: expose more APIs to public","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Weijie,\n\nOn Mon, 20 Apr 2026 at 19:19, Weijie Gao <weijie.gao@mediatek.com> wrote:\n>\n> On Sat, 2026-04-18 at 12:47 +1200, Simon Glass wrote:\n> > Hi Weijie,\n> >\n> > On 2026-04-17T02:35:14, Weijie Gao <weijie.gao@mediatek.com> wrote:\n> > > cmd: ubi: expose more APIs to public\n> > >\n> > > Export ubi_detach/ubi_create_vol/ubi_find_volume/ubi_remove_vol to\n> > > public for better ubi manipulation used by other modules.\n> > >\n> > > Signed-off-by: Weijie Gao <weijie.gao@mediatek.com>\n> > >\n> > > cmd/ubi.c           | 10 +++++-----\n> > >  include/ubi_uboot.h |  5 +++++\n> > >  2 files changed, 10 insertions(+), 5 deletions(-)\n> > > diff --git a/include/ubi_uboot.h b/include/ubi_uboot.h\n> > > @@ -47,9 +47,14 @@\n> > > +extern int ubi_create_vol(char *volume, int64_t size, int dynamic,\n> > > int vol_id,\n> > > +                       bool skipcheck);\n> > > +extern struct ubi_volume *ubi_find_volume(char *volume);\n> > > +extern int ubi_remove_vol(char *volume);\n> >\n> > The volume parameter should be const char * since these functions do\n> > not modify the string. In patch 3/3, env_ubi_volume_create() receives\n> > a const char * and has to cast away const when calling these\n> > functions. Please can you fix the signatures in both cmd/ubi.c and\n> > ubi_uboot.h to take const char *volume.\n>\n> OK. We need another patch to change all existing functions with char *\n> to const char *.\n\nYes that sounds like a good idea.\n\nRegards,\nSimon","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=Tdjr8v3c;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"Tdjr8v3c\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzwcP4wTSz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2026 05:32:37 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id C275584390;\n\tMon, 20 Apr 2026 21:32:34 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id D846184376; Mon, 20 Apr 2026 21:32:32 +0200 (CEST)","from mail-ej1-x632.google.com (mail-ej1-x632.google.com\n [IPv6:2a00:1450:4864:20::632])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id E1DEA84347\n for <u-boot@lists.denx.de>; Mon, 20 Apr 2026 21:32:29 +0200 (CEST)","by mail-ej1-x632.google.com with SMTP id\n a640c23a62f3a-b8f97c626aaso542695066b.2\n for <u-boot@lists.denx.de>; Mon, 20 Apr 2026 12:32:29 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776713549; cv=none;\n d=google.com; s=arc-20240605;\n b=TgNkIL+R3tp2dQFgSfuQhs99WInAJG2j5w5C2LLIDysjseTrO0/IbLv2lnt813Tm1H\n xPvt/biW7O7k+MjyEWx4p+WnBnn+d2YUC9HhWh+2/Bu+5p7TOzRqibk9yjfSH8DreTvH\n P9eFL2hV/cjSdTtcHcePvytoQGgtk49s5j+RODMpCL4wtG1ycD7QC4igsO/Iz649o9de\n QR+y5Oiczx3Lf5la6X0bEQLrOwh+jNXAqfiJYwVzE5JcOJid0TqQDNTov6yPHZ9mIfX2\n Ubl13pNUdZadKBRVwoRgvDxPP/uIBiTwCmLd57yzFTh4jJzrvGtxbNZwA3WGG5ziriJL\n qifw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=6o95kJwdMrtAnSvaJoCNPyYqgiEcDZmQxU8A8lU3B9s=;\n fh=QQJE3IaAeunPHumA5bQT00HUdZQapHaeCUQ1zQOCaEg=;\n b=UdejOn1VZhFldW+7SukBFI5KvoNBOg/r6N/N82+aN8QOrMqOX6+8zOdad4SklHm58g\n hqK/nrPvVfJL604qbfKK7P5fkkti2GrjXq38qPaL5ZnxuHNR8O599g6YQ/KQxxYMPp0s\n XRVG3PbCxdlUiwPW4iCUaXUVxhlIH5mjSCMjpQPKDjUz6WjhbuOzapHAAZ0w7d8Wiiyz\n V2HmYc6QpwGbUK6J1RCvvRbT9WgucPsSC6w1bhIG0/NNM52pr6MKDrBTpl89mGMmqMYa\n CRV0/qC6hnMy+9vQZ6ka2PvgNg2bn+GzrO7IT1hXq6W6ZVYwbh3BpCjlbiMX0HaPlbCN\n jvpQ==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776713549; x=1777318349; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=6o95kJwdMrtAnSvaJoCNPyYqgiEcDZmQxU8A8lU3B9s=;\n b=Tdjr8v3cONgRp3cQfYQYz/7QU+fYYAvWfe+nQzzJHi6DMyNaYXS2Y09+L0dd6f6w/A\n EiY+8LWYDd8e2SHIqQSdnTCRUNs2LeoHDPJuV3MOPom+YItebyecdwXNmeg+HCaVb2o+\n suCNKkATQC+pc4P4MV7MUIW5U53SC7KQjQV30=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776713549; x=1777318349;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=6o95kJwdMrtAnSvaJoCNPyYqgiEcDZmQxU8A8lU3B9s=;\n b=JjjR0JMpVYQH/j8UIbrXSNYmwiozA5a8dmaBPTe+vkMtsjtYnhi35KqIhZjFD1jhMz\n nP5eSuN6ZeFCQ5Nf4gTCJc1/Q9ActxqAf7x6cGxD+unA3ZwtDCZvINE2eLPE7KIgBdYc\n S1ico1dj4/CwyQ7WX45KWXx38h8f2nwNkt1PN7fEyaBJzYYbwfcxE98Ul2mnen0Dj0od\n 5t9fXbEa6D0KpzcGGUjEbzcg8QC5tM2IR7Wz5fav+gSuTsBL1Q486/RpV2jsgGb8s4lS\n ZgruCUOEKxS3knw/gtT819cnG5rGMyhitf7GBU19TIVIwhm6877plTiUh1oLWkxLA4QX\n 1rlg==","X-Gm-Message-State":"AOJu0YyDxippkEFX8tHTstIcemd6yOl/w/iAGI7fRVzhMNQfw3GiQENq\n U3++LNLjxuvAvU65qbgbKpKhGhWjRVV2X/ImSObb4KHXIsmDlGCkyfr402MeQ21WELaDBSoWA+C\n J19eS6g0gDGTlTD8kk96cGb9nDHzQ0nB7Z48S+3fn8mbs/dRbmJd7eg==","X-Gm-Gg":"AeBDietosKtx+1iiyapEZfL0S8IXIpYpcmH2mh4Ekb9qKsg3Jwvj6wjOQTZUcj1CLcN\n GLm3T8Wp0ka6JzI2QX5mlwoxtOE7madPMl8ABZZWM2/DyKWiPYi0QsL3tfHOQPhttoOymkqGNoT\n A1dLo4AeulWJW0uBbnMfKqVMv5JE8toZXiGQ/tHEf5qds4/xqSbOyf98KqWEb1R1GcLe6CAZoak\n qzKnunHMuSgfBp/GV7qwQPo6nD195Q5SlRHA8JpgmicbaJEXHspkufCjEKlsrrX3cyXYQipMOQo\n jObIFV3T0xHjdiq3HeYn","X-Received":"by 2002:a17:907:da16:b0:b9c:afde:9b59 with SMTP id\n a640c23a62f3a-ba41bad0086mr753835066b.8.1776713549326; Mon, 20 Apr 2026\n 12:32:29 -0700 (PDT)","MIME-Version":"1.0","References":"<cover.1776392312.git.weijie.gao@mediatek.com>\n <f0024175a615b0217cb3f2181d7957a9f59b9ec8.1776392312.git.weijie.gao@mediatek.com>\n <CAFLszTiVYt0ShOO83nT7UqZSW4Z0ZpP3goooOkeNOTwYGq60nw@mail.gmail.com>\n <7a5fd195af42407ad79de05235beabff083b94b3.camel@mediatek.com>","In-Reply-To":"<7a5fd195af42407ad79de05235beabff083b94b3.camel@mediatek.com>","From":"Simon Glass <sjg@chromium.org>","Date":"Tue, 21 Apr 2026 07:32:15 +1200","X-Gm-Features":"AQROBzCCSBrmgXEpXOdLAee2_kgyJdm7T89O4aVkZgWhZhlIOh9xuzMsV0RLrg4","Message-ID":"\n <CAFLszTgMDj4+MuvUZuu8AcPStt8ZArkYFFn4PXNnV5sMSqEnsw@mail.gmail.com>","Subject":"Re: [PATCH 1/3] cmd: ubi: expose more APIs to public","To":"Weijie Gao <weijie.gao@mediatek.com>","Cc":"u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]