[{"id":3678819,"web_url":"http://patchwork.ozlabs.org/comment/3678819/","msgid":"","list_archive_url":null,"date":"2026-04-17T15:16:46","subject":"Re: [PATCH v2 2/3] PCI: switchtec: Replace pci_alloc_irq_vectors()\n with pcim_alloc_irq_vectors()","submitter":{"id":70191,"url":"http://patchwork.ozlabs.org/api/people/70191/","name":"Logan Gunthorpe","email":"logang@deltatee.com"},"content":"On 2026-04-16 8:26 p.m., Shawn Lin wrote:\n> Replace pci_alloc_irq_vectors() with pcim_alloc_irq_vectors() to\n> explicitly request devres-managed interrupt vectors. This makes the\n> driver's intention clear and avoids the ambiguous implicit management\n> previously provided by pcim_enable_device().\n> \n> The change prepares the driver for the eventual removal of the hybrid\n> IRQ management pattern from pcim_enable_device(), ensuring consistent\n> resource management through devres.\n> \n> Signed-off-by: Shawn Lin \n\nThis direction makes sense to me. I remember thinking it was odd that\npci_alloc_ir_vectors() was applicable to managed cases without the pcim\nprefix. Thanks!\n\nReviewed-by: Logan Gunthorpe ","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=deltatee.com header.i=@deltatee.com header.a=rsa-sha256\n header.s=20200525 header.b=g/oYhrQA;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-pci+bounces-52726-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=deltatee.com header.i=@deltatee.com\n header.b=\"g/oYhrQA\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=204.191.154.188","smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=deltatee.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=deltatee.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxzxx1zzLz1yD3\n\tfor ; Sat, 18 Apr 2026 01:56:05 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 79F523087113\n\tfor ; Fri, 17 Apr 2026 15:51:43 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 3F1FE1ADC7E;\n\tFri, 17 Apr 2026 15:51:41 +0000 (UTC)","from ale.deltatee.com (ale.deltatee.com [204.191.154.188])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id EE7B2175A72\n\tfor ; Fri, 17 Apr 2026 15:51:39 +0000 (UTC)","from s0106ac1f6bb1ecac.cg.shawcable.net ([96.51.150.74]\n helo=[10.0.33.11])\n\tby ale.deltatee.com with esmtpsa (TLS1.3) tls\n TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256\n\t(Exim 4.98.2)\n\t(envelope-from )\n\tid 1wDkwf-0000000EGsO-0LVR;\n\tFri, 17 Apr 2026 09:17:25 -0600"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776441101; cv=none;\n b=ly8sb/e9x6Hx+ESUO7tqthWNJS8oq/RO+zJsVX5Eg5FpqH0CHNieR16ZV6VTTL2q9IQ+rRt7GR3cOcj0RLzQ6j5AO3Sr9US+nxOuG2KlrRr94u9FNcmwpL9lGFo0yr0oqpgJGkPa7psq5gy5zAn9unkPT/CDEf51jW5InaAhF4Y=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776441101; c=relaxed/simple;\n\tbh=ixbHQbDg5pJETt37zIjFO0J4AmJGuU3o+3aRQBgcbhU=;\n\th=Message-ID:Date:MIME-Version:To:Cc:References:From:In-Reply-To:\n\t Content-Type:Subject;\n b=sR4HssDEzC60m+uiGQtAMb8PsjNmQi+VUKOo/cbYPy2MTrujdKrSITR8qJ4f6hGjBSs0JA/1wmzjV5UzQwB18RKJZTO1zTq0G5Bx3Q5mJJ3Mc1/Jx3W/JgJlwQWaXy2sYD8mjCXWJWBS1j+bxRS2C8SwHPcW9B881TXLb+mOEgE=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=deltatee.com;\n spf=pass smtp.mailfrom=deltatee.com;\n dkim=pass (2048-bit key) header.d=deltatee.com header.i=@deltatee.com\n header.b=g/oYhrQA; arc=none smtp.client-ip=204.191.154.188","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=deltatee.com; s=20200525; h=Subject:In-Reply-To:From:References:Cc:To:\n\tMIME-Version:Date:Message-ID:content-disposition;\n\tbh=9AvDY0ISEyLjnWkJjYEzw0I+S9rjrAOHDSJlPQul7Vc=; b=g/oYhrQAHC0VuSr5pkvzrz0Hjo\n\tF/M3jw2TYaEzdFYdyhlGngQRZ4iL8MUKAmbPGVZoHZeZV7CkL5paDCUMaPcSBAErt2GFaYwyI177g\n\tii4lS1fHvUggZu7ZUT5VeZJQkaJsQiMj3TCPPP84lF607bu4OC2rCuRjMy4B+njmZzo4vou7LSm9Y\n\tzCT/aHGu628Eabx8diLdGRqKh5cQRmfhGI5KoeAsO+F/lzJ/UZBrsYOrkwswKWIUXF+6YvuwUvVWj\n\tTBwAm12kRq85I3VoPfmvtUHAune6aGMjuUUfteGArjjuErGCxjDVhDvy0pMBP34ul2epEzQIBDyCh\n\t94hRDC7Q==;","Message-ID":"","Date":"Fri, 17 Apr 2026 09:16:46 -0600","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","To":"Shawn Lin , Bjorn Helgaas ","Cc":"Nirmal Patel ,\n Jonathan Derrick ,\n Kurt Schwemmer ,\n Philipp Stanner , linux-pci@vger.kernel.org","References":"<1776392767-83668-1-git-send-email-shawn.lin@rock-chips.com>\n <1776392767-83668-3-git-send-email-shawn.lin@rock-chips.com>","Content-Language":"en-CA","From":"Logan Gunthorpe ","In-Reply-To":"<1776392767-83668-3-git-send-email-shawn.lin@rock-chips.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-SA-Exim-Connect-IP":"96.51.150.74","X-SA-Exim-Rcpt-To":"shawn.lin@rock-chips.com, bhelgaas@google.com,\n nirmal.patel@linux.intel.com, jonathan.derrick@linux.dev,\n kurt.schwemmer@microsemi.com, phasta@kernel.org, linux-pci@vger.kernel.org","X-SA-Exim-Mail-From":"logang@deltatee.com","X-Spam-Level":"","Subject":"Re: [PATCH v2 2/3] PCI: switchtec: Replace pci_alloc_irq_vectors()\n with pcim_alloc_irq_vectors()","X-SA-Exim-Version":"4.2.1 (built Sun, 23 Feb 2025 07:57:16 +0000)","X-SA-Exim-Scanned":"Yes (on ale.deltatee.com)"}}]