[{"id":3678622,"web_url":"http://patchwork.ozlabs.org/comment/3678622/","msgid":"<91f26c77330be0783aad379dd1b04bb4c1411713.camel@linux.ibm.com>","list_archive_url":null,"date":"2026-04-17T09:53:05","subject":"Re: [PATCH v2 1/1] PCI/hotplug: Add 'uevent' sysfs attribute to\n trigger slot events","submitter":{"id":78856,"url":"http://patchwork.ozlabs.org/api/people/78856/","name":"Niklas Schnelle","email":"schnelle@linux.ibm.com"},"content":"On Thu, 2026-04-16 at 16:39 -0500, Ramesh Errabolu wrote:\n> Add a write-only 'uevent' sysfs attribute for synthesizing\n> uevents for a PCI slot. This extends the existing uevent\n> support which emits a KOBJ_ADD uevent in pci_hp_add() with\n> the ability to replay such uevents for cold plugged devices.\n> As such events are only emitted by hotplug capable PCI slots\n> so is the support for synthesizing them.\n> \n> The change was validated by manually triggering 'add' uevent\n> for a specific hotplug PCI slot:\n> \n> $ echo \"add $(uuidgen)\" | sudo tee \\\n> /sys/bus/pci/slots//uevent\n> \n> Signed-off-by: Ramesh Errabolu \n> ---\n> drivers/pci/hotplug/pci_hotplug_core.c | 25 +++++++++++++++++++++++++\n> 1 file changed, 25 insertions(+)\n> \n\nSorry for the review delay. This looks good to me and will really help\nwith udev rule execution for devices which are discovered in standby\nstate during boot and thus currently don't create any uevents. Of\ncourse to work by default this still requires a systemd/udev addition\nthat I know you're also working on. \n\nConsequently, I tested the uevent synthesization with both slots with a\nconfigured (slot powered on) and standby (slot powered off) PCI\nfunction.\n\nFeel free to add:\n\nReviewed-by: Niklas Schnelle \nTested-by: Niklas Schnelle \n\nThanks,\nNiklas","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=J+cPCMJl;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=linux-pci+bounces-52709-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com\n header.b=\"J+cPCMJl\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=148.163.158.5","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linux.ibm.com"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxqwy6Vn2z1yDF\n\tfor ; Fri, 17 Apr 2026 19:54:42 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id D38A93006B7F\n\tfor ; Fri, 17 Apr 2026 09:54:16 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 66E7A38E129;\n\tFri, 17 Apr 2026 09:54:13 +0000 (UTC)","from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n [148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 1261B3382CB;\n\tFri, 17 Apr 2026 09:54:11 +0000 (UTC)","from pps.filterd (m0356516.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63GM4FpY1859863;\n\tFri, 17 Apr 2026 09:54:10 GMT","from ppma22.wdc07v.mail.ibm.com\n (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dh89prqfc-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tFri, 17 Apr 2026 09:54:09 +0000 (GMT)","from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1])\n\tby ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 63H71xpJ031138;\n\tFri, 17 Apr 2026 09:54:09 GMT","from smtprelay05.dal12v.mail.ibm.com ([172.16.1.7])\n\tby ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4dg10ypt5e-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tFri, 17 Apr 2026 09:54:09 +0000","from smtpav03.dal12v.mail.ibm.com (smtpav03.dal12v.mail.ibm.com\n [10.241.53.102])\n\tby smtprelay05.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63H9s8oF26280506\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tFri, 17 Apr 2026 09:54:08 GMT","from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 2677458056;\n\tFri, 17 Apr 2026 09:54:08 +0000 (GMT)","from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 2F6C35803F;\n\tFri, 17 Apr 2026 09:54:06 +0000 (GMT)","from [9.111.8.97] (unknown [9.111.8.97])\n\tby smtpav03.dal12v.mail.ibm.com (Postfix) with ESMTP;\n\tFri, 17 Apr 2026 09:54:06 +0000 (GMT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776419653; cv=none;\n b=OFrGP8DhWMzurjdGq9+UvlsQ43utAAvhJJ8JdgAC/P781iDCHzgQFJz0l7gMsDuuj39hGAy1fR28VGQynswwEaHSNhi84/2aXdNIDyNxUZrWq+gJK+7Am6+FKdjjzMMvyaLogITskcAITP2sOuwaAuUSKFIFpTv0QgWsCbS3deM=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776419653; c=relaxed/simple;\n\tbh=ca3E8ILlyEKM34/nlvVS0FdJGThA3OVE6uPkh+d1c6k=;\n\th=Message-ID:Subject:From:To:Cc:In-Reply-To:References:Content-Type:\n\t Date:MIME-Version;\n b=W2FSuQizZAXGOOx9/+/HaTeKUt9tJb8/OLivZ8EWn1zO+uUoxp+xhsET1oaNbXfxDb69XTrAp/YUAX33YfKq+frFbVx3hmsHLLN1M5owu/u8zuE6aCXCawLeTblxy5sDxgxBueR8BBr6nK2x513R8X5eK8HVPqFA1exlJPQqnfw=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com;\n spf=pass smtp.mailfrom=linux.ibm.com;\n dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com\n header.b=J+cPCMJl; arc=none smtp.client-ip=148.163.158.5","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n\t:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=pp1; bh=Uwn/Qo\n\trNpy7FRGTcQcohOkKyXQnWg9Dv4q4Jpo2GVVw=; b=J+cPCMJl6+wjauI17rGguO\n\tIjdzR60H2Lis5HIFifDu84t+1Vn3ryAhuh0a0q1HygtzhGuAuKM4kgr53HG7sMkF\n\ttHisTb+fnMQWDDElcbkuHQgmztkhtYmjLb7pp7Iy7fy3sbwQjYqujnKVhA0EOIpJ\n\tpuzw9F3+6BduSfdCqybzxo9qF54r/QQsixzEov6z38N1mTBBih1n1LY/8NSPqQdQ\n\toLP13Rt9jjmW1Y7/zBBz6wY2lOmx/MGvSwBiRd41AapAseAA+17kfa8nM2siYUt1\n\tJ9JnmDHNQidrGhnR9srkyiAtjVCD2h0J4OnAu6gIKlbc9ccbxar47wLYrM8vDgsg\n\t==","Message-ID":"<91f26c77330be0783aad379dd1b04bb4c1411713.camel@linux.ibm.com>","Subject":"Re: [PATCH v2 1/1] PCI/hotplug: Add 'uevent' sysfs attribute to\n trigger slot events","From":"Niklas Schnelle ","To":"Ramesh Errabolu , linux-pci@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,\n Bjorn Helgaas\n\t , Lukas Wunner ,\n Peter Oberparleiter\n\t ,\n Matthew Rosato ,\n Gerd\n Bayer\t ,\n Heiko Carstens ,\n Vasily\n Gorbik\t ,\n Alexander Gordeev ","In-Reply-To":"<20260416213909.705753-2-ramesh@linux.ibm.com>","References":"<20260416213909.705753-1-ramesh@linux.ibm.com>\n\t <20260416213909.705753-2-ramesh@linux.ibm.com>","Autocrypt":"addr=schnelle@linux.ibm.com; prefer-encrypt=mutual;\n keydata=mQINBGHm3M8BEAC+MIQkfoPIAKdjjk84OSQ8erd2OICj98+GdhMQpIjHXn/RJdCZLa58k\n /ay5x0xIHkWzx1JJOm4Lki7WEzRbYDexQEJP0xUia0U+4Yg7PJL4Dg/W4Ho28dRBROoJjgJSLSHwc\n 3/1pjpNlSaX/qg3ZM8+/EiSGc7uEPklLYu3gRGxcWV/944HdUyLcnjrZwCn2+gg9ncVJjsimS0ro/\n 2wU2RPE4ju6NMBn5Go26sAj1owdYQQv9t0d71CmZS9Bh+2+cLjC7HvyTHKFxVGOznUL+j1a45VrVS\n XQ+nhTVjvgvXR84z10bOvLiwxJZ/00pwNi7uCdSYnZFLQ4S/JGMs4lhOiCGJhJ/9FR7JVw/1t1G9a\n UlqVp23AXwzbcoV2fxyE/CsVpHcyOWGDahGLcH7QeitN6cjltf9ymw2spBzpRnfFn80nVxgSYVG1d\n w75ksBAuQ/3e+oTQk4GAa2ShoNVsvR9GYn7rnsDN5pVILDhdPO3J2PGIXa5ipQnvwb3EHvPXyzakY\n tK50fBUPKk3XnkRwRYEbbPEB7YT+ccF/HioCryqDPWUivXF8qf6Jw5T1mhwukUV1i+QyJzJxGPh19\n /N2/GK7/yS5wrt0Lwxzevc5g+jX8RyjzywOZGHTVu9KIQiG8Pqx33UxZvykjaqTMjo7kaAdGEkrHZ\n dVHqoPZwhCsgQARAQABtChOaWtsYXMgU2NobmVsbGUgPHNjaG5lbGxlQGxpbnV4LmlibS5jb20+iQ\n JXBBMBCABBAhsBBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAhkBFiEEnbAAstJ1IDCl9y3cr+Q/Fej\n CYJAFAmmAWs8FCQl6sYAACgkQr+Q/FejCYJAn2g//UKzlXOgizdk0wudLooRbGzDo23ktGSPK5Oj9\n 9o5z6v4Jz5+qOHo5835683cqkMLM9//udA1ZcKV88LVwyfmoHChPW24cWBmOEy7RJOWCR4WeEINaO\n pZUGF5YOx7oKTkPs511ky2FR0Heg35754pgTuTMEpYzRXr5pNMPS8mHXcXSARFPDPaCF+uBJ9BafO\n L7XbpSwKRttePsWAlPHbSbloeDApBfHUhcF/pbuM9GNs+c/8V9NK+SwwqNK214t7jaSq9k+19/hfE\n jvU45nbiYQM4VqGCelxVFRWol93JnwPFp/JaMgxgV1VYFH9Ijtgh+qNVVBqO8bbTjioFKy1bHdprN\n 9GyPLDxoaI/lBg+5CwKewzazUjFd0xaqZbTXSgNK4ev/IuNI3qZV8tpvZZWwIgZU1K0Bhplt8Sku+\n O9Yl2H54erq9zuzwXjqBJtoW0+MaKbe+1gZ/v2/AVE2VeQMugPUWDg+2bpJaApRkeA4xQ9XfeW6Bp\n It7xYrwwbVhQtWRC0sRh+QNlU9HI28wPSnLWn7HFBeWupaIrxSp4IEL3eHUn8xv4aA8lpdNsHXD/X\n vqOSUwy5jlTPTlemvwaC9mNHagNdVXng8C6+hxiDLhZ6xH2P4qNHTKmjW61NsdF6Y/HfWP+lmbi8/\n 474UNCltDt/fP01ajqogfWZKFymoH0O0KU5pa2xhcyBTY2huZWxsZSA8bmlrbGFzLnNjaG5lbGxlQ\n GlibS5jb20+iQJUBBMBCAA+AhsBBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAFiEEnbAAstJ1IDCl9y\n 3cr+Q/FejCYJAFAmmAWusFCQl6sYAACgkQr+Q/FejCYJAtIw//WmQW/Z+SLdfrlDH5J2bvixzFNnO\n TOvp8uM8vcNZsxZwPXem4AeCXHayCqipxpa0iXWufEIvdMxkBxWvvM//V+rTUgQnJe6nhDxfLGklx\n 5Mb2H+K/ndS73ElCuA30MPYq7mHr8i3gEmi2ZFX1W47JecJ8hno/DQxhHRG7bd+GFsiKCbsjLWXNq\n s/VaAK9uyOTQx7m6/2nR8L+Mvl1BrRXwkj7Qp0qxfQSd4r+IVNBzNFOcrGagBqsyHrN7Is7IICktH\n 9VFl/G8P+hfviHQLnlxw9ltzpM1Dy6N1+BM3kbqD59gX+L6wqiLJI42eh+SHCiy35FvD3AFlYx4jZ\n MWE6qIgFnbwcL1kvcA7nnwfr3ZizCYPm8e334xXxslXBoRGsvjXSbAeAyZo2dvJXffNHdcDdUbJSl\n CfOixNGGKiQvs00X9ekfq9WmmRFvmYHu/m3lg1OXnMjFFIO41O51ZdhbEYJiqZEki7jA8Hd9xuWwQ\n nFDHhacU3xxivZ4BKQGQc+4XZ3yp/q6+7ux9prepRy/LeRyoaAmE67oxEsAgj+qyA3Tfy5nRTDdRQ\n E//gpaIt9H1VEx+68dRWHroxBQeozpnFPi25AlX3k4/EtVZjcItPWgE9iru1qT4DH3BBrz7Kd1zUw\n NnQC77zDJyZD2WUj1E+5bftO0aeE+7HZXj3tM/ea0K05pa2xhcyBTY2huZWxsZSA8bmlrbGFzLnNj\n aG5lbGxlQGdtYWlsLmNvbT6JAlQEEwEIAD4CGwEFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AWIQSds\n ACy0nUgMKX3Ldyv5D8V6MJgkAUCaYBa6wUJCXqxgAAKCRCv5D8V6MJgkF/TEACOY2kL4NGFIbWeM5\n TUhatxqe8c3RT6jvNjq32CkvaK/cSZzBkS0smddyOzxt2WnsvMgkr9cM7P+CevoMwhT3e0lgQbqBD\n /vXZJjWKddC+iKXeqWkjMVcgCOsWNZ7PWEzRUT5X1AEFq2zzxQAQ/bCWEYNqIbHN4b6G1Wk+2Y598\n +KypZ3FS0bwiItnPQOWzOOqJCGxDxaEUuXFx4ah8HtVdtIev8jPS/5uzQO9iG2vZQUWeMEYZtfMHW\n sbFWqo2A3lxB+KPzNIYFhul4Lyx1CwvKUAGSHOx7FZuc2xI5DYt/Wdh2QyKFYr7xVzv3uwJjeS1+3\n 6gvyB7DJaQuY+PziNPv4GPr5wy0cRkJ6Ps15fgC6y6wNwoNdNXKlwiuclIsBzJKa7A0pZMIfpCpIJ\n bEHP7oy3drBRAhIrBx7Lx1lyqqodDqc+ok5IQ5WcKG/TOrH732mTmJX6fxYTiCVxcU4WLJSNZbrZ/\n pjF0AWXs7E+onAkQy6RLg/XU1iiU5QdMvug+fTA6TpPSUMdujWtGWUt3/4nC+69AVc8tXtRQTZ7gP\n t7uIcQFwPqUuJGS26vl0w/6dIABQAyU9acvE3adCZra+/PBKFZi/yxT1WgV1T2mexKSWwQgLcR57J\n Yp5oWnQRgi/S6fAoskIWkp9UVcfAQPY0p45NwO5cZR9/g06JZmyrQhTmlrbGFzIFNjaG5lbGxlIDx\n uaWtzQGtlcm5lbC5vcmc+iQJUBBMBCAA+AhsBBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAFiEEnbAA\n stJ1IDCl9y3cr+Q/FejCYJAFAmmAWusFCQl6sYAACgkQr+Q/FejCYJAz4A/9F+dMhzu7YonagL4qh\n WDz5IpRD4vzYKOBZ+qwYp1ugJz1BIUppN9i68HKoS4ARfgP97Sv9GpOy9g7L0lymH2MPF8hRPK0Yn\n 7DKIkeu/r28YWEoWfoVm5reC+gpxMgmxBz4JScE4f6xfa7+Nw0bbTDl+nxftJD7lf/dTiruNJsXph\n HQnZ5wPXmxeH6XVJikfpyrGe8iJZALbtHtjlx6Omu7NvRGikenB8trrWS5W0F60ZdbqH1HdmDDcrZ\n pDq6LtAARHK5tGRm0SK6sZpKe3nULFeeCt7T/edk2FC6KVh4sL1jw1kyceX4DjiMffqYBPrhK5gz5\n cDIixLBF9C6Wt1ObvuDBrIQf1/3q6EZrUrUuf6qtaXDMuC6cSlShm47qaPEvVYh67O9JZQ7vzvaea\n UI74DJUb8Pjnz7mTOmMOzsS1gUhCue4n2YSSM6ythioCGb/3bgMGTpuer3JhvZG5s5uKD9yyj8s8x\n 35qJkCFfjmjVx9s3vSUS48X+cUpYcMispErKzFu7C0YgKoxvJ4XTfXlDBiMFMPYcN67hsb2jeYHVJ\n wzE+fIZiDx9JLh1oQW2krwjweisE+3glOaKXZKi0fBtkxyH41iemLtLNYZRJopv6ykdl3hiI+Nh+a\n 3FZJPTo/OpqchMm8XIeDxC4NFFiPMpyLeYzIxO7eZpiGrAjVTE=","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Date":"Fri, 17 Apr 2026 11:53:05 +0200","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Evolution 3.58.3 (3.58.3-1.fc43) ","X-TM-AS-GCONF":"00","X-Proofpoint-Reinject":"loops=2 maxloops=12","X-Proofpoint-GUID":"BvEtxZrtutzZ_vSfRWaiCYBM7hf1cmDs","X-Proofpoint-ORIG-GUID":"dvKe91HVtz2B91rMryD9JpOUE1R_9a9j","X-Authority-Analysis":"v=2.4 cv=WbE8rUhX c=1 sm=1 tr=0 ts=69e20342 cx=c_pps\n a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=Y2IxJ9c9Rs8Kov3niI8_:22 a=VnNF1IyMAAAA:8\n a=J2mpDwMlNH794PE16W8A:9 a=QEXdDO2ut3YA:10","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDE3MDA5NyBTYWx0ZWRfXxoVl3wrxmN2/\n CkuRn99l2Bza1J5YThZLui5z+pLH+HSArYjQDXLGFGEfQgS7xIXJN9kZgcYL66dqjjKSct3qf5w\n MOso+YdJadfOq4DISkrncCT4zcT+dyx4h8ni8YN4N7v5vt3/pq7yxmpEsFwdONN/kymZnf2wONi\n o+eGKF8ITVsKKGBmIKG1Zms7CA/SERkCwhrhfE6l8Thf6gCSRvhTKH0QntHZQNaic8MlReVXi3y\n rHEXR5j3/yB4wtYebm45jr24p7ODOpo3ct4kVgMbwog9xw8Xbxzkhz682+N7lSdTdQcsHDsfQqq\n P+qJUp3NsmmGCku/iuVKzk89cTXSaTMrdGkFeqjzHuIj0M+m0rLURMls1FibBcAjxnczdNA+R62\n F2olKdh8L+pKla3+F4Gy7G7p099IR15HnBPWrztxPuop1MJPu1ktDW03KOmHjmVbDOEsAsaD3Gn\n sSgyNGJ5BorIcBXnZZg==","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-16_04,2026-04-16_03,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n suspectscore=0 bulkscore=0 priorityscore=1501 spamscore=0 clxscore=1015\n phishscore=0 impostorscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604170097"}},{"id":3679553,"web_url":"http://patchwork.ozlabs.org/comment/3679553/","msgid":"<5c1498cb-5de6-41be-8db7-f76a385237c0@linux.ibm.com>","list_archive_url":null,"date":"2026-04-20T19:37:46","subject":"Re: [PATCH v2 1/1] PCI/hotplug: Add 'uevent' sysfs attribute to\n trigger slot events","submitter":{"id":91783,"url":"http://patchwork.ozlabs.org/api/people/91783/","name":"Ramesh Errabolu","email":"ramesh@linux.ibm.com"},"content":"Thanks for testing and also giving me the review-by\n\nRegards,\nRamesh\n\n\nOn 4/17/2026 4:53 AM, Niklas Schnelle wrote:\n> On Thu, 2026-04-16 at 16:39 -0500, Ramesh Errabolu wrote:\n>> Add a write-only 'uevent' sysfs attribute for synthesizing\n>> uevents for a PCI slot. This extends the existing uevent\n>> support which emits a KOBJ_ADD uevent in pci_hp_add() with\n>> the ability to replay such uevents for cold plugged devices.\n>> As such events are only emitted by hotplug capable PCI slots\n>> so is the support for synthesizing them.\n>>\n>> The change was validated by manually triggering 'add' uevent\n>> for a specific hotplug PCI slot:\n>>\n>> $ echo \"add $(uuidgen)\" | sudo tee \\\n>> /sys/bus/pci/slots//uevent\n>>\n>> Signed-off-by: Ramesh Errabolu \n>> ---\n>> drivers/pci/hotplug/pci_hotplug_core.c | 25 +++++++++++++++++++++++++\n>> 1 file changed, 25 insertions(+)\n>>\n> Sorry for the review delay. This looks good to me and will really help\n> with udev rule execution for devices which are discovered in standby\n> state during boot and thus currently don't create any uevents. Of\n> course to work by default this still requires a systemd/udev addition\n> that I know you're also working on.\n>\n> Consequently, I tested the uevent synthesization with both slots with a\n> configured (slot powered on) and standby (slot powered off) PCI\n> function.\n>\n> Feel free to add:\n>\n> Reviewed-by: Niklas Schnelle \n> Tested-by: Niklas Schnelle \n>\n> Thanks,\n> Niklas","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=fvtp4b3I;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-52798-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com\n header.b=\"fvtp4b3I\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=148.163.158.5","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linux.ibm.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzwkV6zZYz1yD4\n\tfor ; Tue, 21 Apr 2026 05:37:54 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 21A7F3022613\n\tfor ; Mon, 20 Apr 2026 19:37:53 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 3CE863845CD;\n\tMon, 20 Apr 2026 19:37:52 +0000 (UTC)","from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n [148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id D047D3C872E;\n\tMon, 20 Apr 2026 19:37:50 +0000 (UTC)","from pps.filterd (m0353725.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63K9SNPO2492449;\n\tMon, 20 Apr 2026 19:37:49 GMT","from ppma23.wdc07v.mail.ibm.com\n (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dm2k0rmkx-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tMon, 20 Apr 2026 19:37:48 +0000 (GMT)","from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1])\n\tby ppma23.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 63KJZI2A021402;\n\tMon, 20 Apr 2026 19:37:48 GMT","from smtprelay01.wdc07v.mail.ibm.com ([172.16.1.68])\n\tby ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4dmnsgwyg8-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tMon, 20 Apr 2026 19:37:48 +0000 (GMT)","from smtpav05.wdc07v.mail.ibm.com (smtpav05.wdc07v.mail.ibm.com\n [10.39.53.232])\n\tby smtprelay01.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63KJbl7o1508110\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tMon, 20 Apr 2026 19:37:47 GMT","from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id ED59658053;\n\tMon, 20 Apr 2026 19:37:46 +0000 (GMT)","from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 5EDED58043;\n\tMon, 20 Apr 2026 19:37:46 +0000 (GMT)","from [9.16.40.3] (unknown [9.16.40.3])\n\tby smtpav05.wdc07v.mail.ibm.com (Postfix) with ESMTP;\n\tMon, 20 Apr 2026 19:37:46 +0000 (GMT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776713872; cv=none;\n b=UhfGNKSKM7j5SKQLhNqsYXUn4jGgQof8KbgOfezyvr5J23pL01bL+OELaDEmfthxmEWScpF4tq9qGs/371UHm60el/W2DRvohJp06WmjkerK6Nv8Z+uip5Btcu1CDOZb5Epf7Oj2q7SR86EWP2u6IBNmQ6bvoVDo/4VrKh8/cFg=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776713872; c=relaxed/simple;\n\tbh=jMHTE4tbMd0Ik2MeWBlvgzwC4gxSOJlFTyiQrOS4lgc=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=D2UwBUKVE52Iw5ePiaNPc3ahDLqDvdG0r+6M01SNSQG2MUjYWMVkm3in/BV2NpzzNSOPos2sGdOP5lCBiqkDJBot0wu4+5tjnJf500RzJkgApR6Cfg8eRD6lTRr/HA+FTDfSqiQBou3nDaTTSaPsQd7A12Q4vOo57KGOhXZezbE=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com;\n spf=pass smtp.mailfrom=linux.ibm.com;\n dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com\n header.b=fvtp4b3I; arc=none smtp.client-ip=148.163.158.5","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n\t:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:reply-to:subject:to; s=pp1;\n\t bh=kXfS9t43hMBtiRLlGqvBQDUHz89EVpV6pEmffSvYM7Q=; b=fvtp4b3Im9tz\n\tX2v7n3DcQALDcnkuZd4MJ6mIYTKTp4T6ATSy8kzovLe+aqRrhkfE0vcvw4THq32G\n\tAYGIIEhku1H+h5ZR83y/EW7MF8ql5Gg+CBb5PNna7T9jJ9rJRznQA+77W4tvKGYd\n\tUACKiCJiqpkrgINZ2RreH6C9E8JLh6gRdQuQdfHmF6FOycHSI+rSuTO7JBqumnZE\n\tJ/Pwi4VB/co5KlcR6BhHA64OF9cUXAcfVRz9+LKdV8I5WMsDA3A3HWe83Z1G85Wh\n\tCOQVLScdN6cOfp92m9u8HVL8lrLkSswgng4yRKPpZc0e4l4Z9S3avJea7Qm+sDKW\n\t47DBwNAfUw==","Message-ID":"<5c1498cb-5de6-41be-8db7-f76a385237c0@linux.ibm.com>","Date":"Mon, 20 Apr 2026 14:37:46 -0500","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Reply-To":"ramesh@linux.ibm.com","Subject":"Re: [PATCH v2 1/1] PCI/hotplug: Add 'uevent' sysfs attribute to\n trigger slot events","To":"Niklas Schnelle , linux-pci@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,\n Bjorn Helgaas , Lukas Wunner ,\n Peter Oberparleiter ,\n Matthew Rosato ,\n Gerd Bayer , Heiko Carstens ,\n Vasily Gorbik ,\n Alexander Gordeev ","References":"<20260416213909.705753-1-ramesh@linux.ibm.com>\n <20260416213909.705753-2-ramesh@linux.ibm.com>\n <91f26c77330be0783aad379dd1b04bb4c1411713.camel@linux.ibm.com>","Content-Language":"en-US","From":"Ramesh Errabolu ","In-Reply-To":"<91f26c77330be0783aad379dd1b04bb4c1411713.camel@linux.ibm.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","X-Proofpoint-Reinject":"loops=2 maxloops=12","X-Proofpoint-ORIG-GUID":"bB9VXPujCJ7NzEiCp2uGlIrhpKj-cUQr","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDIwMDE4OCBTYWx0ZWRfX/7VZ1lLWOtMY\n s2BEqBqG4ocGU5sISkT16shJNZkYz88EfuY4CzMuHZ4xiQl3SazE18BFjqwZFcaTPp1p8OSCB8k\n 440ndo0l1PHX5U6zoEeoE2YgvbfNg4SIS27R8er9xLLqi3zEZCkC/Ge0RNdFhEE+DXI8g1wBw+W\n sxzGjRp4w+XyRkSERPvVLMdqLtjfPymgZBqwF/ppto2zeN8xbMBZ1M3jJVB1GTRZeSOWn9066ER\n xmAa+BiHKrQoJGXJFnhrwqL+zCUFdpqyTWqzjUqwoFpYxWZPzzz9rKDj5ONWg5AcNrIx+a/UdQY\n s2JBZhl4cQUC5Fulv/zku7s/2T+6dtRFIPVJsYfJWmM0Z+ThuY96mZb2GHMTUaIDvvN0JlNy76F\n K0urwZuqv+cc4v0j37/3PXSZyhpCBK+b1FvKNKqgiMDe4N8soOIQc0LjLUZzwN4DH4QQa+Qp6nd\n bhlU9NuJUorBeA+C7zQ==","X-Authority-Analysis":"v=2.4 cv=PtujqQM3 c=1 sm=1 tr=0 ts=69e6808d cx=c_pps\n a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=V8glGbnc2Ofi9Qvn3v5h:22 a=VnNF1IyMAAAA:8\n a=RE2A0m1FG7ZolbHhaAUA:9 a=QEXdDO2ut3YA:10","X-Proofpoint-GUID":"lZX-d6iqeEQccDjoDCSDTMPkogwtlmqt","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-20_03,2026-04-20_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n malwarescore=0 suspectscore=0 clxscore=1015 spamscore=0 impostorscore=0\n priorityscore=1501 bulkscore=0 adultscore=0 lowpriorityscore=0 phishscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604200188"}},{"id":3679993,"web_url":"http://patchwork.ozlabs.org/comment/3679993/","msgid":"<20260421171334.GA1684602@rocinante>","list_archive_url":null,"date":"2026-04-21T17:13:34","subject":"Re: [PATCH v2 1/1] PCI/hotplug: Add 'uevent' sysfs attribute to\n trigger slot events","submitter":{"id":77280,"url":"http://patchwork.ozlabs.org/api/people/77280/","name":"Krzysztof Wilczyński","email":"kw@linux.com"},"content":"Hello,\n\n> +static struct pci_slot_attribute hotplug_slot_attr_uevent = {\n> +\t.attr = {.name = \"uevent\", .mode = S_IFREG | 0200},\n> +\t.show = NULL,\n> +\t.store = uevent_write_file\n> +};\n\nI think, you could use the __ATTR_WO() macro here.\n\nThank you!\n\n\tKrzysztof","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-pci+bounces-52863-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.214.171","smtp.subspace.kernel.org;\n dmarc=fail (p=none dis=none) header.from=linux.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0TYw2rMxz1yGt\n\tfor ; Wed, 22 Apr 2026 03:17:24 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id EDBFC306F968\n\tfor ; Tue, 21 Apr 2026 17:13:41 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id EA8DB37A481;\n\tTue, 21 Apr 2026 17:13:37 +0000 (UTC)","from mail-pl1-f171.google.com (mail-pl1-f171.google.com\n [209.85.214.171])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id CE87D33F8B4\n\tfor ; Tue, 21 Apr 2026 17:13:36 +0000 (UTC)","by mail-pl1-f171.google.com with SMTP id\n d9443c01a7336-2b4583f0a1aso28313265ad.3\n for ; Tue, 21 Apr 2026 10:13:36 -0700 (PDT)","from localhost (fpd11144dd.ap.nuro.jp. [209.17.68.221])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b5fa9ff713sm142070275ad.5.2026.04.21.10.13.35\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 21 Apr 2026 10:13:35 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776791617; cv=none;\n b=pOzky77EjI9PqNfEAR9oa3iBnojJpwb7L/XXZPbYw8eeFcklajXNpnv7ojnKsDT50k2NR/GPq/iqES6Bs5tLwPsYArelsfTysPkJGvOW1I2tX8dyPi10MOkIxNA8BCZNJbBS3zM3n6WzOhqqvWNp4rtTcQGE2U35GvpNWdZTGho=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776791617; c=relaxed/simple;\n\tbh=dNPqhdaCExXnqljjtmyEiK2FfGUZQrh5olPv++EE6Kw=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=otAn3o8Yp8qtnoDlu6HTxf+qCvVjgyr7+BGR+OEn6xFdVTt3L08Lse+qzLPPkyLfsoIkPqsfqV1eNNXcWBF4JxzEyFrqCDys2hqGFsxweTJZruZYwYCiHrQD4FDhI+Nq5rABqQrf4lxnj3H8118JEOwR3fUQ0g+3y5CIibxp6Hw=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=fail (p=none dis=none) header.from=linux.com;\n spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.214.171","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776791616; x=1777396416;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=NOptXCQFoecDGSEMq5oXbgb/TQScxdLgsFvp93S1GiI=;\n b=TyWuSlsKG7AdZ+/8igOxGVWZnNtZvxt279CZ+JPq3obl9jAmDdTb+Poo0uFNt119y5\n efkv61fu+p4Nhfdco2++d5/8q13lAZ4lOQB3fc6sm6mQuMJ1MDwRSQlHt6s5xKBpCr0Q\n IrqyXKdrwQhGgau+wyMzgJzqMi9mUP4zE+xnaQiIG46NoyIr+JKDqS3SXwmPUSp4Y4ec\n FUSXCwe4CkmxynqQHNyeiLgcU+O2sxxYg9jWidE0LP5fWBLcuPIOFJjE+zgygvTPZEbp\n FJ581VZpyesCCJdWFB3KPks1Mgat6moo8v68oDR17Td7dlzz7rcj6/lU/erAdTfMAz++\n h6MA==","X-Gm-Message-State":"AOJu0YyyHLQovnhjXfh5s3eo3MslHCTU4f+c4sWik4cfg+9SxmCFG/hp\n\tdybAWao4aPQRhQ0FzdOfF2BVgpmr2Y0+i7QexfidJXJF78bO5GwKSRif","X-Gm-Gg":"AeBDies1VxurIdbQehvB7osbtvMOodK3U8j86ltYUOCgPQ6I1BVZJOJdk6l9SbQ8Kdk\n\tKs9IJDkd7qPugv4xMxJRJmNi6z64VWhJr/L99gNcXnY0yD/SM9ckUEE3GWkkenBwHjvmuIoSWDn\n\twdVc1aRPfj43e+G6CWdV36+lnbC4wqUELaQPArjvNipa4fKu7ioHZgOX+tNINNs49+1asHQcjDp\n\tUD1C9AFevgtex5Yt8pc5k8B130DeYBxXSHbrdQu/PEO6zZIXQqTeDOFZAUpSlwM8jLkr9x89quO\n\t3esnigEYU/zbYxmQZBh3CPsuO0qQzHSWZZ9MKG5y/Rjp98ioul9k0KsSyjjP+t961zHoHtFmQLI\n\t4UnxPc025H5XfRjTolRorJxjHmhcs1ceq84WOlLsW0dfgyTB3bTkSM1Q2cwGLV395/DjVE83AhC\n\t8PxtLNa5mFDqQOVhPJfLvYHgDNNpuYHbFARsLhRwgwN04gX0kyLuxP9y6gL6CklbLFEM8ZLuTxu\n\tQ80t5MCA9QhMHb2ozjli5pJMdWGGYQQbuPphZmihi8dtpA+ER3NSoykMS6hZfJPfTJWD16lKkvj\n\tdFgFsRZvJLuf20dogdFUjhYcdY4YXUaGDidKyyEvrQ==","X-Received":"by 2002:a17:902:bf4a:b0:2b2:4e5c:69a9 with SMTP id\n d9443c01a7336-2b5f9e79fa8mr145008315ad.5.1776791616146;\n Tue, 21 Apr 2026 10:13:36 -0700 (PDT)","Date":"Wed, 22 Apr 2026 02:13:34 +0900","From":"Krzysztof =?utf-8?q?Wilczy=C5=84ski?= ","To":"Ramesh Errabolu ","Cc":"linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tlinux-s390@vger.kernel.org, Bjorn Helgaas ,\n\tLukas Wunner ,\n\tNiklas Schnelle ,\n\tPeter Oberparleiter ,\n\tMatthew Rosato ,\n\tGerd Bayer ,\n\tHeiko Carstens ,\n\tVasily Gorbik ,\n\tAlexander Gordeev ","Subject":"Re: [PATCH v2 1/1] PCI/hotplug: Add 'uevent' sysfs attribute to\n trigger slot events","Message-ID":"<20260421171334.GA1684602@rocinante>","References":"<20260416213909.705753-1-ramesh@linux.ibm.com>\n <20260416213909.705753-2-ramesh@linux.ibm.com>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260416213909.705753-2-ramesh@linux.ibm.com>"}},{"id":3680070,"web_url":"http://patchwork.ozlabs.org/comment/3680070/","msgid":"<305d85a8-660a-4063-9b47-5707d8b25fa2@linux.ibm.com>","list_archive_url":null,"date":"2026-04-21T21:38:43","subject":"Re: [PATCH v2 1/1] PCI/hotplug: Add 'uevent' sysfs attribute to\n trigger slot events","submitter":{"id":91783,"url":"http://patchwork.ozlabs.org/api/people/91783/","name":"Ramesh Errabolu","email":"ramesh@linux.ibm.com"},"content":"On 4/21/2026 12:13 PM, Krzysztof Wilczyński wrote:\n\n> Hello,\n>\n>> +static struct pci_slot_attribute hotplug_slot_attr_uevent = {\n>> +\t.attr = {.name = \"uevent\", .mode = S_IFREG | 0200},\n>> +\t.show = NULL,\n>> +\t.store = uevent_write_file\n>> +};\n> I think, you could use the __ATTR_WO() macro here.\nUse of the suggested macro is not appropriate\n>\n> Thank you!\n>\n> \tKrzysztof","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=V2RfIuf2;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-52885-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com\n header.b=\"V2RfIuf2\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=148.163.156.1","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linux.ibm.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0bQ65q19z1yGs\n\tfor ; Wed, 22 Apr 2026 07:41:02 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id D78C430866A7\n\tfor ; Tue, 21 Apr 2026 21:38:51 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 33BCA3DCD84;\n\tTue, 21 Apr 2026 21:38:51 +0000 (UTC)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n [148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 010352773F0;\n\tTue, 21 Apr 2026 21:38:49 +0000 (UTC)","from pps.filterd (m0356517.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63LImJ6S590754;\n\tTue, 21 Apr 2026 21:38:47 GMT","from ppma11.dal12v.mail.ibm.com\n (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dpeu20jg2-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tTue, 21 Apr 2026 21:38:46 +0000 (GMT)","from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1])\n\tby ppma11.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 63LLKRgl028602;\n\tTue, 21 Apr 2026 21:38:46 GMT","from smtprelay06.wdc07v.mail.ibm.com ([172.16.1.73])\n\tby ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 4dmpyy27gw-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tTue, 21 Apr 2026 21:38:46 +0000 (GMT)","from smtpav05.wdc07v.mail.ibm.com (smtpav05.wdc07v.mail.ibm.com\n [10.39.53.232])\n\tby smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63LLcikw18875062\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tTue, 21 Apr 2026 21:38:44 GMT","from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 8C3F958053;\n\tTue, 21 Apr 2026 21:38:44 +0000 (GMT)","from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id B34F358043;\n\tTue, 21 Apr 2026 21:38:43 +0000 (GMT)","from [9.61.249.207] (unknown [9.61.249.207])\n\tby smtpav05.wdc07v.mail.ibm.com (Postfix) with ESMTP;\n\tTue, 21 Apr 2026 21:38:43 +0000 (GMT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776807531; cv=none;\n b=VhuA+F9JOu6SCuEMthj1r9ITEh3qrxh9Gd4iE79AMeSPQfgRW1C1L5WAbwe6N1sN+uOtQhB0A3URrqdMEUa7DeRm87nTEKSwbzmCkiR6VLzyxecaDPMzGMqfmD26uIGB15A7QmcvQbDk5Ot7hrrNN4O4kyyCGs+lvCvv9DmkMLE=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776807531; c=relaxed/simple;\n\tbh=CcnIhNX1Ct+b8gr30wn4e1tvYOD7yALVZlMLTbe45WI=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=NbjhwsnyixVBAkbeJS/rhq1zAg9VRjIs+1ooDJTC0Y8OJdT168ghbwrN/pJZC6AY3ZGDqbCN5YOMb2eQXX+qUKgMMGYQqUhsKd0Cxxm0AdMrpFhro+BWMa6prrpWbYhDarBaNClUup584SMzWy4IGkdA74HjgHaVCH9nXhHffjk=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com;\n spf=pass smtp.mailfrom=linux.ibm.com;\n dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com\n header.b=V2RfIuf2; arc=none smtp.client-ip=148.163.156.1","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n\t:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:reply-to:subject:to; s=pp1;\n\t bh=JUf5xe32ftQAeXDeJ8yyX8svTFp1E8fbIyIRFi3qqwg=; b=V2RfIuf2OTVd\n\tuZ04Bz99InlFj3o3lfgGDsv7Vu40uVn84qgNhhK2gqAXfYzcZB4EeMPaxjRVil/k\n\twubxGCIk7DZptleat9lPnzogDmWUlnMFLStJ3EfL9UxwdYZ7qTSMgrVD6n36IiIi\n\tIMr8pzczORoW66R8+6ZoaYDc6wTQV8s8Mj+td71kUJNE9HOVVLCWy4mTq4awf2HW\n\tIpo94ogE0EqhquaC9ZR1hYpcSouB3r+t/jl+IsMeNdiympChIERTJ3pV2dMTw2mK\n\t8O9dsxB9KlanudR+rCzum4iPipMdgLXmL3fiiW72sqW1PSJy/NPUd5g2IzsqdvKS\n\tOqoicaJgCA==","Message-ID":"<305d85a8-660a-4063-9b47-5707d8b25fa2@linux.ibm.com>","Date":"Tue, 21 Apr 2026 16:38:43 -0500","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Reply-To":"ramesh@linux.ibm.com","Subject":"Re: [PATCH v2 1/1] PCI/hotplug: Add 'uevent' sysfs attribute to\n trigger slot events","To":"=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= ","Cc":"linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,\n linux-s390@vger.kernel.org, Bjorn Helgaas ,\n Lukas Wunner ,\n Niklas Schnelle ,\n Peter Oberparleiter ,\n Matthew Rosato ,\n Gerd Bayer , Heiko Carstens ,\n Vasily Gorbik ,\n Alexander Gordeev ","References":"<20260416213909.705753-1-ramesh@linux.ibm.com>\n <20260416213909.705753-2-ramesh@linux.ibm.com>\n <20260421171334.GA1684602@rocinante>","Content-Language":"en-US","From":"Ramesh Errabolu ","In-Reply-To":"<20260421171334.GA1684602@rocinante>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Proofpoint-Reinject":"loops=2 maxloops=12","X-Proofpoint-GUID":"kjO1FGRRJEH0Owfen7rjb3pT3iW8W1BI","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDIxMDIxMiBTYWx0ZWRfX1voHI0bWLjYr\n a3Gosp13w6l+/COI4ELRiopckOqN9o5AD2M1o5venYBKOi2xpRL4f7N2yDKB8OBCqUsgt2pvMn0\n QYi26ID5OTnF6DPbW8Ya/bEn0OfwDGa/0XaloAP5v684ofjAnCcHUdAcgb4mTNsUk4NW13vMy/J\n SXzZSTocsZH7WWtuGtecTjZUpwziyKMT/DFKunlovJw9H/MJnhvqe5KQbW30O729HigE/BzbqpE\n AINPhFk6fU8Ji2Jp1ehx6eH2su4jqvPKPKFEv09A8FD1cstceN5L7vvYher/wZwijyBNKmaBcoK\n mIbS4enTf2QEiVu1bwH/xLtB4rEXlVjW8zFIVA/koEOT7p324B6udodtwhuNV8W++9OvrD3zU5o\n bpuE+DyuayetUd6DX14m/v4j/WIJHlUaclV86ACH/Q2EMrdUuuSJctHH3Ds9aXJLG1iMlfGXH6M\n Rm7WisXx6QtMXWPxnJA==","X-Authority-Analysis":"v=2.4 cv=C8LZDwP+ c=1 sm=1 tr=0 ts=69e7ee67 cx=c_pps\n a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=U7nrCbtTmkRpXpFmAIza:22 a=Xe8eY8ZVJCK048dyR0cA:9\n a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10","X-Proofpoint-ORIG-GUID":"-KZ-uPc59IxeIQQ4dM2P-GSfloP3vUUj","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-21_03,2026-04-21_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n adultscore=0 suspectscore=0 priorityscore=1501 malwarescore=0\n lowpriorityscore=0 clxscore=1011 bulkscore=0 impostorscore=0 spamscore=0\n phishscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000\n definitions=main-2604210212"}},{"id":3680219,"web_url":"http://patchwork.ozlabs.org/comment/3680219/","msgid":"<20260422044450.GA2544787@rocinante>","list_archive_url":null,"date":"2026-04-22T04:44:50","subject":"Re: [PATCH v2 1/1] PCI/hotplug: Add 'uevent' sysfs attribute to\n trigger slot events","submitter":{"id":77280,"url":"http://patchwork.ozlabs.org/api/people/77280/","name":"Krzysztof Wilczyński","email":"kw@linux.com"},"content":"Hello,\n\n> > > +static struct pci_slot_attribute hotplug_slot_attr_uevent = {\n> > > +\t.attr = {.name = \"uevent\", .mode = S_IFREG | 0200},\n> > > +\t.show = NULL,\n> > > +\t.store = uevent_write_file\n> > > +};\n> > I think, you could use the __ATTR_WO() macro here.\n> Use of the suggested macro is not appropriate\n\nJust to expand on the \"not appropriate\" bit here.\n\nNot wanting to change the name to have the _store suffix would be fine.\n\nThe __ATTR() would work here. But, this file is old and wanting to\nkeep the style aligned with rest of it would be fine, too.\n\nSo, both of these reasons would be fine, to avoid using any new macro.\n\nThank you!\n\n\tKrzysztof","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-52914-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.210.179","smtp.subspace.kernel.org;\n dmarc=fail (p=none dis=none) header.from=linux.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0mqD5YYMz1yGs\n\tfor ; Wed, 22 Apr 2026 14:44:56 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 347C8301D31A\n\tfor ; Wed, 22 Apr 2026 04:44:55 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 4FA6128D830;\n\tWed, 22 Apr 2026 04:44:54 +0000 (UTC)","from mail-pf1-f179.google.com (mail-pf1-f179.google.com\n [209.85.210.179])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 1350414AD0D\n\tfor ; Wed, 22 Apr 2026 04:44:52 +0000 (UTC)","by mail-pf1-f179.google.com with SMTP id\n d2e1a72fcca58-82faf871346so2461211b3a.0\n for ; Tue, 21 Apr 2026 21:44:52 -0700 (PDT)","from localhost (fpd11144dd.ap.nuro.jp. [209.17.68.221])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-82f8e9d2f9asm16487176b3a.19.2026.04.21.21.44.51\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 21 Apr 2026 21:44:51 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776833094; cv=none;\n b=eKmCP48TWKUdYM1LzI2uhiDvCHjAtLSBL9fNZJat/YVhKvrP/2RhHr6pN7GHUwyqV676DSXwHlUy0a8G3zaGoSC0EOs/wwG89yU2+gID4QXbE/d+sN62hxtflhId+3+8wCA2IN9DwCYcPZ5TGJAHQVmJGc7rrlKiEvMaVDT4XRo=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776833094; c=relaxed/simple;\n\tbh=oOwDGIKkQYinZ6cEzj7x1hi+TEyEe7g2fiXeqCNMaws=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=bLXaUHsqksgpvT48Lvi5hP2/4pNf+ohd7PFmQBhCSe+3IgH/tUS4PwMNHBvQgFBV7zetVm/+pXYyZGxu/3Ma93ZZRsbaAA71owzCfWDBrstC/G+XevkSIt6M9jhJ4+kALbrgGnBAxHUDfkZXhCknujUnTxYFjCo0QipNnAasANk=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=fail (p=none dis=none) header.from=linux.com;\n spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.210.179","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776833092; x=1777437892;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=XhIDpGgSMmQPWhVlMLk1NWm+UmS94pEyHKaTl2QDpX0=;\n b=Dvd5gBuPClPHsAUPjBrwwOUYTKupgZe3o+FkQHUO2sXVWkPXCye8+UD5hJLS5fxQbp\n VoT0kJr1P6GMo7K3TU6uTVlTM4W1X5+lVo6/MbIk7xGTyMy4WTvGY/ew35pz7cOQ3Ho3\n oCNyMscKNxTmQGywEBTbsPdZoWm21mp4+uuFxuFW14vhnw3erO2JUVnV0DejYQ093ObI\n 22dL0yKGLja14vUYmqfntAj3fdx5k1U2lJ+c9O7n5ARILyxhHvI00JYVjQv2hsP1Pb5N\n fnfA8gMVePCJA6pgcxtMDS5J2xcmCgBlbJEvMNs9Z+iCzVlbQl9Zrp+NxqpJQMCbF9my\n 7Olw==","X-Gm-Message-State":"AOJu0Yz0DarSHCI4zadm9JtZxBuskjf9ai/IX8cSwESL/Y+ClZt24UMe\n\tflfw4VxOM/s+Lc47cwqvS7/X9kyibxKbwxCAf/HQr+k9UBknKL5xAw8k","X-Gm-Gg":"AeBDievFxxy6dkd0EoRzGUJYJDUcwW17v0h85Kvn68m3dDqucmHqqrICVh6niAyWC9J\n\txrlXXVJrNM21By9ViC2ZAB+n3OYi5EMP5WeqvJPqBbKEZqEqFqQjqzfjpG4MXnX/OXY2P4uqYis\n\t4DEP2Qo80khKsMUahLJVsbYVYD8DLZf2cBSqziCBTQKnqSH68P9VJXdySKE28ATzcOLjLgEmTb+\n\tBjCY2eDab5kjTZtimmTTGb7bwy4L83a3kAtcFMLxSCaJmWEpwKf+HWQkuXwLw83ek81b81hfLno\n\tBDQW6tsv2xo6XsGBz4d4ckTuhjIMTrfuPFXMCn+/lwZG/UE4APm556nhr4VWhyU0iyLAGxchBSr\n\twnyJvwqubpPvP7GZzMT/r5aiLz20Kiv+/5GVFXNCSV0q5Ob+wU4MMXpPQ03hN364+EtEqCccxDb\n\trx+xwRxC15Pft31N13zbOdElML0DoZfOdgmWRjgRKiste4ZogtnqNOKjErqOmPCz8fwPmsfO5Zq\n\t8rLRHEpd5EL5GOQztnKo21Pm4tb6tBMB6g2RtiovKA7SRvXpcGSNyMFpEnpmi3y4bIruTCpCPq7\n\trdFIi8tMovl/Ievv6oFq9QTnyVO4wy/q873Gzc3apw==","X-Received":"by 2002:a05:6a00:17a0:b0:82c:e0d7:2682 with SMTP id\n d2e1a72fcca58-82f8c8c8c5cmr22933258b3a.25.1776833092489;\n Tue, 21 Apr 2026 21:44:52 -0700 (PDT)","Date":"Wed, 22 Apr 2026 13:44:50 +0900","From":"Krzysztof =?utf-8?q?Wilczy=C5=84ski?= ","To":"Ramesh Errabolu ","Cc":"linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tlinux-s390@vger.kernel.org, Bjorn Helgaas ,\n\tLukas Wunner ,\n\tNiklas Schnelle ,\n\tPeter Oberparleiter ,\n\tMatthew Rosato ,\n\tGerd Bayer ,\n\tHeiko Carstens ,\n\tVasily Gorbik ,\n\tAlexander Gordeev ","Subject":"Re: [PATCH v2 1/1] PCI/hotplug: Add 'uevent' sysfs attribute to\n trigger slot events","Message-ID":"<20260422044450.GA2544787@rocinante>","References":"<20260416213909.705753-1-ramesh@linux.ibm.com>\n <20260416213909.705753-2-ramesh@linux.ibm.com>\n <20260421171334.GA1684602@rocinante>\n <305d85a8-660a-4063-9b47-5707d8b25fa2@linux.ibm.com>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<305d85a8-660a-4063-9b47-5707d8b25fa2@linux.ibm.com>"}},{"id":3680720,"web_url":"http://patchwork.ozlabs.org/comment/3680720/","msgid":"<20260422171312.GA410657@rocinante>","list_archive_url":null,"date":"2026-04-22T17:13:12","subject":"Re: [PATCH v2 1/1] PCI/hotplug: Add 'uevent' sysfs attribute to\n trigger slot events","submitter":{"id":77280,"url":"http://patchwork.ozlabs.org/api/people/77280/","name":"Krzysztof Wilczyński","email":"kw@linux.com"},"content":"Hello,\n\n> > > > > +static struct pci_slot_attribute hotplug_slot_attr_uevent = {\n> > > > > +\t.attr = {.name = \"uevent\", .mode = S_IFREG | 0200},\n> > > > > +\t.show = NULL,\n> > > > > +\t.store = uevent_write_file\n> > > > > +};\n> > > > I think, you could use the __ATTR_WO() macro here.\n> > > Use of the suggested macro is not appropriate\n> > Just to expand on the \"not appropriate\" bit here.\n> > \n> > Not wanting to change the name to have the _store suffix would be fine.\n> > \n> > The __ATTR() would work here. But, this file is old and wanting to\n> > keep the style aligned with rest of it would be fine, too.\n> > \n> > So, both of these reasons would be fine, to avoid using any new macro.\n[...]\n> \n> Hello Krzysztof, let me first apologize to you in the way I said it. I\n> should have elaborated the reasoning the way you did. I am open to making\n> the changing if anyone else feels it is a better way.\n\nOh, no worries. No hard feelings. :)\n\nI just wanted to add a little bit more details for posterity. \n\nThank you!\n\n\tKrzysztof","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-53013-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.216.45","smtp.subspace.kernel.org;\n dmarc=fail (p=none dis=none) header.from=linux.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g15T54BsGz1yGs\n\tfor ; Thu, 23 Apr 2026 03:15:21 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id A950930480A9\n\tfor ; Wed, 22 Apr 2026 17:13:16 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 16B042E62A9;\n\tWed, 22 Apr 2026 17:13:16 +0000 (UTC)","from mail-pj1-f45.google.com (mail-pj1-f45.google.com\n [209.85.216.45])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id D5FAD233722\n\tfor ; Wed, 22 Apr 2026 17:13:14 +0000 (UTC)","by mail-pj1-f45.google.com with SMTP id\n 98e67ed59e1d1-35d99bae2ebso5217593a91.3\n for ; Wed, 22 Apr 2026 10:13:14 -0700 (PDT)","from localhost (fpd11144dd.ap.nuro.jp. [209.17.68.221])\n by smtp.gmail.com with ESMTPSA id\n 41be03b00d2f7-c797704b575sm13710354a12.29.2026.04.22.10.13.13\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 22 Apr 2026 10:13:13 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776877996; cv=none;\n b=IWThamJc1AjKFj/snihLBLvuahgU1KsDtNaaIF7MiYnneT0emFmeYE/sflaTcPKSZEfdM/LvN014tL05u/l8IcUQcr4xmzfqVfLTTYxLR5j2hxMf90/7MZEPWM2uSznmWVMn7+5uhEW9pWJlCbscxMvHzYNFENDJilSRMGjtgz8=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776877996; c=relaxed/simple;\n\tbh=52ACKqtJPNU8J7IzyA8jZwWgrUe0P6rodTQxUqKSM14=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=Of0Q5SLwA/gIqijjlsqG6DjAntsNt8EpafG8EsFUseWy80JHu5sI5awBWyPN6bF5a4waj33cCNnePETeJS00bYZX8gfjFHRYynDA4GlUsE2kasBoS6Yqs/xI2g/tCwHpvEQvNykQUTfNGsVlYHkSx15lTkUnfodvJc9bJnQb0iI=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=fail (p=none dis=none) header.from=linux.com;\n spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.216.45","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776877994; x=1777482794;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=Y7OLq8sGj5BrTnHpABdVqreRTaKZmGbdWyjjPj4eOAQ=;\n b=M6sfp75exEvNgbr3iMgTRN2THYiTLToY73hDUFboqTyY5cmYdvtiAdIvaVUHoi1hpl\n BynwROmBDoFuZ91ZWppBTYWs90uNuHqwFhko+bcmn1v1f2giaX2KijUnkvP5zruW5Wtv\n y9Sqd8zNDkXPg83lObWre+d1LILhVKEj/vy54FYZt2PmWXjr2hj806TvDTYktJYzJ8yR\n fqLQRxqmt6Tf2I5jSPdZZYOvEZP8DVTrXaSisAr0y5Y40JJiCuVVrWfQq4W2CxymDrh5\n JsCBiNI11McxKxqmk9dLIHWMm0vPsA0xVtbS53nsSdE2ZdqAUq2w8IP+MxX6nOtWww5Y\n rPJA==","X-Gm-Message-State":"AOJu0YzH/+RydTembGEjT9vNdCeFThKI59jYKPvP30Bia4Tdnw39mEZz\n\tjC4DGlMY/8WBR95N6UtMDb2CIsHOk2PEXOiN/9jg6FKdwenj3tIWm2zV","X-Gm-Gg":"AeBDiesnGFlW8QxzyD6feVgkM+69FhLYHCUrINFJyQKhJ6ICiHupHPsgNDQz1ubgGl7\n\tovx3lZ7NOjSQY6C/YCz8/eg5hmo87eWE32hV+CPbAExo5QqytxdbPfCRDhW+p5hI64K91jKnJdT\n\tyuGqF0Y7gSeoFbLzKnzCRXmJQY37j4Qows5+ddghp9tXSVs0dRZ5LrzPw1AmGwIGTD05D9IvrVP\n\tkxzazwDH+gUlf+PHsq4gBA4Unbl+nemq+DMaFHwX3ngU9t4vd2YqrvCY8ej5GlrtfbqHqk95XW1\n\trEDlMsh6l8E0QvmNdSuasGEPXeFa1aYc1P5WhWJsKs3iHAGk+/Ve8X63T+bUaNhiq8kJxFIj3B4\n\tYhLFvsaL8c95JErCZBXuAwxlcTdbDPoTrB70g4+iFPb3F28ZvGFXfgO3mOQfPPn0uvqMRbaA/95\n\tmSaPmr6V+Tno30OtC3E7cngva3RnckmBJOwy7uvmPofiAaF9PkV735Edj077KY3yHPoRWPl5uE5\n\tMSvc6c/1KYJh6SjutjQeooO43tAYl2NSpjCK4gsLqZ/3effMtc0uhRfI4TI2j8lDBmU7CaXDxMH\n\tsV+yaQqzgvFTiayLObhS52fxJ8aE+PXq/avKcVxSyQ==","X-Received":"by 2002:a17:90b:5185:b0:35f:b7f5:9b3 with SMTP id\n 98e67ed59e1d1-361403b18c9mr24815197a91.3.1776877994335;\n Wed, 22 Apr 2026 10:13:14 -0700 (PDT)","Date":"Thu, 23 Apr 2026 02:13:12 +0900","From":"Krzysztof =?utf-8?q?Wilczy=C5=84ski?= ","To":"Ramesh Errabolu ","Cc":"linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tlinux-s390@vger.kernel.org, Bjorn Helgaas ,\n\tLukas Wunner ,\n\tNiklas Schnelle ,\n\tPeter Oberparleiter ,\n\tMatthew Rosato ,\n\tGerd Bayer ,\n\tHeiko Carstens ,\n\tVasily Gorbik ,\n\tAlexander Gordeev ","Subject":"Re: [PATCH v2 1/1] PCI/hotplug: Add 'uevent' sysfs attribute to\n trigger slot events","Message-ID":"<20260422171312.GA410657@rocinante>","References":"<20260416213909.705753-1-ramesh@linux.ibm.com>\n <20260416213909.705753-2-ramesh@linux.ibm.com>\n <20260421171334.GA1684602@rocinante>\n <305d85a8-660a-4063-9b47-5707d8b25fa2@linux.ibm.com>\n <20260422044450.GA2544787@rocinante>\n <742b8820-4bfe-40ef-85a9-5704af038ee1@linux.ibm.com>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<742b8820-4bfe-40ef-85a9-5704af038ee1@linux.ibm.com>"}}]