[{"id":3678425,"web_url":"http://patchwork.ozlabs.org/comment/3678425/","msgid":"<223c45a0-1fcb-4976-aa3a-89b8127d04e9@linaro.org>","list_archive_url":null,"date":"2026-04-16T23:04:57","subject":"Re: [PATCH v4 2/4] target/mips: Remove unnecessary target_ulong uses\n in LD/ST Multiple","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/17/26 07:05, Philippe Mathieu-Daudé wrote:\n> @do_r31 is a boolean, @base_reglist a size (size_t) and @i an\n> unsigned index.\n> \n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> target/mips/tcg/ldst_helper.c | 32 ++++++++++++--------------------\n> 1 file changed, 12 insertions(+), 20 deletions(-)\n> \n> diff --git a/target/mips/tcg/ldst_helper.c b/target/mips/tcg/ldst_helper.c\n> index 7be2cad89d6..fdc192e9c14 100644\n> --- a/target/mips/tcg/ldst_helper.c\n> +++ b/target/mips/tcg/ldst_helper.c\n> @@ -228,13 +228,11 @@ void helper_lwm(CPUMIPSState *env, target_ulong addr, target_ulong reglist,\n> {\n> MemOpIdx oi = memop_idx;\n> unsigned mem_idx = get_mmuidx(oi);\n> - target_ulong base_reglist = reglist & 0xf;\n> - target_ulong do_r31 = reglist & 0x10;\n> + size_t base_reglist = reglist & 0xf;\n\nWhy size_t, for what is clearly a 4-bit quantity...\n\n> + bool do_r31 = reglist & 0x10;\n> \n> if (base_reglist > 0 && base_reglist <= ARRAY_SIZE(multiple_regs)) {\n> - target_ulong i;\n> -\n> - for (i = 0; i < base_reglist; i++) {\n> + for (unsigned i = 0; i < base_reglist; i++) {\n\n... which you later compare with plain 'unsigned'?\n\nUsing 'unsigned' everywhere is fine.\n\n\n> @@ -252,13 +250,11 @@ void helper_swm(CPUMIPSState *env, target_ulong addr, target_ulong reglist,\n> {\n> MemOpIdx oi = memop_idx;\n> unsigned mem_idx = get_mmuidx(oi);\n> - target_ulong base_reglist = reglist & 0xf;\n> - target_ulong do_r31 = reglist & 0x10;\n> + size_t base_reglist = reglist & 0xf;\n> + bool do_r31 = !!(reglist & 0x10);\n\nYou don't need the \"!!\". That's implied in the assignment to bool.\n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=IuR1goEa;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxYXD70jjz1yCv\n\tfor ; Fri, 17 Apr 2026 09:05:47 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDVlw-0007IN-1r; Thu, 16 Apr 2026 19:05:20 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDVlo-0007Ey-1I\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 19:05:12 -0400","from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wDVlm-0005O8-7V\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 19:05:11 -0400","by mail-pj1-x1033.google.com with SMTP id\n 98e67ed59e1d1-35d95017a68so64075a91.3\n for ; Thu, 16 Apr 2026 16:05:09 -0700 (PDT)","from ?IPV6:2401:d002:dc0f:2100:a60a:7c34:dd75:e66c?\n (bg30dj02y68bx09myf73.ip6.superloop.au.\n [2401:d002:dc0f:2100:a60a:7c34:dd75:e66c])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-36140fe07c7sm10988a91.5.2026.04.16.16.05.05\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 16 Apr 2026 16:05:07 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776380708; x=1776985508; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=S+6veR2pGHlHj7K/mhDttRxbVu6/5iF4oun6Ke7K+qA=;\n b=IuR1goEanX5HWcdbRhYEeO3SE5vVP31BpFh3l0IWoTJIw20FL4WmrvghJ3uLzl6OqC\n I5AAjvuAlcDYiqKTR1ojT6poM1pN1vWiY59te3vW1cafViavibVnGWyAWPjZEL0IShmR\n KR2t7tcEdV/j4xc2iuTviuDLfOJAHGburKq8MNtgXqU5R7bFa1F3/bd1aLw150C3PBpT\n IOw6+zuOqdbbTHpKz+lWHYtcKI3/5u9gZ7Bqkysr/AGms16iTHGhccfYgNdZbbWcAgUn\n dyY10Otr1nkV5uyhfv/DwoQGOZ0xtTb/o5O8kV2w8hcirNBVDs9RmaTrifynuyGg1GjH\n FIIQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776380708; x=1776985508;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=S+6veR2pGHlHj7K/mhDttRxbVu6/5iF4oun6Ke7K+qA=;\n b=FArPqqiXHcLO3iK2T9QJ/OjbtrtcD5D+cN5Y6AQLJI6UOQGX0fgTxmg4TpXlVT2os0\n e2wPkODZu+VQurIiA31LN1/h7CkpidCVrwrDzXmWw41BThwJVlKFtn+Xug/tdpSlKtof\n ewWOJcU0ifxTotLyWs3WWZd+9tqEaKWXNVdcFKmSGWNdTJXx5fRNyGmqmmMP4P5hyNZI\n H3Y8WWx7iK0V06Jx7FdqVx9rzL7rP0EZEbkkb2ZaG5PTCACXwhfMsUSvF48CR2z9nh25\n dCg2bU05IVZBExlizw57XFuBhQLKnCy0XkRJtIl7DXykqWIdMREa/fqmUYmb+vFrPrLL\n bRTA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8UpjMc3WXRlto7A8WexOF2dz81u5uvsyrNhFAZzSiyw/CYlOQLI5Z3gCtZZlNcj7JNwgs6yoxu04BY@nongnu.org","X-Gm-Message-State":"AOJu0Yw9lt59dH7pSgI0I8yT6mHfp4tEpUwfvZQ/yB3kbaIa8ohvIdYI\n GZ1G/W7TtNwvLFkecT3SwOLDfDvmLkjW9BPDVMT+4xZbExh+pYx6rrvYsEsPaVda0Nc=","X-Gm-Gg":"AeBDiesDiV2hn/6waTZ75kUnZ9o3QXkxxsoFUUP6vBL42gksX+6lyACFOSKXr0MPj4g\n nr7Y0GW4LMyD7pVxnuqvwZqe+P0wHVOV0gLMicuRG47B5N1rQGoUOhVxrtdG9PkZL00ArcQDkJP\n Ad5bbQzmxOxjxqeTzJIPaAu7LB/OM3dkv2fmJBD+lDfX6ks9QIgSImczyPPxzPclgnVj5GrHpX4\n cjSSKYFFX+hLq0AaBr/NPPhLMrwpBVb0oaqMMkWODlTdsR672Oe1nxhpskJlrIUA9Om/cOmtFjA\n P6Rzn8Mlzk5fNr+KaNTyA+tYnFVdiG5waKJvzSsFdWOOnf8rXnBxzyz4S3r/S5JO1Amm3wuMJZS\n xZ9gTY4aVQDfZpdeCFxiiWgeyZFwruQr76Uih8rX6cv4BWkpUeVMA5/ddv7QjKDU6zlzJ6HJUq5\n xCwC29U+pFs700bOcz6/jBEXNN8NAQbzI6jplSBXdI1loCp1qfgH7q+N7KgbZF4Qw7rxRdmLcVI\n yIsHZWgu6HRjQa88xKR6wbBIpCrsJPodH9pVXEReH3R9UPErybR+WKJVVrhb6Rrng==","X-Received":"by 2002:a17:90a:da8c:b0:35e:581c:6bca with SMTP id\n 98e67ed59e1d1-361403ca597mr324739a91.3.1776380708156;\n Thu, 16 Apr 2026 16:05:08 -0700 (PDT)","Message-ID":"<223c45a0-1fcb-4976-aa3a-89b8127d04e9@linaro.org>","Date":"Fri, 17 Apr 2026 09:04:57 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v4 2/4] target/mips: Remove unnecessary target_ulong uses\n in LD/ST Multiple","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","Cc":"Jiaxun Yang ,\n Aurelien Jarno , Aleksandar Rikalo ","References":"<20260416210508.30686-1-philmd@linaro.org>\n <20260416210508.30686-3-philmd@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260416210508.30686-3-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::1033;\n envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1033.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]