[{"id":3678385,"web_url":"http://patchwork.ozlabs.org/comment/3678385/","msgid":"<3fb10483-4474-4cfa-8e41-081d82a05158@linaro.org>","list_archive_url":null,"date":"2026-04-16T21:12:16","subject":"Re: [PATCH v5 2/9] hw/hexagon: Add global register tracing","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 16/4/26 23:02, Brian Cain wrote:\n> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n> Signed-off-by: Brian Cain <brian.cain@oss.qualcomm.com>\n> ---\n>   meson.build                    |  1 +\n>   hw/hexagon/trace.h             |  2 +\n>   hw/hexagon/hexagon_globalreg.c | 73 ++++++++++++++++++++++++++++++++++\n>   hw/hexagon/trace-events        |  3 ++\n>   4 files changed, 79 insertions(+)\n>   create mode 100644 hw/hexagon/trace.h\n>   create mode 100644 hw/hexagon/trace-events\n\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=QvEfFjLt;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxW1l6BrCz1yGt\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 17 Apr 2026 07:12:42 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wDU0f-0006Pn-Qd; Thu, 16 Apr 2026 17:12:26 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wDU0a-0006Ow-Gr\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 17:12:22 -0400","from mail-wm1-x334.google.com ([2a00:1450:4864:20::334])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wDU0Z-0003vx-1w\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 17:12:20 -0400","by mail-wm1-x334.google.com with SMTP id\n 5b1f17b1804b1-483487335c2so92708295e9.2\n for <qemu-devel@nongnu.org>; Thu, 16 Apr 2026 14:12:18 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43ead401ca0sm14626190f8f.36.2026.04.16.14.12.16\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 16 Apr 2026 14:12:16 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776373937; x=1776978737; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=3QevSFvKa0pcJKxRM3Y84I0qN7jGsotXoEvBJ7Whqag=;\n b=QvEfFjLtLFiMFbza1hKDL7LCQ2RS3bcnUv+IKDgO9kX8bric9sP2HaSFdJlKMCY6xY\n MS9t3Ckjq1c/rk+0zi+AE87EfFd/6nQYrGUBqllCLfbhmaR8/WtE4SWO0gYyshG59gpQ\n B0XAcSPwn0gdY2dZUu89H8A8FTTIi400BMojVnD/2tEDDuxZYtX8CgOUMD8gg3q5/XED\n 5R1GfczebacmBe/57hGYAMvt2FMXLax7M1G4S7KawV/9W8mKbRK7hYvqMnD2cQmEynRO\n pcJmdWV2jNtkKoNMpTviqcaYbkXhYMraRVxBEPS8vhjgiYxzVHPyIV1MQwEYB1vnZxTA\n 8JRA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776373937; x=1776978737;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=3QevSFvKa0pcJKxRM3Y84I0qN7jGsotXoEvBJ7Whqag=;\n b=guGtvjwG60NETU7E89njcU7yHaVksojDVBlH7NQOECUxL7OXNNKIvebHanBK3v1/zb\n fvrAHRsNTdyyyeZR1b61CP48yOlVu4OU7TfAY5VFh6NxW/6qSic2s2qNnAGI+OB7Kq/R\n KO0cVGIrNAoMyb5HpOrmCHOKUSFwlqQ1PMnu16UtYrWsXCihYXn7u4MgUluiG+AoOmIB\n ucwIY+jvJdGDON5fONYEEHrCoBtETW+s0VI5WvChqtdtfdCrqvPYQCJTKk3BvmtZqoNC\n wwvKWpGS14oqVcTN8olfAJCnR/C9H8uuN0VXGDimQv8kdDVSB8z2omkWpocDYxyloERn\n LX1g==","X-Forwarded-Encrypted":"i=1;\n AFNElJ88ZiYtn41j/qZSzyZbnHDgaX1Tc2aI28sI+1wzkt6Q6eyXGwDnCmaHrJDAbEe/o1kv5uDJjKkUrB7B@nongnu.org","X-Gm-Message-State":"AOJu0Yy2DIBWAHeVWHYX9GHK8PEm0rKFniaN8w86fGhyGor5BCWlw6T2\n g5MT/2NX4c1UWopjHdlVpf47Du8EKoKcRTA3taethB+Zj0pt4TON+9+NTbvFXBMmdXc=","X-Gm-Gg":"AeBDiet3Vvdkyqdd4qK1EGg6m7jbt3Y/i3vurPzH/56J13jG7P6JBOqZZFpuwh8Nbm0\n RrN2cZlsThf2K/P9/k4bpD1g7yxqgf29YekR1SSP41FBWyqegaYZEfEhHOoPQkECxmeoqZtyidd\n hyvDxctZveeY4cfBW6Jm5cOkuwRFEpSEby/bpSmG8qfKS27Z0A92Zf6e7zQ0MCX1Lf2IdOEpAT6\n 8Bna+DLCz/utjE8xOSrGz/0nK3TCMNsM4jrcZM4UnNA/goGGnrGH3aXNXJ59JsSpwmlWZF9JRiK\n dXoRlgNZ0O0Ovo5eJTnR2DnDhTJQlhynYqOPTsKVSblVBXzyw7vBdEUzkF2M9TI67pvmgVjcTcp\n gdRJiRkqSZjDFben+vnrjgaueX+r1se2umkK11wTONMXl7Ci1xNIra7Lm0uBjPyCUnphSlYtZ+3\n DyHucGUbJtl5xhVDgW7lbBStMM5bfhUQQthuVZKIhKesHv/hxDYT1llFMREV3pSWtrgB6pEkOm5\n Yna","X-Received":"by 2002:a05:600c:4f0e:b0:488:945a:ed63 with SMTP id\n 5b1f17b1804b1-488fb6e8491mr3900245e9.0.1776373937514;\n Thu, 16 Apr 2026 14:12:17 -0700 (PDT)","Message-ID":"<3fb10483-4474-4cfa-8e41-081d82a05158@linaro.org>","Date":"Thu, 16 Apr 2026 23:12:16 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v5 2/9] hw/hexagon: Add global register tracing","Content-Language":"en-US","To":"Brian Cain <brian.cain@oss.qualcomm.com>, qemu-devel@nongnu.org","Cc":"ltaylorsimpson@gmail.com, matheus.bernardino@oss.qualcomm.com,\n marco.liebel@oss.qualcomm.com, quic_mburton@quicinc.com,\n sid.manning@oss.qualcomm.com, ale@rev.ng, anjo@rev.ng,\n pierrick.bouvier@oss.qualcomm.com, Paolo Bonzini <pbonzini@redhat.com>,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n\t=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>","References":"<20260416210305.2255579-1-brian.cain@oss.qualcomm.com>\n <20260416210305.2255579-3-brian.cain@oss.qualcomm.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>","In-Reply-To":"<20260416210305.2255579-3-brian.cain@oss.qualcomm.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::334;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]