[{"id":3679479,"web_url":"http://patchwork.ozlabs.org/comment/3679479/","msgid":"<4e02874b-214b-406f-97b2-af7b78368a7e@oss.qualcomm.com>","list_archive_url":null,"date":"2026-04-20T16:57:58","subject":"Re: [PATCH v5 3/9] hw/hexagon: Add machine configs for sysemu","submitter":{"id":93152,"url":"http://patchwork.ozlabs.org/api/people/93152/","name":"Pierrick Bouvier","email":"pierrick.bouvier@oss.qualcomm.com"},"content":"On 4/16/2026 2:02 PM, Brian Cain wrote:\n> From: Brian Cain <bcain@quicinc.com>\n> \n> Some header includes are modified here: these are uniquely required for\n> basic system emulation functionality and had not been required for linux-user.\n> \n> Acked-by: Markus Armbruster <armbru@redhat.com>\n> Co-authored-by: Mike Lambert <mlambert@quicinc.com>\n> Co-authored-by: Sid Manning <sidneym@quicinc.com>\n> Signed-off-by: Brian Cain <brian.cain@oss.qualcomm.com>\n> ---\n>   MAINTAINERS                            |   2 +\n>   include/hw/hexagon/hexagon.h           | 150 +++++++++++++++++++++++\n>   hw/hexagon/machine_cfg_v66g_1024.h.inc |  64 ++++++++++\n>   hw/hexagon/hexagon_dsp.c               | 161 +++++++++++++++++++++++++\n>   system/qdev-monitor.c                  |   2 +-\n>   target/hexagon/translate.c             |   1 +\n>   hw/Kconfig                             |   1 +\n>   hw/hexagon/Kconfig                     |   4 +\n>   hw/hexagon/meson.build                 |   6 +\n>   hw/meson.build                         |   1 +\n>   10 files changed, 391 insertions(+), 1 deletion(-)\n>   create mode 100644 include/hw/hexagon/hexagon.h\n>   create mode 100644 hw/hexagon/machine_cfg_v66g_1024.h.inc\n>   create mode 100644 hw/hexagon/hexagon_dsp.c\n>   create mode 100644 hw/hexagon/Kconfig\n>   create mode 100644 hw/hexagon/meson.build\n> \n\nReviewed-by: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=F3BIZDek;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=QUfS+SuU;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzsBc23L0z1yGs\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2026 02:58:32 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wErwl-0004kZ-9o; Mon, 20 Apr 2026 12:58:07 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pierrick.bouvier@oss.qualcomm.com>)\n id 1wErwj-0004kA-Ew\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 12:58:05 -0400","from mx0b-0031df01.pphosted.com ([205.220.180.131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pierrick.bouvier@oss.qualcomm.com>)\n id 1wErwh-0003wx-Pa\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 12:58:05 -0400","from pps.filterd (m0279872.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63KAvYKr3015375\n for <qemu-devel@nongnu.org>; Mon, 20 Apr 2026 16:58:02 GMT","from mail-dy1-f200.google.com (mail-dy1-f200.google.com\n [74.125.82.200])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dnjuksaky-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for <qemu-devel@nongnu.org>; Mon, 20 Apr 2026 16:58:02 +0000 (GMT)","by mail-dy1-f200.google.com with SMTP id\n 5a478bee46e88-2ba9a744f7dso4091145eec.0\n for <qemu-devel@nongnu.org>; Mon, 20 Apr 2026 09:58:02 -0700 (PDT)","from [192.168.1.170] (216-71-219-44.dyn.novuscom.net.\n [216.71.219.44]) by smtp.gmail.com with ESMTPSA id\n a92af1059eb24-12c831d5b29sm12722153c88.8.2026.04.20.09.57.59\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Mon, 20 Apr 2026 09:58:00 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n efCJJ1CYyU7LnnnVOM3l/OUM0go681cI51T3+cnHC2A=; b=F3BIZDek/XBQrXY7\n j7ASnKt6uHmkdz3zeJ5nN1CwBOsZAElHy/LmKg89boF+XJsefpKVX4HqBvTXHfGX\n AHLciiJFZMKHFYbLV9CK8mElRuRxJPjb9/gMNM1uRuUXUrnsq2aG8cGbV4AoN8S6\n 6pIcRy5vYi/9HwrNo3tsOj7Pze8ob6B2qy1fU4IY6V03oxumy+yLmta6/1/uFzbN\n 5I3BpNYY3f4Q/9Fpua8I25v3Fe4Fox2lt8XlRYNIyZNtlSc2lQNwdWoGZ3CjXSj8\n c+Er1K+34CGryqVS+s+7RmGea7SE2CQN7qIrqjaX7GVKDebEOgA3x4w6xMC18T+2\n /x39iw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1776704281; x=1777309081; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=efCJJ1CYyU7LnnnVOM3l/OUM0go681cI51T3+cnHC2A=;\n b=QUfS+SuUHr/rvQDVs3GFzz8AbA9bpP3fDQj4PvOCoVhd5QB3mXskWTUiDxUinhJsO/\n Rl8WKtCLXHbTXwEn9SgxPQfrWileihgh1eYFRW03wElzR3BHL0cSG61Tg7c1mBZ/0INp\n ge3IFJ6NU8PIANwKqkGin0O9Aptzl51QvoGRGUGcTvqI4SaL8NqsjdWlCZfPbfM64Sa/\n okOkRiH1RUUOyQ2iOxAq0XHlIFV4XJ9ln8E/NjxgovSputnNiQGOIiIgPCGpcz4hftSs\n 0LBF7lfViyBZnS81xK/ynkSPI/qHyrlEM5blzKPjXs+CgLpgc6rz15Ko8OEqDm79SVY2\n sXgw=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776704281; x=1777309081;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=efCJJ1CYyU7LnnnVOM3l/OUM0go681cI51T3+cnHC2A=;\n b=pe+A+EA9vCx8peNB9AKJRY32xqJPOGqSui8sCZZHBHXvqAB/rcrYbMjkyK9y3SBY9m\n jJGK2uSysPSH+hlUr6VtDuv1Uzs5+6dgz8mrZLkyikwRNX67TLxEdDD1JpSj5L24UYNp\n lPtVrN8QKi62sr+4aAVLZZYBLap3yLt64cMqmYlX9lakwFhZ86Kpr4ZjgmF/4O2oa5Jl\n lf5Uk1dLHmUMrx9VagVdIyYnxWVzO2hKQ5pSFRsxkmLDKsPTaF0xik+JeuKpNuHWXcI7\n e7H8KWqYFUkg4FxVrhSbxAIl9s7IHYM9xy7sRIFftePZ5EPNwwhetxu9/fgzwjNPrR0z\n lR2Q==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9pKpacdihveQi+5trbKSewbmDZ86zAxGCP7HjDZt9aOvURAsRkpSF/0fkGLItUHD70sXrSdpi9eJKL@nongnu.org","X-Gm-Message-State":"AOJu0YxIrXEkyAcQMPsXRX9i00IT9bWTncTkKM+cr54Kvfnqpgk1w06i\n v4fdBf/dulRL50YL7LZ3r8+K76OfdXaMwNgtHJMF0oFjxgRDwu6d2nDTam9/Nad21UaMKahio6C\n JGfbsL/w26SrtA4HsaSJxp/XLkVSYTrGws40//PnYZh10ZgN7Oz4jWPpIrA==","X-Gm-Gg":"AeBDieu7woQiSDyk8er8Y3pXvtY7t3gJkeHaZOwZ8D3Tt0MHJdRGzX/mwhKmvWc1LDg\n U7XOUaXi/23MiRm9tH8AwXPBlf7vMbtw4NdEet0NbbsaMZYu+tGeApUphoYvQU74lLC1ciqoyyT\n 3VoyPqNYTZ2fMc/gyt4AjL+eRXuyZ5r3AKVDlTBVlK+EQiT1fW5FJMpWvTDDnyB+cM8Ic5zNYJR\n aK1d8vtKqllM91gAWUlgZ96zg744pxSEtoYoZxiBH0cuAVgM0GABYmAU0Vwg5mUi+OxSgNgWl2q\n FuxGryTCFStWBDyeGHWlzNenzyYsj3w42N+lMr0gG4bTv5Hg3KgmXm1T+H+xpK/5U5X0IAwUwOj\n iJSqsvxX2uxg5tS9/fOvVGjv2gab1os7b3zWARGTmLngiQ/WbDzRELcQluxW6gk+5ZJM+fYgSvp\n lJq3a/X/2OK852aIutx2V8HSQC","X-Received":["by 2002:a05:7022:3d87:b0:124:9fd8:4ba9 with SMTP id\n a92af1059eb24-12c73f6cd01mr7549097c88.12.1776704281418;\n Mon, 20 Apr 2026 09:58:01 -0700 (PDT)","by 2002:a05:7022:3d87:b0:124:9fd8:4ba9 with SMTP id\n a92af1059eb24-12c73f6cd01mr7549061c88.12.1776704280792;\n Mon, 20 Apr 2026 09:58:00 -0700 (PDT)"],"Message-ID":"<4e02874b-214b-406f-97b2-af7b78368a7e@oss.qualcomm.com>","Date":"Mon, 20 Apr 2026 09:57:58 -0700","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v5 3/9] hw/hexagon: Add machine configs for sysemu","To":"Brian Cain <brian.cain@oss.qualcomm.com>, qemu-devel@nongnu.org","Cc":"philmd@linaro.org, ltaylorsimpson@gmail.com,\n matheus.bernardino@oss.qualcomm.com, marco.liebel@oss.qualcomm.com,\n quic_mburton@quicinc.com, sid.manning@oss.qualcomm.com, ale@rev.ng,\n anjo@rev.ng, Brian Cain <bcain@quicinc.com>,\n Markus Armbruster <armbru@redhat.com>, Mike Lambert <mlambert@quicinc.com>,\n Sid Manning <sidneym@quicinc.com>, Paolo Bonzini <pbonzini@redhat.com>,\n\t=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>","References":"<20260416210305.2255579-1-brian.cain@oss.qualcomm.com>\n <20260416210305.2255579-4-brian.cain@oss.qualcomm.com>","From":"Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>","Content-Language":"en-US","In-Reply-To":"<20260416210305.2255579-4-brian.cain@oss.qualcomm.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-Proofpoint-GUID":"xXJz2kdgWz6-Xe1kpnkmZnay_B0PYQ2u","X-Proofpoint-ORIG-GUID":"xXJz2kdgWz6-Xe1kpnkmZnay_B0PYQ2u","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDIwMDE2NCBTYWx0ZWRfXwExSDBKBA8+4\n W6fIwu8Np+ik705l/s33bt/5LyOnmwVUZwMfOhlHUknmJndl3biCQgVLao5es6T35ALZn+fjSzK\n s+ZbxOuw+a9tmndZm27C+SLG2kCW7C6Qp0iHx24U+9KK4dN69VuJNt9qg9UnYBn3r1QtWYlqcd2\n 5BpxQzszCMgGy05leuW9nm8tNgb7AdGtMU0Mjberiv21fPZmXQ8kapHarZHPqSwU5bYQmd/+iCX\n GfHqSJUoGcLECYeTzvZA3F0NMxNJsD4ogRiaB4wTK8lLOWvuA0xpVZ7/Esr7z5j1+CJcD4qUxJD\n KUCJOH0wjJoy0/79Z2t+IHY1s3wFWhppY2MjY+o6BHIMxZHE+/+mKQweWVb8yMyzBLMvI79yIIo\n hzly+G+zwH2tDRJnQLfyqok5OOryI9mKSixC8LAnsJ6dbZWs9wjiTjeyvGD0IkBHkox/5YiLpZ+\n 30ZUrnlbInHW5VLLrYw==","X-Authority-Analysis":"v=2.4 cv=WuUb99fv c=1 sm=1 tr=0 ts=69e65b1a cx=c_pps\n a=PfFC4Oe2JQzmKTvty2cRDw==:117 a=iLqgmErQAxjCjdq5jj1Aqg==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22\n a=COk6AnOGAAAA:8 a=20KFwNOVAAAA:8 a=EUspDBNiAAAA:8 a=_VBVod5Mx91-bRSl_JMA:9\n a=QEXdDO2ut3YA:10 a=6Ab_bkdmUrQuMsNx7PHu:22 a=TjNXssC_j7lpFel5tvFf:22","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-20_03,2026-04-20_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n malwarescore=0 lowpriorityscore=0 adultscore=0 spamscore=0 phishscore=0\n priorityscore=1501 suspectscore=0 clxscore=1015 impostorscore=0 bulkscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604200164","Received-SPF":"pass client-ip=205.220.180.131;\n envelope-from=pierrick.bouvier@oss.qualcomm.com;\n helo=mx0b-0031df01.pphosted.com","X-Spam_score_int":"-27","X-Spam_score":"-2.8","X-Spam_bar":"--","X-Spam_report":"(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3680071,"web_url":"http://patchwork.ozlabs.org/comment/3680071/","msgid":"<1c3088c0-4388-4915-8bb3-c1f11675c093@linaro.org>","list_archive_url":null,"date":"2026-04-21T21:42:39","subject":"Re: [PATCH v5 3/9] hw/hexagon: Add machine configs for sysemu","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 16/4/26 23:02, Brian Cain wrote:\n> From: Brian Cain <bcain@quicinc.com>\n> \n> Some header includes are modified here: these are uniquely required for\n> basic system emulation functionality and had not been required for linux-user.\n> \n> Acked-by: Markus Armbruster <armbru@redhat.com>\n> Co-authored-by: Mike Lambert <mlambert@quicinc.com>\n> Co-authored-by: Sid Manning <sidneym@quicinc.com>\n> Signed-off-by: Brian Cain <brian.cain@oss.qualcomm.com>\n> ---\n>   MAINTAINERS                            |   2 +\n>   include/hw/hexagon/hexagon.h           | 150 +++++++++++++++++++++++\n>   hw/hexagon/machine_cfg_v66g_1024.h.inc |  64 ++++++++++\n>   hw/hexagon/hexagon_dsp.c               | 161 +++++++++++++++++++++++++\n>   system/qdev-monitor.c                  |   2 +-\n>   target/hexagon/translate.c             |   1 +\n>   hw/Kconfig                             |   1 +\n>   hw/hexagon/Kconfig                     |   4 +\n>   hw/hexagon/meson.build                 |   6 +\n>   hw/meson.build                         |   1 +\n>   10 files changed, 391 insertions(+), 1 deletion(-)\n>   create mode 100644 include/hw/hexagon/hexagon.h\n>   create mode 100644 hw/hexagon/machine_cfg_v66g_1024.h.inc\n>   create mode 100644 hw/hexagon/hexagon_dsp.c\n>   create mode 100644 hw/hexagon/Kconfig\n>   create mode 100644 hw/hexagon/meson.build\n> \n> diff --git a/MAINTAINERS b/MAINTAINERS\n> index 4055fbe3c21..b9a7c553dfa 100644\n> --- a/MAINTAINERS\n> +++ b/MAINTAINERS\n> @@ -246,6 +246,8 @@ Hexagon TCG CPUs\n>   M: Brian Cain <brian.cain@oss.qualcomm.com>\n>   S: Supported\n>   F: target/hexagon/\n> +F: hw/hexagon/\n> +F: include/hw/hexagon/\n\nIMHO long-term it is better to split architectural code from\nhardware modelling in distinct MAINTAINERS sections (and distinct\nset of reviewers / maintainers / lists).\n\n>   X: target/hexagon/idef-parser/\n>   X: target/hexagon/gen_idef_parser_funcs.py\n>   F: linux-user/hexagon/\n\n\n> +static void hexagon_common_init(MachineState *machine, Rev_t rev,\n> +                                const struct hexagon_machine_config *m_cfg)\n> +{\n> +    MemoryRegion *address_space;\n> +    MemoryRegion *sram;\n> +    DeviceState *glob_regs_dev;\n> +\n> +    memset(&hexagon_binfo, 0, sizeof(hexagon_binfo));\n> +    if (machine->kernel_filename) {\n> +        hexagon_binfo.ram_size = machine->ram_size;\n> +        hexagon_binfo.kernel_filename = machine->kernel_filename;\n> +    }\n> +\n> +    machine->enable_graphics = 0;\n> +\n> +    address_space = get_system_memory();\n> +\n> +    sram = g_new(MemoryRegion, 1);\n> +    memory_region_init_ram(sram, NULL, \"ddr.ram\",\n\nDDRAM or SRAM?\n\n> +        machine->ram_size, &error_fatal);\n> +    memory_region_add_subregion(address_space, 0x0, sram);\n> +\n> +    glob_regs_dev = qdev_new(TYPE_HEXAGON_GLOBALREG);\n> +    qdev_prop_set_uint64(glob_regs_dev, \"config-table-addr\", m_cfg->cfgbase);\n> +    sysbus_realize_and_unref(SYS_BUS_DEVICE(glob_regs_dev), &error_fatal);\n> +\n> +    for (int i = 0; i < machine->smp.cpus; i++) {\n> +        HexagonCPU *cpu = HEXAGON_CPU(object_new(machine->cpu_type));\n> +        qemu_register_reset(do_cpu_reset, cpu);\n> +\n> +        /*\n> +         * CPU #0 is the only CPU running at boot, others must be\n> +         * explicitly enabled via start instruction.\n> +         */\n> +        qdev_prop_set_bit(DEVICE(cpu), \"start-powered-off\", (i != 0));\n> +        if (i == 0) {\n> +            hexagon_init_bootstrap(machine, cpu);\n> +            if (!qdev_realize_and_unref(DEVICE(cpu), NULL, &error_fatal)) {\n> +                return;\n> +            }\n> +        } else if (!qdev_realize_and_unref(DEVICE(cpu), NULL, &error_fatal)) {\n> +            return;\n> +        }\n> +\n> +    }\n> +}\n> +\n> +static void init_mc(MachineClass *mc)\n> +{\n> +    mc->block_default_type = IF_SD;\n\nIs \"By default try to boot on SD Card first\" what you want?\n\n> +    mc->default_ram_size = 4 * GiB;\n> +    mc->no_parallel = 1;\n> +    mc->no_floppy = 1;\n> +    mc->no_cdrom = 1;\n> +    mc->no_serial = 1;\n> +    mc->is_default = false;\n> +    mc->max_cpus = 8;\n> +}\n\n\n> diff --git a/system/qdev-monitor.c b/system/qdev-monitor.c\n> index 1ac6d9a8575..72abc9182a9 100644\n> --- a/system/qdev-monitor.c\n> +++ b/system/qdev-monitor.c\n> @@ -69,7 +69,7 @@ typedef struct QDevAlias\n>                                 QEMU_ARCH_SPARC | \\\n>                                 QEMU_ARCH_XTENSA)\n>   #define QEMU_ARCH_VIRTIO_CCW (QEMU_ARCH_S390X)\n> -#define QEMU_ARCH_VIRTIO_MMIO (QEMU_ARCH_M68K)\n> +#define QEMU_ARCH_VIRTIO_MMIO (QEMU_ARCH_M68K | QEMU_ARCH_HEXAGON)\n>   \n>   /* Please keep this table sorted by typename. */\n>   static const QDevAlias qdev_alias_table[] = {\n> diff --git a/target/hexagon/translate.c b/target/hexagon/translate.c\n> index ae980c087f0..15258a203b3 100644\n> --- a/target/hexagon/translate.c\n> +++ b/target/hexagon/translate.c\n> @@ -32,6 +32,7 @@\n>   #include \"translate.h\"\n>   #include \"genptr.h\"\n>   #include \"printinsn.h\"\n> +#include \"exec/target_page.h\"\n\nRebase left-over?\n\n>   \n>   #define HELPER_H \"helper.h\"\n>   #include \"exec/helper-info.c.inc\"\n\n\n> diff --git a/hw/hexagon/meson.build b/hw/hexagon/meson.build\n> new file mode 100644\n> index 00000000000..f528d2bc4ab\n> --- /dev/null\n> +++ b/hw/hexagon/meson.build\n> @@ -0,0 +1,6 @@\n> +hexagon_ss = ss.source_set()\n> +hexagon_ss.add(files('hexagon_tlb.c'))\n> +hexagon_ss.add(files('hexagon_globalreg.c'))\n> +hexagon_ss.add(when: 'CONFIG_HEX_DSP', if_true: files('hexagon_dsp.c'))\n> +\n> +hw_arch += {'hexagon': hexagon_ss}\n\nBetter would be:\n\n   hw_common_arch += {'hexagon': hexagon_common_ss}\n\nPierrick can help here!","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=pwyhb1hI;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0bSt6BRbz1yGs\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 07:43:25 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFIrn-0003Sb-Om; Tue, 21 Apr 2026 17:42:47 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wFIrl-0003S0-NX\n for qemu-devel@nongnu.org; Tue, 21 Apr 2026 17:42:45 -0400","from mail-wm1-x330.google.com ([2a00:1450:4864:20::330])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wFIrj-0005jC-PF\n for qemu-devel@nongnu.org; Tue, 21 Apr 2026 17:42:45 -0400","by mail-wm1-x330.google.com with SMTP id\n 5b1f17b1804b1-488a88aeec9so63700305e9.2\n for <qemu-devel@nongnu.org>; Tue, 21 Apr 2026 14:42:42 -0700 (PDT)","from [192.168.69.210] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a575ad67asm50796675e9.2.2026.04.21.14.42.40\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 21 Apr 2026 14:42:40 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776807762; x=1777412562; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=C6TUEyny4IJuhtMm7N5t43FrA1i9fO+v93mBZP7/xIc=;\n b=pwyhb1hIvkK3ijd8AhfN5L2a53++ltLjwzU9gADD/ivf4qXnpkjy2cg/KSJVMWrDN5\n X5PnfLbnetq+nBO7BEYd4Fwlo4QCdpTkKL63ghRF/B2sBsfWnlj7DyMvXYFim9gbKMhw\n dP9l/i08tGNYcpl3vWfHR0ofDkWq5jJ9aF2rFk7jlxQ8zPMyPSTOSMNoU+cI+HTU15L0\n ZpNgsHpb4inZ/dmwOTqjJu5CuJ/aPUHTuSRRWItd58UFBGvZaVHWnRvnEv9uckzULFLU\n Ijvt3AOSTix7HXW9yTJbnG8HLkymx8WEme1wkkRThWuAlehE+icIqO0yB/6UhSZksqks\n yZ+A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776807762; x=1777412562;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=C6TUEyny4IJuhtMm7N5t43FrA1i9fO+v93mBZP7/xIc=;\n b=ry96KUlagkZ2UMQ2gRyu58yXYIPPKRrzhKg325CK/Bc1HjhFyJq1mGmE9gQlmn6n2N\n VBjPnVZjGlqurcs/va+/c8t3bzAFWYer4IhVL8rqIqvrKd9Xb7fVxfI9+Eh8xxDm3YiK\n Xdit+2TvOd8sNJkfpqvGWyETTqZPagyb6NiupdcAl0HgL5sbKON3Riec3MXO/2qxYCeu\n 4DhlXK0iDWkY4BdMKUN6SQTj02FtAPRF3TuRBb6qk2aB2oXP3C8sV0PKA5IaWJ78eV7m\n J4SncuTaj0D/dTWZF1zBz8caZ5/tlhWQiL3jGWcFdYgfUjQY0sSEZNYlZCWrr32tgk9E\n f7CA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8/jhSuTLN5gihyvJrOH+EfqNGngXicfLsfO8qIVUYN5pCnqvzNQyWjqcMfmMZgHxIU0aQDisf6V/Yw@nongnu.org","X-Gm-Message-State":"AOJu0Yy7BT1KbSlbvr78GI+lqQn7faC0dVeeZow/79BF8+kY4cUZ7vb1\n j14cqx6mmlvi99gmHtNZeAhe3NmCkR1YLFqXlBxpU9HUUk1/OxkdCh+tidVLvtv58yw=","X-Gm-Gg":"AeBDiesygiX4apEMj08ILgGMKCRQK26tyRCoL8cCiJnV3comAxWMrxqfb/gHj15nGf0\n OdXeLUjh7R91LRnH2dgMIQeRTgvFOK33fKD9YWm5BvYnxPtCOA1MkgRE6f5D/nmXdikBcVFDiT8\n 5nXAwIRZ4dCveVqNiPSB8b0c8q97qSfS3DaW0P6ORH8T3cz9wxLQn6CsLTWB9FmwOdfViL4V/Rj\n vBjoAOeDRpqn5hQSaB8U6Z+D1R9CFOdzISTXh++MjVi1Ae0mZJAhd2lxMFmNlGKEpUw3OjxZEO+\n 1POehKspVLZCPwGfVxMW8mr34SJFuSRM4Mas99OtQiM3E3+UZhxgp6QN9ViJSrXDDV9hX4LNlA+\n TP/lCVGA42dR8Eapn/Crufw3Ma+OlAdP0Y6mlbjIxIwZCZOCjFIcMrfEL/FWDIt8ZFlhDHmPg0/\n Zxhxn/ohIg4Xdf0v8+z95n2g3DT2dCGO4o/er+F+TXkoDoCwRPeJbijaZzFZNyDOCIntM1js765\n fP0","X-Received":"by 2002:a05:600c:c04a:b0:485:3cf3:1010 with SMTP id\n 5b1f17b1804b1-488fb73ddefmr200321635e9.2.1776807761690;\n Tue, 21 Apr 2026 14:42:41 -0700 (PDT)","Message-ID":"<1c3088c0-4388-4915-8bb3-c1f11675c093@linaro.org>","Date":"Tue, 21 Apr 2026 23:42:39 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v5 3/9] hw/hexagon: Add machine configs for sysemu","To":"Brian Cain <brian.cain@oss.qualcomm.com>, qemu-devel@nongnu.org","Cc":"ltaylorsimpson@gmail.com, matheus.bernardino@oss.qualcomm.com,\n marco.liebel@oss.qualcomm.com, quic_mburton@quicinc.com,\n sid.manning@oss.qualcomm.com, ale@rev.ng, anjo@rev.ng,\n pierrick.bouvier@oss.qualcomm.com, Brian Cain <bcain@quicinc.com>,\n Markus Armbruster <armbru@redhat.com>, Mike Lambert <mlambert@quicinc.com>,\n Sid Manning <sidneym@quicinc.com>, Paolo Bonzini <pbonzini@redhat.com>,\n\t=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>","References":"<20260416210305.2255579-1-brian.cain@oss.qualcomm.com>\n <20260416210305.2255579-4-brian.cain@oss.qualcomm.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>","Content-Language":"en-US","In-Reply-To":"<20260416210305.2255579-4-brian.cain@oss.qualcomm.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::330;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x330.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]