[{"id":3678420,"web_url":"http://patchwork.ozlabs.org/comment/3678420/","msgid":"<3a27667d-1a4e-47e4-944c-ffe68fe5b579@linaro.org>","list_archive_url":null,"date":"2026-04-16T22:59:02","subject":"Re: [PATCH v5 2/2] target/mips: Use probe_access_full() in Atomic\n Load/Store helpers","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/17/26 06:05, Philippe Mathieu-Daudé wrote:\n> Let the probe_access() API check the address alignment\n> (request MO_ALIGN in the MemOp bits).\n\nI just reviewed v4 without seeing a v5 existed, but comments still apply.\n\nhttps://lore.kernel.org/qemu-devel/73a6d4c3-9108-4172-b1b6-11ee857909fc@linaro.org/\n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=CyeBFMBQ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxYPT3jmvz1yGt\n\tfor ; Fri, 17 Apr 2026 08:59:55 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDVg6-0005XK-2I; Thu, 16 Apr 2026 18:59:18 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDVg4-0005X9-Rs\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 18:59:16 -0400","from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wDVg3-0001Ul-9b\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 18:59:16 -0400","by mail-pl1-x629.google.com with SMTP id\n d9443c01a7336-2b2494440f3so86055ad.2\n for ; Thu, 16 Apr 2026 15:59:14 -0700 (PDT)","from ?IPV6:2401:d002:dc0f:2100:a60a:7c34:dd75:e66c?\n (bg30dj02y68bx09myf73.ip6.superloop.au.\n [2401:d002:dc0f:2100:a60a:7c34:dd75:e66c])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b5fa5c06b6sm448105ad.84.2026.04.16.15.59.10\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 16 Apr 2026 15:59:13 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776380354; x=1776985154; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=+yx2Mi4a31RlM2Vmu4Ilip6w0vjoRvaqTZ0g7ICNbC4=;\n b=CyeBFMBQcDgo0zb/hiMJKlyu4pH9t0ww13fUitmFnvRUuXvDwLTJ8dkquRbhQNOGMD\n Ux/XP2tgp7TkRqNiMUSypgtOUjBnDDQcfcPo6+1imZbaK4vQhjApDyN6yNFZ6t7xjhoS\n M/27SYOSzjL2AOiL498CyU4KOkc2GrKFB8VblUXkNS7vefp/HD/n5Td/54a87gWoAiBD\n Rc9z3XFSi0SSsYctVSBFnTEiSfQeoLkzF3nkf1z9LTvo3XqswP3EGb2C6eFwGlT6ap8R\n UIeHAVZVyuyyJgCOOzA6YkxoHoMNmUZMlNW7+0/KcgwDEsf7e/Fqz54zGBdVBZufvM1E\n QCAw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776380354; x=1776985154;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=+yx2Mi4a31RlM2Vmu4Ilip6w0vjoRvaqTZ0g7ICNbC4=;\n b=FtV4uirPk1RjqyREetWQ2KMhVViJQVhaGPc3MZwjXGNx6jZ2C25E00/DUgIeRcmjHk\n ftoWCFLo0CWiK9x09I9TxBxJSYKfr4QObDp2hCFYn0Z/ZQifT1KBsYSmaJkvQ7zLG4j7\n P/9kqbz2X5ywprDKi4actU/5QZgQBv22Uq+si+Ii2Q4H1dm6TIsURNA5WrDbs4xPjNBA\n mfFESBaK/QFN2N8lSycKa7tzEjfiTKwNBW90bOLDjQ0Mx+UqUULfAOIrQTgLMXtzjiZs\n mocNsQKHZ/OjYnNVgsz9ygQI2FWeIdRrnR0/mSYG3HFCOo4DyYUCFz7h8gow9fWbn+ct\n 7ciA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/yZAEnw7hwSZrOalt8aFAZ3Ron9wbO3vlCyiMKlMCNWg4SMrs7FcWu6jTVayxNN2GaoCvFBoCOI5u5@nongnu.org","X-Gm-Message-State":"AOJu0YyASv2C5TkgPPy5TIeAw3I3gPgTwbEQF+0tpmU1FwvkXNlzhbJf\n bYtrYVjWBPcdz3fn35G4FwkV+nMUO1T2/euOuWLoohH9FjZpdZorCLG6+KhzPi4KteQ=","X-Gm-Gg":"AeBDieuEmnBOqma2c8xLkvgtacxRcIiKYuVjP9kDBkegHHy3uU4uPpNnKr4l5yXg9HM\n gixard7bcPFbNHueuKY3MproPfPO3jpc4HxPQtOfxfJQrkE+lFXvBIIRk8QHWk0vSnxdnARD1kb\n BX2d3EEYxiwLzZVxx/NCPQl3lgkVQgRoyeKk5ynhDTrKSwRymR69dlvCKj9VsH/VSvP3cbnOrOr\n fuxh3V04CJHqpavmnNTr9+GyvwFi78giHbiCM+In0WlWcaZf9LR/OBg5PKFUIsp+5xHtsNWrd3D\n pg0xMa+FjP4cw56ESTa77NrrIvIIXQJPKWV2/1RY5obePoku3F0NTCQ/ztM0OqYyKhFndTkKFWa\n QGrGQnbHrnHvNZlQdY0GC3R3kGgkiAz+lGMBF34Y7vplxbQ0IdHpCKk5DNHRx0c/YXM3avXRSxT\n VmHPNyRV+va2WR5t2AlUqtRZoddgz/JZnmJt2bQxnqHnX8kS0fhkTDqoZ5kml1GSy5IKSu3iNb2\n aIz+2A0f4n4foKQmsylgu35ijrvLaq/eUYBChEMEtFZqgjZu6/XZtRcDscFGpScNnD+yiPVEI2j","X-Received":"by 2002:a17:903:166e:b0:2b0:a957:304 with SMTP id\n d9443c01a7336-2b5f9e85b42mr2923355ad.6.1776380353646;\n Thu, 16 Apr 2026 15:59:13 -0700 (PDT)","Message-ID":"<3a27667d-1a4e-47e4-944c-ffe68fe5b579@linaro.org>","Date":"Fri, 17 Apr 2026 08:59:02 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v5 2/2] target/mips: Use probe_access_full() in Atomic\n Load/Store helpers","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","Cc":"Jiaxun Yang ,\n Aurelien Jarno , Aleksandar Rikalo ","References":"<20260416200513.27100-1-philmd@linaro.org>\n <20260416200513.27100-3-philmd@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260416200513.27100-3-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::629;\n envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x629.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]