[{"id":3680038,"web_url":"http://patchwork.ozlabs.org/comment/3680038/","msgid":"<20260421194215.GC1684602@rocinante>","list_archive_url":null,"date":"2026-04-21T19:42:15","subject":"Re: [PATCH v5 07/23] PCI/sysfs: Convert PCI resource files to static\n attributes","submitter":{"id":86709,"url":"http://patchwork.ozlabs.org/api/people/86709/","name":"Krzysztof Wilczyński","email":"kwilczynski@kernel.org"},"content":"Hello,\n\n> @@ -1685,14 +1700,14 @@ static ssize_t __resource_resize_store(struct device *dev, int n,\n> \tpci_write_config_word(pdev, PCI_COMMAND,\n> \t\t\t cmd & ~PCI_COMMAND_MEMORY);\n> \n> -\tpci_remove_resource_files(pdev);\n> +\tsysfs_remove_groups(&pdev->dev.kobj, pci_dev_resource_attr_groups);\n> \n> \tret = pci_resize_resource(pdev, n, size, 0);\n> \n> \tpci_assign_unassigned_bus_resources(bus);\n> \n> -\tif (pci_create_resource_files(pdev))\n> -\t\tpci_warn(pdev, \"Failed to recreate resource files after BAR resizing\\n\");\n> +\tif (sysfs_create_groups(&pdev->dev.kobj, pci_dev_resource_attr_groups))\n> +\t\tpci_warn(pdev, \"Failed to recreate resource groups after BAR resizing\\n\");\n> \n> \tpci_write_config_word(pdev, PCI_COMMAND, cmd);\n> pm_put:\n\nMoving __resource_resize_store() and everything else related to resizable\nBAR resources behind the HAVE_PCI_MMAP and/or ARCH_GENERIC_PCI_MMAP_RESOURCE\ncheck, where either is required for resizable BAR support, would stop this\nfrom being included on architectures that offer no support for resizable\nBARs.\n\nSomething for the next version.\n\nThank you,\n\n\tKrzysztof","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=dU4ij2Q8;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=linux-pci+bounces-52875-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"dU4ij2Q8\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0XnC0ykdz1yHB\n\tfor ; Wed, 22 Apr 2026 05:42:23 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id CEC663025181\n\tfor ; Tue, 21 Apr 2026 19:42:19 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 9872C3DD516;\n\tTue, 21 Apr 2026 19:42:18 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 487A63DD513;\n\tTue, 21 Apr 2026 19:42:17 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 59753C2BCB0;\n\tTue, 21 Apr 2026 19:42:17 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776800538; cv=none;\n b=jLJefcHNmdVWjnCdCzDkkxOa479Y6s2lRtL+Prj+go2M/WiUX70nDbehPRNAzZQ0jtGrJI/OtG9gZ5Rg5Ce5ntxg4CzZAihA4sQjVKzCpLjBpPCDHiKNSbVfCGL/GZ1jEjpMyvqjAN7P9VhjDvlr9Buc6+n6p0XMjCM+eXhHN60=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776800538; c=relaxed/simple;\n\tbh=xmNghYGrPS7aPnR9Fe2A0c3Av//2yBrrb9EMpzvM8+g=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=LRnDF+/E1Ep42wmLZa2IgWGRF0++ZZGRPs71HG//7Vcvt8GhOorNINcjqSdVfzwCWCyGaGSMqAefOp13PAnomxWMF7OBdMNteEOwgLfE0ZJY9ad1m/94OPhdDy+BicXdB2puIUoC9co8uTLiBYHXFimxEuJT2+e/ouIjUlbu+qA=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=dU4ij2Q8; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776800537;\n\tbh=xmNghYGrPS7aPnR9Fe2A0c3Av//2yBrrb9EMpzvM8+g=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=dU4ij2Q88BapDuHDIZ0EvWzRjerjWcRD2plESQJMgaZTUL0aIFNovwtrRqNKA3ugf\n\t eoIcmU1bOv50WdUsaaNP4RpkU+LKK5kEJTTe2DNvcgSdGt5SWkyd07v0xkVULrgtQh\n\t VneMWWQpMiFBgNFZuDu9d9Dm7Oge7EA7DIn9wZlJRv6q+LZrht9XX1tyreLccYsy8B\n\t NshzYTdRpvYB6ofg6JEC5w46QE+PSjjITJKp84oIb/g67ElZfH1SjbqUo9ONqNzB2F\n\t xgAKMogtdPQb6Pee/Xj7dZM+MRIkHtm74+T6YdA3KLJfs78MpSut4PvBzWMVsYvm3t\n\t uvIhwa1wrf2IA==","Date":"Wed, 22 Apr 2026 04:42:15 +0900","From":"Krzysztof =?utf-8?q?Wilczy=C5=84ski?= ","To":"Bjorn Helgaas ","Cc":"Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Magnus Lindholm , Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n Krzysztof =?utf-8?q?Ha=C5=82asa?= ,\n Lukas Wunner , Oliver O'Halloran ,\n Saurabh Singh Sengar ,\n Shuan He , Srivatsa Bhat ,\n Ilpo =?utf-8?b?SsOkcnZpbmVu?= ,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org","Subject":"Re: [PATCH v5 07/23] PCI/sysfs: Convert PCI resource files to static\n attributes","Message-ID":"<20260421194215.GC1684602@rocinante>","References":"<20260416180107.777065-1-kwilczynski@kernel.org>\n <20260416180107.777065-8-kwilczynski@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260416180107.777065-8-kwilczynski@kernel.org>"}}]