[{"id":3680040,"web_url":"http://patchwork.ozlabs.org/comment/3680040/","msgid":"<20260421195042.GD1684602@rocinante>","date":"2026-04-21T19:50:42","subject":"Re: [PATCH v5 11/23] alpha/PCI: Add security_locked_down() check to\n pci_mmap_resource()","submitter":{"id":86709,"url":"http://patchwork.ozlabs.org/api/people/86709/","name":"Krzysztof Wilczyński","email":"kwilczynski@kernel.org"},"content":"Hello,\n\n> @@ -71,7 +72,11 @@ static int pci_mmap_resource(struct kobject *kobj,\n>  \tstruct resource *res = attr->private;\n>  \tenum pci_mmap_state mmap_type;\n>  \tstruct pci_bus_region bar;\n> -\tint i;\n> +\tint i, ret;\n> +\n> +\tret = security_locked_down(LOCKDOWN_PCI_ACCESS);\n> +\tif (ret)\n> +\t\treturn ret;\n\nThere is feedback from Sashiko about this:\n\n  https://sashiko.dev/#/patchset/20260416180107.777065-1-kwilczynski%40kernel.org?part=11\n\nMight be something to look into later.  Out of scope for this series.\n\nThank you!\n\n\tKrzysztof","headers":{"Return-Path":"\n <linuxppc-dev+bounces-19913-incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=XCYXlXCD;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19913-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2600:3c0a:e001:78e:0:1991:8:25\"","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=XCYXlXCD;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org;\n envelope-from=kwilczynski@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0Xyw2YDCz1yGs\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 05:50:48 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g0Xyv48T5z30Wg;\n\tWed, 22 Apr 2026 05:50:47 +1000 (AEST)","from sea.source.kernel.org (sea.source.kernel.org\n [IPv6:2600:3c0a:e001:78e:0:1991:8:25])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g0Xyt3qFZz30WT\n\tfor <linuxppc-dev@lists.ozlabs.org>; Wed, 22 Apr 2026 05:50:46 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby sea.source.kernel.org (Postfix) with ESMTP id 2532741957;\n\tTue, 21 Apr 2026 19:50:44 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id B40D7C2BCB4;\n\tTue, 21 Apr 2026 19:50:43 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776801047;\n\tcv=none;\n b=f3XjRRnqYVL15wtykHJaHmAZv8dhv6nj9Iu+FHDe8ehc7TEn0W0ZIK2vDGs2I79LoGNzLAuOqiCoqISOr1/jF2Kzf+Y34Lps5NqPztoovkKnDqbSary9077TX0XsTHyQIraD/iIgIJWIcii7Dk7xOyXWpOVipxPS14F0wWUSX4oO/6xz747x+cYPKUM7WDZ77w5r9dGu43IpTLtf9ZnPde00wfeTKQduCyU5M1D5y5PzF1PSw6qal9xo3m/1PgAL0U3MQbYcYQ9ZFSjn4+egt9wRwsK6kHudDQFShXWKPpXwtBIMEJc4DBM0e6CkjJslQrLD2hAel/k/SWPKneqOWA==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776801047; c=relaxed/relaxed;\n\tbh=fHdkP/YSV1JBsv1HLBhc8GJUwKj7/oOdCUPF6mdXDUs=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=UhqdpBmTGnvQNlmXu+Ik1RAEhDN7vnOPaT6jhlIw/dlzXjKsyPyNzkMxTo78aNQ8bV+MKuru+uLQVtxw64LvlSfBk3Hiv8yMZWZaYhSVqKBtp5rs+2YTaBmReuQhAx4XIPcvetnxMB5DvBWNHMFLrL33qzXL++kv7dQJ4V3cQdTeSJ9jLM5LEbFckbsdzoG06rolZdm4yJ+BaSgVPvIsdyHXRN450JpPQ/bWzLDcfx03tzvoB/67n3XXCgl8pIS5E9u/R6m3Tr3ONZyGojs7YBHWYbIqrKiLC+/wMTtFn6K5/jC+DZicaj1EfvmEdWtv9+bzBbZWXtVpSfurnmzf3w==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=XCYXlXCD; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c0a:e001:78e:0:1991:8:25;\n helo=sea.source.kernel.org; envelope-from=kwilczynski@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776801044;\n\tbh=ooUX033PRSor4DZZcfiE5ZgW5rEzRajyd8nkM8cfXwc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=XCYXlXCD5ncatsOJrtdenK4w6lbDvos2aOvw1Vk0DVjK9s1BJl+4Yh6nhtCD21UtX\n\t 8Aj+jgcfHe7bMH0TJ2A1fuhrgOrVc98OKspi1hYSNiDXiIiTh2NpZ6sR7hga2m7WZD\n\t Jf1tUW33tnqt+sKJvc+Ap0ut/TAsl9S+nza2U+lyoKpDN6zKk1UZ9Z4UJKx7wZIPv9\n\t NrQhx1+I04JOQ8tzkj56EudFABZqJY0SH6KxkOpwy0iiHexCeWwmyT328QwzyPX9fK\n\t 7HI4JT4EmPdwn0qnOtYTgeWILzZNoGhCIOc6nQY2448nY4xnBw4Mk8bwW6WXMXMI9N\n\t CqS5bIo6A0CEg==","Date":"Wed, 22 Apr 2026 04:50:42 +0900","From":"Krzysztof =?utf-8?q?Wilczy=C5=84ski?= <kwilczynski@kernel.org>","To":"Bjorn Helgaas <bhelgaas@google.com>","Cc":"Bjorn Helgaas <helgaas@kernel.org>,\n Manivannan Sadhasivam <mani@kernel.org>,\n Lorenzo Pieralisi <lpieralisi@kernel.org>,\n Magnus Lindholm <linmag7@gmail.com>, Matt Turner <mattst88@gmail.com>,\n Richard Henderson <richard.henderson@linaro.org>,\n Christophe Leroy <chleroy@kernel.org>,\n Madhavan Srinivasan <maddy@linux.ibm.com>,\n Michael Ellerman <mpe@ellerman.id.au>, Nicholas Piggin <npiggin@gmail.com>,\n Dexuan Cui <decui@microsoft.com>,\n Krzysztof =?utf-8?q?Ha=C5=82asa?= <khalasa@piap.pl>,\n Lukas Wunner <lukas@wunner.de>, Oliver O'Halloran <oohall@gmail.com>,\n Saurabh Singh Sengar <ssengar@microsoft.com>,\n Shuan He <heshuan@bytedance.com>, Srivatsa Bhat <srivatsabhat@microsoft.com>,\n Ilpo =?utf-8?b?SsOkcnZpbmVu?= <ilpo.jarvinen@linux.intel.com>,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org","Subject":"Re: [PATCH v5 11/23] alpha/PCI: Add security_locked_down() check to\n pci_mmap_resource()","Message-ID":"<20260421195042.GD1684602@rocinante>","References":"<20260416180107.777065-1-kwilczynski@kernel.org>\n <20260416180107.777065-12-kwilczynski@kernel.org>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"<linuxppc-dev.lists.ozlabs.org>","List-Help":"<mailto:linuxppc-dev+help@lists.ozlabs.org>","List-Owner":"<mailto:linuxppc-dev+owner@lists.ozlabs.org>","List-Post":"<mailto:linuxppc-dev@lists.ozlabs.org>","List-Archive":"<https://lore.kernel.org/linuxppc-dev/>,\n  <https://lists.ozlabs.org/pipermail/linuxppc-dev/>","List-Subscribe":"<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n  <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n  <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>","List-Unsubscribe":"<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260416180107.777065-12-kwilczynski@kernel.org>","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]