[{"id":3680039,"web_url":"http://patchwork.ozlabs.org/comment/3680039/","msgid":"<20260421194215.GC1684602@rocinante>","date":"2026-04-21T19:42:15","subject":"Re: [PATCH v5 07/23] PCI/sysfs: Convert PCI resource files to static\n attributes","submitter":{"id":86709,"url":"http://patchwork.ozlabs.org/api/people/86709/","name":"Krzysztof Wilczyński","email":"kwilczynski@kernel.org"},"content":"Hello,\n\n> @@ -1685,14 +1700,14 @@ static ssize_t __resource_resize_store(struct device *dev, int n,\n> \tpci_write_config_word(pdev, PCI_COMMAND,\n> \t\t\t cmd & ~PCI_COMMAND_MEMORY);\n> \n> -\tpci_remove_resource_files(pdev);\n> +\tsysfs_remove_groups(&pdev->dev.kobj, pci_dev_resource_attr_groups);\n> \n> \tret = pci_resize_resource(pdev, n, size, 0);\n> \n> \tpci_assign_unassigned_bus_resources(bus);\n> \n> -\tif (pci_create_resource_files(pdev))\n> -\t\tpci_warn(pdev, \"Failed to recreate resource files after BAR resizing\\n\");\n> +\tif (sysfs_create_groups(&pdev->dev.kobj, pci_dev_resource_attr_groups))\n> +\t\tpci_warn(pdev, \"Failed to recreate resource groups after BAR resizing\\n\");\n> \n> \tpci_write_config_word(pdev, PCI_COMMAND, cmd);\n> pm_put:\n\nMoving __resource_resize_store() and everything else related to resizable\nBAR resources behind the HAVE_PCI_MMAP and/or ARCH_GENERIC_PCI_MMAP_RESOURCE\ncheck, where either is required for resizable BAR support, would stop this\nfrom being included on architectures that offer no support for resizable\nBARs.\n\nSomething for the next version.\n\nThank you,\n\n\tKrzysztof","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=dU4ij2Q8;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19912-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2600:3c04:e001:324:0:1991:8:25\"","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=dU4ij2Q8;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org;\n envelope-from=kwilczynski@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0XnJ1mQDz1yHB\n\tfor ; Wed, 22 Apr 2026 05:42:27 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g0Xn95RNNz30Wg;\n\tWed, 22 Apr 2026 05:42:21 +1000 (AEST)","from tor.source.kernel.org (tor.source.kernel.org\n [IPv6:2600:3c04:e001:324:0:1991:8:25])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g0Xn83cmMz30WT\n\tfor ; Wed, 22 Apr 2026 05:42:20 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id E2B7C60126;\n\tTue, 21 Apr 2026 19:42:17 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 59753C2BCB0;\n\tTue, 21 Apr 2026 19:42:17 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776800541;\n\tcv=none;\n b=B5WyXUOHYOZEZKaWt4Yqg8OczrqmTAS5DpIL9M660lhCctSp8KQEIDnm8J+TE7LuqtQ9esw8V50/IWxuNmBEhKh9dalZY0UCIn+hBkaXFYHCEV/lSHlxfGsH8YpoRCl0pybPOKymu8/d3Qo0XtWPGxH+oJeK0WYoZCO/12ymQaq0cpfGbqqH978V7FE7l/d+bdViqIosb+UuVYUjpzz8xbbagNVooMWmygsckS7KU1gDh7FPS85meCSz4UwVOcfd4khvDeRMEyypCjyKjgmlK7lVA+29vDwk1rH5iZSIm/NcP2PlMnNdIjhMbxlOcGSZRQI+/LaULVCMXAA8w9HpXA==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776800541; c=relaxed/relaxed;\n\tbh=JnGcUUKlrL/Lf9ZhzfvaHj0jBDYJxx3WhTbUzx9JodE=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=YQBOYKCgCcs0f7gGVTBqj6wqrFUt+Q+skhr5D8XxiqzK5Vg4AyebFEdHJY820L2Lz+ouBYG7XNrOK6iQd7nKFIna8g8iVYvARQrYnNbESc2/fgLaKaexGJq6MLAe6W1s7UzDY6J/KSyf586pQUCm7pSbsmrTDf4oQsqUn5ZrW3Mdvu4m6nL1V7jXOuu9ScCJMFMfKCmcY6OEgVLzz6DKCOqPOp70/Uh3269V/U6zR3Us7Oo9pHJCUvb8bt28e4K2L1Eqo1k2A8szIpHFxkdbWe1uMdm8KFCCYDQBhCIGlwUcfM2CJb/XKP0kO6QLXX1BJTivxqDCDw66XZqPYjquTw==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=dU4ij2Q8; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c04:e001:324:0:1991:8:25;\n helo=tor.source.kernel.org; envelope-from=kwilczynski@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776800537;\n\tbh=xmNghYGrPS7aPnR9Fe2A0c3Av//2yBrrb9EMpzvM8+g=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=dU4ij2Q88BapDuHDIZ0EvWzRjerjWcRD2plESQJMgaZTUL0aIFNovwtrRqNKA3ugf\n\t eoIcmU1bOv50WdUsaaNP4RpkU+LKK5kEJTTe2DNvcgSdGt5SWkyd07v0xkVULrgtQh\n\t VneMWWQpMiFBgNFZuDu9d9Dm7Oge7EA7DIn9wZlJRv6q+LZrht9XX1tyreLccYsy8B\n\t NshzYTdRpvYB6ofg6JEC5w46QE+PSjjITJKp84oIb/g67ElZfH1SjbqUo9ONqNzB2F\n\t xgAKMogtdPQb6Pee/Xj7dZM+MRIkHtm74+T6YdA3KLJfs78MpSut4PvBzWMVsYvm3t\n\t uvIhwa1wrf2IA==","Date":"Wed, 22 Apr 2026 04:42:15 +0900","From":"Krzysztof =?utf-8?q?Wilczy=C5=84ski?= ","To":"Bjorn Helgaas ","Cc":"Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Magnus Lindholm , Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n Krzysztof =?utf-8?q?Ha=C5=82asa?= ,\n Lukas Wunner , Oliver O'Halloran ,\n Saurabh Singh Sengar ,\n Shuan He , Srivatsa Bhat ,\n Ilpo =?utf-8?b?SsOkcnZpbmVu?= ,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org","Subject":"Re: [PATCH v5 07/23] PCI/sysfs: Convert PCI resource files to static\n attributes","Message-ID":"<20260421194215.GC1684602@rocinante>","References":"<20260416180107.777065-1-kwilczynski@kernel.org>\n <20260416180107.777065-8-kwilczynski@kernel.org>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260416180107.777065-8-kwilczynski@kernel.org>","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]