[{"id":3678351,"web_url":"http://patchwork.ozlabs.org/comment/3678351/","msgid":"","list_archive_url":null,"date":"2026-04-16T19:45:09","subject":"Re: [PATCH] hw: Move ARM_SYSCTL_GPIO definitions to arm sysctl\n specific header","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 16/4/26 19:26, Peter Maydell wrote:\n> include/hw/arm/primecell.h used to be more expansive, but now the\n> only thing it defines is the ARM_SYSCTL_GPIO_* constants for the GPIO\n> lines for the arm-sysctl system-control device used on the Realview,\n> Versatile and Versatile Express boards.\n> \n> Replace it with a header file specific to that device.\n> \n> virt.c and vmapple.c included primecell.h despite not using the\n> constants it defined; there we can simply drop the include entirely.\n> \n> Signed-off-by: Peter Maydell \n> ---\n> Trivial cleanup; I was trying out emacs eglot and it flagged\n> up that virt.c includes primecell.h unnecessarily, which led\n> me to this.\n> ---\n> MAINTAINERS | 2 +-\n> hw/arm/realview.c | 2 +-\n> hw/arm/vexpress.c | 2 +-\n> hw/arm/virt.c | 1 -\n> hw/misc/arm_sysctl.c | 2 +-\n> hw/vmapple/vmapple.c | 1 -\n> include/hw/arm/primecell.h | 12 ------------\n> include/hw/misc/arm_sysctl.h | 16 ++++++++++++++++\n> 8 files changed, 20 insertions(+), 18 deletions(-)\n> delete mode 100644 include/hw/arm/primecell.h\n> create mode 100644 include/hw/misc/arm_sysctl.h\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=Jt39y32E;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxT5p1J32z1yD3\n\tfor ; Fri, 17 Apr 2026 05:46:06 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDSeT-0002eT-5t; Thu, 16 Apr 2026 15:45:25 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wDSeM-0002b9-5P\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 15:45:19 -0400","from mail-wr1-x435.google.com ([2a00:1450:4864:20::435])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wDSeI-000368-0x\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 15:45:16 -0400","by mail-wr1-x435.google.com with SMTP id\n ffacd0b85a97d-43d7e23defbso2469414f8f.0\n for ; Thu, 16 Apr 2026 12:45:12 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43ead3d5eb4sm16469685f8f.20.2026.04.16.12.45.10\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 16 Apr 2026 12:45:10 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776368711; x=1776973511; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id:from\n :to:cc:subject:date:message-id:reply-to;\n bh=tXGADF0m9fvSVjoVMvi01D2+qEpRcaU0JW8MXDn0hV8=;\n b=Jt39y32EOg2mvB9Q1qMPFktOSkJervuz9Kx+sOUVV/MVi+AzLywc6ognZG10PBrXMR\n qwsn8IiS05kLkVQCZmexs90sD6E5RniEEzlLl4bZnXWWdKJHUBvGYN6XSrWWXobIslu3\n mRpbY3Mwvm7QPNfflRkC45nObBX33f58AiYiDLIM9cr/uPytVw1VbMn1nNWH/2/0uKLq\n q4LatYn+qqBzzKrATtDKeUR7zh3U1pzw4o2XHa1i/nK/u/vuYv32ebKN6hN6jyuvJLbW\n ZuRyN7zh1WwEUu1W/frE1F6dA9U+/BkL2hNDUMVwf/TfBXa68YjNPJD3ydDQRkr7y0nq\n exZA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776368711; x=1776973511;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=tXGADF0m9fvSVjoVMvi01D2+qEpRcaU0JW8MXDn0hV8=;\n b=BhPlJuVWWQRjMj9hUXzg3Z2ppRw+51E5c+fZfr1BWmTz647/97AtUiozS7HhOyzwKQ\n 9QrqW1fVuR/MmFpx4/Hxoiob4HrZEIpu6kEUdKCoTrcqwoSCNu1S3z07od3F7PeSmNbO\n OuUkOYjk8N/ZeLAQSJSByxpi8k0LbBZbvSFvp9+Mmc2n2LfCk21SyA4iPb9XuzVdhStV\n aZe6GaCSX2p7W1NFaBEcRpd2Ksfjj3X4DJoF3iwRlfMpZdQyObeKmt58y5FCPm7cS4pc\n 7RtiD0xBtZbNSWG72W5Nx/ECVxx/B5C0BJOEJuTpynzbsi73uFH7XbSKrRL6SVkxK/EH\n dJfw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ90BQ9QtmAYwS0SWQHLgX8qJWI55fBZCGxPYa6zsuLulhXEbtF8KwbqjPu/sYRYDAk3ibgRH11j5Y2p@nongnu.org","X-Gm-Message-State":"AOJu0Yy32ca4E/nNtY7teb/fXydHdHKh6zRw+FKG077RTVf4owP+zK42\n Ggsa+2X0wz8HPngPW42GOdyJWbCHbpjvH1vApubUH+xCrh6MkFJdaCPb5k2b+QDel8E=","X-Gm-Gg":"AeBDieseG4qnZAi2CueuWgVQ8sKpg65kwMK2UtokJXbsQ1A6xrva5tcdhTCDhUPAikm\n dDCbW41R6BDGmvln2f4THEokeI9juRoYeJhIZspNUoKVCw+jBurnm/fybSAjG0xzVPBLeJgdPG/\n FemnSXJFzlRp1p6CP0Cy2pghVDp0UdZ2wRS+if1nFcsu0tGp25FeIwDpfnpSnXLCUy6EYCyYrkn\n Wo9lW+LXuGVBHyb8ns+JQaOqehVEW0fkyk1FvtWoevehAjMc//VN+AS0Fv3n++T6p0QPs3j0qfz\n iIpdEXU05NZzLLNrWI25vucmQtuUMB8CKpINJjTU1i6IqKl6Ceg+ywcCI4dASD5ohGcU+nkHH2T\n QcK0i+6F9u7d4+3Xx/p5GAbacalNXMje3SvAGJBRy0PbFmAsRfwjmU0JBEuknIRWyHlTnWIA88Q\n 1/z84tTZf9vr2BwdWzDrCiLyIvQrXW3DC6YgTFoQACv5+1YOrgiMIW8KF+T+kZjH1/pkGxI4+Cs\n NIZIRyHQw2k19s=","X-Received":"by 2002:a05:6000:2586:b0:43d:9bb5:bd97 with SMTP id\n ffacd0b85a97d-43fe0ea3d84mr1039467f8f.8.1776368711464;\n Thu, 16 Apr 2026 12:45:11 -0700 (PDT)","Message-ID":"","Date":"Thu, 16 Apr 2026 21:45:09 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] hw: Move ARM_SYSCTL_GPIO definitions to arm sysctl\n specific header","To":"Peter Maydell , qemu-arm@nongnu.org,\n qemu-devel@nongnu.org","References":"<20260416172627.690396-1-peter.maydell@linaro.org>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Content-Language":"en-US","In-Reply-To":"<20260416172627.690396-1-peter.maydell@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::435;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x435.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]