[{"id":3678264,"web_url":"http://patchwork.ozlabs.org/comment/3678264/","msgid":"","list_archive_url":null,"date":"2026-04-16T15:41:36","subject":"Re: [PATCH v2] Bluetooth: btintel_pcie: Fix build error when\n CONFIG_ACPI is disabled","submitter":{"id":64186,"url":"http://patchwork.ozlabs.org/api/people/64186/","name":"Luiz Augusto von Dentz","email":"luiz.dentz@gmail.com"},"content":"Hi Chandrashekar,\n\nOn Thu, Apr 16, 2026 at 11:39 AM Chandrashekar Devegowda\n wrote:\n>\n> btintel_pcie_acpi_reset_method() uses ACPI APIs such as\n> acpi_evaluate_object() and acpi_has_method() which are not available\n> when CONFIG_ACPI is disabled, causing build errors on architectures\n> that lack ACPI support.\n>\n> Guard btintel_pcie_acpi_reset_method() and btintel_pcie_perform_pldr()\n> with IS_ENABLED(CONFIG_ACPI). Since PLDR relies entirely on ACPI reset\n> methods, skip the entire PLDR flow when ACPI is not enabled instead of\n> unnecessarily unbinding and reprobing WiFi with no actual reset.\n>\n> Fixes: 912a499a7955 (\"Bluetooth: btintel_pcie: Support Product level reset\")\n> Reported-by: kernel test robot \n> Signed-off-by: Chandrashekar Devegowda \n> ---\n> v1 -> v2:\n> - Guard btintel_pcie_perform_pldr() along with\n> btintel_pcie_acpi_reset_method() under IS_ENABLED(CONFIG_ACPI)\n> instead of providing a separate stub for the ACPI method, since\n> PLDR is meaningless without ACPI support (Paul).\n> - Tested with CONFIG_ACPI=y, CONFIG_ACPI disabled, and 0day CI\n> alpha config.\n>\n> drivers/bluetooth/btintel_pcie.c | 7 +++++++\n> 1 file changed, 7 insertions(+)\n>\n> diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c\n> index 076beb45c410..07223965388a 100644\n> --- a/drivers/bluetooth/btintel_pcie.c\n> +++ b/drivers/bluetooth/btintel_pcie.c\n> @@ -2280,6 +2280,7 @@ static void btintel_pcie_inc_recovery_count(struct pci_dev *pdev,\n> static int btintel_pcie_setup_hdev(struct btintel_pcie_data *data);\n> static void btintel_pcie_reset(struct hci_dev *hdev);\n>\n> +#if IS_ENABLED(CONFIG_ACPI)\n> static int btintel_pcie_acpi_reset_method(struct btintel_pcie_data *data)\n> {\n> union acpi_object *obj, argv4;\n> @@ -2389,6 +2390,12 @@ static void btintel_pcie_perform_pldr(struct btintel_pcie_data *data)\n> BT_ERR(\"BT reprobe failed for BDF:%s\", pci_name(pdev));\n> }\n> }\n> +#else\n> +static void btintel_pcie_perform_pldr(struct btintel_pcie_data *data)\n> +{\n> + bt_dev_warn(data->hdev, \"PLDR not supported, ACPI is disabled\");\n> +}\n> +#endif\n>\n> static void btintel_pcie_reset_work(struct work_struct *wk)\n> {\n> --\n> 2.43.0\n\nDoesn't making btintel_pci depend only on ACPI resolve all of this? Or\ndo we really need to support systems without ACPI?","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=M5k8RptB;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-52620-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"M5k8RptB\"","smtp.subspace.kernel.org;\n arc=pass smtp.client-ip=74.125.224.50","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxMk93xcsz1yHP\n\tfor ; Fri, 17 Apr 2026 01:43:45 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 3B93C303CC2B\n\tfor ; Thu, 16 Apr 2026 15:41:50 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 03C743DFC86;\n\tThu, 16 Apr 2026 15:41:50 +0000 (UTC)","from mail-yx1-f50.google.com (mail-yx1-f50.google.com\n [74.125.224.50])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 953C038AC76\n\tfor ; Thu, 16 Apr 2026 15:41:48 +0000 (UTC)","by mail-yx1-f50.google.com with SMTP id\n 956f58d0204a3-64d5a7926cfso7811176d50.2\n for ; Thu, 16 Apr 2026 08:41:48 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776354109; cv=pass;\n b=lrZO7geh8DYHe86SXiymV5eOVuNNUfTuT4jgwD2292RvB4GAuKgcuRyYgCSDJnALtoGOhHrWoyysf9N2KX1vPy72wFxbZL7GJJt9t99zQMwT9oYJTdtbOWNs73KDAYoe0g+xvDfiBdOCN7IQytOMDWQxdYPKlHQpAFxNMIZnMBs=","i=1; a=rsa-sha256; t=1776354107; cv=none;\n d=google.com; s=arc-20240605;\n b=fbe275OICg+o/uHfiFbqDGQq5LgyoLh2fke2PxPE6CXSpnmqIyA+9451AUwzk/rugy\n y1y7djI47jhNxKawambfktTUfB9FD9JP1zHnkqvk0o15njmplZBb+DYObBTodaFl9fOl\n e55PWOZWs7mL7WxA+45t6y1OpaGmaZ4IMx6YU4/7mwnw5Y+tqCzMNLO7WKmOLB1wDflB\n 2eJl6Tedpq7Rm179XW+1xubNLQzpVfKwC0+bg3jQomB4uF78VAwg3yUmy1//GRCrRJxn\n YI6mlMHPXOeiDUb/crVCnyKFwEELD2+qngsZ5E/q1a/jSCfvBE4NBF3j5VJmsp9TTyxY\n s4Mw=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776354109; c=relaxed/simple;\n\tbh=zBGBrZMTwKJ68rCLDRs8azQlORU5x7myV+tVHdcijts=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=rt5RpzcYnWTiiimw4przfvUwtOe64oDQ13QL6PtbsiNSRlzfZOxh+zvy05coYiCe162Vz1l1jO8w9CEXxxaiSTqV5335Nr41cU1MvzYWGT7smfDGOy8NkO+Drg+xIAiSCPimxtULHnrgxwutrISFJ/o67yTQegRyUMnObtlPtqM=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=OCnOF4+nugCQPZVKQw/7phANXrJTt1mtYs1TJKi/ahA=;\n fh=4KK2MYDtvIbWafzKYa2NWNg5eHRbAhY71j1d3vUChUs=;\n b=LffHTT8ASasxkBh4y+7DzppTVI4J882ax78RhJ2RY/o7fCLxpxn1CI2GWMSTUrIHM5\n uTrAJiYyLQOHgyq0IGIW1rn0X+UI2H0xsdGiZ99cQ0lyAGDzsTYRydH2LAsDg+rEbsz4\n 3Rdtpl1OsC4zF/YpmDpTLCAZwzGQdzsNykT7/TZ/4S18WZ6I8JroekLY7jLCmWYogVk4\n 4KnzyBmPOk6jeI+Om9Fo/q7Mni/MFgI4MglQd1qfPkTNDg6XW1pLMRpOvwO2pPSmvNqv\n TXPlXwz4TbIzh2TA34uIwOeRe54FsecS/WH4HnyCBqaPInODPymeGNjaEQeHkSPjkl4W\n PA8A==;\n darn=vger.kernel.org"],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=M5k8RptB; arc=pass smtp.client-ip=74.125.224.50","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776354107; x=1776958907;\n darn=vger.kernel.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=OCnOF4+nugCQPZVKQw/7phANXrJTt1mtYs1TJKi/ahA=;\n b=M5k8RptBKBQylc39mD81QB/Ke4Y2T/5tjiqNXhpXkt0/dgWorzOuzLv6/itt+uoQzw\n npwfwrOHsUzOkhTqp8KCP6oYr7LFjXTrUNzZNPgl2RUKmcjcs+ZxiewM4tzY4U/4qgLz\n 4L0wcCgYfKman6YI7/ynhgitzbc4oGWksbSKKt9aVdXGxkn7vjFyBpUNV9/Q+EUSNy5m\n XQ2qP8gWGH5Z85ixnlxrDaJc6VgC5zgOPMC1ybJwUBtiN2Ic2GMkJkyRW5XyMaR8YjPw\n H0MgDNkBqNsOaVKRNVkSSa/dZVSCmYmJ+rraev6g3BKgVrU2UgiiXULh/IvQDGNxNFBC\n 7mNw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776354107; x=1776958907;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=OCnOF4+nugCQPZVKQw/7phANXrJTt1mtYs1TJKi/ahA=;\n b=r416l2G0YWiWnr/z2I0OmoE/xCtRIOUM/oPzMIrQ8Jfr2xllMHu7g5zQQHcbcHq4Xw\n 2iHEmI6FRuVx/yepTRdbJxE5aYie39HufwoTEss6mqjtEVcurQEj+7SXf82f0TIuwtVe\n 2S2bR4Sah+wfDwPfndWZ9i519vnT4gr8PfSejFOszjWt3fosYqkaH22SVnqqqA1vJq/i\n /TXpE1TPmLr+MgS7PnfTPxoPbeg9YG3VFG3FsiCtJLfww01pCkWJAepx9MdasrKEE21S\n C8gga87OZQc9J0DD3NY8MTGO3HBdriAcl8jV4TYg/nmlQxJk9HMlPx6kK0UcSSdVuwkL\n jxCA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8HJJQYpWDwTjO1rAXCE5nPt0QRSSdl+RuDnAUjsjFoNlVLqkofwm9Fz8XmF6i30sjoy0oJI2PFLac=@vger.kernel.org","X-Gm-Message-State":"AOJu0YyZHZRixXbCZsiCRONgodMdXDOs9YjqnL+9qPltZzgCTvr/uy2W\n\t6jINB39AWAsUTEKKnwwJi77Ltg/PqNa0WbSZRa37rYLM6XsM3RqjGfPykrmCR+WJO8AzKRZjrYb\n\tM3xtpWpkDoX6jEEhxUu3UBScu6lgyxZY=","X-Gm-Gg":"AeBDietLRg7ux1JZ5Gzxy56RpmWnjOsTBne1Tr3t8qMYJgjFhJtnsFAuKi7MW2P42w6\n\tHsx9/9mQDaTiS77j1+Ljs/5qY3nNWc10469rkpFVUkwjaZpOu90J2YzdKx/rCWh+oCmUKsx2ifB\n\tA9qjz0+5gxNzPBEBFABSGUiSFdGkBL+0DXjgAza+BTjSDMgKe54mi1YnwLieljTODB0ZAM9M/wz\n\tWTvxHlREshj7V1eDJhzx+/vb+QaEnTk11au7Yw2s6JNVfQYxeNJSdOg7pDIcTMBOSdw7tCVW7Rm\n\tneIlaZ9deM4KvE1fof5HHYT4uWwuIHRJtlJcbQGoKuhkpO4mB3xL4U5m3PPJYVTF8JOc56QOkhB\n\tyc2jf","X-Received":"by 2002:a53:bc05:0:b0:650:814:8124 with SMTP id\n 956f58d0204a3-65198a88374mr18632177d50.17.1776354107448; Thu, 16 Apr 2026\n 08:41:47 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260416153524.1405955-1-chandrashekar.devegowda@intel.com>","In-Reply-To":"<20260416153524.1405955-1-chandrashekar.devegowda@intel.com>","From":"Luiz Augusto von Dentz ","Date":"Thu, 16 Apr 2026 11:41:36 -0400","X-Gm-Features":"AQROBzBjZjfRaING-KzrTi6Vvj06l3R7e7yZ4kftBDRWWzyE4CVrpze4YP2lhJE","Message-ID":"\n ","Subject":"Re: [PATCH v2] Bluetooth: btintel_pcie: Fix build error when\n CONFIG_ACPI is disabled","To":"Chandrashekar Devegowda ","Cc":"linux-bluetooth@vger.kernel.org, linux-pci@vger.kernel.org,\n\tbhelgaas@google.com, ravishankar.srivatsa@intel.com,\n\tchethan.tumkur.narayan@intel.com, kernel test robot ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}}]