[{"id":3678265,"web_url":"http://patchwork.ozlabs.org/comment/3678265/","msgid":"","list_archive_url":null,"date":"2026-04-16T15:48:02","subject":"Re: [PATCH v2] smb/client: fix chan_max and UNC state corruption in\n smb3_reconfigure","submitter":{"id":89563,"url":"http://patchwork.ozlabs.org/api/people/89563/","name":"Henrique Carvalho","email":"henrique.carvalho@suse.com"},"content":"Isn't this a policy change? If multichannel fails all the other changes\nup to that point are persisted (i.e. password change). Despite that, we\nwill be returning an error to the user, but have a state that we have no\nidea what actually happened. Did the password change fail? Did the\nmultichannel change fail?\n\nBefore we had a best-effort remount and after this change we will be\nhaving a partial success reported as failure.\n\nSo I would say that, for this change, if this is indeed a bug,\nno need for mchan_rc, roll back all the changes that happened during\nsmb3_reconfigure.\n\nFuthermore, we need to handle mchan update ses channels just like we do\nduring mount, because remount could end up being delayed the same way as\nmount, AFAICS. I have a patch for this with the series of that\nserialization smb3_update_ses_channels patch.","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256\n header.s=google header.b=WGQCPa21;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=104.64.211.4; helo=sin.lore.kernel.org;\n envelope-from=linux-cifs+bounces-10868-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com\n header.b=\"WGQCPa21\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.128.46","smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=suse.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=suse.com"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org [104.64.211.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxMqQ62CTz1yG9\n\tfor ; Fri, 17 Apr 2026 01:48:18 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 1EDF7300F29D\n\tfor ; Thu, 16 Apr 2026 15:48:16 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 99B9823182D;\n\tThu, 16 Apr 2026 15:48:12 +0000 (UTC)","from mail-wm1-f46.google.com (mail-wm1-f46.google.com\n [209.85.128.46])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 27B3219D093\n\tfor ; Thu, 16 Apr 2026 15:48:10 +0000 (UTC)","by mail-wm1-f46.google.com with SMTP id\n 5b1f17b1804b1-488b8bc6bc9so58361025e9.3\n for ;\n Thu, 16 Apr 2026 08:48:10 -0700 (PDT)","from precision ([2804:14c:61:8c96:217b:6bed:9d72:8046])\n by smtp.gmail.com with ESMTPSA id\n 71dfb90a1353d-56fa23b7a49sm132695e0c.17.2026.04.16.08.48.04\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 16 Apr 2026 08:48:08 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776354492; cv=none;\n b=J7auYTTLNdnA40p6d52B960frsEd8Mqvxr9F2ZNjQcVVSC5GsDH9tATdB2AlyrElQBH3JcBei2DUEm8FRHv+ubBc7Dm+BUWee8qxcYOhTIrY6Pl0nhd/PJzL61WlsS2yMmIuH/BjM2wBeCoeQp/IM9Qo2PHtNohqro/gS1OrzD0=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776354492; c=relaxed/simple;\n\tbh=hwZFhQIelvPFjAfHD5HdfNs20TZhFLZm708jedZ80rE=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=YV4OTV03UcS9f9CT6sL+or6wYQ9ZVXafgJAuIqmqBwMHRG/pnULLAtNOL0PWu3NAGG7+bomQmJ7V5+LeMB5V34wzJTVmpdI4ZN0S6cJX7Cv5j9BkDd2tyKlBXVkW7snuMBY5vTXCbIZwh8Mmw95MgY5H6qy6VwZUm8RSsIOiSO8=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=suse.com;\n spf=pass smtp.mailfrom=suse.com;\n dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com\n header.b=WGQCPa21; arc=none smtp.client-ip=209.85.128.46","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=suse.com; s=google; t=1776354489; x=1776959289;\n darn=vger.kernel.org;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=FkhH3vKqP4FUt7rWsyq+PlRfGLrYykKyfQpciwbqXv0=;\n b=WGQCPa21BspMOdjjGvSYfm/v+hZiRqpmerBy6Z79zIhFwqrmGfTkh1l1HI3Y4zLGau\n Nz6moh7nNCMhoEMjcK3wsLXUo14erKI5zVz3V+YQwbH49fJgpvRjI8HbjOfZT4wMrQ1/\n Y8MgRZh6lcaWLQyxKg72mOkRMIJaWqQxKzykD1bfXtZc1u/rPRG0Qh1+DPjPpaa2aKga\n hE26Sk1N6/nETU0HVBjKgvRaAcZlSaC5ycWBsNxpSiWAXUwvZYURh9J0dDW7jh+64oOm\n ijIrIf2XYXmgBbyixoRwdw4pPA9VxNRPG+HHPdZbfGjpBhMwXI1MI7eZwRMmvCp5Vabv\n MTiQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776354489; x=1776959289;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=FkhH3vKqP4FUt7rWsyq+PlRfGLrYykKyfQpciwbqXv0=;\n b=oroVTk6tDkELrL5e6p2LqLZOnUIP/OnyNrMufXN0zVypz5bgbwLsie61jkK8mMW2Au\n KioGIGoQY75xN8jzMcsFZR1o/i40vuaVrdJJttIeYct47ByWWOxZXYXavtAZ2Evgn55B\n VfqK4ycRJ6sLWAjosJKGXpV+ZkPbd+vFc6uJPNaNyi/KNg5Tz62cEKD5VWepQ+w+C7nx\n yDN/CO/ytXNl+Zw/PTHqbpO1mugLmm5qocFjlCg9OOvtB1eS2hgslGojCc9EC+/GVVoE\n GVpujMy/IyYbA10fU1juYfeCG3C8rZywNXAMQAnmDKKFifMs8ypanWONJvmphfyoxfzp\n NAdA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9vzfBxwzlhGrQ6s7IXSopTFivplLIj5Tkst0QytEnyj/I/2u23quUan5K1CmX7BiXs8Mc6GKbF91uL@vger.kernel.org","X-Gm-Message-State":"AOJu0YymuY6tXkNFMwj4uAl21THz4uw1WcEoyOV4uQNoWRbvcIFcNQ8g\n\t/YH3nzrfsv3t5TetbdrYQrr8dyirYZGIJUtSY02Qjv2F55oExiLJUyV4eVrlYzosl8Q=","X-Gm-Gg":"AeBDiev0US9VROCZLPf9YekDLE1a72k84ln7rKDVczEW4hN5mHHkXGhtiaEnxQgVRWm\n\tLlBYU7nEvfYyPtAD8c/Z8YIfLuQfm4P8HUE8G5/yxP6eK2U7/7FYwOwaUjJxuddE4SFLUwLd3Z9\n\tuKzo3yOvD4g/kRxv+0I33e9SBZPSxpB4JTLxZP9RfFeFunLhlHHDZ6vohESBsHDmnW8wnBHtWOW\n\t+UW1r7cyXfyy9i+oIhJZ8ztA5sMCX2xSwwNOVmPIR0VEo25wfULMry6gyOxF1b6VWDoCtm3gToG\n\tTckSzJ9ll76SPGhT6F+2+4r5I/DPvfEirblZV4rUVZfZ00E4UEoWQpJ6rgRK0NW4uCUgD79fIcJ\n\tYqQ3ZgsY20EOch7JsGEpNQtrSr7pB28bKB+QcAIg39z1Eg6vuLSh1GtxtoZ+8qC9ryVKPZlRy9s\n\t3rFueMkWmWPloJ7jjCdFdWNP0KS/KUZA==","X-Received":"by 2002:a05:600d:2:b0:485:9a50:3370 with SMTP id\n 5b1f17b1804b1-488d681f36amr289279475e9.8.1776354489349;\n Thu, 16 Apr 2026 08:48:09 -0700 (PDT)","Date":"Thu, 16 Apr 2026 12:48:02 -0300","From":"Henrique Carvalho ","To":"DaeMyung Kang ","Cc":"sfrench@samba.org, pc@manguebit.org, ronniesahlberg@gmail.com,\n\tsprasad@microsoft.com, tom@talpey.com, bharathsm@microsoft.com,\n\trajasimandalos@gmail.com, rajasimandal@microsoft.com,\n linux-cifs@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH v2] smb/client: fix chan_max and UNC state corruption in\n smb3_reconfigure","Message-ID":"","References":"<20260416022811.2692096-1-charsyam@gmail.com>\n <20260416151839.3315696-1-charsyam@gmail.com>","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260416151839.3315696-1-charsyam@gmail.com>"}}]