[{"id":3678246,"web_url":"http://patchwork.ozlabs.org/comment/3678246/","msgid":"<725334d3-4990-4d16-98b3-4aeac073478f@linaro.org>","list_archive_url":null,"date":"2026-04-16T15:19:31","subject":"Re: [PATCH v4 1/2] target/mips: Pass MemOpIdx argument to Linked\n Load/Store helpers","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 16/4/26 17:06, Philippe Mathieu-Daudé wrote:\n> In preparation of using the MemOp content in the next commit\n> (thus stopping ignoring it), pass it as MemOpIdx.\n> \n> The helper prototype declaration always took a TCGv_i32 as\n> last argument, correct that.\n> \n> Rename the ignored 'mem_idx' argument on user emulation.\n> \n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> target/mips/helper.h | 4 ++--\n> target/mips/tcg/ldst_helper.c | 5 ++++-\n> target/mips/tcg/translate.c | 7 ++++---\n> 3 files changed, 10 insertions(+), 6 deletions(-)\n\n\n> -#define OP_LD_ATOMIC(insn, ignored_memop) \\\n> +#define OP_LD_ATOMIC(insn, memop) \\\n> static inline void op_ld_##insn(TCGv ret, TCGv arg1, int mem_idx, \\\n> DisasContext *ctx) \\\n> { \\\n> - gen_helper_##insn(ret, tcg_env, arg1, tcg_constant_i32(mem_idx)); \\\n> + MemOpIdx oi = make_memop_idx(memop | MO_ALIGN, mem_idx); \\\n\nOops, MO_ALIGN is part of the following patch.\n\n> + gen_helper_##insn(ret, tcg_env, arg1, tcg_constant_i32(oi)); \\\n> }\n> #endif\n> OP_LD_ATOMIC(ll, mo_endian(ctx) | MO_SL);","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=CV6dtYYA;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxMCJ45Byz1yCv\n\tfor ; Fri, 17 Apr 2026 01:20:27 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDOVI-0003HP-6u; Thu, 16 Apr 2026 11:19:40 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wDOVF-0003Gw-Iz\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 11:19:37 -0400","from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wDOVD-0003UY-Tb\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 11:19:37 -0400","by mail-wm1-x32b.google.com with SMTP id\n 5b1f17b1804b1-488af96f6b2so107531865e9.0\n for ; Thu, 16 Apr 2026 08:19:35 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488f095ceeesm60522105e9.8.2026.04.16.08.19.32\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 16 Apr 2026 08:19:32 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776352774; x=1776957574; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=Cm9DhN9qeOqvJmzp7A+inBp61xXu7ErgVFtYcoKtPOk=;\n b=CV6dtYYAxrfO3ZPc9PzRQHABskxmY3Pl5rrTMqLR7W797JH2/nV1ZhbVD3RyeZsV5g\n yuKLmuSSPmaaEj27DSUXlAp8dYtY3j/pY7Xq3tfIejhNTACgTLRhtg35vSWZ0gP45i8+\n JqTJUuEWCFWk+t4PXRkTm0Cez3GeDGr+sxz8ED7ficuFNySqJmiCMDhQrF7hS5iwSJcv\n rG/UNZ5Oc21aZ8XXf8YDZ42bFXhpVOXF+Zl6u0DqyeE70X4/gR7+9RWdUySutBd9D303\n 8yim55hPLK19wdoOi+O1W0dysk6TuFVyWM5D7P6PllmU3iGzEWlHUywd10oChvvOpLN0\n ISGw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776352774; x=1776957574;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=Cm9DhN9qeOqvJmzp7A+inBp61xXu7ErgVFtYcoKtPOk=;\n b=SoKziJrKIBr/yCq8etyWkeEwG3wqsaj4W55YpvvaqcfCtiVJdKuJLn3OYC7Op0tKcv\n OWpMoo07rLEnKzfnuLbgBxRlCAnJwFPeKksE/0R17BlyhquUP7z2gpKGQ7VcwalRczC6\n /0DuSfnu5myQrGXlnKcU7rdU9xHtkHc0j2V3aRYH3ca6CbaEGGLSPjR0REencdJ6hKJW\n qMmd4R/GhU+enAhIZRtZ2f4zsWUDpycmXglfBr2RQGAdeYhxXg6g99XMnzdU3jAna2xE\n SBgkrI3osNxO+MdwYbUk63BJP1p+BNJJD/AT80ZZJSR4LZb5LHXZqIWDLysuft1p6P3I\n FxVg==","X-Gm-Message-State":"AOJu0YzJjs4FMlHX4zaZZ2QKe0gdhlb0Kd8ClctB7M5uY3setSHebshX\n Fe7oHlFRU10+UWAcFEppo40m+Ew0oGgvgEupH6LZ3pvfaDJ+LXB1AV37VuB4Abz8lCwFbYEqjk4\n toXKyIdo=","X-Gm-Gg":"AeBDieuCGd7T1XspiN+ryugTff7T4tF+26ZUZRWf6ruW5tgry14FLC1CP6A4CoSU28b\n 9rwdTQ2VllXh7GMiG0ct3FRDc//0xnykw6EIB+BAhBGADfKwFwFu/1OGGaalc9b5G1SEzt4ShIN\n cX5Xp6FKqVc6JlEbc26svMxrYC0dfBR24zzG1FBEOlYEmsW9zAs2aqe7MPueawrI0ut9JxXnlXZ\n 2cM5sBRk0mdkHGkuK7A1+q1067iT2rUvctvuG3QfzHADXz8TIOD7TfUZEr6t5cljVqHZsCBoeVg\n n0LPSRHlsN0MGrHsl0vg0PGUU5CmrIeCk/VpKGnLkmTJVlCJKd7eNCo3qtdKdnW4Bmk4fa9KtNl\n bnMtdSiGHyIiFnyuEHSxDY1F1RHNyAfL1c/qtJCu2Zsp6GPtNnVF9RVB51nu0ByhWgWlLgpgJZ6\n ul6nWvYu5E2BPVZQhWcPr0wVsE+q8EI65BcM9O/vLqHsvAdGiLt8i0y8X3OXRSuk1vUA==","X-Received":"by 2002:a05:600c:8904:b0:488:c257:a73b with SMTP id\n 5b1f17b1804b1-488d67effd0mr248706635e9.9.1776352773647;\n Thu, 16 Apr 2026 08:19:33 -0700 (PDT)","Message-ID":"<725334d3-4990-4d16-98b3-4aeac073478f@linaro.org>","Date":"Thu, 16 Apr 2026 17:19:31 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v4 1/2] target/mips: Pass MemOpIdx argument to Linked\n Load/Store helpers","To":"qemu-devel@nongnu.org","Cc":"Jiaxun Yang ,\n Aleksandar Rikalo ,\n Richard Henderson ,\n Aurelien Jarno ","References":"<20260416150649.23671-1-philmd@linaro.org>\n <20260416150649.23671-2-philmd@linaro.org>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Content-Language":"en-US","In-Reply-To":"<20260416150649.23671-2-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32b;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]