[{"id":3678260,"web_url":"http://patchwork.ozlabs.org/comment/3678260/","msgid":"<20260416153437.4144-1-linuxtestproject.agent@gmail.com>","list_archive_url":null,"date":"2026-04-16T15:34:37","subject":"Re: [LTP] lib: add safe macros for stream testing suite","submitter":{"id":93132,"url":"http://patchwork.ozlabs.org/api/people/93132/","name":null,"email":"linuxtestproject.agent@gmail.com"},"content":"Hi Andrea,\n\n--- [PATCH 3/7] ---\n\nOn Thu, 16 Apr 2026 16:33:37 +0200, Andrea Cervesato wrote:\n> lib: add TST_EXP_PASS_PTR_NULL() macro\n\nThis lib commit is sandwiched between stream01 and stream02 test commits.\nAll library helper additions should come before the test rewrites that\ndepend on them.\n\n--- [PATCH 5/7] ---\n\nOn Thu, 16 Apr 2026 16:33:39 +0200, Andrea Cervesato wrote:\n> fs: rewrite stream03 test using new API\n\n> +\trewind(stream);\n> +\tTST_EXP_EQ_LI(SAFE_FTELL(stream), SEEK_SET);\n\nSEEK_SET is a whence-direction constant (== 0), not a byte offset.\nUse 0 here instead.\n\n---\nNote:\n\nOur agent completed the review of the patch. The full review can be\nfound at: https://patchwork.ozlabs.org/project/ltp/list/?series=500172\n\nThe agent can sometimes produce false positives although often its\nfindings are genuine. If you find issues with the review, please\ncomment this email or ignore the suggestions.\n\nRegards,\nLTP AI Reviewer","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=h7AkOoYL;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=213.254.12.146; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [213.254.12.146])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxMWr1ylWz1yG9\n\tfor ; Fri, 17 Apr 2026 01:34:48 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 44BA93E5B60\n\tfor ; Thu, 16 Apr 2026 17:34:45 +0200 (CEST)","from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::5])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id F20563E1BDF\n for ; Thu, 16 Apr 2026 17:34:41 +0200 (CEST)","from mail-dy1-x1341.google.com (mail-dy1-x1341.google.com\n [IPv6:2607:f8b0:4864:20::1341])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-5.smtp.seeweb.it (Postfix) with ESMTPS id 120FC60046A\n for ; Thu, 16 Apr 2026 17:34:41 +0200 (CEST)","by mail-dy1-x1341.google.com with SMTP id\n 5a478bee46e88-2d891442388so8410070eec.0\n for ; Thu, 16 Apr 2026 08:34:40 -0700 (PDT)","from\n runnervm35a4x.c41v2zfaraieda3n4uxiuojluc.phxx.internal.cloudapp.net\n ([20.168.108.231]) by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2de8fa5f221sm7758497eec.27.2026.04.16.08.34.38\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 16 Apr 2026 08:34:38 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776353679; x=1776958479; darn=lists.linux.it;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=UY2Prq3r54qJWFQNr36iLLX09R9j4zJWV56xIeOfnvo=;\n b=h7AkOoYLgJOJaiTeJnUFdIGXM36j0/tsi4KX74QPzEHo7J5y/GW9S2oB3faEAYRKCf\n yZ6UJ/gtjmzfJM3VDQ0JiZrqxQDnil+DTaNEYyY4fh/pnNVALmYnaOLy8WzllH+qtnB7\n u3IDAJSoqiMuRBgtJr47WV5dE5TvosGS8+LjHsgw1EG3LHpjDBM4MujX0soGT868BSiy\n HY6VE/8pB5VCSsScevEYAWJq3OupZ1YELOQYQGzvPf0wkE/mgOMfQs2H6SumtZrM6wNK\n W9CBgaUrI9Jz8WE0MAveKUWRto/XAKsbxOLUC/avdmSiwWA/6I1rtr7arQwTZ8v/tvUr\n S/4g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776353679; x=1776958479;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=UY2Prq3r54qJWFQNr36iLLX09R9j4zJWV56xIeOfnvo=;\n b=UjxTfdUh4XP+ey5fcom1l6gY9wGwC2VJ4LF8gS9LoY1RArijZhbh+8uFEBgA6c/sky\n uMYDapPUOfdDfy88+oIkBIVPYqcWv2FpaY4fEXXZe2NbhrL7kfn92LPNg1GTlMtJUSBh\n oW1JQTA75FOxZZ6VkECsvHcrKiUZqyilC5fgrghnS0+/Ln/lOSFnIgOVziL5Z1ZuJgUx\n qGPTC4MilLHfA//ZYLbwwUvX7vxG0gdJSpsAgZq7vWPNkQFULQ/SLIg7Y+fioFBm/f6U\n 5TgSVcq68Mrfpl1asvLwW4nN8t0W/msFOTMm6fN10Mc1w+fepTBDkdt8FdsZQcxRBdjk\n eL/A==","X-Gm-Message-State":"AOJu0YxHpYbGxyEL7IPf84FgaQbRfgrU8n5qIqDnzaJOVHW2tiMBRI6e\n gYqJ5CdIUIWdZfXYtMHStYssS4iy6mcDUZxJ+FCvl6SauUjh+fFzSWg+7M80DN3Dr5Q=","X-Gm-Gg":"AeBDievHl/OZC2Q6atrk86wU1v5FByf1kOSD37mDIUh+LRvX23BAlpm/hjbl7pRcRxd\n dWvxXb+idr7ZLIAUKYex5aNIFOg9nE7VgxxNhJXlpLU0/N3CmuELLB8lsMdYUvwVG2ebn6EAQoL\n x1+Wu14NjPBmOPmc1RLYW0jx1Pd+Cao5V0BaXacIf3AuMlOMMEzrHsZKhpu98MluIpmAcf7nPxA\n 9WGS1XQZwBOoy9SV02vkGYZCGc7exL8l0aoD+HMj1PTN4XJSVbYp9d6rfT6rLXaiArj4lZXVHP6\n 0+K7rAKPYmoXoPtIGG6YfYkv5BMTXfc3hNRlZJEiMl0V03LozWg/MctQuaN8BJlkcMELufqU4Zi\n pNL8Ia4DD0K9Edn3dcbzKUZ5uZbq4tPKlAeS2YE7WuPJcxPRqMn1AJXxvygyo09Y9XFMydEiqic\n eiPPXVUs8NWIg2cvFZ9paMigSJUy9K0EIfgnnUl5sJwB334AfTM9qt7u3nWL2jaUAeNchLpiGgY\n R1XbrA1DivjnSGAQTa3Fzz2n1x1la+v0UDU7LwR+uw=","X-Received":"by 2002:a05:693c:2c85:b0:2be:6f30:f2f9 with SMTP id\n 5a478bee46e88-2d58a39d35dmr17037088eec.26.1776353679253;\n Thu, 16 Apr 2026 08:34:39 -0700 (PDT)","From":"linuxtestproject.agent@gmail.com","To":"Andrea Cervesato ","Date":"Thu, 16 Apr 2026 15:34:37 +0000","Message-ID":"<20260416153437.4144-1-linuxtestproject.agent@gmail.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260416-stream_refactoring-v2-1-8321b1ec6f68@suse.com>","References":"<20260416-stream_refactoring-v2-1-8321b1ec6f68@suse.com>","MIME-Version":"1.0","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS\n shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-5.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-5.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] lib: add safe macros for stream testing suite","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]