[{"id":3678710,"web_url":"http://patchwork.ozlabs.org/comment/3678710/","msgid":"","list_archive_url":null,"date":"2026-04-16T20:54:23","subject":"Re: [PATCH v3 08/10] mach-snapdragon: Add commands to create wrapper\n ELF","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Varadarajan,\n\nOn 2026-04-16T05:39:18, Varadarajan Narayanan\n wrote:\n> mach-snapdragon: Add commands to create wrapper ELF\n>\n> The IPQ5210 boot ROM expects the SPL binary image to be embedded within\n> an ELF along with additional binaries. Hence add the relevant commands\n> and linker script needed to convert u-boot-spl.bin to the expected\n> format.\n>\n> Signed-off-by: Varadarajan Narayanan \n>\n> arch/arm/mach-snapdragon/Kconfig | 7 +++++++\n> arch/arm/mach-snapdragon/ipq5210-spl-wrap-elf.lds | 18 +++++++++++++++++\n> scripts/Makefile.xpl | 24 +++++++++++++++++++++++\n> 3 files changed, 49 insertions(+)\n\n> +ifeq ($(CONFIG_ARCH_SNAPDRAGON),y)\n> +INPUTS-$(CONFIG_SPL_WRAPPER_ELF) += spl/u-boot-spl.wrap-elf\n> +endif\n\nPlease can you use $(obj)/$(SPL_BIN).wrap-elf here to follow the\nconvention used elsewhere in this file. The hardcoded path would break\nout-of-tree builds.\n\n> +/*\n> + * SPDX-License-Identifier: GPL-2.0\n\nU-Boot convention for new files is GPL-2.0+ - is that OK, or do you need 2.0 ?\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=K63m0mLp;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"K63m0mLp\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxvln28bzz1yCv\n\tfor ; Fri, 17 Apr 2026 22:47:01 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 902AB84372;\n\tFri, 17 Apr 2026 14:44:05 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id D9CEE8407E; Thu, 16 Apr 2026 22:54:40 +0200 (CEST)","from mail-ed1-x531.google.com (mail-ed1-x531.google.com\n [IPv6:2a00:1450:4864:20::531])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id BBD4E83EEF\n for ; Thu, 16 Apr 2026 22:54:38 +0200 (CEST)","by mail-ed1-x531.google.com with SMTP id\n 4fb4d7f45d1cf-672bd8d2400so345859a12.1\n for ; Thu, 16 Apr 2026 13:54:38 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776372878; cv=none;\n d=google.com; s=arc-20240605;\n b=hs9OAO+bSvT+JLTYWZq5V9ovG4oFUA9X1yZxdk9/UbzDWXZIUK1xyB/pRh7ZBWRimy\n 1pxoj+38j3VfvXC1ZZ42IHfBd+n3TGb09MfCAArRDfXfNS/lg//7qzFpuXjBJ+Qxhq5W\n QYfJZO3VDP1IVaNFxsF3fEAE9vYypxfecf957kzDVEuMAUr0f9pg/L2kQPA18eSzcwd8\n TN282nQObC+QQpXJjxWxPV6bqsl3uXn1IJ83tDZDsUhouWYZdLjMgi0yzlqp7qEBvSwP\n FAZXlN2yfiMKK2gawBRREmrpWeC56Dx3LUPuGLNf+qKqTtlrgQFKhjFL0xp+j6lZC3Vn\n aKrQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=Pl5bX6YwBr6/FuDLad5VR93gR+g5Q8i5dDrIKwXLKjI=;\n fh=Xs636b9cxoz7QiX8lA0xHfFF4N8UAO0T7pnns8a2EOs=;\n b=IL2bYstsyy1EtF9I2+kW44xA2J93c+XSuCRPG/Vm8xK1otfeYhp4/5whVhUSNQnw8d\n ki2jvnBTIcS+QvPZb5MnnMGpQW4kvJpZs5wvoqGUE4SOWrYb2E5V8B66N/L3gpt6E0wZ\n i36B22I32gkLWg6VpAUVOzPn3yNqj/kPJXu0HhzBPLZ8Eg1CreHcvqvUy4Fawp3OnVmt\n /uIz4AA7RZt+WcxFehKfTzSCK31PY+RP13TAl45RDdbnt6ws9Gm9gv9r80hkqIRuMlbP\n SyhytpXVKFyL5cF0nURDgJJTr+/rI0Neklye9SAbtiTMxD10lOIHTNx1kh2Di88Uafcd\n CSKQ==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776372878; x=1776977678; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=Pl5bX6YwBr6/FuDLad5VR93gR+g5Q8i5dDrIKwXLKjI=;\n b=K63m0mLpDs0SLP898ZrbOoKod+4EveezxAgY4yLP7yZsW9ze5VUDz/ZVYO32/k9h+l\n KfpA0pbKmg8xmL0aLUbC+YCj9JQv8bW+y5SXe2slXhUYnlTzOMJRSBqTD4iOc8yBj0Yt\n Dp91sKEOJ9motRZH4Z4ExW6vhJoZEcmwRZGpw=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776372878; x=1776977678;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Pl5bX6YwBr6/FuDLad5VR93gR+g5Q8i5dDrIKwXLKjI=;\n b=khfoXs4vkpx8L/fxDQVmCEm/63DI0ILPfB8reEO/VIYiDcIHmhn+lRDBEX1qSi3wPO\n 3j5m38DmlOTEJMtV7A0h8ehVUkDi0DihUEEhgo5JDEvuGhj7QTdbQjPpc8bWvNkQ1Who\n suE5iPpMQczqKSJW9KUM5azuusvFbD1H81ll/OBG+rgBzx63Me1OWExkZKyyBcG6A0lE\n QEDwZ8LpyNcdrkI9IqGdoZt4nI15rUyd6eYsVnceQ9q+qe2VytrChqj1MRInVNCGF0wS\n baJC3Bb78e+ai/YchxEPF7opmQWSf0PGr+s4oW8jwEoHhZP3Vy+cuY2DqUOa/ZjDLL/7\n GL8A==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/Zrv3z0NvLvv6o6Ub2oelYBk5uLTK3qUnc/3bCQ6Lbue4ENHZcPjkJg2zbcuqKdYjmECsZfFM=@lists.denx.de","X-Gm-Message-State":"AOJu0YwqgonYHVVfEbzqVPXzduudlk1JWcUhrxAE8P14uxb25zGnruOd\n 91wrTwt4eh+R3WT26b25+5b7eWrQtKbm2ihPhF+v54H6uFGK/RNoQPiy9yysWDZCH97NSx2dQvD\n 5IPIwlItmFRFnl67qTiryb5KnvwWQXNmp+UChi9Td","X-Gm-Gg":"AeBDieu9Ze8WEb6AwAcUPQNs9b2nXywpYzWI+SEl23po46zjsaGp8XDb+oS5ybq1kwa\n L+wPD/Oaz24rKLigY9FaEZBKvGYTCSecT7qNmlttHDlQ6ciC/PRZRVCxELucPiU6ATmKInXr8eN\n eH0ocQS8qSQr+YO9ZAzOi4XUtqfqhishmcbLijjZkI3mB3fsusbwXamYL4sYUaU+7yH37spIN9K\n JMDAaMpzHsjmLSITLyGqqro7xqMjAN0gy8QziZTRGSnvfd9hB5a6hGK4IqVMNZpm7fl323MwnUr\n NjhIuZiG97uxfqDJ2+7j","X-Received":"by 2002:a17:907:a60b:b0:b9c:b069:8ab6 with SMTP id\n a640c23a62f3a-ba418b7e7d6mr5761466b.7.1776372878070; Thu, 16 Apr 2026\n 13:54:38 -0700 (PDT)","MIME-Version":"1.0","References":"<20260416053928.2834699-1-varadarajan.narayanan@oss.qualcomm.com>\n <20260416053928.2834699-9-varadarajan.narayanan@oss.qualcomm.com>","In-Reply-To":"<20260416053928.2834699-9-varadarajan.narayanan@oss.qualcomm.com>","From":"Simon Glass ","Date":"Fri, 17 Apr 2026 08:54:23 +1200","X-Gm-Features":"AQROBzD_VkL-V5Lsqku1jH6RE7RoNCXuzgriUM9bQDUK323GAvxrCrkqFXBTY1I","Message-ID":"\n ","Subject":"Re: [PATCH v3 08/10] mach-snapdragon: Add commands to create wrapper\n ELF","To":"varadarajan.narayanan@oss.qualcomm.com","Cc":"rayagonda.kokatanur@broadcom.com, trini@konsulko.com,\n casey.connolly@linaro.org, neil.armstrong@linaro.org, sumit.garg@kernel.org,\n peng.fan@nxp.com, jh80.chung@samsung.com, lukma@denx.de,\n tien.fong.chee@altera.com, tingting.meng@altera.com, anshuld@ti.com,\n alif.zakuan.yuslaimi@altera.com, alice.guo@nxp.com, quentin.schulz@cherry.de,\n ilias.apalodimas@linaro.org, sjg@chromium.org, mkorpershoek@kernel.org,\n h-salunke@ti.com, alchark@gmail.com, dario.binacchi@amarulasolutions.com,\n ye.li@nxp.com, andre.przywara@arm.com, dinesh.maniyam@altera.com,\n luca.weiss@fairphone.com, danila@jiaxyga.com, aswin.murugan@oss.qualcomm.com,\n balaji.selvanathan@oss.qualcomm.com, adrian@mainlining.org, n-francis@ti.com,\n wens@kernel.org, jamie.gibbons@microchip.com, justin@tidylabs.net,\n ycliang@andestech.com, david.wronek@mainlining.org,\n james.hilliard1@gmail.com,\n richard.genoud@bootlin.com, michael@amarulasolutions.com,\n philip.molloy@analog.com, sughosh.ganu@arm.com, u-boot@lists.denx.de,\n u-boot-qcom@groups.io","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailman-Approved-At":"Fri, 17 Apr 2026 14:43:59 +0200","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]