[{"id":3678709,"web_url":"http://patchwork.ozlabs.org/comment/3678709/","msgid":"","list_archive_url":null,"date":"2026-04-16T20:54:05","subject":"Re: [PATCH v3 07/10] mach-snapdragon: spl: Update SMEM with boot\n details","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Varadarajan,\n\nOn 2026-04-16T05:39:18, Varadarajan Narayanan\n wrote:\n> mach-snapdragon: spl: Update SMEM with boot details\n>\n> Update SMEM with the storage medium from which the system booted.\n>\n> Signed-off-by: Varadarajan Narayanan \n>\n> arch/arm/mach-snapdragon/spl.c | 65 ++++++++++++++++++++++++++++++++++++++++++\n> include/smem.h | 3 ++\n> 2 files changed, 68 insertions(+)\n\n> + if (IS_ENABLED(CONFIG_SPL_MMC))\n> + *fltype = SMEM_BOOT_MMC_FLASH;\n> + return 0;\n> +}\n\nIf CONFIG_SPL_MMC is not enabled, fltype is left uninitialised. The\nfunction should either set a default value or return an error when no\nboot medium matches.\n\n> +}\n> +#endif /* IS_ENABLED(CONFIG_SPL_SMEM) */\n> +/**\n\nMissing blank line between the #endif and the next function comment.\n\n> +void spl_board_prepare_for_boot(void)\n> +{\n> + int ret;\n> +\n> + /*\n> + * Populate SMEM in coldboot (Dload bit not set)\n> + */\n> + if (!QCOM_SPL_IS_DLOAD_BIT_SET) {\n> + printf(\"Populating SMEM\\n\");\n\nThis printf() is user-visible during every coldboot - try log_debug() etc.\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=I3MRrME3;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"I3MRrME3\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxvlb4kdvz1yCv\n\tfor ; Fri, 17 Apr 2026 22:46:51 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 557C084368;\n\tFri, 17 Apr 2026 14:44:05 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 1B7E88407E; Thu, 16 Apr 2026 22:54:21 +0200 (CEST)","from mail-ej1-x636.google.com (mail-ej1-x636.google.com\n [IPv6:2a00:1450:4864:20::636])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 899A283EEF\n for ; Thu, 16 Apr 2026 22:54:18 +0200 (CEST)","by mail-ej1-x636.google.com with SMTP id\n a640c23a62f3a-b9c745e18a0so3470566b.1\n for ; Thu, 16 Apr 2026 13:54:18 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776372858; cv=none;\n d=google.com; s=arc-20240605;\n b=TxTwGuJuu7Bv+Kiws9PRyNQoNPskTD9hqa8BITnF2/JPLQJY1K/UrjgyFEMREbj/Qe\n XMP5pnauJGsm0z/0C/2SDKeglyp8dPx4PTlqHBYPubAdFtaZmqpGS5Pjzfl/L43sJcdL\n zPPbVlHfaiYfjOrGMu7F/EzEzLlwNXoeMUuz6cdUdBbfBURMl6xBM7/ZNCsUbD9p70Te\n 2m3Sn0TNISk3igR+CI0EGB1hK0hnkafjVDabdoGrMcGgaAvVZcN54DxWreIpiGoFEXyc\n nYTt89xjRfyn3FPY8s/9nEFojRPauZAWlnCc834GCrxy+AMz4cAwIf9O88aSaGJqzg0w\n 5AYA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=2cCOY6qlTIZNLRiUAOtWtSm5VVh9LTxPa1jSFexVE+0=;\n fh=qhe+P1zBU0548ejKTaXQcQfiQCbxOitDwCoR2S/jUHY=;\n b=WgkBx4NkAU8prGizpXndkFBcFYowQ0CxfRMRQrelvHl4/2KOsGqmOXN2LxCDs/rmT5\n 0OO0AkcbEBnmgaiNnZNs/FItu+3mULV6EYfXEQ5SHgLtxyLcbJRkQ6xigVrNVrA/kIet\n 1kHTewHH0asWFjPRc9pZc0zG1j8DtGuljdQ40okNhAyr0Zz9lv1H7TaU75rMteSs87Wr\n SQ90KjXqVlblPZOvssLs5fyMNASUI779++JakV2R+5WeAGskEnOKmjUW+QrtX6xZIGA7\n FDSqAKHKluAjOMz1eCjJKbTvb+Y8eSyoNk+9klXG9dMUKc1Z0kkRhTPfi1U03dWg2BW1\n mD0Q==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776372858; x=1776977658; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=2cCOY6qlTIZNLRiUAOtWtSm5VVh9LTxPa1jSFexVE+0=;\n b=I3MRrME3iroLcmFmeAmlJyKe+J+0dLBYYqkZo/c9HEtJ6ARCDT3LWp5pK79ADCpr85\n kn80C6YzeRCsZ3zPUgbLh1xYIXiMJN1a6G29R9rNuxdxF1mlY5PNfj9II3AlWmep/EjD\n LLW2NY/DsNvzIA+G6J/nxnLyOTglhbbrD6KjU=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776372858; x=1776977658;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=2cCOY6qlTIZNLRiUAOtWtSm5VVh9LTxPa1jSFexVE+0=;\n b=IWuvaDOn0lRl63/rGqcYNuxnShcHJlhYobDh1b6PR3cdRaK+uLf8NB6yJTZTHJa5yr\n 435OG3r5W7IFjAo1p8BOg855hredCdX3O0lV97XALH7dHU0s/HAI17mxdjS4jIGsCAaA\n Vi5+GXQEuCBkTEI7qsqefx/pFAauW2ZGMmG0J/oivX89n9U9HnlHWYUCNREFXtLpnDgS\n 9Mtr5178RLUgnMJWwA04+cjIg46T6/jj3n03L6IzX9UvPMxlNfDQ5VtYjIqqIQpqw1Ib\n h2tEUWF16LBL2cLVzmDBbA87PkhpJfL3ZRaUN2FChwRzAQ6AQbBI8s70T7f+dFxv171N\n qPqw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ//4XivdQ7dMfHYDTuQjk43ICMUZkzxGrx/PxAsom1iZuawy/iIhdNwNLEEYCy2Gt0NRilQjdE=@lists.denx.de","X-Gm-Message-State":"AOJu0YyCBeQFq/UllaOKOHbqBX2b6Uy6AIAnc99JBOyhA0INHi+ngm6l\n ef9bO2OTBowPfIQnrmqHFGDEOqtAeBpLAbpLvgq6fEjt8CsGO8FAswt82jHZHdGnwUvm/IZDgW3\n eVjs+clXD/DWb6TlyYzRLIo/d3O0uH1By7+SAQl7J","X-Gm-Gg":"AeBDievEGSSMKiXJ8nht+lL+P4tG2b+iirU97nGk5k5lt++0VwnIvJV+CMfzEz8qGqT\n jj4MxoIXG3LCqcUP/BT9Bruf9mVOMjsF+Nbl6wymMr4fn3irfexecSsV5jJqhOi2tsBjOaGcsx3\n r861ATgVi34m6taMPLF5E5tsV9eK55RGkjAC1/eflnB2GAk+4FEl/8wiD12YkHDvnR8ibZJ+jRE\n 4aq+P1hY10FQocLJp2XwAp9XCr7MimJ/SEc3hf9fu06uutRHyRTg4r9+KxA2mJ54hEUMMkyiMEp\n JLbyu+V/hzYG9P4tscIf","X-Received":"by 2002:a17:907:a088:b0:ba0:9335:b133 with SMTP id\n a640c23a62f3a-ba422add0eamr98466b.11.1776372857908; Thu, 16 Apr 2026 13:54:17\n -0700 (PDT)","MIME-Version":"1.0","References":"<20260416053928.2834699-1-varadarajan.narayanan@oss.qualcomm.com>\n <20260416053928.2834699-8-varadarajan.narayanan@oss.qualcomm.com>","In-Reply-To":"<20260416053928.2834699-8-varadarajan.narayanan@oss.qualcomm.com>","From":"Simon Glass ","Date":"Fri, 17 Apr 2026 08:54:05 +1200","X-Gm-Features":"AQROBzDgqrrAsvIk3ZLUZBoNK1ElplIj1h2MmRPITeUsVAx6l-y86UZI8fSDO6U","Message-ID":"\n ","Subject":"Re: [PATCH v3 07/10] mach-snapdragon: spl: Update SMEM with boot\n details","To":"varadarajan.narayanan@oss.qualcomm.com","Cc":"rayagonda.kokatanur@broadcom.com, trini@konsulko.com,\n casey.connolly@linaro.org, neil.armstrong@linaro.org, sumit.garg@kernel.org,\n peng.fan@nxp.com, jh80.chung@samsung.com, lukma@denx.de,\n tien.fong.chee@altera.com, tingting.meng@altera.com, anshuld@ti.com,\n alif.zakuan.yuslaimi@altera.com, alice.guo@nxp.com, quentin.schulz@cherry.de,\n ilias.apalodimas@linaro.org, sjg@chromium.org, mkorpershoek@kernel.org,\n h-salunke@ti.com, alchark@gmail.com, dario.binacchi@amarulasolutions.com,\n ye.li@nxp.com, andre.przywara@arm.com, dinesh.maniyam@altera.com,\n luca.weiss@fairphone.com, danila@jiaxyga.com, aswin.murugan@oss.qualcomm.com,\n balaji.selvanathan@oss.qualcomm.com, adrian@mainlining.org, n-francis@ti.com,\n wens@kernel.org, jamie.gibbons@microchip.com, justin@tidylabs.net,\n ycliang@andestech.com, david.wronek@mainlining.org,\n james.hilliard1@gmail.com,\n richard.genoud@bootlin.com, michael@amarulasolutions.com,\n philip.molloy@analog.com, sughosh.ganu@arm.com, u-boot@lists.denx.de,\n u-boot-qcom@groups.io","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailman-Approved-At":"Fri, 17 Apr 2026 14:43:59 +0200","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]