[{"id":3678707,"web_url":"http://patchwork.ozlabs.org/comment/3678707/","msgid":"","list_archive_url":null,"date":"2026-04-16T20:53:22","subject":"Re: [PATCH v3 04/10] misc: qcom_geni: Add minicore support","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Varadarajan,\n\nOn 2026-04-16T05:39:18, Varadarajan Narayanan\n wrote:\n> misc: qcom_geni: Add minicore support\n>\n> The qcom_geni driver reads an ELF from storage and configures a set of\n> registers and programs the firmware to the GENI Serial Engine (GENI-SE)\n> wrapper device for the expected functionality.\n>\n> Unlike the GENI-SE wrapper found in MSM SoCs, the IPQ5210's GENI-SE\n> wrapper is pre-configured for one of the functions defined in 'enum\n> geni_se_protocol_type'. Hence, the firmware download is not needed.\n> Only the register configuration part is needed.\n>\n> Earlier, the boot stages before U-Boot would configure the GENI-SE (to\n> access UART/SPI etc). Since for IPQ5210 U-Boot SPL, the previous stage\n> (i.e. boot ROM) doesn't do that modify the driver to do the register\n> configuration part alone without reading an ELF from the storage.\n>\n> Signed-off-by: Varadarajan Narayanan \n>\n> drivers/misc/Kconfig | 6 +++\n> drivers/misc/Makefile | 1 +\n> drivers/misc/qcom_geni-minicore.c | 102 ++++++++++++++++++++++++++++++++++++++\n> drivers/misc/qcom_geni.c | 94 ++++++++++++++++++++++++++++++-----\n> include/soc/qcom/geni-se.h | 2 +\n> include/soc/qcom/qup-fw-load.h | 15 ++++++\n> 6 files changed, 208 insertions(+), 12 deletions(-)\n\n> +config QCOM_GENI_MINICORE\n> + bool \"Support minicores in Qualcomm Generic Interface (GENI) driver\"\n> + depends on QCOM_GENI\n> + help\n> + Enable support for minicores in Qualcomm GENI and it's peripherals.\n\nits\n\n> + } else if (IS_ENABLED(CONFIG_QCOM_GENI_MINICORE)) {\n> + struct qup_mini_core_info *qmc = info;\n> +\n> + for (; qmc->serial_protocol != GENI_SE_INVALID_PROTO; qmc++)\n> + if (qmc->serial_protocol == rsc->protocol)\n> + break;\n> +\n> + tmp_hdr.magic = MAGIC_NUM_SE;\n\nPlease add an error return when no matching protocol is found.\n\n> +#define QUPV3_SE_HW_PARAM_2 0xe2c\n> +#define GENI_USE_MINICORES BIT(12)\n\nSE_HW_PARAM_2 is already added in geni-se.h in this same patch - maybe\nuse the one in geni-se.h and move the GENI_USE_MINICORES definition\nthere as well?\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=dtVdbNMm;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"dtVdbNMm\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxvlF6Nnwz1yCv\n\tfor ; Fri, 17 Apr 2026 22:46:33 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id CE39384353;\n\tFri, 17 Apr 2026 14:44:04 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 00B748407E; Thu, 16 Apr 2026 22:53:38 +0200 (CEST)","from mail-ej1-x633.google.com (mail-ej1-x633.google.com\n [IPv6:2a00:1450:4864:20::633])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 3B0A783EEF\n for ; Thu, 16 Apr 2026 22:53:35 +0200 (CEST)","by mail-ej1-x633.google.com with SMTP id\n a640c23a62f3a-b8f9568e074so2620366b.0\n for ; Thu, 16 Apr 2026 13:53:35 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776372815; cv=none;\n d=google.com; s=arc-20240605;\n b=L47EMcUuv+WBzhGt9I5deNKGE9Y07aDbQ1aaJdtkLQn2bhrSnrViUu2cIMOUcRz5dA\n aM1Bacy9L7wMlrv20yJjTVG9gw3bc0Hd/IBDK1C+axLNHOTigh2R55TsA9W+asPDa1vF\n ihoq35pErbvoWpWyK67ciJxjK3SO4A/u0qyiZVjDzmAPWdSBdLbD4p5cHHjT3O2wDjbm\n ggZPmHbNnaC5t5YEdppQ5CSkrEvPIQkH+vClvLnif7FvfAhmjjLlvXgEiuHADN60GbwX\n lkM6q8j9xPHDokIwBVoqkFdgh6ojWj4SyXveWmwBN2uCWtxQe/ZIQetyR8+ij7Hew7CQ\n FIOw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=gu4feCICSDPImOCHAm02vNn9Z4WEP3cVTBxFGL2ZEGc=;\n fh=hHTO6f4nuEnxFL3rCec6fxwnC5MEplwuDaj8wiynJ0E=;\n b=DpwwqRUMNj6g8tC7zph4e0vF5ZF3Nz97d2v0ALdyuLZzEdsCzZJOPYX5QpyGYLyg0A\n pzPxQQ0KXzg3BS0cKlWoNKzJVrNzeLWcGXA8A/qn4rXCv9Ao7Iyf6iShg6exWI6jtE4t\n DM+mRikKgoga0mphoHx9L2cTvCeKB9bjZf0VNKum0Aw+OSSO2URnEMpiE0KnoUvhJonM\n GuQyg4+jJWHg6l1e46MwjFBYITsiQmJwMsBhpLksAxHK6nluF5PsnERJUjXbIIEaoj0O\n HLE/qYuFzDAABEtWWc6ZJow1RPBs69SvC1OdANSOxpWMY3zRWhEw/1AmpRYVsXrCBbac\n TSZQ==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776372815; x=1776977615; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=gu4feCICSDPImOCHAm02vNn9Z4WEP3cVTBxFGL2ZEGc=;\n b=dtVdbNMmQ3I3RSqu9E74Ba6VJI7p7J2e0CM0zvu5ae08mcdfLR8XIzLSrod5k8rcOT\n pQlfiHA+7MjDGu+q5Aewul/ByFIesv+SCzbUrLgJpZZSJ43HR9OMhoY8uJd4F+7141Dg\n /XyTiKBbkOLx4/1vW9LmJ3m4qCcmSQOeCvjRw=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776372815; x=1776977615;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=gu4feCICSDPImOCHAm02vNn9Z4WEP3cVTBxFGL2ZEGc=;\n b=oYh5+3eb3wrmgyd/YI9Xj5zFXMroB7rODCv9znQczMIHGoSN0yW87GnxVRiW8Sk1ul\n MecBNQrdWBGBnpoYilPUmc1cQGMijb3LyfyJhnVBjSlpnXZEYFaoJbu3OoQ7U+Aurg5I\n QToAZaUO00Isolj/lMLIPgl41sxPIcsMfsulL4ys0JHckWMuhdZp3M5A1Rh3ytVjU/OM\n Ejpv7hIAPW8+eDxzr+1G5QFPf+DJT/QqQ2eau+5gKH1D8K1qyH1XxWWmQTBRP6pk5HLn\n qQJRU6871NVPYuAyfKmreI0vJc6iX6mH8GB1ppG6yGjB0kBRYyvxhThwRN2t5N+/T18M\n DGsw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9kxsF6p6IY4x4zaZg9LMfUFF/CwIvj5SDs80FBEofqu72iPt0yN+fWQZRRkQN/wLNagGMg2ek=@lists.denx.de","X-Gm-Message-State":"AOJu0YwWiJB1E6GqpZIeam55J2v0XfOvr0avMDE2hS6CAkBu5wtprlgo\n YAHoAJjkeXra7zlZ0HraW2Z+yi4tlnS+B/y4b5yqqISG4C0QjI4U6sUPS9O+R7gMkfVJfEH7d5L\n g/I12yJdb+8E5nJEPAAI2D4HKkqY47QiO+J8y6JgN","X-Gm-Gg":"AeBDietfmF8AQv+URSyTvjiHIqtqGZFGZBsYhPE2Rur/vdRecc69bsjnoEnLsyWx6Og\n gbQOIRiYO+nPhy6Tp6pcUmumAhKYbnOlxiJjYPRBO7jT/1k+fykrd/O568V4/jgTkuJcnh4VeQ3\n JX2GdNWhAIVP4DY5mY8pEF5GIDglFMqe9JCbzV5W8W05WHHXGAuk9srRG9J386HDBZHaYy/nFgf\n 2+pIBfWMu5YOYnqPJLMTS/u94+o5rgM5vDpVRyO0222Cds5Tya9PYBufNGS2qBeOZmkyveLA02D\n nhjdyPfwYx2AkdxuCFRh","X-Received":"by 2002:a17:906:8e14:b0:ba1:43cd:1b76 with SMTP id\n a640c23a62f3a-ba419171316mr6654266b.17.1776372814671; Thu, 16 Apr 2026\n 13:53:34 -0700 (PDT)","MIME-Version":"1.0","References":"<20260416053928.2834699-1-varadarajan.narayanan@oss.qualcomm.com>\n <20260416053928.2834699-5-varadarajan.narayanan@oss.qualcomm.com>","In-Reply-To":"<20260416053928.2834699-5-varadarajan.narayanan@oss.qualcomm.com>","From":"Simon Glass ","Date":"Fri, 17 Apr 2026 08:53:22 +1200","X-Gm-Features":"AQROBzBQYGf7jVh6t1WQoN3XN_xFDPUGwV_Aqc8QWBDHpHFKpT523VT9sOmQsvk","Message-ID":"\n ","Subject":"Re: [PATCH v3 04/10] misc: qcom_geni: Add minicore support","To":"varadarajan.narayanan@oss.qualcomm.com","Cc":"rayagonda.kokatanur@broadcom.com, trini@konsulko.com,\n casey.connolly@linaro.org, neil.armstrong@linaro.org, sumit.garg@kernel.org,\n peng.fan@nxp.com, jh80.chung@samsung.com, lukma@denx.de,\n tien.fong.chee@altera.com, tingting.meng@altera.com, anshuld@ti.com,\n alif.zakuan.yuslaimi@altera.com, alice.guo@nxp.com, quentin.schulz@cherry.de,\n ilias.apalodimas@linaro.org, sjg@chromium.org, mkorpershoek@kernel.org,\n h-salunke@ti.com, alchark@gmail.com, dario.binacchi@amarulasolutions.com,\n ye.li@nxp.com, andre.przywara@arm.com, dinesh.maniyam@altera.com,\n luca.weiss@fairphone.com, danila@jiaxyga.com, aswin.murugan@oss.qualcomm.com,\n balaji.selvanathan@oss.qualcomm.com, adrian@mainlining.org, n-francis@ti.com,\n wens@kernel.org, jamie.gibbons@microchip.com, justin@tidylabs.net,\n ycliang@andestech.com, david.wronek@mainlining.org,\n james.hilliard1@gmail.com,\n richard.genoud@bootlin.com, michael@amarulasolutions.com,\n philip.molloy@analog.com, sughosh.ganu@arm.com, u-boot@lists.denx.de,\n u-boot-qcom@groups.io","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailman-Approved-At":"Fri, 17 Apr 2026 14:43:59 +0200","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]