[{"id":3678706,"web_url":"http://patchwork.ozlabs.org/comment/3678706/","msgid":"","list_archive_url":null,"date":"2026-04-16T20:53:12","subject":"Re: [PATCH v3 03/10] pinctrl: qcom: Add ipq5210 pinctrl driver","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Varadarajan,\n\nOn 2026-04-16T05:39:18, Varadarajan Narayanan\n wrote:\n> pinctrl: qcom: Add ipq5210 pinctrl driver\n>\n> Add pinctrl driver for the TLMM block found in the ipq5210 SoC.\n>\n> Signed-off-by: Varadarajan Narayanan \n>\n> drivers/pinctrl/qcom/Kconfig | 8 +\n> drivers/pinctrl/qcom/Makefile | 1 +\n> drivers/pinctrl/qcom/pinctrl-ipq5210.c | 349 +++++++++++++++++++++++++++++++++\n> 3 files changed, 358 insertions(+)\n\n> +static const struct msm_pinctrl_data ipq5210_data = {\n> + .pin_data = {\n> + .pin_count = 53,\n> + .special_pins_start = 53, /* There are no special pins */\n\nFrom my reading, the PINGROUP definitions run from 0 to 53, which is\n54 pins, so shouldn't these two be 54 ?\n\n> + pr_err(\"Can't find requested function for pin %u pin\\n\", pin);\n\nThe word 'pin' appears twice\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=kumjdz6I;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"kumjdz6I\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxvl44kJMz1yCv\n\tfor ; Fri, 17 Apr 2026 22:46:24 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 94E2B84347;\n\tFri, 17 Apr 2026 14:44:04 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 3C7DC8407E; Thu, 16 Apr 2026 22:53:29 +0200 (CEST)","from mail-ej1-x633.google.com (mail-ej1-x633.google.com\n [IPv6:2a00:1450:4864:20::633])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 51A8E83EEF\n for ; Thu, 16 Apr 2026 22:53:27 +0200 (CEST)","by mail-ej1-x633.google.com with SMTP id\n a640c23a62f3a-b936331786dso1010218366b.3\n for ; Thu, 16 Apr 2026 13:53:27 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776372807; cv=none;\n d=google.com; s=arc-20240605;\n b=J+IEnr3lp66kPbSxeiV5L8mdZz1LBTUz46h5UueNzBhqfYLtkLl3eH5+Do3MYkNu/+\n 6jFf/ydCrWWcI0L+Eo4vmN2muPQOzah+gWX+hVLZMHlcQQZR1JZu3jZGJF8TXeAjZoL+\n 9RAjVcrbVCNnHBgnCAcqyzPD3BAwGrWz/+tYAfe70SsxIXS8RmVnptA8Qh3TQ7oUp7bi\n +WgUIhVW/El6YYcFMFzXcdeF96yPZkWqLcTxG+WYH2PrY4YI8a/1SOD0awO95RBEbFif\n tGftGaT/L38DDH6HdlOusBfVrVOGg5FAYvGH9Erp9EyLJR2TELLMgx6pNFXHnXc2Shpx\n Regw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=wyRjX8pMh7+RhZHjmCtdJoJ7fJ4lXKm2bNXrge3eIIg=;\n fh=1W6KVLriV9vHZUBTib7uFWDJ5E/IlPKOWOKt6b9rVJ8=;\n b=a+UTB3xGfnvbbNvYvvnRR7dugFK9JW9UoaXojjjGbt+JaAyjIG8LRgelkQSin3ZtFs\n 2Kbd6vZY4J0Koq/66DH1EWk9EBYwV1SMrTAjAi1bFPIaKNEedNtAMcooLGK90BaZjQFl\n WtDEiHojGeo5G51U9f6zC9zDtX4L75UDpBytC3N+s5KxI20arW6y7OVDRpvSRTU3757X\n AIOazU/RFcPIgM8xw++uMfVEbKb6JKRkWLSgS4MMWb7XVvrjo2dUeYYHlYv4mx+qPbF7\n dStg0+ME3pT7AW+8Dujk45cGgYB5k/sf2opWlq4BYl0I4EUZ0N9rx9nulM3jCCXfv7Pl\n +2yA==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776372807; x=1776977607; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=wyRjX8pMh7+RhZHjmCtdJoJ7fJ4lXKm2bNXrge3eIIg=;\n b=kumjdz6I4gTNG5BO85cU7T7A4R8hEVc7azbxYqbCDWt1TGMCalEoq6YcVvweIJpKqS\n 56MUeiZ8tvEt4X5bApjbz9TlcTkoOW1Fd2t5y+beGnq9DdMWOpTDfRi/HTPfn7xzSKFi\n DMGUozkc0q2u2GKvIU4tyBRyySTzBn5eMSONc=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776372807; x=1776977607;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=wyRjX8pMh7+RhZHjmCtdJoJ7fJ4lXKm2bNXrge3eIIg=;\n b=VYztX6NHQB6VeNMTJV9W9LHenJKYxVX8fguzhsYDa5ktHpHyvn4LN8OSY06VKkvS0O\n FAlAHWDMcHP6kU9i50urZ9LznC9baL+P3jBH7CYGZ+2fsMqjw1zkEsCfeclDFX01DjeU\n x3iFCiV8NmUBqZcvPrraXQiuBr4vGc5dJd0qP2cSa4y1fSvw45b+9QcqXVtlcuPtME04\n mWkqSWs823YetUMM4ds23P8t3O8xcUF78Xb2rmEC4tdIxc5Xs8tId14oH4k71ZdyHvQb\n agLvZxAiUVQl/5gM0EKMSgd6kuUMxnYHHMCtQt2x54Vz3ZKaicDiJdTIIN1NrHa7Z048\n 81RA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ86SsjtmWp76ccmpzqpelOuwMQw6b6SmbDX3ju+38iExfL0sX2Uqg21aUPRvYfFtaPDnSJ/Pfs=@lists.denx.de","X-Gm-Message-State":"AOJu0YyNSAmQN0koZ451hoRI3zUtwLTTtWE229gknZlVm47vzP1+6SNt\n sjhX177MmsWOfQWzZiaqDh+r7O9DS3nUpU8aZd2p8oslMmOM2iEADhUjU67lfTEpn6Qruk641xc\n JJNYro3eZltSMnezk/e2e+nYjUqBiASiNtYV6E4G3","X-Gm-Gg":"AeBDiev2Qz7cRqDeZnmWQS8rEuD4FEKVLveh+MtnfepyFEZNyyGHJztH0prvgTXdqZQ\n WmtgilxKvSnLfh3tXtOppCwNb587TxhMYB1h2zjtb4VB+JltePjr0sDWTgIMVr7/GIBZjlFZFeC\n G7wHUq/rvYqYwpNU4N6EEvCPTdPqWDt4WtjICb4rRW6v78wzN4pmJ68fH7cdPzH5PQpKJD/+gK6\n ovynxywT7YNneNJJgQbDLZDIzwoJs5Uh5qEzjdIu5OCoDqm1AnD4eALy4s29UYV+tg3RzDq75e1\n lEEA7DFy+n68nSX1ZYi3GoeSefjyVwk=","X-Received":"by 2002:a17:907:d206:b0:b9b:fa57:d5b2 with SMTP id\n a640c23a62f3a-ba41b0e2b8amr4533966b.42.1776372806756; Thu, 16 Apr 2026\n 13:53:26 -0700 (PDT)","MIME-Version":"1.0","References":"<20260416053928.2834699-1-varadarajan.narayanan@oss.qualcomm.com>\n <20260416053928.2834699-4-varadarajan.narayanan@oss.qualcomm.com>","In-Reply-To":"<20260416053928.2834699-4-varadarajan.narayanan@oss.qualcomm.com>","From":"Simon Glass ","Date":"Fri, 17 Apr 2026 08:53:12 +1200","X-Gm-Features":"AQROBzCXkRPg8GtgkprvEHwa2O2YEoCbzMD0FpTe9cWAzfuM6mf4PCTljPEH4YM","Message-ID":"\n ","Subject":"Re: [PATCH v3 03/10] pinctrl: qcom: Add ipq5210 pinctrl driver","To":"varadarajan.narayanan@oss.qualcomm.com","Cc":"rayagonda.kokatanur@broadcom.com, trini@konsulko.com,\n casey.connolly@linaro.org, neil.armstrong@linaro.org, sumit.garg@kernel.org,\n peng.fan@nxp.com, jh80.chung@samsung.com, lukma@denx.de,\n tien.fong.chee@altera.com, tingting.meng@altera.com, anshuld@ti.com,\n alif.zakuan.yuslaimi@altera.com, alice.guo@nxp.com, quentin.schulz@cherry.de,\n ilias.apalodimas@linaro.org, sjg@chromium.org, mkorpershoek@kernel.org,\n h-salunke@ti.com, alchark@gmail.com, dario.binacchi@amarulasolutions.com,\n ye.li@nxp.com, andre.przywara@arm.com, dinesh.maniyam@altera.com,\n luca.weiss@fairphone.com, danila@jiaxyga.com, aswin.murugan@oss.qualcomm.com,\n balaji.selvanathan@oss.qualcomm.com, adrian@mainlining.org, n-francis@ti.com,\n wens@kernel.org, jamie.gibbons@microchip.com, justin@tidylabs.net,\n ycliang@andestech.com, david.wronek@mainlining.org,\n james.hilliard1@gmail.com,\n richard.genoud@bootlin.com, michael@amarulasolutions.com,\n philip.molloy@analog.com, sughosh.ganu@arm.com, u-boot@lists.denx.de,\n u-boot-qcom@groups.io","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailman-Approved-At":"Fri, 17 Apr 2026 14:43:59 +0200","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]