[{"id":3678705,"web_url":"http://patchwork.ozlabs.org/comment/3678705/","msgid":"<CAFLszTj=iQO73XC8+d83Um8sw-QPd0ceTDLN6zU53GDD8B3aSQ@mail.gmail.com>","list_archive_url":null,"date":"2026-04-16T20:52:10","subject":"Re: [PATCH v3 02/10] clk/qcom: add initial clock driver for ipq5210","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Varadarajan,\n\nOn 2026-04-16T05:39:18, Varadarajan Narayanan\n<varadarajan.narayanan@oss.qualcomm.com> wrote:\n> clk/qcom: add initial clock driver for ipq5210\n>\n> Add initial set of clocks and resets for enabling U-Boot on ipq5210\n> based RDP platforms.\n>\n> Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>\n>\n> drivers/clk/qcom/Kconfig         |  8 ++++\n>  drivers/clk/qcom/Makefile        |  1 +\n>  drivers/clk/qcom/clock-ipq5210.c | 97 ++++++++++++++++++++++++++++++++++++++++\n>  3 files changed, 106 insertions(+)\n\n> +#include <dm/device-internal.h>\n\nIs this needed?\n\n> +static ulong ipq5210_set_rate(struct clk *clk, ulong rate)\n> +{\n> +     struct msm_clk_priv *priv = dev_get_priv(clk->dev);\n> +\n> +     switch (clk->id) {\n> +     case GCC_QUPV3_WRAP_SE1_CLK:\n> +             clk_rcg_set_rate_mnd(priv->base, priv->data->clks[clk->id].cbcr_reg,\n\ncbcr_reg is a bit confusing since that name suggests a CBCR register -\nsee the ipq5424 driver which uses 'reg'. What do you think about using\nreg consistently, or maybe add a comment explaining this?\n\n> +static int ipq5210_enable(struct clk *clk)\n> +{\n> +     struct msm_clk_priv *priv = dev_get_priv(clk->dev);\n> +\n> +     if (priv->data->num_clks <= clk->id) {\n> +             debug(\"%s: unknown clk id %lu\\n\", __func__, clk->id);\n> +             return 0;\n> +     }\n\nShouldn't the comparison be <  ?\n\nAlso, should return an error, not 0.\n\n> +     qcom_gate_clk_en(priv, clk->id);\n> +\n> +     return 0;\n\nShould return any error from qcom_gate_clk_en()\n\nRegards,\nSimon","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=mKFnpgMC;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"mKFnpgMC\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxvkv4JG5z1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 17 Apr 2026 22:46:15 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 5979184332;\n\tFri, 17 Apr 2026 14:44:04 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id E23278407E; Thu, 16 Apr 2026 22:52:26 +0200 (CEST)","from mail-ej1-x630.google.com (mail-ej1-x630.google.com\n [IPv6:2a00:1450:4864:20::630])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id E08DC83EEF\n for <u-boot@lists.denx.de>; Thu, 16 Apr 2026 22:52:24 +0200 (CEST)","by mail-ej1-x630.google.com with SMTP id\n a640c23a62f3a-b9910707d82so345366b.1\n for <u-boot@lists.denx.de>; Thu, 16 Apr 2026 13:52:24 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776372744; cv=none;\n d=google.com; s=arc-20240605;\n b=jcxyuMm5nsBIDtlk2t1itf1dBLtcnSokvRm7/LGvcZ0c/SMNJI1IIk3V9IWZRewGRr\n WPYhyUAdviLPW+W3Aa1WbEoHxNY2z0b+i/eAE6CVNliW/JjiLoNag/frgmD6H8c5xVMR\n ThLYMxAw8jwWuCss8I9IOeFX58kYTMekOu5nXLDG07v3oPXtnyUtfn6VLEw33YrMMlyk\n dM/D/TXL/ePt6nTQkQOzXbys1/oohR5t/Xpg8IhAjhCioN2UI1MAeERUqXDd+tiis3Vx\n txaQB7fEUzWs0/D2U5aBsjZrO2y0hr8bzzdnO+wPNUr85hYJa8pDsCqDk1L5u+mIr1sm\n 0WdA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=srVDOUhev8QJnVpl1futru5agXzcinhCiCfNtACUqr0=;\n fh=PzcHDHniSDSnSUoX2MAnjnpEO0mAOzqNIR7VgfcIVrA=;\n b=KTSwSF4quu5Xq8JBUko6dzakpgF340B/sllyy5JU+1KhxDouMah/c1SxwLQc83bWHj\n hE/Z+Hsvth++ruDf4Sgk9EOZy99oeebj0L+V/lIj9dzc8sNvS73TO2VDtZXYOhnJ+rHO\n TUibN78jdzLlTs4OqSMZB/HB8FCSi5CA5x6R1n/Hr3UIunnppYnnD3Y67m+AsF71qIpR\n Yqs8UEwdSO6XilTGmM3iqPPqiAA03jBXWe21boqBLJBuMyRPFEthUf0wc2VvR4cMOyZK\n eEfHcWCRwrw0vXF5bVk1a8trRc6Bw3dy4MZFbDA1leaPRi/lOQn929E0qdU3DdvT5XhO\n U/bQ==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776372744; x=1776977544; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=srVDOUhev8QJnVpl1futru5agXzcinhCiCfNtACUqr0=;\n b=mKFnpgMCKzkTIE7qmo2SVBM9dC1ieyJXh42KcPHSpT4HlmA90W6RDebIhpwAG1nALx\n KUWCR1PLp/lukh1EngkoaalOvy00fkeNB2GA0BOgPqcuiuK97vRnx9k9SFC3p91K2GXV\n mhG508I1EXRj0nZOXsB7AUZ6L4ZeR1519HCh0=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776372744; x=1776977544;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=srVDOUhev8QJnVpl1futru5agXzcinhCiCfNtACUqr0=;\n b=UvMA2J+05YFoLFSEhsJQfjjVg3ydeWc5fV/CqAisECraC9YiYwecxPChA7oNlJuUoQ\n xsVyTddCIj8dAT8jmp9yl1nwfo4N4SuS0kWGT6096nGDmycL2o+D9RiXYpzhyZQRkPkF\n 9Tu/P9vlsi+Hjt/pNq+gzVJKbst3Tq7uBQk5unxC8rJFOJN2qBR4gWD5jr1ibnwl3wZz\n Gq27D6B7Ll3amOID5x0NC6U3ZbNlmqXy/lGxtD7aV3QnAmNiSMU7PtNJAY+C09v3F1uW\n uabA6JTN/9jGkX83mSlwQ1RaCggr5K1sQy5zst5njJe84ISrghjx+ynbLkzAhKyZr+UV\n akgg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+fRICzM0x9OGMFZrGCpaFOKPyt3DrTmmAaD476ijvBMsVrWyVwARRQ4EjO6/HtzGgKbPJ+/4E=@lists.denx.de","X-Gm-Message-State":"AOJu0Yw3kyaRxn3Sho5LrC81X3S04lcKksT6sgQFsd1su2aBqxkfqDB5\n ow+tqcvtjfOsXcDso2bm5HK1Qxu3aKfQV2R5WNSTApiZzT4RdOSeRRXsRRWQMBWdwkNpTK+EBNQ\n XeEk2dPH8iW4ygCUv3nme4xHYqsPsIe0b82zGsSyp","X-Gm-Gg":"AeBDiesX947HDAn7HuMErd0/Kq6KYrt82pT3uy76ZDe+wMTfJDPmaa64xDIV86U61rx\n zvmKUOGsx7XAp4Ak0qV508jPW8JVtFc1DCltGCZ9Y6JZ7PiIbeJ5aZbnfa3eY+k0b5aGaKIu4Eu\n h7WdGaBIGETeTjkBdAz9K2xr5Ci2IVUu7amgxlIFEAQywPD94qJdx7ltD9jrv8kScNcrHOhgnUh\n YqTzGytz4t8tLJdElnm8RgTmcQWcKhzPN+jUp6gOabHmdrSDg2Ynrc22cv21iCVpLIH83VnFzOR\n LmZafA1MqPj1oDCeIIqhNOvG/zV3S5A=","X-Received":"by 2002:a17:907:a602:b0:b9c:c3ca:a724 with SMTP id\n a640c23a62f3a-ba418982fd2mr6495966b.8.1776372743799; Thu, 16 Apr 2026\n 13:52:23 -0700 (PDT)","MIME-Version":"1.0","References":"<20260416053928.2834699-1-varadarajan.narayanan@oss.qualcomm.com>\n <20260416053928.2834699-3-varadarajan.narayanan@oss.qualcomm.com>","In-Reply-To":"<20260416053928.2834699-3-varadarajan.narayanan@oss.qualcomm.com>","From":"Simon Glass <sjg@chromium.org>","Date":"Fri, 17 Apr 2026 08:52:10 +1200","X-Gm-Features":"AQROBzDkZZ76zcjyuMXk5-yahlHPcHsLk7S0U9WQnAe7jDOandTxNACJMYHMdNI","Message-ID":"\n <CAFLszTj=iQO73XC8+d83Um8sw-QPd0ceTDLN6zU53GDD8B3aSQ@mail.gmail.com>","Subject":"Re: [PATCH v3 02/10] clk/qcom: add initial clock driver for ipq5210","To":"varadarajan.narayanan@oss.qualcomm.com","Cc":"rayagonda.kokatanur@broadcom.com, trini@konsulko.com,\n casey.connolly@linaro.org, neil.armstrong@linaro.org, sumit.garg@kernel.org,\n peng.fan@nxp.com, jh80.chung@samsung.com, lukma@denx.de,\n tien.fong.chee@altera.com, tingting.meng@altera.com, anshuld@ti.com,\n alif.zakuan.yuslaimi@altera.com, alice.guo@nxp.com, quentin.schulz@cherry.de,\n ilias.apalodimas@linaro.org, sjg@chromium.org, mkorpershoek@kernel.org,\n h-salunke@ti.com, alchark@gmail.com, dario.binacchi@amarulasolutions.com,\n ye.li@nxp.com, andre.przywara@arm.com, dinesh.maniyam@altera.com,\n luca.weiss@fairphone.com, danila@jiaxyga.com, aswin.murugan@oss.qualcomm.com,\n balaji.selvanathan@oss.qualcomm.com, adrian@mainlining.org, n-francis@ti.com,\n wens@kernel.org, jamie.gibbons@microchip.com, justin@tidylabs.net,\n ycliang@andestech.com, david.wronek@mainlining.org,\n james.hilliard1@gmail.com,\n richard.genoud@bootlin.com, michael@amarulasolutions.com,\n philip.molloy@analog.com, sughosh.ganu@arm.com, u-boot@lists.denx.de,\n u-boot-qcom@groups.io","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailman-Approved-At":"Fri, 17 Apr 2026 14:43:59 +0200","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3679272,"web_url":"http://patchwork.ozlabs.org/comment/3679272/","msgid":"<aeXKZvVE6ViBz0Az@hu-varada-blr.qualcomm.com>","list_archive_url":null,"date":"2026-04-20T06:40:38","subject":"Re: [PATCH v3 02/10] clk/qcom: add initial clock driver for ipq5210","submitter":{"id":92283,"url":"http://patchwork.ozlabs.org/api/people/92283/","name":"Varadarajan Narayanan","email":"varadarajan.narayanan@oss.qualcomm.com"},"content":"On Fri, Apr 17, 2026 at 08:52:10AM +1200, Simon Glass wrote:\n> Hi Varadarajan,\n>\n> On 2026-04-16T05:39:18, Varadarajan Narayanan\n> <varadarajan.narayanan@oss.qualcomm.com> wrote:\n> > clk/qcom: add initial clock driver for ipq5210\n> >\n> > Add initial set of clocks and resets for enabling U-Boot on ipq5210\n> > based RDP platforms.\n> >\n> > Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>\n> >\n> > drivers/clk/qcom/Kconfig         |  8 ++++\n> >  drivers/clk/qcom/Makefile        |  1 +\n> >  drivers/clk/qcom/clock-ipq5210.c | 97 ++++++++++++++++++++++++++++++++++++++++\n> >  3 files changed, 106 insertions(+)\n>\n> > +#include <dm/device-internal.h>\n>\n> Is this needed?\n\nWill remove.\n\n> > +static ulong ipq5210_set_rate(struct clk *clk, ulong rate)\n> > +{\n> > +     struct msm_clk_priv *priv = dev_get_priv(clk->dev);\n> > +\n> > +     switch (clk->id) {\n> > +     case GCC_QUPV3_WRAP_SE1_CLK:\n> > +             clk_rcg_set_rate_mnd(priv->base, priv->data->clks[clk->id].cbcr_reg,\n>\n> cbcr_reg is a bit confusing since that name suggests a CBCR register -\n> see the ipq5424 driver which uses 'reg'. What do you think about using\n> reg consistently, or maybe add a comment explaining this?\n\nipq5424 used GATE_CLK (defined in drivers/clk/qcom/clock-qcom.h).\nThat has been deprecated and ipq5210 uses GATE_CLK_POLLED. Hence\nthe difference.\n\n> > +static int ipq5210_enable(struct clk *clk)\n> > +{\n> > +     struct msm_clk_priv *priv = dev_get_priv(clk->dev);\n> > +\n> > +     if (priv->data->num_clks <= clk->id) {\n> > +             debug(\"%s: unknown clk id %lu\\n\", __func__, clk->id);\n> > +             return 0;\n> > +     }\n>\n> Shouldn't the comparison be <  ?\n\nNo, this check is right. The clock id defines range from zero to the\nhighest_id. So num_clks will get set to highest_id + 1. So a clock id of\nhighest_id + 1 is invalid.\n\n> Also, should return an error, not 0.\n\nOk.\n\n> > +     qcom_gate_clk_en(priv, clk->id);\n> > +\n> > +     return 0;\n>\n> Should return any error from qcom_gate_clk_en()\n\nOk.\n\nThanks\nVarada","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=WHUvx1ad;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=h9e+cLH/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=oss.qualcomm.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=\"WHUvx1ad\";\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=\"h9e+cLH/\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=none (p=none dis=none)\n header.from=oss.qualcomm.com","phobos.denx.de; spf=pass\n smtp.mailfrom=varadarajan.narayanan@oss.qualcomm.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzcwB1WlKz1yGs\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 20 Apr 2026 17:45:14 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 38D38839D5;\n\tMon, 20 Apr 2026 09:45:06 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id B1924839D9; Mon, 20 Apr 2026 08:40:58 +0200 (CEST)","from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n [205.220.168.131])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 625C2805D7\n for <u-boot@lists.denx.de>; Mon, 20 Apr 2026 08:40:56 +0200 (CEST)","from pps.filterd (m0279864.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63JMUahd1341653\n for <u-boot@lists.denx.de>; Mon, 20 Apr 2026 06:40:54 GMT","from mail-pg1-f197.google.com (mail-pg1-f197.google.com\n [209.85.215.197])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dm34hcbx1-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for <u-boot@lists.denx.de>; Mon, 20 Apr 2026 06:40:54 +0000 (GMT)","by mail-pg1-f197.google.com with SMTP id\n 41be03b00d2f7-c76bb22a8ceso3070857a12.2\n for <u-boot@lists.denx.de>; Sun, 19 Apr 2026 23:40:54 -0700 (PDT)","from hu-varada-blr.qualcomm.com\n (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-82f8ebe6642sm11893057b3a.45.2026.04.19.23.40.42\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 19 Apr 2026 23:40:52 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-type:date:from:in-reply-to:message-id:mime-version\n :references:subject:to; s=qcppdkim1; bh=+mwXPahJVRvaLgPjoQXORJxj\n 69nMBv4KBmjQmrXmEIk=; b=WHUvx1ad/Y25JoXwRcEsjihdMYDaoE31PYrWEDKV\n PDH07lWIrt84qShpv/6BIAEFTkF4AQyj1rmU6RsJ1ZodJgeL/rxe7ZKd9VlK8GvU\n v3nPc2VYd0vTTFBNjTo2xn7emlOUeRXRQIQvK4sefl6LkJBFVIEhxEtWP+y89N+T\n Y5Vf9CnXANG+LuYClbavnKv95BGt85Q6SFyPoiWzj3vZ7+xFqkzJZeHONVgstbgd\n VzUjSJMIeknPuk8t9XJY4u+WQlyWGZtDFlffimDgXpUcgkxM0Rhjn9kt4p+e6ZkS\n D/kQL/yEB1/p8sM3sFALPLB/KkmYfB+b4gMBk3g25/O44A==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1776667254; x=1777272054; darn=lists.denx.de;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=+mwXPahJVRvaLgPjoQXORJxj69nMBv4KBmjQmrXmEIk=;\n b=h9e+cLH/U5q6Ab6o7OGbR14vlXeaJUip6vVPTGk9IZwzKTsZ8I07qo8T/rGFGat7e0\n 6XqVgAkB9kyZc7tuAWUyImQX75Hc9V9kDNzAmAMd5HW4+QuhcpjV7Ru9kqvoLJd5BA23\n jUueNkNyhW5wL8RF0GQIbV5g0sDEuoGouXSAiVG/lBRQOdF0gvN0/i4JDDBPD3JBMA2S\n gqTklDKMydRP/ytTXe12Jm9K/wgbPtg+bYzR5ZViBHpkPdXc8wk79lWwG5IarNIdM1d2\n wEtDX9mYU8YejCM5r7H3cQsO1UQZTEskT7TopLNc6L0o+xjQKrKm9EIbWdlSwj5PDaJm\n vy0A=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776667254; x=1777272054;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=+mwXPahJVRvaLgPjoQXORJxj69nMBv4KBmjQmrXmEIk=;\n b=oxiB/xg9aNcc0gtyXD+q+Gem1bHaQqWx8eeMVAxTn+ch1Qse6QuqsdhW2HFLeZq3e/\n krSiovo5Mx+vTSo1H5L9N4kWBBgzCIi+PxM8KD5NlvmDWMGNFHDakS7dKeHJkQloiMpw\n PfhScXr0WDNrhFefZoL3eX7qLsP6SX6a4s39KW/i8jRtbA/T14SNaPV5LxZJU1I+gjWj\n T5kBFOvpytpekSUayFOCEf3mF3pHlszdrKA2OkF5JVYSrZOggJVMtQC1lB66cwA3PRCy\n sFKMtTp8RwGNa8So9wZRrrNYpiaKLN8CF8X42FFjJvpH+QSJNWQWpkzP9rqFVLt+PgwF\n vX/A==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8kM6G000QUTYUGdE0YeiR1ztp4GX+MVPlITe6qd1cSmvvSlnv8tfyRecOURPL6g4QNK4BiS4I=@lists.denx.de","X-Gm-Message-State":"AOJu0Yz2/65FmaLNCZN/MBlwpKwkaD0/3m/MEDt2BqSYAYbq06p84V/e\n HQZijRrsMxD4eQGZVfneM/jEqDQfwePV0shBos2Hmj88RPFBUMAwzXNuIKyW5h8KSqxJ8bRJYxQ\n sXRomKU/y8iEoQjSkfEJ83Ru14r5dlseBTlSRMbiRYShI1czNQPf7l4L5","X-Gm-Gg":"AeBDieuUoHszektpsFzhF2KTHir4pBmmA45xVvkc7KL9mLTwn1ZCSoy+u5CNbyhxR1e\n WhAoMVJYsYZNAdMP3qQ4a4n3AVdcyb1ABGI5y2s3iIYWpB/+p+syyEOnHtgVPwmzWErTKwVnafp\n fEKKDrosKCrPY9w/7svL0dL64QdCc4Wd9ptApN0bOldKZz7mrmMI/mUSI3bp08g3kZjAJvic4fO\n wjG33NdsS5ayiM9LKWPTGqT7eZlnOcMnUntq+oT2w9+WlzUSNTCX2CAMJCl0HTE3wxagzd18kSs\n /hnajPHPzdMpyqvUDjvGxJfo5uc3jXfqPvVLlLwmGTQPfv90+72sNf2nuKhiMXyd3+V701A3Tro\n xB3JU6zMhsEdRyfmk8YxmnVGZa1wHnpBDUR6tpOb3tyALhp+2tzn875Hrox2AWMqCLdmP8DYUc8\n 90xUIJ6gZRm9gYhgbrxDrCh3dKUhOGl1PyM2cHWezTI11j7ftsSdMlbYG5lNTlfA==","X-Received":["by 2002:a05:6a00:bb91:b0:81f:31c3:2e34 with SMTP id\n d2e1a72fcca58-82f8c902072mr12338412b3a.25.1776667253591;\n Sun, 19 Apr 2026 23:40:53 -0700 (PDT)","by 2002:a05:6a00:bb91:b0:81f:31c3:2e34 with SMTP id\n d2e1a72fcca58-82f8c902072mr12338379b3a.25.1776667253112;\n Sun, 19 Apr 2026 23:40:53 -0700 (PDT)"],"Date":"Mon, 20 Apr 2026 12:10:38 +0530","From":"Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>","To":"Simon Glass <sjg@chromium.org>","Cc":"rayagonda.kokatanur@broadcom.com, trini@konsulko.com,\n casey.connolly@linaro.org, neil.armstrong@linaro.org,\n sumit.garg@kernel.org, peng.fan@nxp.com, jh80.chung@samsung.com,\n lukma@denx.de, tien.fong.chee@altera.com, tingting.meng@altera.com,\n anshuld@ti.com, alif.zakuan.yuslaimi@altera.com, alice.guo@nxp.com,\n quentin.schulz@cherry.de, ilias.apalodimas@linaro.org,\n mkorpershoek@kernel.org, h-salunke@ti.com, alchark@gmail.com,\n dario.binacchi@amarulasolutions.com, ye.li@nxp.com,\n andre.przywara@arm.com, dinesh.maniyam@altera.com,\n luca.weiss@fairphone.com, danila@jiaxyga.com,\n aswin.murugan@oss.qualcomm.com, balaji.selvanathan@oss.qualcomm.com,\n adrian@mainlining.org, n-francis@ti.com, wens@kernel.org,\n jamie.gibbons@microchip.com, justin@tidylabs.net,\n ycliang@andestech.com, david.wronek@mainlining.org,\n james.hilliard1@gmail.com, richard.genoud@bootlin.com,\n michael@amarulasolutions.com, philip.molloy@analog.com,\n sughosh.ganu@arm.com, u-boot@lists.denx.de, u-boot-qcom@groups.io","Subject":"Re: [PATCH v3 02/10] clk/qcom: add initial clock driver for ipq5210","Message-ID":"<aeXKZvVE6ViBz0Az@hu-varada-blr.qualcomm.com>","References":"<20260416053928.2834699-1-varadarajan.narayanan@oss.qualcomm.com>\n <20260416053928.2834699-3-varadarajan.narayanan@oss.qualcomm.com>\n <CAFLszTj=iQO73XC8+d83Um8sw-QPd0ceTDLN6zU53GDD8B3aSQ@mail.gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"\n <CAFLszTj=iQO73XC8+d83Um8sw-QPd0ceTDLN6zU53GDD8B3aSQ@mail.gmail.com>","X-Authority-Analysis":"v=2.4 cv=J46aKgnS c=1 sm=1 tr=0 ts=69e5ca76 cx=c_pps\n a=rz3CxIlbcmazkYymdCej/Q==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17\n a=kj9zAlcOel0A:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22\n a=EUspDBNiAAAA:8 a=MWgSPYugQ9fGs0IJWzkA:9 a=CjuIK1q_8ugA:10\n a=bFCP_H2QrGi7Okbo017w:22","X-Proofpoint-GUID":"9dpVBPR99LoH-kS-716yM1mcjpnKYxJn","X-Proofpoint-ORIG-GUID":"9dpVBPR99LoH-kS-716yM1mcjpnKYxJn","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDIwMDA2MyBTYWx0ZWRfX1vT/c8wWMEM4\n xYaWtWopwRRs+9nYk56GcUJU2D1iIna9qs2mz027e795Bf0V2EVVHS56f298FtoJJKUDHk6pHqg\n ItFBwiLWhiyabroso9KGiEOeDdQo8Nn4L9avsp+w5/7SnvP93pvtW/rSOj/y0xWnfxxhsoGV92P\n zy/Sn0hUc5V30e82LCXvVeUKKHq7i/NBv+gZPUzaNyIUqGS/zjcN/TNk8nXOsVlzu7/nGa8tKMb\n gHclxxw4mbTfizUIWVcbtxSQO2MMniHAKNYTAP3xTTa1KliAcpcY73IwTvVl7XM7GBCy5y1L/FO\n uqdWwtGODBjhpX3LxgFxvNpuP9VU8VaZhhUfwuGWQkceoVyLCIAVX9Uoe65t8imljgnHyDpw5SP\n hJfMraggfUDPh2ZK5Po8vTINg7rCOY0edYkVP/gulsAoZMsoVmL6SPyHsxTC+/bueEt0c3jHodd\n tlMJ+KLfRrRLfWPYBdg==","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-20_01,2026-04-17_04,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n impostorscore=0 adultscore=0 phishscore=0 suspectscore=0 spamscore=0\n malwarescore=0 priorityscore=1501 clxscore=1015 bulkscore=0\n lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000\n definitions=main-2604200063","X-Mailman-Approved-At":"Mon, 20 Apr 2026 09:45:05 +0200","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]