[{"id":3678188,"web_url":"http://patchwork.ozlabs.org/comment/3678188/","msgid":"<20260416134504.3846-1-linuxtestproject.agent@gmail.com>","list_archive_url":null,"date":"2026-04-16T13:45:04","subject":"Re: [LTP] nanosleep: use POSIX runtime detection for CLOCK_MONOTONIC","submitter":{"id":93132,"url":"http://patchwork.ozlabs.org/api/people/93132/","name":null,"email":"linuxtestproject.agent@gmail.com"},"content":"Hi Andrea,\n\nOn 2026-04-16, Andrea Cervesato wrote:\n> nanosleep: use POSIX runtime detection for CLOCK_MONOTONIC\n\n> +static inline clockid_t get_supported_clock(void)\n> +{\n> +#ifdef _POSIX_MONOTONIC_CLOCK\n> +\tif (_POSIX_MONOTONIC_CLOCK > 0)\n> +\t\treturn CLOCK_MONOTONIC;\n> +\n> +\tif (!_POSIX_MONOTONIC_CLOCK && sysconf(_SC_MONOTONIC_CLOCK) > 0)\n> +\t\treturn CLOCK_MONOTONIC;\n> +#endif\n> +\n> +\tprintf(\"CLOCK_MONOTONIC unavailable, test may fail due to \"\n> +\t \"external clock adjustments\\n\");\n> +\treturn CLOCK_REALTIME;\n> +}\n\nCorrect POSIX runtime detection — handles all three _POSIX_MONOTONIC_CLOCK\nstates (>0, ==0, undefined) properly, and the unistd.h include in helpers.h\ncloses the silent fallback that affected 1-1.c, 2-1.c, and 10000-1.c.\n\nReviewed-by: LTP AI Reviewer \n\n---\nNote:\n\nOur agent completed the review of the patch.\n\nThe agent can sometimes produce false positives although often its\nfindings are genuine. If you find issues with the review, please\ncomment this email or ignore the suggestions.\n\nRegards,\nLTP AI Reviewer","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=BJvS3nyS;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxK5Q3qbtz1yG9\n\tfor ; Thu, 16 Apr 2026 23:45:14 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 5D2D53E4AD6\n\tfor ; Thu, 16 Apr 2026 15:45:12 +0200 (CEST)","from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [217.194.8.2])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 4D00D3E2928\n for ; Thu, 16 Apr 2026 15:45:08 +0200 (CEST)","from mail-qt1-x843.google.com (mail-qt1-x843.google.com\n [IPv6:2607:f8b0:4864:20::843])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-2.smtp.seeweb.it (Postfix) with ESMTPS id C1BDE6008AA\n for ; Thu, 16 Apr 2026 15:45:07 +0200 (CEST)","by mail-qt1-x843.google.com with SMTP id\n d75a77b69052e-50d7c12e48eso6240311cf.1\n for ; Thu, 16 Apr 2026 06:45:07 -0700 (PDT)","from\n runnervm35a4x.acrcebrcupsetj21tpkunvq0he.ex.internal.cloudapp.net\n ([20.102.223.155]) by smtp.gmail.com with ESMTPSA id\n d75a77b69052e-50e21f8eb5csm28347621cf.8.2026.04.16.06.45.05\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 16 Apr 2026 06:45:05 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776347106; x=1776951906; darn=lists.linux.it;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=pWNYZLqsS5ALkE960tFGHXGTM/F4BVT64ItzDLcG3Rs=;\n b=BJvS3nySeA8Q8qxg/G5YoOXnrJTITBEypYCiTuWXtT98cvEhQEOIpDEqf/MpbyOpiy\n GzbvEXoK18P0u/TA4B7/lCz8ybbna5L3C2w/aitiU5Y+k+PNbb4wE78TAjBTRbCX7ADi\n hPlB7G8F8tBUwdmkXAqCY/ldWqEKJgbBqNcu6CNJtYwJyQFouXT9r0KwlLFjY683Ws2F\n kc6fGr8S9oKOh2C/KwRF++9aZQKX00kocLF211mHAEsoBLNrR/v9lbBveOKNqJzUn7LX\n aww65j/HA1Te8+UIniq2O3KQc9OCgKzSdYA5ZNc2bKJnPN5CoHbxY/tSOqjAYb4VvgTI\n VidA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776347106; x=1776951906;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=pWNYZLqsS5ALkE960tFGHXGTM/F4BVT64ItzDLcG3Rs=;\n b=RjYYnAiBUMOqQhDtvDAr0LIVKlarEaOhpC/WD9AJCrFqHZxfmZ7kqmPT4ccU3rksVF\n ZQgHsiEj90V1f/A2SSNgd7bp+jMRcN9KRCu6rpb/jIqLnEv8wbojZa4g8dMd4g5k+3zS\n tukIygCrBIK/32wxFHhoTI1fpiV6bymFE28slNo1vgsNo001u4EOBexWxEnf7K7WObkj\n dg647DibydpdIi7pPp7hZlO2X/QVBUknzGYRji53R4lvvufbCWopM7k9cjhF/CRp2LOG\n FHXMFP3wkRG5eQ2exZIlZDaPoijgT7w+JiLdDSXxG3n8BbHUetaSAi8D3zGkU/34FpSg\n C1pA==","X-Gm-Message-State":"AOJu0YzGCbcEVe78WBMqY3hpZ3PVxMclrLL2tMy+biFAs7R0wbl4E+jv\n HJ4eGcSjU/ZvK0F/cJ272FnAqkOFYiyeNTUFdjqCWisn0cUsSwRS68sBCD5+NjMHMDA=","X-Gm-Gg":"AeBDiet2p23rq67JosY4+/je+LGD3ouWoAeBpoqu/JGWDSDqaPCThidc53+aZwIu/Ie\n 3UqSrBk9kyFsk7T0paGx0Ksws+KO+EaUmf+1XQnv7QU3lO7hoG1C3mFIopuh3k5gvQA5hBTxGTI\n WmhCEDMqCe8fLFkotfdsFZjbEZHmtFrnVdglN5HmcTldVIhmJQPcOO+SRbLinkENGlEndy3EVM8\n 8s1+bMpYnH0pijfsjDxaYIE0qXp9GNjWzd6+ADOwo8+uFwyzk+YEA8+Rl46CPf312upAnpD8ATU\n aBqdFc4TSr2i2muXH2FD2LQ3T/HCWTsYUDijAk0gua9p7NxfXcWhcUtqtJfhUoA3VLUQD4nFhFA\n 4pBd1U/6FmI4qKWmx87OOvB9lso/7zpIdZQB8KLzF0CXL82FhCkPWfSgkc2bCeIqfLqDjScOdc2\n l8PrPK3U1HJJaXxNNaw+RDZEFRQiBLu2Sgy4dUbRQdRYgZHhE75HDexmyFTxNfv2FbO4x3yjUsl\n X1VYEr0hld6WwQVIcui1/stzCbX6R+Wr1CqNw95","X-Received":"by 2002:a05:622a:5a17:b0:50d:7632:ddb2 with SMTP id\n d75a77b69052e-50e24ae4d5emr51479851cf.12.1776347105561;\n Thu, 16 Apr 2026 06:45:05 -0700 (PDT)","From":"linuxtestproject.agent@gmail.com","To":"Andrea Cervesato ","Date":"Thu, 16 Apr 2026 13:45:04 +0000","Message-ID":"<20260416134504.3846-1-linuxtestproject.agent@gmail.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260416-fix_nanosleep_include-v2-1-b3147763acb8@suse.com>","References":"<20260416-fix_nanosleep_include-v2-1-b3147763acb8@suse.com>","MIME-Version":"1.0","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,DMARC_PASS,FREEMAIL_FROM,SPF_HELO_NONE,\n SPF_PASS shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-2.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-2.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] nanosleep: use POSIX runtime detection for CLOCK_MONOTONIC","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it, LTP AI Reviewer ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}},{"id":3678721,"web_url":"http://patchwork.ozlabs.org/comment/3678721/","msgid":"<20260417125821.GB419619@pevik>","list_archive_url":null,"date":"2026-04-17T12:58:21","subject":"Re: [LTP] [PATCH v2] nanosleep: use POSIX runtime detection for\n CLOCK_MONOTONIC","submitter":{"id":70792,"url":"http://patchwork.ozlabs.org/api/people/70792/","name":"Petr Vorel","email":"pvorel@suse.cz"},"content":"Hi Andrea,\n\n...\n> --- /dev/null\n> +++ b/testcases/open_posix_testsuite/conformance/interfaces/nanosleep/helpers.h\n> @@ -0,0 +1,28 @@\n> +/*\n> + * Copyright (c) 2026, Linux Test Project\n> + * SPDX-License-Identifier: GPL-2.0-or-later\n> + */\n> +\n> +#ifndef NANOSLEEP_HELPERS_H\n> +#define NANOSLEEP_HELPERS_H\n> +\n> +#include \n> +#include \n> +#include \n> +\n> +static inline clockid_t get_supported_clock(void)\n> +{\n> +#ifdef _POSIX_MONOTONIC_CLOCK\n> +\tif (_POSIX_MONOTONIC_CLOCK > 0)\n> +\t\treturn CLOCK_MONOTONIC;\n> +\n> +\tif (!_POSIX_MONOTONIC_CLOCK && sysconf(_SC_MONOTONIC_CLOCK) > 0)\n> +\t\treturn CLOCK_MONOTONIC;\n> +#endif\n> +\n> +\tprintf(\"CLOCK_MONOTONIC unavailable, test may fail due to \"\n> +\t \"external clock adjustments\\n\");\n+1 for warning. But please don't split string just due few chars over 100.\n\n> +\treturn CLOCK_REALTIME;\nI've suggested [1] in clock_settime [2] to move this function to newly created\ntestcases/open_posix_testsuite/include/clock.h, so that clock_settime/helpers.h\ncan also use it.\n\nKind regards,\nPetr\n\n[1] https://lore.kernel.org/ltp/20260417125322.GA419619@pevik/\n[2] https://patchwork.ozlabs.org/project/ltp/patch/20260416-fix_clock_settime_helper-v1-1-2874202291bf@suse.com/","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=PRwGHv7L;\n\tdkim=fail reason=\"signature verification failed\" header.d=suse.cz\n header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519\n header.b=r4lOe7kd;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa\n header.b=tS6sFkvK;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=J9nUlcdk;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=213.254.12.146; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)","smtp-out1.suse.de;\n\tnone"],"Received":["from picard.linux.it (picard.linux.it [213.254.12.146])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxw1K35fKz1yD3\n\tfor ; Fri, 17 Apr 2026 22:58:43 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 4C66A3E594D\n\tfor ; Fri, 17 Apr 2026 14:58:41 +0200 (CEST)","from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::7])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 2285F3E2983\n for ; Fri, 17 Apr 2026 14:58:37 +0200 (CEST)","from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-7.smtp.seeweb.it (Postfix) with ESMTPS id 49A542003B6\n for ; Fri, 17 Apr 2026 14:58:36 +0200 (CEST)","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id 631196A9C5;\n Fri, 17 Apr 2026 12:58:27 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4CB48593AE;\n Fri, 17 Apr 2026 12:58:27 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id SDHEEXMu4mn7TAAAD6G6ig\n (envelope-from ); Fri, 17 Apr 2026 12:58:27 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1776430711;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=mIF/V/m3w4LJp4IOxMMfhgzz5DrjcyHPqzIuAMnKjCk=;\n b=PRwGHv7LbGSBIK2MnJnQFptRr2BXwk50ixutZv0DSGWfs2tFt/r5dKvgsscIbCrlF1T0Et\n WxJd1idMI4ZrC/YlW2MQyKNRPq9XS4LQDzGL361esrmT/7XrNxGXNMVIGCExHqrNQDMfMi\n +5luDSoWjTjRogN3Jys5wH0wfTQNuJA=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1776430711;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=mIF/V/m3w4LJp4IOxMMfhgzz5DrjcyHPqzIuAMnKjCk=;\n b=r4lOe7kd/qcPLTKYAZe102J3auXdMbAFQj/dQ2darkmhtwGl/4k+9qSWPnpJZXuxUXZD1K\n Rnsv8UWxw/EnyVCg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1776430707;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=mIF/V/m3w4LJp4IOxMMfhgzz5DrjcyHPqzIuAMnKjCk=;\n b=tS6sFkvKwD4gB+2vkpXGkFtqkqbDn/NVDkDL0eCvgkmm1DqVyMq/KN7r7+JT+WqMQP8/WJ\n qeXlH/KVv70dyj0BvxMNiZWusGm8AeUzgbQhvg/P7apWXfJD4qP0FaerMQIZo/FoI7iAEL\n 3EaAZXS2/GGDoRrMuco2ohUJl8+4Stk=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1776430707;\n h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:\n cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=mIF/V/m3w4LJp4IOxMMfhgzz5DrjcyHPqzIuAMnKjCk=;\n b=J9nUlcdkDnqSXuodgIO+2fnkBTeSa3b6FnN5/6/fFIPewCUYKD6UPjB3l/qITLTuxl6lFS\n pqoxK14BxIkWnHCg=="],"Date":"Fri, 17 Apr 2026 14:58:21 +0200","From":"Petr Vorel ","To":"Andrea Cervesato ","Message-ID":"<20260417125821.GB419619@pevik>","References":"<20260416-fix_nanosleep_include-v2-1-b3147763acb8@suse.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20260416-fix_nanosleep_include-v2-1-b3147763acb8@suse.com>","X-Spamd-Result":"default: False [-3.50 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[];\n HAS_REPLYTO(0.30)[pvorel@suse.cz];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; MISSING_XM_UA(0.00)[];\n RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+];\n RCPT_COUNT_TWO(0.00)[2];\n DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[];\n TO_DN_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[ozlabs.org:url,imap1.dmz-prg2.suse.org:helo,suse.cz:replyto];\n RCVD_COUNT_TWO(0.00)[2]; REPLYTO_EQ_FROM(0.00)[]","X-Spam-Score":"-3.50","X-Spam-Level":"","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-7.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-7.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] [PATCH v2] nanosleep: use POSIX runtime detection for\n CLOCK_MONOTONIC","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"Petr Vorel ","Cc":"Linux Test Project ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]