[{"id":3682311,"web_url":"http://patchwork.ozlabs.org/comment/3682311/","msgid":"<aezznOpfVei-LZF8@google.com>","list_archive_url":null,"date":"2026-04-25T17:02:20","subject":"Re: [PATCH 5/9] configs: stmark2: add support for mmc","submitter":{"id":87364,"url":"http://patchwork.ozlabs.org/api/people/87364/","name":"Kuan-Wei Chiu","email":"visitorckw@gmail.com"},"content":"Hi Angelo,\n\nOn Thu, Apr 16, 2026 at 02:14:27PM +0200, Angelo Dureghello wrote:\n> Add support for mmc.\n> \n> Signed-off-by: Angelo Dureghello <angelo@kernel-space.org>\n\nit looks like the changes to stmark2_defconfig were edited manually.\nCould you please use make savedefconfig to generate this file?\n\nRegards,\nKuan-Wei\n\n$ make stmark2_defconfig\n$ make savedefconfig\n$ diff -u configs/stmark2_defconfig defconfig\n--- configs/stmark2_defconfig   2026-04-25 17:01:03.607521115 +0000\n+++ defconfig   2026-04-25 17:01:11.186044050 +0000\n@@ -28,18 +28,17 @@\n # CONFIG_CMD_IMPORTENV is not set\n CONFIG_CMD_I2C=y\n # CONFIG_CMD_LOADS is not set\n+CONFIG_CMD_MMC=y\n CONFIG_CMD_SPI=y\n # CONFIG_CMD_SETEXPR is not set\n CONFIG_CMD_CACHE=y\n-CONFIG_CMD_MTDPARTS=y\n-CONFIG_MTDIDS_DEFAULT=\"nor0=spi-flash.0\"\n-CONFIG_MTDPARTS_DEFAULT=\"mtdparts=spi-flash.0:1m(u-boot),7m(kernel),-(rootfs)\"\n-CONFIG_CMD_MMC=y\n CONFIG_CMD_EXT2=y\n CONFIG_CMD_EXT4=y\n CONFIG_CMD_FAT=y\n CONFIG_CMD_FS_GENERIC=y\n-CONFIG_DOS_PARTITION=y\n+CONFIG_CMD_MTDPARTS=y\n+CONFIG_MTDIDS_DEFAULT=\"nor0=spi-flash.0\"\n+CONFIG_MTDPARTS_DEFAULT=\"mtdparts=spi-flash.0:1m(u-boot),7m(kernel),-(rootfs)\"\n CONFIG_ENV_IS_IN_SPI_FLASH=y\n CONFIG_ENV_SPI_CS=1\n CONFIG_ENV_RELOC_GD_ENV_ADDR=y\n@@ -48,9 +47,8 @@\n CONFIG_NO_NET=y\n CONFIG_DM_I2C=y\n CONFIG_SYS_I2C_FSL=y\n-CONFIG_MTD=y\n CONFIG_MMC=y\n-CONFIG_FSL_ESDHC_IMX=y\n+CONFIG_MTD=y\n CONFIG_DM_SPI_FLASH=y\n CONFIG_SPI_FLASH_ISSI=y\n CONFIG_SPI_FLASH_MTD=y\n\n> ---\n>  configs/stmark2_defconfig | 18 +++++++++++++-----\n>  1 file changed, 13 insertions(+), 5 deletions(-)\n> \n> diff --git a/configs/stmark2_defconfig b/configs/stmark2_defconfig\n> index ae1fa34df2a..763cbac158d 100644\n> --- a/configs/stmark2_defconfig\n> +++ b/configs/stmark2_defconfig\n> @@ -3,19 +3,19 @@ CONFIG_TEXT_BASE=0x47E00000\n>  CONFIG_SYS_MALLOC_LEN=0x40000\n>  CONFIG_SF_DEFAULT_SPEED=50000000\n>  CONFIG_ENV_SIZE=0x2000\n> -CONFIG_ENV_OFFSET=0x40000\n> +CONFIG_ENV_OFFSET=0x80000\n>  CONFIG_ENV_SECT_SIZE=0x10000\n>  CONFIG_DEFAULT_DEVICE_TREE=\"stmark2\"\n> -CONFIG_SYS_MONITOR_LEN=262144\n> -CONFIG_SYS_LOAD_ADDR=0x40010000\n> +CONFIG_SYS_MONITOR_LEN=327680\n> +CONFIG_SYS_LOAD_ADDR=0x42000000\n>  CONFIG_TARGET_STMARK2=y\n>  CONFIG_SYS_BARGSIZE=256\n>  CONFIG_SYS_MONITOR_BASE=0x47E00400\n>  CONFIG_TIMESTAMP=y\n>  CONFIG_USE_BOOTARGS=y\n> -CONFIG_BOOTARGS=\"console=ttyS0,115200 root=/dev/ram0 rw rootfstype=ramfs rdinit=/bin/init devtmpfs.mount=1\"\n> +CONFIG_BOOTARGS=\"console=ttyS0,115200 root=/dev/ram0 rw rootfstype=ramfs rdinit=/sbin/init devtmpfs.mount=1\"\n>  CONFIG_USE_BOOTCOMMAND=y\n> -CONFIG_BOOTCOMMAND=\"sf probe 0:1 50000000; sf read ${loadaddr} 0x100000 ${kern_size}; bootm ${loadaddr}\"\n> +CONFIG_BOOTCOMMAND=\"run boot_sd; bootm ${loadaddr} ${loadaddr_ramfs}\"\n>  CONFIG_SYS_PBSIZE=283\n>  # CONFIG_DISPLAY_BOARDINFO is not set\n>  CONFIG_SYS_MALLOC_BOOTPARAMS=y\n> @@ -34,6 +34,12 @@ CONFIG_CMD_CACHE=y\n>  CONFIG_CMD_MTDPARTS=y\n>  CONFIG_MTDIDS_DEFAULT=\"nor0=spi-flash.0\"\n>  CONFIG_MTDPARTS_DEFAULT=\"mtdparts=spi-flash.0:1m(u-boot),7m(kernel),-(rootfs)\"\n> +CONFIG_CMD_MMC=y\n> +CONFIG_CMD_EXT2=y\n> +CONFIG_CMD_EXT4=y\n> +CONFIG_CMD_FAT=y\n> +CONFIG_CMD_FS_GENERIC=y\n> +CONFIG_DOS_PARTITION=y\n>  CONFIG_ENV_IS_IN_SPI_FLASH=y\n>  CONFIG_ENV_SPI_CS=1\n>  CONFIG_ENV_RELOC_GD_ENV_ADDR=y\n> @@ -43,6 +49,8 @@ CONFIG_NO_NET=y\n>  CONFIG_DM_I2C=y\n>  CONFIG_SYS_I2C_FSL=y\n>  CONFIG_MTD=y\n> +CONFIG_MMC=y\n> +CONFIG_FSL_ESDHC_IMX=y\n>  CONFIG_DM_SPI_FLASH=y\n>  CONFIG_SPI_FLASH_ISSI=y\n>  CONFIG_SPI_FLASH_MTD=y\n> -- \n> 2.53.0\n>","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=VlpW4ddQ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.b=\"VlpW4ddQ\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=visitorckw@gmail.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2x2v0CCLz1yHS\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 26 Apr 2026 03:02:30 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 6EFFC840AB;\n\tSat, 25 Apr 2026 19:02:28 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 5F7B0842BF; Sat, 25 Apr 2026 19:02:27 +0200 (CEST)","from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com\n [IPv6:2607:f8b0:4864:20::1036])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 2E3E580087\n for <u-boot@lists.denx.de>; Sat, 25 Apr 2026 19:02:25 +0200 (CEST)","by mail-pj1-x1036.google.com with SMTP id\n 98e67ed59e1d1-362ddc1de56so1862286a91.1\n for <u-boot@lists.denx.de>; Sat, 25 Apr 2026 10:02:25 -0700 (PDT)","from google.com (61-230-36-6.dynamic-ip.hinet.net. [61.230.36.6])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-361410bafa9sm26946189a91.15.2026.04.25.10.02.21\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 25 Apr 2026 10:02:23 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_GMAIL_RCVD,FREEMAIL_FROM,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,UPPERCASE_50_75\n autolearn=no autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777136544; x=1777741344; darn=lists.denx.de;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=O7TtxyxFXFkfRnjj/wzyKATo8ENPdXnEmenWmHaRghs=;\n b=VlpW4ddQNuXOSL2cPzkJ4XNWsW8PuKY2za6xzp7xJiTIZCs4lWeB+tC2rQNGJMYGZs\n JWVpkyOHCLwzH+3zxHHVPjgmL/zcDMCoR1q2duUHZ3s2x8kg3a5b8eQ6mFBLwTUedYP7\n Wf9WGXad0HKFy9/5k4CUhxRiGyHFNeWoyJW2QJcVsoJ3fwQ2ZXFxbZxMBiNliX4feczQ\n vMW8El40jgNS3hdS1XYjIqB5N9K+tBggYjaUE3xOtq6JV916HX/QA2LWARnZtSyZdsf2\n KpVFA/kk/Hzu58TAjHm7tcJkNwb7m6WdL6TnHcxDV9OGEcp65jVJejKlx9qczyLLsJv0\n VRDg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777136544; x=1777741344;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=O7TtxyxFXFkfRnjj/wzyKATo8ENPdXnEmenWmHaRghs=;\n b=rg2+0mZz6NQ4WWrV6EM9/bl+d6cABLSrYTac0bRHQZYVpp3my8Ndp9HfXa1+c//4p/\n /1y6fR4oI+nSbFhKpwWVgnjiYvN1uXyOHR8KD+Ar4dxmJcoONGo8XYX+5X5uFdOq195S\n RfzCKrGBaSAPplO+SJeKQl6T56NR9GM8DDroe94f3z6eUbWepvI1qomSh46BT0pGUVbW\n SjkaKv78rxVaK3QBFJijzODvElxK2Kn5g5uKzmAqVyEbsBwOGg3aXChK9zeAaVxuRalr\n CejBmxfSsyGHihBQ/YI9I7FgpB5YPFvlv36sC4Z5u63+Egvf77BLB+2I3UeNanRRWb5x\n kfFQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8cnBsScOGyXer8xWYgutjbWHlIVMHsf6fsWhKhYRx9u3uRT6icWhD5dt2aOIYN1uX9Buazz/U=@lists.denx.de","X-Gm-Message-State":"AOJu0Yy/C12z8qlY3/RTp8TK3wdFyuanYW3KbVu0XdNLQE79ATz9EhXi\n w1mx4gvVFGA1tiUjyO7kJyEdsnRQ90XXq2tS7cXqzIodd4tL+WTbNRgzQlCVKQ==","X-Gm-Gg":"AeBDieu/RY0ZTTkyUvwSDvPIsxHTFcSUWcfmb9N3fq8Ce/a1FZTHDXGxCDlAJWg8O5M\n 566e6P0oLy/NhePfW0HjYSEsZ88o0bQcGL6SnOzGXPwju/4CIgoNQpJZAE7j/iKhh/Z637R4s5y\n rTjKgzsgNF0/jChi4r/vpSaCaqW2B9tdLSkv4nwPh+78SajwN/MY0iJuSGMWLl6AEwGVeNm1XXe\n dO+ROXupNySmL7qipPzOcQ+gWe1AyOtT9WdmucYY8tcOYep6zw93PE24VQlmyWLdfotZzl9aw5L\n eQbCj29EMzq5uXgZL2XNLgPpdDcK1D6ftlylQc+M968KRBoGFoh3CkCZL0xT6LCZzf01+VV8NKN\n B/S2yyom/gBh8OkT4mURkVBcNIXK/+2a3CgZmAGG0D4N8xaOPDYPW+gl2gQcbAdQVlA/DMOYg2m\n SpzkpNu1X2hhId1issEEuPwVLtXBU6ftTMNNUDZBgyBSyA1lTotaI4RNHWi5s+XDUWbB+OB6i4v\n uw1QnMJzQl88w==","X-Received":"by 2002:a17:90b:3504:b0:35f:b6a1:8d27 with SMTP id\n 98e67ed59e1d1-3614046f76amr40664848a91.18.1777136543482;\n Sat, 25 Apr 2026 10:02:23 -0700 (PDT)","Date":"Sun, 26 Apr 2026 01:02:20 +0800","From":"Kuan-Wei Chiu <visitorckw@gmail.com>","To":"Angelo Dureghello <angelo@kernel-space.org>","Cc":"trini@konsulko.com, u-boot@lists.denx.de, sjg@chromium.org","Subject":"Re: [PATCH 5/9] configs: stmark2: add support for mmc","Message-ID":"<aezznOpfVei-LZF8@google.com>","References":"<20260416121431.20852-1-angelo@kernel-space.org>\n <20260416121431.20852-5-angelo@kernel-space.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260416121431.20852-5-angelo@kernel-space.org>","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]