[{"id":3678376,"web_url":"http://patchwork.ozlabs.org/comment/3678376/","msgid":"<76337dfb-ce4d-4b22-9c41-e91a5790e850@intel.com>","list_archive_url":null,"date":"2026-04-16T20:51:20","subject":"Re: [Intel-wired-lan] [PATCH v2 iwl-net] i40e: keep q_vectors array\n in sync with channel count changes","submitter":{"id":9784,"url":"http://patchwork.ozlabs.org/api/people/9784/","name":"Jacob Keller","email":"jacob.e.keller@intel.com"},"content":"On 4/16/2026 4:40 AM, Maciej Fijalkowski wrote:\n> For the main VSI, i40e_set_num_rings_in_vsi() always derives\n> num_q_vectors from pf->num_lan_msix. At the same time, ethtool -L stores\n> the user requested channel count in vsi->req_queue_pairs and the queue\n> setup path uses that value for the effective number of queue pairs.\n> \n> This leaves queue and vector counts out of sync after shrinking channel\n> count via ethtool -L. The active queue configuration is reduced, but the\n> VSI still keeps the full PF-sized q_vector topology.\n> \n> That mismatch breaks reconfiguration flows which rely on vector/NAPI\n> state matching the effective channel configuration. In particular,\n> toggling /sys/class/net//threaded after reducing the channel count\n> can hang, and later channel-count changes can fail because VSI reinit\n> does not rebuild q_vectors to match the new vector count.\n> \n> Fix this by making the main VSI num_q_vectors follow the effective\n> requested channel count, capped by the available MSI-X vectors. Update\n> i40e_vsi_reinit_setup() to rebuild q_vectors during VSI reinit so the\n> vector topology is refreshed together with the ring arrays when channel\n> count changes.\n> \n> Keep alloc_queue_pairs unchanged and based on pf->num_lan_qps so the VSI\n> retains its full queue capacity.\n> \n> Selftest napi_threaded.py was originally used when Jakub reported hang\n> on /sys/class/net//threaded toggle. In order to make it pass on\n> i40e, use persistent NAPI configuration for q_vector NAPIs so NAPI\n> identity and threaded settings survive q_vector reallocation across\n> channel-count changes. This is achieved by using netif_napi_add_config()\n> when configuring q_vectors.\n> \n> $ export NETIF=ens259f1np1\n> $ sudo -E env PATH=\"$PATH\" ./tools/testing/selftests/drivers/net/napi_threaded.py\n> TAP version 13\n> 1..3\n> ok 1 napi_threaded.napi_init\n> ok 2 napi_threaded.change_num_queues\n> ok 3 napi_threaded.enable_dev_threaded_disable_napi_threaded\n> Totals: pass:3 fail:0 xfail:0 xpass:0 skip:0 error:0\n> \n> Reported-by: Jakub Kicinski \n> Closes: https://lore.kernel.org/intel-wired-lan/20260316133100.6054a11f@kernel.org/\n> Fixes: d2a69fefd756 (\"i40e: Fix changing previously set num_queue_pairs for PFs\")\n> Signed-off-by: Maciej Fijalkowski \n> ---\n> v2:\n> - NULL vsi->tx_rings in i40e_vsi_alloc_arrays() (Sashiko)\n> ---\n\nThanks Maciej,\n\nI'll go ahead and replace the older version of the fix on dev-queue\ntoday. Apologies for missing the exchange related to this and the\nprevious fix :(\n\nThanks,\nJake","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=xzWqqGMK;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxVYK0z3nz1yD3\n\tfor ; Fri, 17 Apr 2026 06:51:32 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id E7A6C60AA0;\n\tThu, 16 Apr 2026 20:51:30 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 36W5tKQ-w--T; Thu, 16 Apr 2026 20:51:30 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 1B16C60A3D;\n\tThu, 16 Apr 2026 20:51:30 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133])\n by lists1.osuosl.org (Postfix) with ESMTP id 2A8FAEE\n for ; Thu, 16 Apr 2026 20:51:29 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 0FB314041B\n for ; Thu, 16 Apr 2026 20:51:29 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Ps2Sgf5n6kQl for ;\n Thu, 16 Apr 2026 20:51:28 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.16])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 26AC940164\n for ; Thu, 16 Apr 2026 20:51:27 +0000 (UTC)","from fmviesa008.fm.intel.com ([10.60.135.148])\n by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 16 Apr 2026 13:51:27 -0700","from fmsmsx901.amr.corp.intel.com ([10.18.126.90])\n by fmviesa008.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 16 Apr 2026 13:51:27 -0700","from FMSMSX902.amr.corp.intel.com (10.18.126.91) by\n fmsmsx901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Thu, 16 Apr 2026 13:51:26 -0700","from fmsedg903.ED.cps.intel.com (10.1.192.145) by\n FMSMSX902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Thu, 16 Apr 2026 13:51:26 -0700","from SA9PR02CU001.outbound.protection.outlook.com (40.93.196.37) by\n edgegateway.intel.com (192.55.55.83) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Thu, 16 Apr 2026 13:51:24 -0700","from PH0PR11MB7588.namprd11.prod.outlook.com (2603:10b6:510:28b::16)\n by MW4PR11MB6618.namprd11.prod.outlook.com (2603:10b6:303:1ec::22)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.20; Thu, 16 Apr\n 2026 20:51:22 +0000","from PH0PR11MB7588.namprd11.prod.outlook.com\n ([fe80::42ad:6451:1ae2:edd3]) by PH0PR11MB7588.namprd11.prod.outlook.com\n ([fe80::42ad:6451:1ae2:edd3%3]) with mapi id 15.20.9818.017; Thu, 16 Apr 2026\n 20:51:21 +0000"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org 1B16C60A3D","OpenDKIM Filter v2.11.0 smtp2.osuosl.org 26AC940164"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776372690;\n\tbh=ti218o62VAlO8sUaBxtgj7qMJEkEnv9FeQiYHCITeHc=;\n\th=Date:To:CC:References:From:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=xzWqqGMK4WWEtoUEFdExKjs1GVgvFLm2GGCJYRvTo2LhliexzbHWfq3ZewPIFOOqS\n\t RCLh6M99BJcg75rpZvvA1IMbTTFyWGIFQ1v4HtOAntm/lvRFdeisD5ZE0fsF5ynqFN\n\t Xy3R8VXzfJKMeQG1PeLaVQVKtD4aejrxREFadzq56duDvlJdXgYGRlAwprIWTP5etT\n\t DS5PJYt9fRLnILNd3hijrdr0eXU2KrXCv1V00IDnbaU1k+5EiEqAWeR0tvMLeSeAFZ\n\t GbnZSoVJGUgCp+bM4Hf+gBBBwQ1oDiA/1MPj0ZAiAtmZPhjuFkjHmb5ksZaipiWPmG\n\t 9Dg7hbeUQQmLA==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.16;\n helo=mgamail.intel.com; envelope-from=jacob.e.keller@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org 26AC940164","X-CSE-ConnectionGUID":["K+64knAAQbu/DqSSkdgjgw==","c01Dl0R3T+m5TomQmYB/FQ=="],"X-CSE-MsgGUID":["YwdKg4G6SiWfFB7hlcG8Kg==","Wo76MQDmS7CwKC4QCIJaMQ=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11761\"; a=\"64926419\"","E=Sophos;i=\"6.23,181,1770624000\"; d=\"scan'208\";a=\"64926419\"","E=Sophos;i=\"6.23,181,1770624000\"; d=\"scan'208\";a=\"228170834\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=POn/LNXu4rkgI+OC9isO/ytjTrRs+FcIHLlVzyqvQVHd5ZgbwUKFWNGUb7xYSbqOb7mo6hNP5b6+uPB36hFe4uuAhh0zaWv6k/eQL0WIrpRq8xQbEdFU5BKTLwvaAcPmwsEjy3Hc94IR3B5uP0hDRSP9t+vey2STqqQDSJS8HENjuxSe59qwQ4fKAyDaGfES50GMU9x4nkEe2r4yJ90R/1dc/i9aI7QObIJZFcz2cwp0i0VGGfa7Y4CSg7Tvogfr3Sr2sRhG6+1b0tcDZeNAoMl8idpj+LsuPK+Da3qbQjoQ7S2GnzETR6dnr0oGLZjMcw1wWyt1VEjlk8gYqu5/GQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=ti218o62VAlO8sUaBxtgj7qMJEkEnv9FeQiYHCITeHc=;\n b=frkZ8moMuI9hLRgjxytmtzBqrow5DoMotJwfMJ1Rgp7nUgB+OCbvyWnGX/N8H+ws2MFb1s4ZpgCChGVGqhAfyYDdMKjxZyinFfIfWtjaZ5kOtVILNw4DqA011CLJK26/V3HbxhjZrqwCnhsZl9fLW0pQ72o3tT8i43/WWjRVYgKUg86W7HU+giEsiNGa78S8T+4cm2p6tT+n4K/ABol3Fq7nlFmZ2pInjFcg+JmzBZvZ+ebWULX8tVWtKNm1OvHL3IfX21cysWKpFtomzFYc7SUXehp4xL66C9zUgTavig5Lp2Y/pBoi/9NeyFIopfMBMr/auMre/EeH9ULCiai1sw==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none","Message-ID":"<76337dfb-ce4d-4b22-9c41-e91a5790e850@intel.com>","Date":"Thu, 16 Apr 2026 13:51:20 -0700","User-Agent":"Mozilla Thunderbird","To":"Maciej Fijalkowski ,\n ","CC":", , ,\n , , ","References":"<20260416114046.642171-1-maciej.fijalkowski@intel.com>","Content-Language":"en-US","From":"Jacob Keller ","In-Reply-To":"<20260416114046.642171-1-maciej.fijalkowski@intel.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"MW4PR04CA0224.namprd04.prod.outlook.com\n (2603:10b6:303:87::19) To PH0PR11MB7588.namprd11.prod.outlook.com\n (2603:10b6:510:28b::16)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"PH0PR11MB7588:EE_|MW4PR11MB6618:EE_","X-MS-Office365-Filtering-Correlation-Id":"1dfc6676-ae0e-48ba-20b1-08de9bf9ea85","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|366016|1800799024|376014|56012099003|18002099003|22082099003;","X-Microsoft-Antispam-Message-Info":"\n HTtnb5w0aUQ6EikpVoegaclu6lUTy4pRq1tnq3zN5HsR2Xhd76MlLQS5ZhRYaBfFKu54SPgz0tLm8dMBjTS2CD3z/uWsGyt3CokHmny26kdWaDY0IW+d0j0tLGxAOZvoonTEP4/qIS4cIpefVI55NK3jVN+MXFyAVSRTN5LAQSfZI+W9wEzBgZd5L1kzLb4L10fjq0DESBmQy8tRiDFo5lmwsfqTXL5VsOPREIV+kRkjMYbQQw63Dc6s16EQNll01lsF3g8mJwMdUoI835veeV6g4HMeZNxub3P3r/ijSy3kmf/Ep+86fesU2Q2y4Lrq72B4DDR25D+TchS2KuIidl0a4HI9PJwNnLwqlwv/zMPoZUoUilEPN/O/bI1lfmi3bet/izktP5pkcGgSJ8opQgZLpS8W2myGW0M2v+V0tqRGncHtJvtpq5w2xwdN4BUoOsH7/97pWyByTDV50lW7ayIce4oCyONbThBZCcGPws65lwawwMGxQ9JydJJo4pGHj9l0wSv70YIOrnxX0UsH6FMtk7UDLJLTbRV3wuRBSFQmlIaBAjSzLef6BNGH9UoBhqYYT8+1AEY+/EDNHm+nwTvar/isYU7U75XtITIV1dFtOi0e3GAoBe6/xUoVDNWZlU2mfQOPNbbC5hCZ31v70AnDcL6zcZazRr5sJ0Jdl9mPAfwXaQCztO8rPfSaXlE81H8TPy5M+gDetLqFed6glP22Qo9C3AZ8aBXXQ9hs4fE=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:PH0PR11MB7588.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(366016)(1800799024)(376014)(56012099003)(18002099003)(22082099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?h0nte3P7NRYqnvxnguvqpDFqRITe?=\n\t=?utf-8?q?4lHcjUBTQopMcPwsEtPDcYUIK4HohcwzG0t5ergm7hOZpxZQ70C9IO5VhutMOMTbM?=\n\t=?utf-8?q?7NubBz0lPLeYFjbF/9XwX1vsyfsWl5I61IoXDRwG9Vm5vXo3ftLsjTXzbS8hLr7A1?=\n\t=?utf-8?q?g55Hjl5X/6Ud6x4iHQFiHavSy3zy6zKQGAK1h/AqwSOWIT21+4VPXRCd1lSCX8dvi?=\n\t=?utf-8?q?yMCi18pF3yKaQWvN1URw39upKKm4fnpC9BN3IBbQYZY5g+ErwPOr8m3lIvx6LzA29?=\n\t=?utf-8?q?mFBB8Zkb9cyiWUggrlp1y0ai+gfzYVmiL6K0u1PRRiAM9yo4QboDiGAVDzgTptq9J?=\n\t=?utf-8?q?UB8IerZkNbnS/wdi3xhv1t68rUcB8XrpmVv+/7XK9Zbpaok2VlYME/EFEoLS2SL5u?=\n\t=?utf-8?q?2G4e/ZO+x5s9Dif/ly+4kLKhcM3YGjAN7B+fqJOlcCImif9bSbGkN1JIkrv0eMdZN?=\n\t=?utf-8?q?kofhQ/Z9tKozsy1u3JtUMj8YOQ1THufVbqGY8ppy558szdDi/YoLhbckINuNU8GzP?=\n\t=?utf-8?q?hAil03rt/AISACn/ngvUtsRZ474Sg/3fc1cgfS9johU2Vp7X82GlSS2ZkIhT4uSzC?=\n\t=?utf-8?q?QaPkGHH5/u/7iH8tyQ/6+WcvwmwBofxN88LYSoyYnsC59KlL1xJhpoDJHpBHKJcdU?=\n\t=?utf-8?q?JCVWsgi2xqs6Hp3O3YaSSk7zPOXC8LwI4uNiRmUQzt4LF++6HdCavYRWgX4/jFXCA?=\n\t=?utf-8?q?UYx12a+VwfSCExYh+lOgzC3kGTEKF9rPUNjfd8RfzF8SPE4oHC4YiL8eaW+GGhJDB?=\n\t=?utf-8?q?G4u21uq86UiTCj94JmBXb0w6yCDteNlrJLcGChqfYaF+Tc28RiVc9V9df1FZ19qKq?=\n\t=?utf-8?q?q8jSvDKLgJ37XScZntJkP2+cj2A2vMsz2uX2S51NXHV7LjeJJYeS4L39EC1bK+dqE?=\n\t=?utf-8?q?rY4Pz7AkWTEdRGGY9HYKyabdrstsq7mqeGBLr1cWuKCWKWaRpOEks8Omxiap7f64N?=\n\t=?utf-8?q?zM9GdG0hXw0XrKFa3DYIzqxi9++eTJGfRVAxKErmfG2GrKajOlbOEgDPxLVtkJ9oi?=\n\t=?utf-8?q?eNkzA3Bz+qbjXXu0LelwtfXZN1AJLIyk0a9SF8A6KRpPP2VqGXlWYk/Yh3jRJnjqM?=\n\t=?utf-8?q?PR9BBZCbP6WNRBhi1dCfva3JT1PwWBQXeOo6zKy78P3sQ0X9YLcngqBedkgBdk5lD?=\n\t=?utf-8?q?s1t/nVGsj5SXn9dX1uTxQcAdkIs2oMb6sCGljJNXAIT45e4nCZ6Trd3nOniTDcCsP?=\n\t=?utf-8?q?XJLn/n0tC2o7Z/MfNHqifb+EbO4+W/Sgtxvrwk8dYb6LQe2hd/uUMf2V4zC+GucfQ?=\n\t=?utf-8?q?rkpxZTMGP2FvikbK3RAf3/ErizzAO6SvnfyACFqCzcsR0rqx+AVl7CsUoWrycsLJ6?=\n\t=?utf-8?q?l4mG4+Xl5lmKXQJXva6z2H0tKky6Dg+uDBoI8v71nythtEw0Y/tWYAs08YeQ+cEp/?=\n\t=?utf-8?q?U2jleBwQBoiX6i/A10qIRr5JTyvTjORifuXT4Zcp7rcGqNeTNFepFa2gRiv7T8i4r?=\n\t=?utf-8?q?zmKWOcCEOvKKABUvysuNYhYqYQMsO7xvqQgfNLuRf3RV4v+aDd34SKwuAHzYKAj0U?=\n\t=?utf-8?q?fNWSwvDO2WkGouhenF0H6qBAzn/A49ixq5BdDKWUr4eQ2KmKcRagW+XoZFTnNKw0J?=\n\t=?utf-8?q?/DXxioCg9kbjVFeNp1EODvFrOHzPdliKT2mGPwbVluyHE1Q3GR+QKGJA8RdAF/+bX?=\n\t=?utf-8?q?oQkvHNJgeMH6CLQR49UyaoXDPRhYNgcA=3D=3D?=","X-Exchange-RoutingPolicyChecked":"\n MpETeA9rK3OyYW2veUvWK6NYnVon+lYjXj/d+CsVdiqKNsyHGtmBV8ds16UlR3319PcHafyRbWhjL+J8o8p6G9k6TcaW/AEutFKZTERbpIzltaTf3Q9w0XO2lbhEiyYqIsttihIhN4uSLJECx6EU/oJBJKsf4sdA4tyxEbTuGOSpik4sIjyuNVQe363xiyUFU9wlto7hXKK0+SqyD3OmBEG/duQW8qNPRbgzE9SMave03uI1RpGRuikkpFHvQu4vrdHC0Pk7BaisyX1OdSklwCr037ezT5xrPR6lezgWb7XKFi+ecWANjlXNZigT6fUgs1CheV6eIz/IkUCRYMNU5A==","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 1dfc6676-ae0e-48ba-20b1-08de9bf9ea85","X-MS-Exchange-CrossTenant-AuthSource":"PH0PR11MB7588.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"16 Apr 2026 20:51:21.8291 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n l8LqbSL536NtC7pAsQ7RCzuXJb4i4W3ld/4lTSxZKq3J1mfdqZRbudajWOP2DuDrr4e0vFgYZ3ijwGTFGzToT1IJ0PPchyHO+IXa22rlAPI=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"MW4PR11MB6618","X-OriginatorOrg":"intel.com","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776372688; x=1807908688;\n h=message-id:date:subject:to:cc:references:from:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=Sj6Zyx5uwak2P0dl7IyJgxXkgLmpjXvLKgCTX5ujcOo=;\n b=dkx3t3eOC3BuuZDjwC+n0eZA0Sp03NnKiBsI49PvHcjPPT9LRIX1xGsY\n 13UxFL/0AidEQ196EC86xvLsVtyw00CnTa2IBihxOr/wjLepngaqqdZK6\n LyGewzemzdM6/2iQTw6RohnMiFbtQDO3RH05pELikF4XT+MpOaZJ+7ErG\n 9fbw1zrkOHhrOhW8qCR8aT16Fix99+gJ1lf+83Wm3o7G+D+qs0S+1mq2a\n Zz/PVsKdF5E7AB6EJ4miWPcOxIODmJunP28tSL72jB5S04V1x7Q48ZuIR\n xG6EGLkT/OT7mIWTL2ToCain8LUDdfqa68DnKPTx5UEsbHOvpCSbbmTUE\n w==;","X-Mailman-Original-Authentication-Results":["smtp2.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp2.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=dkx3t3eO","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Subject":"Re: [Intel-wired-lan] [PATCH v2 iwl-net] i40e: keep q_vectors array\n in sync with channel count changes","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3679259,"web_url":"http://patchwork.ozlabs.org/comment/3679259/","msgid":"<20260420072050.GP280379@horms.kernel.org>","list_archive_url":null,"date":"2026-04-20T07:20:50","subject":"Re: [Intel-wired-lan] [PATCH v2 iwl-net] i40e: keep q_vectors array\n in sync with channel count changes","submitter":{"id":82748,"url":"http://patchwork.ozlabs.org/api/people/82748/","name":"Simon Horman","email":"horms@kernel.org"},"content":"On Thu, Apr 16, 2026 at 01:40:46PM +0200, Maciej Fijalkowski wrote:\n> For the main VSI, i40e_set_num_rings_in_vsi() always derives\n> num_q_vectors from pf->num_lan_msix. At the same time, ethtool -L stores\n> the user requested channel count in vsi->req_queue_pairs and the queue\n> setup path uses that value for the effective number of queue pairs.\n> \n> This leaves queue and vector counts out of sync after shrinking channel\n> count via ethtool -L. The active queue configuration is reduced, but the\n> VSI still keeps the full PF-sized q_vector topology.\n> \n> That mismatch breaks reconfiguration flows which rely on vector/NAPI\n> state matching the effective channel configuration. In particular,\n> toggling /sys/class/net//threaded after reducing the channel count\n> can hang, and later channel-count changes can fail because VSI reinit\n> does not rebuild q_vectors to match the new vector count.\n> \n> Fix this by making the main VSI num_q_vectors follow the effective\n> requested channel count, capped by the available MSI-X vectors. Update\n> i40e_vsi_reinit_setup() to rebuild q_vectors during VSI reinit so the\n> vector topology is refreshed together with the ring arrays when channel\n> count changes.\n> \n> Keep alloc_queue_pairs unchanged and based on pf->num_lan_qps so the VSI\n> retains its full queue capacity.\n> \n> Selftest napi_threaded.py was originally used when Jakub reported hang\n> on /sys/class/net//threaded toggle. In order to make it pass on\n> i40e, use persistent NAPI configuration for q_vector NAPIs so NAPI\n> identity and threaded settings survive q_vector reallocation across\n> channel-count changes. This is achieved by using netif_napi_add_config()\n> when configuring q_vectors.\n> \n> $ export NETIF=ens259f1np1\n> $ sudo -E env PATH=\"$PATH\" ./tools/testing/selftests/drivers/net/napi_threaded.py\n> TAP version 13\n> 1..3\n> ok 1 napi_threaded.napi_init\n> ok 2 napi_threaded.change_num_queues\n> ok 3 napi_threaded.enable_dev_threaded_disable_napi_threaded\n> Totals: pass:3 fail:0 xfail:0 xpass:0 skip:0 error:0\n> \n> Reported-by: Jakub Kicinski \n> Closes: https://lore.kernel.org/intel-wired-lan/20260316133100.6054a11f@kernel.org/\n> Fixes: d2a69fefd756 (\"i40e: Fix changing previously set num_queue_pairs for PFs\")\n> Signed-off-by: Maciej Fijalkowski \n> ---\n> v2:\n> - NULL vsi->tx_rings in i40e_vsi_alloc_arrays() (Sashiko)\n\nReviewed-by: Simon Horman \n\n> ---\n> drivers/net/ethernet/intel/i40e/i40e_main.c | 35 +++++++++++++++++----\n> 1 file changed, 29 insertions(+), 6 deletions(-)\n> \n> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\n> index 926d001b2150..1d2a4181966f 100644\n> --- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n> +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n> @@ -11403,10 +11403,14 @@ static void i40e_service_timer(struct timer_list *t)\n> static int i40e_set_num_rings_in_vsi(struct i40e_vsi *vsi)\n> {\n> \tstruct i40e_pf *pf = vsi->back;\n> +\tu16 qps;\n> \n> \tswitch (vsi->type) {\n> \tcase I40E_VSI_MAIN:\n> \t\tvsi->alloc_queue_pairs = pf->num_lan_qps;\n> +\t\tqps = vsi->req_queue_pairs ?\n> +\t\t min_t(u16, vsi->req_queue_pairs, pf->num_lan_qps) :\n\nnit: It looks all the variables involved here u16.\n So min() can be used instead of min_t().\n\n> +\t\t pf->num_lan_qps;\n> \t\tif (!vsi->num_tx_desc)\n> \t\t\tvsi->num_tx_desc = ALIGN(I40E_DEFAULT_NUM_DESCRIPTORS,\n> \t\t\t\t\t\t I40E_REQ_DESCRIPTOR_MULTIPLE);\n> @@ -11414,7 +11418,8 @@ static int i40e_set_num_rings_in_vsi(struct i40e_vsi *vsi)\n> \t\t\tvsi->num_rx_desc = ALIGN(I40E_DEFAULT_NUM_DESCRIPTORS,\n> \t\t\t\t\t\t I40E_REQ_DESCRIPTOR_MULTIPLE);\n> \t\tif (test_bit(I40E_FLAG_MSIX_ENA, pf->flags))\n> -\t\t\tvsi->num_q_vectors = pf->num_lan_msix;\n> +\t\t\tvsi->num_q_vectors = max_t(int, 1,\n> +\t\t\t\t\t\t min_t(int, qps, pf->num_lan_msix));\n\nnit: On the left side, all values seem to be either constants or u16.\n So I think you can use clamp() here, and simply assign the resulting\n value to num_q_vectors, which is an int.\n\n> \t\telse\n> \t\t\tvsi->num_q_vectors = 1;\n> \n\n...\n\n> @@ -14265,12 +14272,27 @@ static struct i40e_vsi *i40e_vsi_reinit_setup(struct i40e_vsi *vsi)\n> \n> \tpf = vsi->back;\n> \n> +\tif (test_bit(I40E_FLAG_MSIX_ENA, pf->flags)) {\n> +\t\ti40e_put_lump(pf->irq_pile, vsi->base_vector, vsi->idx);\n> +\t\tvsi->base_vector = 0;\n> +\t}\n> +\n> \ti40e_put_lump(pf->qp_pile, vsi->base_queue, vsi->idx);\n> \ti40e_vsi_clear_rings(vsi);\n> \n> -\ti40e_vsi_free_arrays(vsi, false);\n> +\ti40e_vsi_free_q_vectors(vsi);\n> +\ti40e_vsi_free_arrays(vsi, true);\n\nnit: with this patch applied the free_vectors argument (the 2nd parameter)\n of i40e_vsi_free_arrays is always passed as true by callers.\n So I think that, as a follow-up, it can be removed.\n\n Similarly for i40e_vsi_alloc_arrays.\n\n> \ti40e_set_num_rings_in_vsi(vsi);\n> -\tret = i40e_vsi_alloc_arrays(vsi, false);\n> +\n> +\tret = i40e_vsi_alloc_arrays(vsi, true);\n> +\tif (ret)\n> +\t\tgoto err_vsi;\n> +\n> +\t/* Rebuild q_vectors during VSI reinit because the effective channel\n> +\t * count may change num_q_vectors. Keep vector topology aligned with the\n> +\t * queue configuration after ethtool's .set_channels() callback.\n> +\t */\n> +\tret = i40e_vsi_setup_vectors(vsi);\n> \tif (ret)\n> \t\tgoto err_vsi;\n> \n\n...","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=Mzz3gGjD;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzcNJ5Vc2z1yCv\n\tfor ; Mon, 20 Apr 2026 17:21:02 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 5D3C860A68;\n\tMon, 20 Apr 2026 07:21:00 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id joFICKa5jRzQ; Mon, 20 Apr 2026 07:20:59 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 7510161034;\n\tMon, 20 Apr 2026 07:20:59 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id B52EE259\n for ; Mon, 20 Apr 2026 07:20:58 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id B31A9409F0\n for ; Mon, 20 Apr 2026 07:20:58 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id S66InPKkxUIF for ;\n Mon, 20 Apr 2026 07:20:57 +0000 (UTC)","from tor.source.kernel.org (tor.source.kernel.org\n [IPv6:2600:3c04:e001:324:0:1991:8:25])\n by smtp4.osuosl.org (Postfix) with ESMTPS id B509D409D7\n for ; Mon, 20 Apr 2026 07:20:57 +0000 (UTC)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n by tor.source.kernel.org (Postfix) with ESMTP id D177160103;\n Mon, 20 Apr 2026 07:20:55 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 9C2C9C2BCB3;\n Mon, 20 Apr 2026 07:20:53 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org 7510161034","OpenDKIM Filter v2.11.0 smtp4.osuosl.org B509D409D7"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776669659;\n\tbh=ClvZ9benTKjETyOZ0inLJRRBMJYiuwXqm8O995zXYZQ=;\n\th=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=Mzz3gGjD6Y4jH+eCkh3rQfpEFv9ashIJ8f5IsHh7aw2G03f4rO50+5s/RZgQKXjrv\n\t 8wgVIeDwWyJ71ETSl2t59nnh9FiAImtC95oQtxxlyILdeslb/FoxPrdAPwBzkLCYIG\n\t PL6r33pjMgNO+NbJ0yd2zbvcWnBbB5TjEpkBCYfzuvmUF2J8rZJhqeiLjLF1EuaefW\n\t SDL2fUUZM+jm7yQARwIXB/zlFoVXRN0KIsPJqdxWeO1Q0upgbjI1MppzpCi7iXeLFm\n\t +NUnKcU7EZCsqTA16jI136efKGR+31MnlIjD66RIJB1A9P1tTJbH67y/DZzgT3N2Fq\n\t oeyMEjCdLhozw==","Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org;\n envelope-from=horms@kernel.org; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org B509D409D7","Date":"Mon, 20 Apr 2026 08:20:50 +0100","From":"Simon Horman ","To":"Maciej Fijalkowski ","Cc":"intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,\n magnus.karlsson@intel.com, kuba@kernel.org, pabeni@redhat.com,\n przemyslaw.kitszel@intel.com, jacob.e.keller@intel.com","Message-ID":"<20260420072050.GP280379@horms.kernel.org>","References":"<20260416114046.642171-1-maciej.fijalkowski@intel.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260416114046.642171-1-maciej.fijalkowski@intel.com>","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=kernel.org; s=k20201202; t=1776669655;\n bh=xDlIjLHGAoKn1DuIwoxmC7n5/0GRJIGPQDQkQQ26XZc=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=MwBbCURPXqrGD6Y9j2/rkAyKYBLYphz6v41HmH9c6GV+aaRSMss4KU8Q3FV+eqRa9\n ZaDhMZVhnEQY6Krjb27xW9ttVH9l7L5S8vwUV86/2OxShpWcPfJBNw28pnJaKwU2IT\n OhC6cNZ5MSLAcaw9exOeYtEzW/W3VYFlo4LJVCj3BGRZww444U/4eDuOotLsIGi3mU\n uG4XO543jLui8+8Mp/8WDGFXUmEK4Njy4Pp3akJcrVaihWCslAP+4uQOQFsJKVEMUH\n X2+DIODPqdv1bos6WYTZMrDxZf1BTXzcC8m84zKAwSXHhHL/k2QuiOQ2gQxsi4UJ1U\n DqWLw8ACbUeUw==","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=kernel.org","smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=MwBbCURP"],"Subject":"Re: [Intel-wired-lan] [PATCH v2 iwl-net] i40e: keep q_vectors array\n in sync with channel count changes","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3681574,"web_url":"http://patchwork.ozlabs.org/comment/3681574/","msgid":"","list_archive_url":null,"date":"2026-04-23T17:04:10","subject":"Re: [Intel-wired-lan] [PATCH v2 iwl-net] i40e: keep q_vectors array\n in sync with channel count changes","submitter":{"id":82402,"url":"http://patchwork.ozlabs.org/api/people/82402/","name":"Mekala, SunithaX D","email":"sunithax.d.mekala@intel.com"},"content":"> -----Original Message-----\n> From: Intel-wired-lan On Behalf Of Maciej Fijalkowski\n> Sent: Thursday, April 16, 2026 4:41 AM\n> To: intel-wired-lan@lists.osuosl.org\n> Cc: netdev@vger.kernel.org; Karlsson, Magnus ; kuba@kernel.org; pabeni@redhat.com; horms@kernel.org; Kitszel, Przemyslaw ; Keller, > Jacob E ; Fijalkowski, Maciej \n> Subject: [Intel-wired-lan] [PATCH v2 iwl-net] i40e: keep q_vectors array in sync with channel count changes\n>\n> For the main VSI, i40e_set_num_rings_in_vsi() always derives\n> num_q_vectors from pf->num_lan_msix. At the same time, ethtool -L stores\n> the user requested channel count in vsi->req_queue_pairs and the queue\n> setup path uses that value for the effective number of queue pairs.\n>\n> This leaves queue and vector counts out of sync after shrinking channel\n> count via ethtool -L. The active queue configuration is reduced, but the\n> VSI still keeps the full PF-sized q_vector topology.\n>\n> That mismatch breaks reconfiguration flows which rely on vector/NAPI\n> state matching the effective channel configuration. In particular,\n> toggling /sys/class/net//threaded after reducing the channel count\n> can hang, and later channel-count changes can fail because VSI reinit\n> does not rebuild q_vectors to match the new vector count.\n>\n> Fix this by making the main VSI num_q_vectors follow the effective\n> requested channel count, capped by the available MSI-X vectors. Update\n> i40e_vsi_reinit_setup() to rebuild q_vectors during VSI reinit so the\n> vector topology is refreshed together with the ring arrays when channel\n> count changes.\n>\n> Keep alloc_queue_pairs unchanged and based on pf->num_lan_qps so the VSI\n> retains its full queue capacity.\n>\n> Selftest napi_threaded.py was originally used when Jakub reported hang\n> on /sys/class/net//threaded toggle. In order to make it pass on\n> i40e, use persistent NAPI configuration for q_vector NAPIs so NAPI\n> identity and threaded settings survive q_vector reallocation across\n> channel-count changes. This is achieved by using netif_napi_add_config()\n> when configuring q_vectors.\n>\n> $ export NETIF=ens259f1np1\n> $ sudo -E env PATH=\"$PATH\" ./tools/testing/selftests/drivers/net/napi_threaded.py\n> TAP version 13\n> 1..3\n> ok 1 napi_threaded.napi_init\n> ok 2 napi_threaded.change_num_queues\n> ok 3 napi_threaded.enable_dev_threaded_disable_napi_threaded\n> Totals: pass:3 fail:0 xfail:0 xpass:0 skip:0 error:0\n>\n> Reported-by: Jakub Kicinski \n> Closes: https://lore.kernel.org/intel-wired-lan/20260316133100.6054a11f@kernel.org/\n> Fixes: d2a69fefd756 (\"i40e: Fix changing previously set num_queue_pairs for PFs\")\n> Signed-off-by: Maciej Fijalkowski \n> ---\n> v2:\n> - NULL vsi->tx_rings in i40e_vsi_alloc_arrays() (Sashiko)\n> ---\n> drivers/net/ethernet/intel/i40e/i40e_main.c | 35 +++++++++++++++++----\n> 1 file changed, 29 insertions(+), 6 deletions(-)\n\nTested-by: Sunitha Mekala (A Contingent worker at Intel)","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=GGHZgqgT;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1jB72K2nz1yCv\n\tfor ; Fri, 24 Apr 2026 03:04:29 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id C22B083C9F;\n\tThu, 23 Apr 2026 17:04:26 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id fCTGsQMhnQvF; Thu, 23 Apr 2026 17:04:21 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 713D583C9B;\n\tThu, 23 Apr 2026 17:04:21 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists1.osuosl.org (Postfix) with ESMTP id 5A6ED24D\n for ; Thu, 23 Apr 2026 17:04:20 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 3FC2A60EFE\n for ; Thu, 23 Apr 2026 17:04:20 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Y-hBWZF1gfRk for ;\n Thu, 23 Apr 2026 17:04:18 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.16])\n by smtp3.osuosl.org (Postfix) with ESMTPS id B24C860EFD\n for ; Thu, 23 Apr 2026 17:04:17 +0000 (UTC)","from fmviesa006.fm.intel.com ([10.60.135.146])\n by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Apr 2026 10:04:16 -0700","from orsmsx902.amr.corp.intel.com ([10.22.229.24])\n by fmviesa006.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Apr 2026 10:04:15 -0700","from ORSMSX903.amr.corp.intel.com (10.22.229.25) by\n ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Thu, 23 Apr 2026 10:04:14 -0700","from ORSEDG901.ED.cps.intel.com (10.7.248.11) by\n ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Thu, 23 Apr 2026 10:04:14 -0700","from CH4PR04CU002.outbound.protection.outlook.com (40.107.201.32) by\n edgegateway.intel.com (134.134.137.111) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Thu, 23 Apr 2026 10:04:14 -0700","from SA3PR11MB7527.namprd11.prod.outlook.com (2603:10b6:806:314::20)\n by DS0PR11MB8717.namprd11.prod.outlook.com (2603:10b6:8:1ab::20) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.22; Thu, 23 Apr\n 2026 17:04:10 +0000","from SA3PR11MB7527.namprd11.prod.outlook.com\n ([fe80::c347:79e5:a47b:f3a2]) by SA3PR11MB7527.namprd11.prod.outlook.com\n ([fe80::c347:79e5:a47b:f3a2%5]) with mapi id 15.20.9846.021; Thu, 23 Apr 2026\n 17:04:10 +0000"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org 713D583C9B","OpenDKIM Filter v2.11.0 smtp3.osuosl.org B24C860EFD"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776963861;\n\tbh=loZcNS8hWCWuPF8nvWSQwx6gvEILgdBXjMOQSa5FK/k=;\n\th=From:To:CC:Date:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=GGHZgqgTQ3dexlkqwua8T/WNBacPxFp0c9yl0S7YjAkP+fMYdYkQPoX4FEnFdBV5x\n\t pFf3WjeX+U5uw1ripk11Bo5UpHKi/LJ/z4ObWREGzA5//IVHR91zh+MykJ5bumoMLC\n\t GxhpP+0zUkap/Bm7H4tCdDWuIz19bDeUCxZ5qT/V9Ym7QiiOeb7VhC2rNnDG920q7k\n\t OYtAk0rnsH9unXyrfieZ/StnNzgTCIHtvoFQfVMYJu3+oxlN515iMwycXTRK15Et+W\n\t Fvsbv9SWk1xK69aHUUmTbVLsScZqAQurxU71u/g5G9KqhbNPVytfb4gtgu2kr/h+Nj\n\t g1HrGeQ7yzXdA==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.16;\n helo=mgamail.intel.com; envelope-from=sunithax.d.mekala@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org B24C860EFD","X-CSE-ConnectionGUID":["yXOlyVVtR+qGAzdkwJKazg==","l4ZCfdwCTleQZotHXWJJAw=="],"X-CSE-MsgGUID":["X40KLAKISoKHfyeTPC0zew==","jaWFthNDRyWw3DCvsQuctQ=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11765\"; a=\"78131914\"","E=Sophos;i=\"6.23,195,1770624000\"; d=\"scan'208\";a=\"78131914\"","E=Sophos;i=\"6.23,195,1770624000\"; d=\"scan'208\";a=\"228142967\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=FkhDzDoUOB1UP0E0ntUxbIe2BTc7d7zB+tsa+5YF3Olh/PQf7Im+KhSx2GVTDedF5t5fEWa5CourXNwelC6rMfWybVJlL9V+eaE47PvkDUbUgcP7sSuG/TSo6vIojqjqjhViITx+0gyl7X4gkvLQPbOqYY1Dy7Hr4qs5XvyJeajz1H7mX/S2QVd9Oo2CX10iU8zwQS147qzUHKLFnS+S9MXTAYYtc8RMvaW93pMXj7gGrF3xD3rn75ve5SwpfNzMwpgCcufCkaOUBsxSqJkTwDyiftKW9A9OHw7nu1LO4m8gqfVZ5fGz3vRnZ45QA6GGTUfTqZtC32+m8xqd71aCQQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=loZcNS8hWCWuPF8nvWSQwx6gvEILgdBXjMOQSa5FK/k=;\n b=X9hG+5pTDtXjArNAb4SEk1gGyjMzJi4w0pjDy0HKK5Jw9fvAkV0U61DBNzz4Y76mR/Ritpx1Xqd+OsK8hTKnNMvRfN0fMbcbmYfMdRXFVf9a+hK8e0SC994E9kf3jGbT2t4wbLCSf/ryy7ap9KEbjPPguR0ao26MrfGmo7svmuok6zK5OaSbD3maLaObutxcEi8KNBMvANF7DpUsQQSzGRzG0XAo5mXm8o/TIgIehV9AuI5CovcXq2wXCh4SdfWMRzgB/elBmxHq9G0/KwSC5AjGnTkWsiAtwuOA8vVpp5qVHv4/M9YiUwGNgeYUFwQ1jbycZSNHDqv+Y0s4uprDQQ==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none","From":"\"Mekala, SunithaX D\" ","To":"\"Fijalkowski, Maciej\" ,\n \"intel-wired-lan@lists.osuosl.org\" ","CC":"\"netdev@vger.kernel.org\" , \"Karlsson, Magnus\"\n , \"kuba@kernel.org\" ,\n \"pabeni@redhat.com\" , \"horms@kernel.org\"\n , \"Kitszel, Przemyslaw\" ,\n \"Keller, Jacob E\" , \"Fijalkowski, Maciej\"\n ","Thread-Topic":"[Intel-wired-lan] [PATCH v2 iwl-net] i40e: keep q_vectors array\n in sync with channel count changes","Thread-Index":"AQHczZYFWBShhEqGL025p/pva2xobrXs5ycw","Date":"Thu, 23 Apr 2026 17:04:10 +0000","Message-ID":"\n ","References":"<20260416114046.642171-1-maciej.fijalkowski@intel.com>","In-Reply-To":"<20260416114046.642171-1-maciej.fijalkowski@intel.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-ms-publictraffictype":"Email","x-ms-traffictypediagnostic":"SA3PR11MB7527:EE_|DS0PR11MB8717:EE_","x-ms-office365-filtering-correlation-id":"4dad3fcb-1149-411e-b4ee-08dea15a56ba","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"BCL:0;\n ARA:13230040|366016|1800799024|376014|38070700021|22082099003|18002099003|56012099003;","x-microsoft-antispam-message-info":"\n zRw2+VN9LJEKqzAOnEzLCiFAbAsAjDz6WuOLD+jSQtvvWfDG1i/Sok+LHlHAHo+0YvbLJQYmxDUGCqf9PBlfm9+UrXEvUsFRxDE5c5cExQ3DX2K9oxchQ+8ewrtBX+JxZNmGAwksBuExg6mosHXDIUsWaZePe6rynpVA20u4whZxyr26bTcRddNgBdtJO6z+6oByiBK39eN4z/fttzrRGJllOWABpF5E+gzBqlSCfZd2f+2TzFox8G6Wx9pkWWpWxieZGP9qI+PDXFivY6appNJj8eMDdIAbTjQHlxmwVAdNXhnCBqo7FR0GxzQcvv3OBeNDnMGQ21KnG83vd7JZ9oz2sSGk9BGMOYOArqfCmIohRRUEmJbL04XQTvBl6tzKqFIc1ab7tQ1htdk1rW4ky5xBXjQ9Sn6kD9eFxJRZgbF/Xv1fE5rr/mD964pN3l9CK7myBHgpr5iZEKKSC/YNzy0I8iJNJnhl7GQR1azNGqBrsAEF6c8CaWIpG3/TUNP6U6bC+6QgNL8FxIPShMP1cf8+TyZ3BWzQiadHwlTosVHrqKwkYZxurj5UDnjRghvwsm9/UgW9V4PR4doOXGpuQiGxia1q87gyHvVyz7tATbwO/IM1f8FxfAzIvQdsGjoXeORJhvBthnJdtgkt9i0e4In74TnFACEFbIi+lew0ZdIToY6Pq6MLBhzb4eAvHuC1TM51o9iq54k7Bmsvho+eRnQv6HpFRl+c+z2lb9iLw2dNOfNBTJjMD3iJyc7HOjRIYQPHfu6oQLnEqhLbMCewLqXK/sHVw/uMY+SdDVt2rlo=","x-forefront-antispam-report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SA3PR11MB7527.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(366016)(1800799024)(376014)(38070700021)(22082099003)(18002099003)(56012099003);\n DIR:OUT; SFP:1101;","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"\n SdZZI5O/Sn7jYqf46BxJCpYQlMfJAti64Wda2F6baEa1aHZ1brKGz25u3T6V19e28SC3Uf9wDrsosWTMus0J1PJaXbJTFVUWknLvxEDCqasqcCL9g//b7Mu5egzI49rq0FW736vH1bJl5JeLo2fJBOThP8teqJDrxa1zJbyyrmbn8mfmBlAyfUinN2YZF34XONGiV4jp3ijIGgFlCw1K3DByr+YRC7SB5z803HOu6SZCYCd5TnY/l8orhwcMi7DYYkP7SvIhJDyKxBsOu3PRGBQGHdit+8MZ9oJl3ZP2DBN1Y+iT578yWvvGHhk49jHDpT0ENVVbrtUqn1HLtkxBiRfsrOauWY15bU61TlOttQ+YsE4QCV8YeN4uMWaqYANvIePAMhGZpYBlr9xXIm7BfENd6VJyTi9qYI0mmlFrfbXqhXsSQ2ENBRub6k5JuCcgZrc3WA97Q8zuPlHR9VxiFpuLKd1ORzwjU4ecqF0FA4eZYtlVvv2zhyEQcYIux1GSr1WfKVH1cM2hy3E32EcPpTRQ8X2PsJpYm+u58yjFCsEMpW/TorUEVctGffa9HmcQtLSxattThXDQffFv8Twim40QXkTmwr7gqHIiZ2Bur8DOugGtIOXRDcNJg0VWBQSV/YYz29x16g0LrpwdddJJcA0hP6/jAllMDdvswc3sqccV+B3uiU2/MGnIsVk+LjhTBee1gUUBtzA0viPH7NXW4yhpjcY2BEi+4Yqr0qeZ0ZT++OkbKgxe8bfh3/F2OOY624hzf5XyRfyDUPL5YNui69yoF326kAxmQGfhmCG9UZw9/l8t3iUDVoaWcqVOlRJDgdp0eBhNEXF+MZU9Q49W5srp9j6+hqKKkxl2ebliRwiZSnmGgvZV0a4Qv5+sPzvcV0Ohh6Ujp/w2jij2NEKMkT/gSf2WH8AY9osGkhjRRyXerA4+g4JxZcK90reaGJ9sImTNGDLEYZzkcvkNhGs1ApsQj8Ok9nN1TZGbMmkInOHm0VEfXQXFgAD7bg4qQKr75oTEEyF9rvFJNZz7k4OZKnOOBH8GmrlDAd56WXhmL9jsdjckKW5lXOi0nTGNitOT4punFwv5bG6jvMTlJGxnJTG5/7VkUewOfPlUu24ha/8Te1ONoHlXy0IgrxQrQ1mAeIgF213hBjtSlRzoEx5yEli71hidGYGMch7QWL2mbQcBZ6bKF5/UpvLLUSt1Ztp/Jk/Lx2ICST8SphNk3Oi44tRJfRNNUoV0k3er2QdflFzBGnS7CYMWHY36/NV+Xd9g5DiNTi6Qfk8b70fcTA2ccarrH7LEVw3p7pjfhBD3Ma4ClI0U86qIU+u+E5J1VAn81Q9jLHf/l+X4tZeS1KQlt/M9Q2UlAZ9Wj+szB3aFp1htYpAQ/O6GJg8fRnisqbLv9iQWE8fyaojO+8c3ExCExRMF8Y6DzNVsobZEmC9G9cA5Bwimbr3a6DkPjjnTdxjmX3l6P4SzeZFWhtfsHZ4e5YfgdSdGoIu5QPwsojWp0Xz93vhKV2emgSv13ccCDj878eVdpfc7KxxBWr5O88VG1/nNdpqTZ9btAFydF6x0jl/w2LJNw+HifPH0131LR6lFgTj8TqRARqQY9v99ltK4xHhhDyPtlhR9YjO9CoZzF1gz9M5c9y5gewnMrif+CFtFnuhDHmeeMUX53LyVNKsbIgYCWmN/YJs6ZDBQAClhgytkkUMwBO6h6T20vDWfBoXB0ZFguCIG2W4dFPB5jKtzUQ==","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-Exchange-RoutingPolicyChecked":"\n Al+m1Ayv0e+xAfb/dCGoV1FbG2s1LrWm2+VShaE4BvOS1F+JG//xJbd2lk1RfTwEhDP0rF6bSqV1/6KlhEmKlrj8zlxQ1Xo3hvC/UCLNIU+5p1KBXBWUoVJB6QPg1kQliJhry4FpGR/pMBG+BvFXGCDp/4KlDWQke7MSXRUkRiOzWj3jqNkFRaBCCScU0DrOueqLywyIqb8vY5+O794JijmsrKy/ruRgIAXT0JY4hojv2nu2Wh4G9XvasILRky/EcLVWzBzMfu2JSG4kd2gdlVxa+Ys4ARAeezJwXRWfpJMJC+0E+3rEd2Aq9Slh1L0gk9FTurUre6G2pyOFZkbxBA==","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"SA3PR11MB7527.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 4dad3fcb-1149-411e-b4ee-08dea15a56ba","X-MS-Exchange-CrossTenant-originalarrivaltime":"23 Apr 2026 17:04:10.7199 (UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"\n k3atnm/n1IKlkQozLWOP+COXdrCKyBXDCBH8N0m8EMDNu8HyUSVXrXwcxCzjyb78GPwdVtfzKxQpX4QJOCEA7eVXqcu2AwH9umrlEwDk2LE=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DS0PR11MB8717","X-OriginatorOrg":"intel.com","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776963858; x=1808499858;\n h=from:to:cc:subject:date:message-id:references:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=WmkNqASSPSa7NH1SAAXhCRs7i5ZGoKRjs45VRegRsRc=;\n b=ejKJAXFfkJQSQSysgGXWALvTfZjWqHZiNBsA3QacEeMQiFq/i27WJaAx\n lE5mGFwsCB84Y2b6roLT22oTGfMZr86SHtK8O68EkpkcUWNq3wgDW4gfN\n f5NI2VMpu1lMk5dbTyfHQN89GZITZg1evkj4lqHeGZCJ+GJQ5PoX80mJt\n VSk19PQ+i3DtFDG6wOrank0mgOxsdiGTaJdS9RHzVxMh+nKpxyPrDimbu\n OsqPQCjilyGOMv5vQCoVh5zuZiGP4arCnbruKe2KBzufmMkjyxiUqOHhU\n JqCfzwx79Q/1d5ege2ZMY6GgRPIDWMbjbYB0ZMrTPqHc4iB2zx7NMpRaA\n g==;","X-Mailman-Original-Authentication-Results":["smtp3.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp3.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=ejKJAXFf","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Subject":"Re: [Intel-wired-lan] [PATCH v2 iwl-net] i40e: keep q_vectors array\n in sync with channel count changes","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]