[{"id":3678196,"web_url":"http://patchwork.ozlabs.org/comment/3678196/","msgid":"<20260416135252.3834-1-linuxtestproject.agent@gmail.com>","list_archive_url":null,"date":"2026-04-16T13:52:52","subject":"Re: [LTP] fsconfig04: Check FSCONFIG_SET_PATH","submitter":{"id":93132,"url":"http://patchwork.ozlabs.org/api/people/93132/","name":null,"email":"linuxtestproject.agent@gmail.com"},"content":"Hi Wei,\n\nOn Thu, 16 Apr 2026, Wei Gao wrote:\n> fsconfig04: Check FSCONFIG_SET_PATH\n\n> +#include \"old/tso_device.h\"\n\n`tst_acquire_loop_device()` is not part of the new API (`tst_device.h`).\nPlease use `tst_find_free_loopdev()` + `tst_attach_device()` from\n`tst_device.h` instead of pulling in a legacy header.\n\n> +static struct tst_test test = {\n> +\t.test_all = run,\n> +\t.setup = setup,\n> +\t.cleanup = cleanup,\n\nThe patch has a `Fixes:` link to GitHub issue #1169, making this a\nregression test. Add a `.tags` field:\n\n\t.tags = (const struct tst_tag[]) {\n\t\t{\"github\", \"1169\"},\n\t\t{}\n\t},\n\n---\nNote:\n\nOur agent completed the review of the patch. The agent can sometimes\nproduce false positives although often its findings are genuine. If you\nfind issues with the review, please comment this email or ignore the\nsuggestions.\n\nRegards,\nLTP AI Reviewer","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=H8syu/Gq;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=213.254.12.146; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [213.254.12.146])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxKGR46WRz1yCv\n\tfor ; Thu, 16 Apr 2026 23:53:03 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 600E63E2DF1\n\tfor ; Thu, 16 Apr 2026 15:53:01 +0200 (CEST)","from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id E28523E2928\n for ; Thu, 16 Apr 2026 15:52:56 +0200 (CEST)","from mail-dy1-x1342.google.com (mail-dy1-x1342.google.com\n [IPv6:2607:f8b0:4864:20::1342])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-4.smtp.seeweb.it (Postfix) with ESMTPS id B3CCC1000A32\n for ; Thu, 16 Apr 2026 15:52:55 +0200 (CEST)","by mail-dy1-x1342.google.com with SMTP id\n 5a478bee46e88-2c15849aa2cso9605531eec.0\n for ; Thu, 16 Apr 2026 06:52:55 -0700 (PDT)","from\n runnervm35a4x.13zhbfioaj5ujjbwrwpeydmywg.dx.internal.cloudapp.net\n ([20.57.198.225]) by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2de8c016305sm7742053eec.5.2026.04.16.06.52.53\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 16 Apr 2026 06:52:53 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776347574; x=1776952374; darn=lists.linux.it;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=sQ3Ql+zzhhwPo9z0WdnZgViC8aomBMjbI3Zpdqw0ZFY=;\n b=H8syu/GqsnMYjyHDKBm10a4NfMjqsmDBv5lNvhBfIQaZvDcVjGApNa/RbaGRn597RY\n 0PIdeK4nQN3eIq4MNWGGjO5JBkQQFoJAxjt4Hk/Ax4mhxrFJzrjsHTIPAnREBcRIeM26\n gRssSiteJp/C1SWxKuGeri2T5dvfBxTCB3m1I0FP4eh6epbEflGHJjz4rTURnsUcF7T+\n gpiq1g1F/uaMd6yTmOl9v33Pu6Yey+wc5LR24Fi4L77HqBRSQRV2WO96xRelDFlglElP\n AWQ6aCd1JCTvpKsBrTRvI9X7BNoQcewvb5EvBuDpwq5bLSvAXGpxbAiUbGTyhw8lSe3f\n w3Tw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776347574; x=1776952374;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=sQ3Ql+zzhhwPo9z0WdnZgViC8aomBMjbI3Zpdqw0ZFY=;\n b=TlpJUPF68m6Km4X/YCcvKJKJFhtMMFcKZGW0kGxuV6taZpEGnnSLyvbNrUveIfRwNA\n oH8mCK2FEBkS82n2cnrV9CXT36M1QBIAla3VuMDeDFxq+JPMVG3pLj8cQ35+7yAFz/Ui\n De08Z2m3BE9WUwxWA/dZeug+Cv76FoTn5gXxAa33WSbeAQr9VpktuKuH5n5R2i+zZ1Al\n VdECK9xqbCfQXO3KZpuytSKC878J1vn9YnVosd2hXLOuAA1F+D4bCJldgjDXou+WItc4\n NqExLSXYmPzknb5VSbvsKfHWtxCshjXT5TxWAVu9PSNn/2U1zr7WyLRfk38E0Ks9wJMg\n pjHA==","X-Gm-Message-State":"AOJu0YyVEqolosvKaC4MjThgWo0gYPQklDiIBAgodWAX3Al9R1WdEqPn\n Sb3x6IP29YQFOeVp7HlWNkRUOzFoUSR+nIODBoNQnzbJU/mjC/oB8VKsZdKTkf6uqyk=","X-Gm-Gg":"AeBDietqAF3pHfsLfycFQ7H2sXCRRZmc/0h4mweCDuuAy2YaKd0ch5NtxS97YtOga8X\n EIMK9lGVFj4HFZXCkz/77kiMwUe7Q1xDApxo2MwKigA/SWIVg/sUfQmMBPT0q+tbRxexAGMNPQ1\n FbTuBAq1hJiU2nUCgFtmApvPHnSbYbDnBhvrY6uUO/zMHsQ15AxQx4tP2vA63ixaxU121DhYT0g\n HSuMyPQ6EHwlIXcRvgBrXtdGw3+ZjZOePWZAxIV62usFqY79DhyTL9ZgGOVh0LJQZejQN4bcpD7\n yFKJMwykCaKslWHktEeGbH46pzH6Rmj7BGMgrW+BICBxb4+mpA8kjeog+sxuKXT1jL2L1KN8wrI\n V7zsCKE37+6MNtL4J7kQNYLTtXW6DhOLD7NpaiIC3rPiXmJ6LzQKfuCXif+o7cUAe8lUmvvJ9qh\n yTLUD2VddlDjeJJDy7DVRAXf5dif7oXSGNZAslx3q36YBDNlccBAy3i20RZ4vlLJ8dvDHk0lF/Q\n eOOjsVc0tjoMUYMfgeud2Unv00A3ZKoRX8/V60=","X-Received":"by 2002:a05:7300:dc06:b0:2d3:f3fc:bb6b with SMTP id\n 5a478bee46e88-2d586381157mr16587771eec.1.1776347573886;\n Thu, 16 Apr 2026 06:52:53 -0700 (PDT)","From":"linuxtestproject.agent@gmail.com","To":"Wei Gao ","Date":"Thu, 16 Apr 2026 13:52:52 +0000","Message-ID":"<20260416135252.3834-1-linuxtestproject.agent@gmail.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260416112611.23057-1-wegao@suse.com>","References":"<20260416112611.23057-1-wegao@suse.com>","MIME-Version":"1.0","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS\n shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-4.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-4.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] fsconfig04: Check FSCONFIG_SET_PATH","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}},{"id":3678198,"web_url":"http://patchwork.ozlabs.org/comment/3678198/","msgid":"<69e0ea48.050a0220.3113a3.2c6c@mx.google.com>","list_archive_url":null,"date":"2026-04-16T13:55:19","subject":"Re: [LTP] fsconfig04: Check FSCONFIG_SET_PATH","submitter":{"id":82886,"url":"http://patchwork.ozlabs.org/api/people/82886/","name":"Andrea Cervesato","email":"andrea.cervesato@suse.com"},"content":"Hi Wei,\n\n> The patch has a `Fixes:` link to GitHub issue #1169, making this a\n> regression test. Add a `.tags` field:\n> \n> \t.tags = (const struct tst_tag[]) {\n> \t\t{\"github\", \"1169\"},\n> \t\t{}\n> \t},\n\nPlease ignore this, I will add a rule so this won't happen, we dont\nwant to have github fixes inside the tst_test struct :-)\n\nRegards,\n--\nAndrea Cervesato\nSUSE QE Automation Engineer Linux\nandrea.cervesato@suse.com","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=lists.linux.it header.i=@lists.linux.it\n header.a=rsa-sha256 header.s=picard header.b=SaTsuhft;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256\n header.s=google header.b=T+itLf+b;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxKKJ72Fmz1yHP\n\tfor ; Thu, 16 Apr 2026 23:55:32 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id C0EBB3E2DEB\n\tfor ; Thu, 16 Apr 2026 15:55:29 +0200 (CEST)","from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [217.194.8.5])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 5B6893C1C92\n for ; Thu, 16 Apr 2026 15:55:26 +0200 (CEST)","from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com\n [IPv6:2a00:1450:4864:20::32b])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-5.smtp.seeweb.it (Postfix) with ESMTPS id 4A3DC600A43\n for ; Thu, 16 Apr 2026 15:55:21 +0200 (CEST)","by mail-wm1-x32b.google.com with SMTP id\n 5b1f17b1804b1-488ba6366a7so96477305e9.0\n for ; Thu, 16 Apr 2026 06:55:21 -0700 (PDT)","from localhost.localdomain ([88.128.90.36])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488f581d8eesm58408085e9.9.2026.04.16.06.55.20\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 16 Apr 2026 06:55:20 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=lists.linux.it;\n i=@lists.linux.it; q=dns/txt; s=picard; t=1776347729; h=message-id :\n to : in-reply-to : date : subject : list-id : list-unsubscribe :\n list-archive : list-post : list-help : list-subscribe : from :\n reply-to : cc : mime-version : content-type :\n content-transfer-encoding : sender : from;\n bh=YvqeNtpBPm9qc3OSfFqse2kZPSzscZfUvg/b/x7dFB4=;\n b=SaTsuhftjA5cgFs2cVYT6Trel6OKiIsvWDm26y0dqK+Tdh0ngcL2L+pUuMebQn/tFlR1n\n 2elXcNPy8pk8DS4wn9g9cODLeJzgqOWLCByRVjIhXBpm90vODW8DFJ3nCuS+Xkdj96//Gqr\n FT2SPl1EVqSRlHo/BelJIG8slXGxwjk=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=suse.com; s=google; t=1776347721; x=1776952521; darn=lists.linux.it;\n h=date:content-transfer-encoding:subject:in-reply-to:cc:to:from\n :message-id:from:to:cc:subject:date:message-id:reply-to;\n bh=vwL83qEngN7e6AD1Mj79n9iCe0N+D5Z/xknt+6rp9xw=;\n b=T+itLf+bth0Vn1JLdSiNEBh4dfWDrJ03eXT2x/qgbGAQKBLaKFUIKuIHVgR2fIRJge\n FaYfB9vapTs4i6Sq73tXNGc75sCJ5HN0COM8HxxIQ88utP0c21vLQCf7LOc49oLBZLzI\n jBFQgXwQ8F22ILMK6h+3TAjLN9pT4243OQg/JACjePivhUMDkVAN8DbsNvxcsPF/z1mf\n zAkiT0dSgUygfluHbWvi4ZEn7R2vQ6MH/CBRd/Isb4UAaPa1n5QFBULSDbuumHdt6umB\n qU2bi5PSZx2OYioCNaRVrn2mkzuTGtF3Y91inA2BYWnCztlg/lfyxfEso1GH+0eB2f05\n Cb/g=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776347721; x=1776952521;\n h=date:content-transfer-encoding:subject:in-reply-to:cc:to:from\n :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=vwL83qEngN7e6AD1Mj79n9iCe0N+D5Z/xknt+6rp9xw=;\n b=g9dn3humMilKGvcktf0BjxZk9oWjBy/JyoA/f/rSgGg0ulGUWeWh04uKjfNx2CETY8\n aRM8ZzK8DNg/wlWKhDxPfGMA4k98Yv5Mo0cgIVQMIc/X5DbyvQNmj4adi15DNdoG/m1A\n bpomGNYa2iGFWTG2DZm4dmFuX8kROYqqcCbl7sQaGY90yP7F3ijf2WoWEwPO028yqcPG\n +F3IuyIPMomQIMCIWowUnpeb9MaKVgot7awll6skWzBbyc3xCiFZEhdUCwa6Ap2Sn0p9\n BmD8ZdJ+wQlVqPudUwwrhRs9KqUFjJ+4hg2JVYrXCcfxqYBQRfwuWT/EhRiTwv7eB4q7\n J1MQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8zjnTeYVK1yXuMSIKWs1tOZ28ceJbTOgWsmiedsEv5VJl26pwZ/ApbFSQMizVKWryGX68=@lists.linux.it","X-Gm-Message-State":"AOJu0YwPCEct9OSCde+Y+zhqO/O4MenaKeugVOhrYijTFCm7CDUKQPq/\n EHZV+soJ2RzfmX9QivEbMdY2aB7cj/ApAbgBTj4AEcgaNbM3kTLm0wVU1mJb0Dbf9/c=","X-Gm-Gg":"AeBDieuRyEITvMk6WXGRf4/D2iQFNMxF1xMd05E1DHh2ueqPttNbc5lm3vxASbl2/rp\n y7fhC5h/J5mo14Rv0VrCUmL+SiveNKTGVCH2ZI8CaLNxvkpXkxNHtZk7rDrW09XHkBsUUNGOHhX\n Kzsd1q2ZedfE4XS7Ktxj6oVXXjpTkwI9rhRgKiUrRE0V6YtIwxEdLDT8C/erxCuUPHxrpj5IQHC\n Kgp9L8S8NovqcVu5M8U6NZ9OoOzKsUCyyonIxiqi8wsIELTnkYa5py3RvQOsYKGvwxUsb7JxTNK\n WjYl2HdSrmTJL7KVEihrzUSj08zrIrz3UUCMpjwtHmwkmMaR0+D2k+eMgL2KbIVtx9f/rG+Syr/\n 3ZiBvHvesl6GzZ6FLGI90RKG/fR47Icvt87um+5pswBVeQFuHG6srV+M4tniKHor3MwpyuSsTGg\n TJs3G0CxG0SWffW3YiaoOcGaWogSClt6aUk6OSb3jNF7359T84spk=","X-Received":"by 2002:a05:600d:9:b0:488:b4e3:aeca with SMTP id\n 5b1f17b1804b1-488d67bf177mr289831615e9.1.1776347720595;\n Thu, 16 Apr 2026 06:55:20 -0700 (PDT)","Message-ID":"<69e0ea48.050a0220.3113a3.2c6c@mx.google.com>","To":"linuxtestproject.agent@gmail.com","In-Reply-To":"<20260416135252.3834-1-linuxtestproject.agent@gmail.com>","Date":"Thu, 16 Apr 2026 13:55:19 +0000","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-5.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-5.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] fsconfig04: Check FSCONFIG_SET_PATH","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Andrea Cervesato via ltp ","Reply-To":"Andrea Cervesato ","Cc":"ltp@lists.linux.it","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]