[{"id":3678411,"web_url":"http://patchwork.ozlabs.org/comment/3678411/","msgid":"<5fb0432b-6c1c-40bc-b022-939d73f2115d@linaro.org>","list_archive_url":null,"date":"2026-04-16T22:36:52","subject":"Re: [PATCH 2/3] target/arm/ptw.c: Add two new spaces to the granule\n protection case","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/16/26 21:12, Jim MacArthur wrote:\n> This makes no functional difference, it just marks out two cases for\n> future use.\n> \n> Signed-off-by: Jim MacArthur \n> ---\n> target/arm/ptw.c | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/target/arm/ptw.c b/target/arm/ptw.c\n> index 7b993bb5b3..d4b63a365a 100644\n> --- a/target/arm/ptw.c\n> +++ b/target/arm/ptw.c\n> @@ -510,6 +510,11 @@ bool arm_granule_protection_check(ARMGranuleProtectionConfig config,\n> break;\n> case 0b1111: /* all access */\n> return true;\n> + case 0b0100: /* system agent only */\n> + case 0b0101: /* non-secure protected */\n> + /* System Agent and Non-secure Protected are GDI extensions. */\n> + /* No processing element should have access to these. */\n> + goto fault_walk;\n> case 0b1000: /* secure */\n> if (!config.support_sel2) {\n> goto fault_walk;\n> \n\nThere's no real point to this patch, since we get the same effect from the default case.\n\nIt should be trivial to \"properly\" implement these two cases for the CPU, since\n\n R_QCLPTA: PE is not permitted to access memory within the NSP\n or the SA PA spaces, from any Security state.\n\nAccess to these spaces is only allowed from external devices via the SMMU.\n\nThe only effect on the PE is to check the various GPCCR fields (SA, NSP, NA6, NA7) to \ntransform them from one type of fault to another: fault_walk -> fault_fail (i.e. break).\n\nThere will have to be some modifications at a later date to actually allow these cases for \nthe SMMU, but at this point none of the SMMU patches to use GPC are upstream. So it's not \nworth worrying about at this time.\n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=vGPGq2Xc;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxXvj70N5z1yCv\n\tfor ; Fri, 17 Apr 2026 08:37:36 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDVKZ-0007Ql-Kx; Thu, 16 Apr 2026 18:37:03 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDVKX-0007QL-ES\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 18:37:01 -0400","from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wDVKV-0002pM-Nz\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 18:37:01 -0400","by mail-pj1-x1034.google.com with SMTP id\n 98e67ed59e1d1-35da9c0c007so92019a91.2\n for ; Thu, 16 Apr 2026 15:36:59 -0700 (PDT)","from ?IPV6:2401:d002:dc0f:2100:a60a:7c34:dd75:e66c?\n ([2401:d002:dc0f:2100:a60a:7c34:dd75:e66c])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b5fa58b49fsm290015ad.51.2026.04.16.15.36.55\n for \n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 16 Apr 2026 15:36:57 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776379018; x=1776983818; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id:from\n :to:cc:subject:date:message-id:reply-to;\n bh=EJiiVFQAGTwr/xgsk5epml8ba8nhOgvN1MNWGGE1Igs=;\n b=vGPGq2Xc1PtwQ9mywQ/eDtNeOytZep8PYuhywLjhdbLqnAVVm25KCGibIWt1rDtQXi\n 6fPLuKVD2zhq0SXMupOgsgnFAiyKD61WIyDB1kE5K+u2wZEnqBCIx6Oxz+dKR8fo9R6j\n RMSIGQIChZLsahJFo2cTt09gqEfPFnrEXgL/ZLY8hZ6MOXFzF+/9nwNIEiN6q7Mno/JJ\n 0ei9Z2pyUC+w4Y2gBRQB764o/DcMZgNdcDmCV4DEKFAuVDvJR9RV1LgpFwFLZSItztQ5\n ynHdEu1foG0kXoedTwpFnt8DaWExfQuDyth+HvRwkcczHnWHTvT05oxPF/8pKXvswGyf\n ZVvw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776379018; x=1776983818;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=EJiiVFQAGTwr/xgsk5epml8ba8nhOgvN1MNWGGE1Igs=;\n b=d5288MHNFMUWmSB1a5sczOkuLZR1wafuEcc0j+qx3xEK698LGxOUyr7vd5xOTyZ+AV\n 23y/6KMDHNExN+m0ubB05ROyVrM/1CRJN/G+rbNyj21OC0KwcLayrEBfDyN8O2JZX5jR\n 8g1dpI+tdkSVnZPb1WhYEYUC1p5DWso8ODhs369Inj2n8EFiUy1YKQU4SS2GqsndVoC3\n ePzdr1FiFu8MkYM8Zla0IjHVM7fbTEExwAIYtOGl7Oe5j4baSNjV7N0S6EI2dMCIqhS1\n LFM1n/JJndWYAlyuj0vCrhfa83YM5iqNbIRM5wdzhN6a8Wo+/Myg9O5d8RsLcwKWHq2E\n 0fLg==","X-Gm-Message-State":"AOJu0YxTkcG2fmrTXeBd4r60njdnY1HeXE5JWwrfPfRaP9282y1lfpMH\n hmtj5K5XJrzh8BFF/TEnwBb/WpPhK+NbckPpG7kjMAffJa55VOIMnEfDEZfvzi5so8eiSgP0FiV\n osT27AU0=","X-Gm-Gg":"AeBDieuv3wix2sc1sOyCYZyd7J01FVwy8rw8z43rgC5RXLfp97JSTwMC+hSIg/JnQXG\n qkHf1tnb4B573m/JXomjgPCqWfpjGWVRZWCCW9xoNm+xDhU4IXF47P1LJJm3hDQ0h1zW2d9QyIl\n UbZwV1DjCRp5HoKfJLV/CcqQ0pJmdMgectyyu0Gbdv1f9r3cxr1VHWOPYA53clioGJXd/N6s+M4\n 6qKFNTH1r1eEi35+l+1q9UdV2PMyhT0hQtouDGenSAErzazPl8WL5zxIa9D7zIWGQiK41AeSnDH\n nUxTEfWcKPqPStzbXa/crMg99A18ZnsnU2tG/X7ZQ9vNhONwb1uZlpR3jBnpBWDnXVV1vwRtehG\n qZMY15uwUXUsyjQrqT2G6uoO7GrowzLsE0y1nuC5WfwTRAvVZyj0N1vloY7rGrD1IuhGN8pW515\n Z86yvnOcGGyoF59YoFz8XVWaQsuy7qSTQQL6IpKabDNk0wUmSYH4HC+DcgQqTO8uhxVRSZ7eck2\n Wsnhjpdu8uyCqkTf6Ypm3AN","X-Received":"by 2002:a17:903:1ac6:b0:2b2:5840:809c with SMTP id\n d9443c01a7336-2b5f9e77d75mr2863505ad.1.1776379017544;\n Thu, 16 Apr 2026 15:36:57 -0700 (PDT)","Message-ID":"<5fb0432b-6c1c-40bc-b022-939d73f2115d@linaro.org>","Date":"Fri, 17 Apr 2026 08:36:52 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 2/3] target/arm/ptw.c: Add two new spaces to the granule\n protection case","To":"qemu-devel@nongnu.org","References":"<20260416-jmac-feat_rme_gdi-v1-0-d9fa0781ed58@linaro.org>\n <20260416-jmac-feat_rme_gdi-v1-2-d9fa0781ed58@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260416-jmac-feat_rme_gdi-v1-2-d9fa0781ed58@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::1034;\n envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1034.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3678621,"web_url":"http://patchwork.ozlabs.org/comment/3678621/","msgid":"","list_archive_url":null,"date":"2026-04-17T09:53:12","subject":"Re: [PATCH 2/3] target/arm/ptw.c: Add two new spaces to the granule\n protection case","submitter":{"id":92076,"url":"http://patchwork.ozlabs.org/api/people/92076/","name":"Jim MacArthur","email":"jim.macarthur@linaro.org"},"content":"On Fri, Apr 17, 2026 at 08:36:52AM +1000, Richard Henderson wrote:\n> On 4/16/26 21:12, Jim MacArthur wrote:\n> > This makes no functional difference, it just marks out two cases for\n> > future use.\n> > \n> > Signed-off-by: Jim MacArthur \n> > ---\n> > target/arm/ptw.c | 5 +++++\n> > 1 file changed, 5 insertions(+)\n> > \n> > diff --git a/target/arm/ptw.c b/target/arm/ptw.c\n> > index 7b993bb5b3..d4b63a365a 100644\n> > --- a/target/arm/ptw.c\n> > +++ b/target/arm/ptw.c\n> > @@ -510,6 +510,11 @@ bool arm_granule_protection_check(ARMGranuleProtectionConfig config,\n> > break;\n> > case 0b1111: /* all access */\n> > return true;\n> > + case 0b0100: /* system agent only */\n> > + case 0b0101: /* non-secure protected */\n> > + /* System Agent and Non-secure Protected are GDI extensions. */\n> > + /* No processing element should have access to these. */\n> > + goto fault_walk;\n> > case 0b1000: /* secure */\n> > if (!config.support_sel2) {\n> > goto fault_walk;\n> > \n> \n> There's no real point to this patch, since we get the same effect from the default case.\n> \n> It should be trivial to \"properly\" implement these two cases for the CPU, since\n> \n> R_QCLPTA: PE is not permitted to access memory within the NSP\n> or the SA PA spaces, from any Security state.\n> \n> Access to these spaces is only allowed from external devices via the SMMU.\n> \n> The only effect on the PE is to check the various GPCCR fields (SA, NSP,\n> NA6, NA7) to transform them from one type of fault to another: fault_walk ->\n> fault_fail (i.e. break).\n\nThe thing that held me back here was the mapping from 'Reserved' in the table in D9.6.5 to fault_walk, which wasn't clear in the documentation, and hence leaving the behaviour unchanged. However, I would agree that we can map (GPCCR.SA=1, gpi=0x0x100) to fault_fail and so on and leave the (SA=0, 0b0100) case to what it would have been before (fault_walk).\n\nThanks for your feedback,\n\nJim","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=bBASfh4X;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxqvj544Yz1yDF\n\tfor ; Fri, 17 Apr 2026 19:53:36 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDft1-00013G-EK; Fri, 17 Apr 2026 05:53:19 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDfsz-00012s-Oz\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 05:53:17 -0400","from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wDfsy-0000iB-0w\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 05:53:17 -0400","by mail-wm1-x32c.google.com with SMTP id\n 5b1f17b1804b1-482f454be5bso15387555e9.0\n for ; Fri, 17 Apr 2026 02:53:15 -0700 (PDT)","from linaro.org ([2a10:d582:31e:0:d023:c0db:d3ea:590d])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fc1c96b4sm52427845e9.13.2026.04.17.02.53.13\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 17 Apr 2026 02:53:13 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776419594; x=1777024394; darn=nongnu.org;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=Sx4whYh0mPRZITS9VYtylGknT7f1uL4QP0rIfJIttHU=;\n b=bBASfh4XgqHPq1REH54/EM5nSj1FhzfkK8BptYMNWCbBvOzOxzRlxr4xfR0lsGBsSG\n /PvM5XyboaeplXSSEG3znMjq37CV5/M+YYAeZ/JVZ5dhCTpKxLph4fw0qVNvwhTEpluC\n EYIIXItXpLddnxB9GNeO3/O+V3C6xEc5o2/nsblSgdPLD42e8QykSwxw5HPpKm2RrUYF\n pg713/5sE8UqlZ5zyG0JGOosH1LcFMxRbzM9Sg3EITQXKKPfGrX97M285B1pazPvVaMj\n AM9v3s41E+8/MK2ALgq4yJ19/0aYeeK11/BSAhbduZPUw0250tZPLc0WAsa+jhcBvP3J\n 2MUw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776419594; x=1777024394;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=Sx4whYh0mPRZITS9VYtylGknT7f1uL4QP0rIfJIttHU=;\n b=sndD2aJhF58Ci4G1SvMdHPQcRdOlJkXUrDxnJOwGoGuSHZbOhtSsYC3hQ/6UrX4GVb\n 6g4mRJnxvAqgDzyc8ywa2Owx3/1HkmieGq8/xeHSwCFassZyQk4KIC45JUJaUs6p/dZj\n zrm1g4kYIybl3khtWRNxWoqtNifh/21ZsUpYAZrubtb+LpfDQCgeViKSBR9+d8QBikae\n R8PXBUf9N/+QFzAur5DRN2liWmwVCTeymLPzON6UcvPFQiEWzfFq8xlLwYM9IFf51FOF\n zDHaDWJIv2JllwIzwxT+wKr9QW0gwwABeNq/kOh7t6UPUuIZqEx6OK/qS0lODI8FB8uK\n k0DQ==","X-Gm-Message-State":"AOJu0YwkR9ZSyjXryGMhLK4xGWBceCRi0DfIkckWDnDljoDTukGNntMN\n iQGQQNOFsZOznw1877TIzJJ7p2HfVonOe8l9zlJkzeWIFKWTxnytLpmBLWRA6rAIxnq5aisTOms\n VaIZu","X-Gm-Gg":"AeBDiet+RFCmh3xq0+H2fOkTGVfIDrlFJ2Ic+RRF4ABCAfhLtCOdrIZLPvIUHeXdrj9\n 5FRZ+buadL7aPoqm0fXCc9FE1qTLaIDgKzptI6I+KjwN9sq///HMuba81Bs/uyXQKUVC7UTLjgX\n ZnJiNOxYlIJVjbZ1952GEb1tBPsI06Q/QOoBssILbW7/YJR+btKpxBjmAl17MuET9YQaMD0jEka\n boqQqJ7bWFaxcgVYrtKlDZqkIS+gRFj+/oPdRV+sVNAVa0qUktypIHAno1DulYGjSXlHyXvTOKo\n yIgI/1F5Pv9aHTgAEOQ3++XsovZonlrlPAzr1+fo8SGhVtBC0ZCwhTtBeZHp/chFZM3Btr9R/se\n rTZ7/mb+mqhVxARnly9wTVD2/LUeM0kUiwtl2jouFMECaRkZHDVVMdxrrwbK3vqm5M1DFEaN4/0\n MKnj6/zVGPpiwfxBTOm+sAus4jUhzHqcWbE/E=","X-Received":"by 2002:a05:600c:6089:b0:487:22ad:403e with SMTP id\n 5b1f17b1804b1-488fb8ba594mr24729015e9.14.1776419593839;\n Fri, 17 Apr 2026 02:53:13 -0700 (PDT)","Date":"Fri, 17 Apr 2026 10:53:12 +0100","From":"Jim MacArthur ","To":"qemu-devel@nongnu.org","Cc":"richard.henderson@linaro.org","Subject":"Re: [PATCH 2/3] target/arm/ptw.c: Add two new spaces to the granule\n protection case","Message-ID":"","References":"<20260416-jmac-feat_rme_gdi-v1-0-d9fa0781ed58@linaro.org>\n <20260416-jmac-feat_rme_gdi-v1-2-d9fa0781ed58@linaro.org>\n <5fb0432b-6c1c-40bc-b022-939d73f2115d@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<5fb0432b-6c1c-40bc-b022-939d73f2115d@linaro.org>","Received-SPF":"pass client-ip=2a00:1450:4864:20::32c;\n envelope-from=jim.macarthur@linaro.org; helo=mail-wm1-x32c.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]