[{"id":3678382,"web_url":"http://patchwork.ozlabs.org/comment/3678382/","msgid":"","list_archive_url":null,"date":"2026-04-16T21:08:54","subject":"Re: [PATCH v1 2/3] board: toradex: add Toradex Verdin iMX95","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Emanuele,\n\nOn 2026-04-16T08:45:22, Emanuele Ghidoli wrote:\n> board: toradex: add Toradex Verdin iMX95\n>\n> Add support for the Toradex Verdin iMX95.\n>\n> Link: https://www.toradex.com/computer-on-modules/verdin-arm-family/nxp-imx95\n> Link: https://www.toradex.com/products/carrier-board/verdin-development-board-kit\n> Signed-off-by: Emanuele Ghidoli \n> Co-developed-by: Ernest Van Hoecke \n> Signed-off-by: Ernest Van Hoecke \n> Co-developed-by: Francesco Dolcini \n> Signed-off-by: Francesco Dolcini \n>\n> arch/arm/dts/imx95-verdin-dev.dtsi | 239 +++++\n> arch/arm/dts/imx95-verdin-wifi-dev-u-boot.dtsi | 112 +++\n> arch/arm/dts/imx95-verdin-wifi-dev.dts | 21 +\n> arch/arm/dts/imx95-verdin-wifi.dtsi | 50 +\n> arch/arm/dts/imx95-verdin.dtsi | 1172 ++++++++++++++++++++++++\n> arch/arm/mach-imx/imx9/Kconfig | 5 +\n> board/toradex/verdin-imx95/Kconfig | 36 +\n> board/toradex/verdin-imx95/MAINTAINERS | 13 +\n> board/toradex/verdin-imx95/Makefile | 8 +\n> board/toradex/verdin-imx95/spl.c | 75 ++\n> board/toradex/verdin-imx95/verdin-imx95.c | 79 ++\n> board/toradex/verdin-imx95/verdin-imx95.env | 20 +\n> configs/verdin-imx95_defconfig | 183 ++++\n> doc/board/toradex/index.rst | 1 +\n> doc/board/toradex/verdin-imx95.rst | 171 ++++\n> include/configs/verdin-imx95.h | 27 +\n> 16 files changed, 2212 insertions(+)\n\n> diff --git a/include/configs/verdin-imx95.h b/include/configs/verdin-imx95.h\n> @@ -0,0 +1,27 @@\n> +/* For 32GB modules: 2GB from 0x80000000..0xffffffff, 30GB above.\n> + * Actual size is determited at runtime.\n\ndetermined\n\n> diff --git a/board/toradex/verdin-imx95/verdin-imx95.c b/board/toradex/verdin-imx95/verdin-imx95.c\n> @@ -0,0 +1,79 @@\n> +const struct ram_alias_check ram_alias_check[] = {\n> + { (void *)(PHYS_SDRAM + SZ_8G), (void *)(PHYS_SDRAM), SZ_16G },\n> + { (void *)(PHYS_SDRAM + SZ_4G), (void *)(PHYS_SDRAM), SZ_8G },\n> + { (void *)(PHYS_SDRAM + SZ_2G), (void *)(PHYS_SDRAM), SZ_4G },\n> + { (void *)(PHYS_SDRAM + SZ_1G), (void *)(PHYS_SDRAM), SZ_2G },\n> + { NULL }\n> +};\n\nHow about ram_alias_checks[] to avoid confusion with the type. Also,\ncan it be static?\n\nReviewed-by: Simon Glass \n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=CqUKEgfs;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"CqUKEgfs\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxVxm6LP2z1yCv\n\tfor ; Fri, 17 Apr 2026 07:09:16 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 75A8C840AB;\n\tThu, 16 Apr 2026 23:09:14 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 4AA2E84214; Thu, 16 Apr 2026 23:09:13 +0200 (CEST)","from mail-pl1-x634.google.com (mail-pl1-x634.google.com\n [IPv6:2607:f8b0:4864:20::634])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id AC6A583FC0\n for ; Thu, 16 Apr 2026 23:09:10 +0200 (CEST)","by mail-pl1-x634.google.com with SMTP id\n d9443c01a7336-2b2ea1b3962so33151985ad.0\n for ; Thu, 16 Apr 2026 14:09:10 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776373749; cv=none;\n d=google.com; s=arc-20240605;\n b=gkuIL3i9I9ZYXHJ7xfav9M+FCHS5Ql5HxnUHVjC5bw+HalK2x6tvDSyt7j5OU+rbvn\n QPsb6jMogb0pEaozZJZB5wf3vDcNf6zJ9lqoKxoVRCA+ohEwEd8+38o2HDkoEgmDBD+V\n URCYbW9QQsZbnZ+1zNR9BIHoouaiHiush2jBmUIl/xN7437e073n2qQjfL+AqvyOSd1C\n qOMFCI+e4wM/Bru2VotZCynNPAvSO0/w4YInCcjOqnA0RLHjCs0DBoSgSqri5TNRE5Xm\n IkJQEGDJkADkJFIIzavnskZu7AlEGKU4k7YFQLbo92u5HFEovecmW++eQJD7o0i2PusQ\n Q8JQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=lpXJaoOet4salwBKU+Xsei1yUHB+jMCTPtfFhFuTNTw=;\n fh=xzHwBz7YVwVTzOkq5RbqDBAwkzxy5sD4Lvb4Det1Qb4=;\n b=KZ6nYOQLqRcPGQurmgj422occItUjjgONMxrhLBxOHfVog5mJMDby66N2p5if3ZGMU\n We5ZjHy7+fL/BrUS3O7V1JNJGDjvAtafMp8kuLTXHFWhS/mydyJbJxkHSG0whZpHGsPg\n SEs0chTnqCUW9TuhCPNxIC1oBoxkAOILVaXLTC4UCpZu7wev9MqDpt5GPd8VYWkf50aE\n R7R0Y5nf3ULoxNVsXHt2QevqLitKbOrNhuYPlXlSJX9AUiyP/GHROAwg2VwCozs+N1r8\n BPQIwsOAmzI7IuzEEyqwi0teEdbpkXXBlQApMQBAzvsTL+fNx1qexWA8OwhnNnEzuMII\n hT6A==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776373749; x=1776978549; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=lpXJaoOet4salwBKU+Xsei1yUHB+jMCTPtfFhFuTNTw=;\n b=CqUKEgfscmnPCJ81Q1xigWM37+7y7hOouTzd0NzATQ+vVt5kwQuENeQQmUNigDAt/n\n oxsfexzvBV0fE9RYPzOK2wAumGfLRxCclDAz/mmyvIKu6fVefewv0/xt4ooxBI52SkWS\n Gk4IOLpvvzVG0ag0ChBZQqcO7zlwWrUrcLT+I=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776373749; x=1776978549;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=lpXJaoOet4salwBKU+Xsei1yUHB+jMCTPtfFhFuTNTw=;\n b=K2jr8FcMS5+wKZZZbUbeO70omaURND8MirzR9erLL6pAvKrncLTlqhtZqFZSgc/y8N\n 1aNNYBcrtGDB9fyRCAoTOYdPHZDQoxQnMR4086EjA35VLvOpZUH8hHptdUssVdUjnjLv\n PwDZCSbLRv2qTaVzb70EM3HhtnQfKOiixN+Ei1BIdudGohuJ5/WmAtS/AyEq8d3RA3xp\n TiY5bzDUEtVSjxKAn0E04FTGn9lIsM8WdabzqilhJQMVsXY2SSQmVqTQwPtFe2AfOPUD\n 51rXIqP7c8IUp/jsf3r/BVUvH/RfXq6fsJMCYMn1NREbGtjmo8OlRuosFXBncJEtd8mp\n Y/Ng==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+IwnGKxxJLZUmD9F18vlS78bKhFPjy1ADV9xekmCYBm5/Dbv9HS6fKw4QDJLgJGXVWjd1bZJ4=@lists.denx.de","X-Gm-Message-State":"AOJu0Yx4Z1RWmhdi+i+hAcSeArkPYQqMAXaBaFysVQt2YaJuz4jPbGPX\n QqwUU/xUQlkMpXrb0SDpm9uYpX4FwSMn15XY20WIM2o34NLxZLv1mujsYT49mVQO5OUqTR4xkNB\n AWEuYZfpLRQe1E8e/xvNcaLWPLXf6iNE3O5sUgEcE","X-Gm-Gg":"AeBDievZ04QrDTKaEVrRIbjg3RE5ABb9WznVKQvnOql2DE2UmzupA+sBUzEcpnw1PTD\n QY4PF+wO+2af/mIaIyuuLoLfDnBAmv/n1XgrwNAGDjKlPJOPmmzEt+Zar9c9sSFYmLcJ7IohBcf\n j8Wv3nRYruVnlWsDHgsKi6oHWvm7190B1CIZBgH99cVPKlCfiB6SA5ceV6YunZgxlMGSMz7+1R9\n SwwMvpccz+kIntiWYxLvGHG8RlW/Kvwwu0S1updhoJZ3yGrjPyPLpJz3Uic2uPG2VGXQXlew4tI\n gsmuQUIoByiRrwYg8OE4","X-Received":"by 2002:a17:902:9001:b0:2b4:5893:3f3c with SMTP id\n d9443c01a7336-2b5f9ef4c3fmr214385ad.13.1776373749036; Thu, 16 Apr 2026\n 14:09:09 -0700 (PDT)","MIME-Version":"1.0","References":"<20260416084535.1490476-1-ghidoliemanuele@gmail.com>\n <20260416084535.1490476-3-ghidoliemanuele@gmail.com>","In-Reply-To":"<20260416084535.1490476-3-ghidoliemanuele@gmail.com>","From":"Simon Glass ","Date":"Fri, 17 Apr 2026 09:08:54 +1200","X-Gm-Features":"AQROBzC8TVxfFHc_OFWuoCBIBbBxoaTtnt9ixTakRwyPwWRkXeoleZWsQ-UmiMc","Message-ID":"\n ","Subject":"Re: [PATCH v1 2/3] board: toradex: add Toradex Verdin iMX95","To":"ghidoliemanuele@gmail.com","Cc":"Tom Rini , Stefano Babic ,\n Fabio Estevam ,\n \"NXP i.MX U-Boot Team\" ,\n Francesco Dolcini ,\n Emanuele Ghidoli , Peng Fan ,\n Alice Guo , Sumit Garg ,\n Simon Glass , u-boot@lists.denx.de,\n Ernest Van Hoecke ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]