[{"id":3678045,"web_url":"http://patchwork.ozlabs.org/comment/3678045/","msgid":"","list_archive_url":null,"date":"2026-04-16T09:23:28","subject":"Re: [Intel-wired-lan] [PATCH net] ixgbe: only access vfinfo and\n mv_list under RCU lock","submitter":{"id":75597,"url":"http://patchwork.ozlabs.org/api/people/75597/","name":"Aleksandr Loktionov","email":"aleksandr.loktionov@intel.com"},"content":"> -----Original Message-----\n> From: Intel-wired-lan On Behalf\n> Of Corinna Vinschen\n> Sent: Thursday, April 16, 2026 10:42 AM\n> To: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org\n> Cc: Vinschen, Corinna \n> Subject: [Intel-wired-lan] [PATCH net] ixgbe: only access vfinfo and\n> mv_list under RCU lock\n> \n> Commit 1e53834ce541d (\"ixgbe: Add locking to prevent panic when\n> setting\n> sriov_numvfs to zero\") added a spinlock to the adapter info. The\n> reason\n> at the time was an observed crash when ixgbe_disable_sriov() freed the\n> adapter->vfinfo array while the interrupt driven function\n> ixgbe_msg_task()\n> was handling VF messages.\n> \n> Recent stability testing turned up another crash, which is very easily\n> reproducible:\n> \n> while true\n> do\n> for numvfs in 5 0\n> do\n> echo $numvfs > /sys/class/net/eth0/device/sriov_numvfs\n> done\n> done\n> \n> This crashed almost always within the first two hundred runs with\n> a NULL pointer deref while running the ixgbe_service_task() workqueue:\n> \n> [ 5052.036491] BUG: kernel NULL pointer dereference, address:\n> 0000000000000258\n> [ 5052.043454] #PF: supervisor read access in kernel mode\n> [ 5052.048594] #PF: error_code(0x0000) - not-present page\n> [ 5052.053734] PGD 0 P4D 0\n> [ 5052.056272] Oops: Oops: 0000 #1 SMP NOPTI\n> [ 5052.060459] CPU: 2 UID: 0 PID: 132253 Comm: kworker/u96:0 Kdump:\n> loaded Not tainted 6.12.0-180.el10.x86_64 #1 PREEMPT(voluntary)\n> [ 5052.072100] Hardware name: Dell Inc. PowerEdge R740/0DY2X0, BIOS\n> 2.12.2 07/09/2021\n> [ 5052.079664] Workqueue: ixgbe ixgbe_service_task [ixgbe]\n> [ 5052.084907] RIP: 0010:ixgbe_update_stats+0x8b1/0xb40 [ixgbe]\n> [ 5052.090585] Code: 21 56 50 49 8b b6 18 26 00 00 4c 01 fe 48 09 46\n> 50 42 8d 34 a5 00 83 00 00 e8 cb 7a ff ff 49 8b b6 18 26 00 00 89 c0\n> 4c 01 fe <48> 3b 86 88 00 00 00 73 18 48 b9 00 00 00 00 01 00 00 00 48\n> 01 4e\n> [ 5052.109331] RSP: 0018:ffffd5f1e8a6bd88 EFLAGS: 00010202\n> [ 5052.114558] RAX: 0000000000000000 RBX: ffff8f49b22b14a0 RCX:\n> 000000000000023c\n> [ 5052.121689] RDX: ffffffff00000000 RSI: 00000000000001d0 RDI:\n> ffff8f49b22b14a0\n> [ 5052.128823] RBP: 000000000000109c R08: 0000000000000000 R09:\n> 0000000000000000\n> [ 5052.135955] R10: 0000000000000000 R11: 0000000000000000 R12:\n> 0000000000000002\n> [ 5052.143086] R13: 0000000000008410 R14: ffff8f49b22b01a0 R15:\n> 00000000000001d0\n> [ 5052.150221] FS: 0000000000000000(0000) GS:ffff8f58bfc80000(0000)\n> knlGS:0000000000000000\n> [ 5052.158307] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033\n> [ 5052.164054] CR2: 0000000000000258 CR3: 0000000bf2624006 CR4:\n> 00000000007726f0\n> [ 5052.171187] PKRU: 55555554\n> [ 5052.173898] Call Trace:\n> [ 5052.176351] \n> [ 5052.178457] ? show_trace_log_lvl+0x1b0/0x2f0\n> [ 5052.182816] ? show_trace_log_lvl+0x1b0/0x2f0\n> [ 5052.187177] ? ixgbe_watchdog_subtask+0x1a1/0x230 [ixgbe]\n> [ 5052.192591] ? __die_body.cold+0x8/0x12\n> [ 5052.196433] ? page_fault_oops+0x148/0x160\n> [ 5052.200532] ? exc_page_fault+0x7f/0x150\n> [ 5052.204458] ? asm_exc_page_fault+0x26/0x30\n> [ 5052.208643] ? ixgbe_update_stats+0x8b1/0xb40 [ixgbe]\n> [ 5052.213714] ? ixgbe_update_stats+0x8a5/0xb40 [ixgbe]\n> [ 5052.218784] ixgbe_watchdog_subtask+0x1a1/0x230 [ixgbe]\n> [ 5052.224026] ixgbe_service_task+0x15a/0x3f0 [ixgbe]\n> [ 5052.228916] process_one_work+0x177/0x330\n> [ 5052.232928] worker_thread+0x256/0x3a0\n> [ 5052.236681] ? __pfx_worker_thread+0x10/0x10\n> [ 5052.240952] kthread+0xfa/0x240\n> [ 5052.244099] ? __pfx_kthread+0x10/0x10\n> [ 5052.247852] ret_from_fork+0x34/0x50\n> [ 5052.251429] ? __pfx_kthread+0x10/0x10\n> [ 5052.255185] ret_from_fork_asm+0x1a/0x30\n> [ 5052.259112] \n> \n> The first simple patch, just adding spinlocking to\n> ixgbe_update_stats()\n> while reading from adapter->vfinfo, did not fix the problem, it just\n> moved it elsewhere: I could now reproduce the same kind of crash in\n> ixgbe_restore_vf_multicasts().\n> \n> But adding more spinlocking doesn't really cut it. One reason is that\n> ixgbe_restore_vf_multicasts() is called from within ixgbe_msg_task()\n> with active spinlock, as well as from outside without locking.\n> \n> Additionally, given that ixgbe_disable_sriov() is the only call\n> changing\n> adapter->vfinfo, and given ixgbe_disable_sriov() is called very\n> seldom compared to other actions in the driver, just adding more\n> spinlocks would unnecessarily occupy the driver with spinning when\n> multiple functions accessing adapter->vfinfo are running in parallel.\n> \n> So this patch drops the spinlock in favor of RCU and uses it\n> throughout\n> the driver.\n> \n> While changing this, it seems prudent to do the same for the\n> adapter->mv_list array, which is allocated and freed at the same time\n> as\n> adapter->vfinfo, albeit there was no crash observed.\n> \n> Fixes: 1e53834ce541d (\"ixgbe: Add locking to prevent panic when\n> setting sriov_numvfs to zero\")\n> Signed-off-by: Corinna Vinschen \n> ---\n> drivers/net/ethernet/intel/ixgbe/ixgbe.h | 7 +-\n> .../net/ethernet/intel/ixgbe/ixgbe_dcb_nl.c | 36 +-\n> .../net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 44 +-\n> .../net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 17 +-\n> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 229 +++++---\n> .../net/ethernet/intel/ixgbe/ixgbe_sriov.c | 547 ++++++++++++-----\n> -\n> 6 files changed, 593 insertions(+), 287 deletions(-)\n> \n> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h\n> b/drivers/net/ethernet/intel/ixgbe/ixgbe.h\n> index 9b8217523fd2..8849b9f42bf6 100644\n> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe.h\n> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe.h\n> @@ -210,6 +210,7 @@ struct vf_stats {\n> };\n> \n> struct vf_data_storage {\n> +\tstruct rcu_head rcu_head;\n> \tstruct pci_dev *vfdev;\n> \tunsigned char vf_mac_addresses[ETH_ALEN];\n> \tu16 vf_mc_hashes[IXGBE_MAX_VF_MC_ENTRIES];\n> @@ -240,6 +241,7 @@ enum ixgbevf_xcast_modes {\n> };\n> \n> struct vf_macvlans {\n> +\tstruct rcu_head rcu_head;\n> \tstruct list_head l;\n> \tint vf;\n> \tbool free;\n> @@ -808,10 +810,10 @@ struct ixgbe_adapter {\n> \t/* SR-IOV */\n> \tDECLARE_BITMAP(active_vfs, IXGBE_MAX_VF_FUNCTIONS);\n> \tunsigned int num_vfs;\n\n...\n\n> \t\tif (!vfdev)\n> \t\t\tcontinue;\n> \t\tpci_read_config_word(vfdev, PCI_STATUS, &status_reg);\n> @@ -9744,17 +9781,23 @@ static int ixgbe_ndo_get_vf_stats(struct\n> net_device *netdev, int vf,\n> \t\t\t\t struct ifla_vf_stats *vf_stats)\n> {\n> \tstruct ixgbe_adapter *adapter = ixgbe_from_netdev(netdev);\n> +\tstruct vf_data_storage *vfinfo;\n> \n> \tif (vf < 0 || vf >= adapter->num_vfs)\n> \t\treturn -EINVAL;\n> \n> -\tvf_stats->rx_packets = adapter->vfinfo[vf].vfstats.gprc;\n> -\tvf_stats->rx_bytes = adapter->vfinfo[vf].vfstats.gorc;\n> -\tvf_stats->tx_packets = adapter->vfinfo[vf].vfstats.gptc;\n> -\tvf_stats->tx_bytes = adapter->vfinfo[vf].vfstats.gotc;\n> -\tvf_stats->multicast = adapter->vfinfo[vf].vfstats.mprc;\n> +\trcu_read_lock();\n> +\tvfinfo = rcu_dereference(adapter->vfinfo);\n> +\tif (vfinfo) {\n> +\t\tvf_stats->rx_packets = vfinfo[vf].vfstats.gprc;\n> +\t\tvf_stats->rx_bytes = vfinfo[vf].vfstats.gorc;\n> +\t\tvf_stats->tx_packets = vfinfo[vf].vfstats.gptc;\n> +\t\tvf_stats->tx_bytes = vfinfo[vf].vfstats.gotc;\n> +\t\tvf_stats->multicast = vfinfo[vf].vfstats.mprc;\n> +\t}\n> +\trcu_read_unlock();\n> \n> -\treturn 0;\n> +\treturn vfinfo ? 0 : -EINVAL;\nBefore it returned always success, but now it will break 'ip link show dev' in short window when SR-IOV is being torn down.\nFor me it looks like UAPI regression.\n\n> }\n> \n> #ifdef CONFIG_IXGBE_DCB\n> @@ -10071,20 +10114,26 @@ static int handle_redirect_action(struct\n> ixgbe_adapter *adapter, int ifindex,\n> {\n> \tstruct ixgbe_ring_feature *vmdq = &adapter-\n> >ring_feature[RING_F_VMDQ];\n> \tunsigned int num_vfs = adapter->num_vfs, vf;\n\n...\n\n> \treturn 0;\n> }\n> --\n> 2.53.0","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=OUJBAas3;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxCHk2Bn8z1yG9\n\tfor ; Thu, 16 Apr 2026 19:23:46 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id B21394072F;\n\tThu, 16 Apr 2026 09:23:44 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 9lwn106uxztY; Thu, 16 Apr 2026 09:23:44 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id E93034084E;\n\tThu, 16 Apr 2026 09:23:43 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id 6B256127\n for ; Thu, 16 Apr 2026 09:23:42 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 5C7CA4084E\n for ; Thu, 16 Apr 2026 09:23:42 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id OCuQtzVCYO96 for ;\n Thu, 16 Apr 2026 09:23:41 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.8])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 7F85E4072F\n for ; Thu, 16 Apr 2026 09:23:41 +0000 (UTC)","from orviesa010.jf.intel.com ([10.64.159.150])\n by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 16 Apr 2026 02:23:40 -0700","from fmsmsx901.amr.corp.intel.com ([10.18.126.90])\n by orviesa010.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 16 Apr 2026 02:23:41 -0700","from FMSMSX902.amr.corp.intel.com (10.18.126.91) by\n fmsmsx901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Thu, 16 Apr 2026 02:23:39 -0700","from fmsedg903.ED.cps.intel.com (10.1.192.145) by\n FMSMSX902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Thu, 16 Apr 2026 02:23:39 -0700","from SA9PR02CU001.outbound.protection.outlook.com (40.93.196.30) by\n edgegateway.intel.com (192.55.55.83) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Thu, 16 Apr 2026 02:23:38 -0700","from IA3PR11MB8986.namprd11.prod.outlook.com (2603:10b6:208:577::21)\n by CY5PR11MB6440.namprd11.prod.outlook.com (2603:10b6:930:33::9) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.20; Thu, 16 Apr\n 2026 09:23:29 +0000","from IA3PR11MB8986.namprd11.prod.outlook.com\n ([fe80::e6f0:6afb:6ef9:ab5c]) by IA3PR11MB8986.namprd11.prod.outlook.com\n ([fe80::e6f0:6afb:6ef9:ab5c%5]) with mapi id 15.20.9818.017; Thu, 16 Apr 2026\n 09:23:28 +0000"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org E93034084E","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 7F85E4072F"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776331424;\n\tbh=jbP2aMUg+8scPFrWREUmcRhVzVUjlFjM4hkUlJeL1DU=;\n\th=From:To:CC:Date:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=OUJBAas3CXONI+4V78cmaQ8SiqZj4dsOj7SUK6I05XrKEXimbx4ZETjQBHxP8BVdg\n\t +uE9X6UmnIsZdKAQT01weX0TdK3O+zhhz8CCFCYct6ZSFwEr/UOTwZfnOU5wl/89mF\n\t Lxc1V1tnmIip8DifPlU0sTyTnDWwGddvOTWKaS08YTr4sZvxkuWfUvqHUgi7Bdm/ug\n\t iN97/krCUuBHSeJFgiAvG/zTN9lVziq3fQcKuOdD7CjSdjWphbIjWFIj3hyr/BAWMa\n\t xr9OcpRB6F2j5V/RLRJZDtfcSY+LE90NGh34TNQtAcEGL2r3fl7YtIzJ7podUEofmB\n\t GJAx6JvWDDj6g==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.8;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 7F85E4072F","X-CSE-ConnectionGUID":["VyfxJangRD2+Q4zbHGBPUQ==","lH1Dgb71Q5KxNceqokr1DA=="],"X-CSE-MsgGUID":["MJTVm/pRQ/6KT2mqMPvHXQ==","tg7RZwMMQ+i04+I77npp8w=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11760\"; a=\"94893123\"","E=Sophos;i=\"6.23,181,1770624000\"; d=\"scan'208\";a=\"94893123\"","E=Sophos;i=\"6.23,181,1770624000\"; d=\"scan'208\";a=\"229849954\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=b0rNTD9U+N5sZFrz+EFwQI/LZq96cTqZjwA0hoqxgOiF+1nsBln17WUBr7FxW9yHVqLKkhCd114rdDUHsGLLIIxUqUCdAN1KWJssAyI+X5P7jErmg/zyo12pU/wfi28MEvdvmnLBj8R6rVoQie6Rlu7MWxwYOtiBFjlkr4Zafbx1c3mlVSIZh+QAU4Ih1aUOs0Y66zEKhb+Za7Zr3gmAIUEe1QZOUZpK8IfePNRL9y7pvyauGs3NdA08KW5s7D08n8GRT1hguDICdGajbsnAlg4SNOgmC6JLAcUAnVSPyOTXgMnFRUnB2DX2tgoZvc5QYODZiJh+hu5SswCmJnM13g==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=jbP2aMUg+8scPFrWREUmcRhVzVUjlFjM4hkUlJeL1DU=;\n b=h9Cs7+PjEAbHEqPJU0NMja3uHA0y+VAINI7zf6/7p9ormkQryE2g7pJIP6ZtVWO/Teza3MmfWIBXqnh5umDWT510OYekR2y4W4GKYe0H493jZsACcDsjBqUZu9cTNfUqlnOqOS3stv3C4lfRpDHHqgXih+bXzt2yxqhyxVRYBp/NQB9L5nqAddhXCLZk2m2NHIZ5jRUDbM9DlQp3YVR2jIID1XNpCHh4FLMIk/f8CRqqTwi+LVblw7cyNBAJNPv6P3C1SCULtvcboz2c3ntrc2L3eXIQpHgkq+5ywVHQNPHQHtdkEp2el/UJ6I4qw9sCNHQPtQNOYEt0ZdB5nmL3GQ==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none","From":"\"Loktionov, Aleksandr\" ","To":"\"Vinschen, Corinna\" ,\n \"intel-wired-lan@lists.osuosl.org\" ,\n \"netdev@vger.kernel.org\" ","CC":"\"Vinschen, Corinna\" ","Thread-Topic":"[Intel-wired-lan] [PATCH net] ixgbe: only access vfinfo and\n mv_list under RCU lock","Thread-Index":"AQHczX0IMdGaNHG3UE6h9Dny5py4rLXhaa2w","Date":"Thu, 16 Apr 2026 09:23:28 +0000","Message-ID":"\n ","References":"<20260416084227.3787828-1-vinschen@redhat.com>","In-Reply-To":"<20260416084227.3787828-1-vinschen@redhat.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-ms-publictraffictype":"Email","x-ms-traffictypediagnostic":"IA3PR11MB8986:EE_|CY5PR11MB6440:EE_","x-ms-office365-filtering-correlation-id":"63f8a3df-5699-4dbd-d052-08de9b99d1f8","x-ld-processed":"46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"BCL:0;\n ARA:13230040|366016|1800799024|376014|38070700021|18002099003|56012099003|22082099003;","x-microsoft-antispam-message-info":"\n 1uI3Gdr7DFKIOgVqDEzachZjVQ/TUAbVVjRRkcrq6RkOj6/r8zXJLQRdVU01hIOKbjWobTM5638S0CsCfuFwpbruxI2zEpW6OelW+R03XnAW18O55ndKzNQWQPhSDiCnbbHUhub2gOljNai7BFjeUamkekSIzrFtpH+cv+puDvscIBF/MR9kA1sQUAxKjTjVkcHG/nBuiTcfT/KNoTl9RCM8/RvAqhECu4efAx3DKPpP/1AbA2lZbg1ZLvYk1vHLWLo0y9mSLTpE8nJZJXyHp7ja9eWhDK4oCgsjl+JQJOcCVlHG98vIzwB4SeoRIt0fqt6GaUE+D3gkqMmmoG5aqUxHtIicsaGEAJIY+DdPlreLTkMM5nIAc80Qr1LuqwShUYPsXV+qc0+HLGfVdSOVedMoIwjlTO6lps0qxans+4fJwrggbllcleojjK5zQe30LbQSYeJwaSGifm2wYC5VXB/xRfPWctdkfcF+SIOIYF+98LNfwXqpP0pflGe/X3ZRVG8IsEdqGslTNZdqe21bMkpxG05VeskxwpP3oa6g6czxhkkQtibUQEJm7dBRwpL7T/GT6bJCEPeL5uOGre+MikdaMcf1E6k1ofr4q85ADzAkSvpIPt+TVLpnScnc7by4XNHJ457dIKgaivSJwHFazLWhZDk9FQhsTm0huKyvd0PKLAtfSMoSGW195adMuA9ds5LRtkzcz2hL4yJbcUPVGEikcDAG7W475G63xAC+mQwvIYsiAi8JMgm1AVcpPyzRRy4G647P870naqHaiXRRnqTy8ptm7ZDB3Il76LI1sf0=","x-forefront-antispam-report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:IA3PR11MB8986.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(366016)(1800799024)(376014)(38070700021)(18002099003)(56012099003)(22082099003);\n DIR:OUT; SFP:1101;","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"\n HG/Ki47mpeegapdl+zYac6Jgt99x1OM/+DZqlIza6/CnRcE3jvJOVwZS0HLX797pZ6TkGJCQwPHu6dxrHFehe689VWAqI94M60Jrt6Tg1VhOX6x1jtKFA3hv0WQK2fx3usJao1T9RUPGBgHDtPBL3twZ7HjnDa8UM5gLo2StuGfxOp7Sk/2w7lCz2hValFnrxTF+qHsfhk1UJobCRl3QA2ELdaunvieQfIS2py32JlUe+zTVCfqkg3vikK00XKe1eVvZcCoxlSsqHAEyT//LA5784te/1NoicL+nIXsQkgfv8sfnmbnegoFH85xEu9QBZZyLqYDbetAr4H7Hb6x8eTp27woMH6wMkqtnPNQMwsedN4QZtBrOvKpUHb3c5PhNFJJWDZCJLmrlV0Dy+H7/yyhEYMaWKqHH/mdpqk42PKNDdeaGUxBECR9NR0gOmKb9SbdE2HgX47ZD7zNw5RmQwPhwXmbpKpa+Z1q1xkfM6uExZonZHFqBqI4q17gAlBHv8SaYb/7x1DVQOmBR8rBMA+iOtpWMKwqY6YAaBFoevwtJuEelpmFURW5H4ByE1FR6MiwIdat8dabNkD3ogYbFuzdWS3E8D5QJtJkGDHPdztMas0NkhKpEyrD12B01cLR+vIicD8aeQDzm/Fmy7jFAfQZlZfbngRqYbWStLUWPvomTettk8y2ASTZLsfMi62VwmXhkWuWYLhmneTGPZnur1v7F/6hAPp5WxQBor1SfBCuT2AmArjg3f670E3asS1WwCerlG01I+X50Uh9o6+XWI6N5SWPobCm6/kGwO3lkc39nRv0wUSoUtQydXHd5/yoPSUOGfU2KEBFVMlweoFs0CDZh5btvSTYYS/vpeGaWCekBvLBCo+JvE1Y+8rm0+IM4wgdLL3LHjszKp7dPPNyLtYONoBNxU2lChlSiLQN9gh6Js+2rVnCJiq5vhWw0i/A2fscZvvV3SkRQ3phH9GlU4IbiZrG9PmJMSFW4rWSewbwrJEzCYaald0yupwH0LURmefqWudZmlXT7Z8zcw2iEY7URSFI1GZQn/Aaw2F+3NTB/Zo2mLz4evib0RVFp4KFuF8Zkevgv6XNs5ndpOcdl67QutUvWOoh0BNhwlKYMn+TQ0ofEAVz16Y2kRrH2WrCgtBeC7WUJhTwXJcLJ3TGAvQ4Z119IYnFZyvROtPpxSsGXNRa6FQTGCGjGIO++jzoEKsrUH1Ec/V1Q5E09YBeCSAPgHoVW3N6SKT4oEnPpwBTbnziMaPkU5I6fSK3MYs4zeJLdR5R3dXjKtd6QlKtNjsb/X0zWzBk/K2N1LedN6g7106DVLnlJqlVFohnjeV8W+Cd6qj7LJU7y5Z2yeIyGZ+5HnhX5NeKZ3FTV7XG2LZK4kdQNTiqCrMHsKAeovy3lUVYoADa5TajrsiwePxvFCHrsgvniiLWb3t+yjAdW7GyuCXTcUYu51vadg017T/wq0l9vtDzgCDoVhGqVtyVoGlopS0tcCI8lGAS4fJ9Am20QxaWVTI6h9A5a4x36zXk6xMk0lajDp0MdARfPg4tu35wAWtHvTXH9rEGnuXoSb1ifwtd1wyCAx5o1+cKONfy74m89N2AKRHkqPTUpntC1TrDAcRk7ZlV4a/WVdBvXjEDmdKZJvQm2PA6W23fyuAWD1933O1tT+0b92KV7YbFzCnGOC7VHLIRhkvfHBkT7CrllQVE9syyQ1EufayK4YKKdRpCPkEtZCu3jf8Inq7OuhjhGnlQXsSa+rx9MK8mlEQg=","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-Exchange-RoutingPolicyChecked":"\n DF7+27gisMuOdtnBMq877EweuSs8UFNXT5BvCvQAE3z5NNklbCoBfGRUE7vhRK1VdJacoPD87XQpXNp9GamTThS/pMQuoXP6BxSH898OBCGmmg4Bc/qFUeLjEtOqvOwwzXtfelDnWlikck85zkdw9rsJYUwsvLU/dw6clXCeHyqQuFQWs3NMFM+qkOS3DonjdhMT7bpvjNCz50rl27IQ3azl2xoqKzAvi8AAlMYXITC1U2ZvWruAOk337ya1NqIyE8/uAzpMf7yT3IqsBDnM+Bb48WZeDXLQEIpP15kDN7PMYpzgXX29mBaDwLoh60F5F+jQlY6vM/r7j1VzJgTDsg==","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"IA3PR11MB8986.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 63f8a3df-5699-4dbd-d052-08de9b99d1f8","X-MS-Exchange-CrossTenant-originalarrivaltime":"16 Apr 2026 09:23:28.8007 (UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"\n OzbWen8+PbQZNHlOyDke+DSxb9Tr9nJqMY1CAC1Zp2lCaVSs6Shuvz0RAhEH49wjj1rE34bKzgOK8AYP8ZNO8VHvJWcFEPrrfw0wqLWNTwM=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"CY5PR11MB6440","X-OriginatorOrg":"intel.com","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776331421; x=1807867421;\n h=from:to:cc:subject:date:message-id:references:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=lmLV7CPCY46ETDT6PXNZnJZBEaH6CjRMdUVLNjmKlLk=;\n b=UVMsrqOoPAoxLPoARyLE3fJOiJCK+NJQQ2gu7Dl5M/DSlvbbMozrflz8\n 3J194fB+v6bZXkwdmE7pE8HGtflp+nQI0sIFSiRYwKFWHoxFnUPGpqadb\n UPnFPSIgNalw8/GmHpxdg2EIB6Dq26lY00McyPcf5P/cR1Ahu2JRJ3L5K\n L3CteQMnFKb908OVKGvD56UKn6/Asmv6Ugz/SOOoeD6zaffCPCjM+EjqT\n n4ns9Heiezkw912w0INTaZYPQ9j1LeZDq5+1cKLtVIgdf9+XykSGTqvA7\n 8lfAiIbtElGgBmEd32f2KlEFKKFx5rngiLGQrHAoTfuN71E/QdxIZf0M+\n Q==;","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=UVMsrqOo","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Subject":"Re: [Intel-wired-lan] [PATCH net] ixgbe: only access vfinfo and\n mv_list under RCU lock","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3678086,"web_url":"http://patchwork.ozlabs.org/comment/3678086/","msgid":"","list_archive_url":null,"date":"2026-04-16T10:42:07","subject":"Re: [Intel-wired-lan] [PATCH net] ixgbe: only access vfinfo and\n mv_list under RCU lock","submitter":{"id":7921,"url":"http://patchwork.ozlabs.org/api/people/7921/","name":"Corinna Vinschen","email":"vinschen@redhat.com"},"content":"On Apr 16 09:23, Loktionov, Aleksandr wrote:\n> > From: Intel-wired-lan On Behalf\n> > [...]\n> > @@ -9744,17 +9781,23 @@ static int ixgbe_ndo_get_vf_stats(struct\n> > net_device *netdev, int vf,\n> > \t\t\t\t struct ifla_vf_stats *vf_stats)\n> > {\n> > \tstruct ixgbe_adapter *adapter = ixgbe_from_netdev(netdev);\n> > +\tstruct vf_data_storage *vfinfo;\n> > \n> > \tif (vf < 0 || vf >= adapter->num_vfs)\n> > \t\treturn -EINVAL;\n> > \n> > -\tvf_stats->rx_packets = adapter->vfinfo[vf].vfstats.gprc;\n> > -\tvf_stats->rx_bytes = adapter->vfinfo[vf].vfstats.gorc;\n> > -\tvf_stats->tx_packets = adapter->vfinfo[vf].vfstats.gptc;\n> > -\tvf_stats->tx_bytes = adapter->vfinfo[vf].vfstats.gotc;\n> > -\tvf_stats->multicast = adapter->vfinfo[vf].vfstats.mprc;\n> > +\trcu_read_lock();\n> > +\tvfinfo = rcu_dereference(adapter->vfinfo);\n> > +\tif (vfinfo) {\n> > +\t\tvf_stats->rx_packets = vfinfo[vf].vfstats.gprc;\n> > +\t\tvf_stats->rx_bytes = vfinfo[vf].vfstats.gorc;\n> > +\t\tvf_stats->tx_packets = vfinfo[vf].vfstats.gptc;\n> > +\t\tvf_stats->tx_bytes = vfinfo[vf].vfstats.gotc;\n> > +\t\tvf_stats->multicast = vfinfo[vf].vfstats.mprc;\n> > +\t}\n> > +\trcu_read_unlock();\n> > \n> > -\treturn 0;\n> > +\treturn vfinfo ? 0 : -EINVAL;\n> Before it returned always success, but now it will break 'ip link show dev' in short window when SR-IOV is being torn down.\n> For me it looks like UAPI regression.\n\nGood point. I'll change that back for a v2, just waiting for more\nfeedback.\n\n\nThanks,\nCorinna","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=DBfIj+o4;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxF2N5cNLz1yCv\n\tfor ; Thu, 16 Apr 2026 20:42:20 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id E69654085E;\n\tThu, 16 Apr 2026 10:42:17 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id lylIAcF5RglF; Thu, 16 Apr 2026 10:42:17 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 712AC40863;\n\tThu, 16 Apr 2026 10:42:17 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n by lists1.osuosl.org (Postfix) with ESMTP id 7F714127\n for ; Thu, 16 Apr 2026 10:42:16 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 70AA26070D\n for ; Thu, 16 Apr 2026 10:42:16 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Si3wq2nk9g7A for ;\n Thu, 16 Apr 2026 10:42:15 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 6683B606F0\n for ; Thu, 16 Apr 2026 10:42:14 +0000 (UTC)","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-642--14bVJQ7OcKPn3bjhwmcBw-1; Thu,\n 16 Apr 2026 06:42:11 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 4F8CF1955F0E; Thu, 16 Apr 2026 10:42:10 +0000 (UTC)","from calimero.vinschen.de (unknown [10.44.32.30])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id 05B1A19560B6; Thu, 16 Apr 2026 10:42:10 +0000 (UTC)","by calimero.vinschen.de (Postfix, from userid 500)\n id 70801A80D59; Thu, 16 Apr 2026 12:42:07 +0200 (CEST)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 712AC40863","OpenDKIM Filter v2.11.0 smtp3.osuosl.org 6683B606F0"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776336137;\n\tbh=YcHRMn2MX9rE+OcZPrjtF6d4B4T1aBhGiFRSbBkCQVE=;\n\th=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=DBfIj+o4v1ZOTQwC2sDH2L5IbM/UBdcud6orSsDJ0m9T5VP53zyKt7FHL4sPAgW50\n\t ue3++eN34NBleer2DLaStGCukcr8DPSj7e94JglatI7l1qkPMTc9CDM2AFJt7yo2+U\n\t QlHKfPGukk0j2uZkFoU/z6pMXcym8NOq2xdl9ygCghYOAc+TsYQA9c9QWtSHAIUCoz\n\t Y6x8iPYDMd86YBt5LxWPgQF4EpQkU/aGkQpBquJAZE5gU1vfJb+Csme+UQQL9j+Tm/\n\t kOGfBO1LqXT1OGd7YnfhwOPJrBLCleN700jEoby0g141eI7icjjEhyxQFd2gxHe5D2\n\t T8Djw2hlkaj0g==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.133.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=vinschen@redhat.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org 6683B606F0","X-MC-Unique":"-14bVJQ7OcKPn3bjhwmcBw-1","X-Mimecast-MFC-AGG-ID":"-14bVJQ7OcKPn3bjhwmcBw_1776336130","Date":"Thu, 16 Apr 2026 12:42:07 +0200","From":"Corinna Vinschen ","To":"\"Loktionov, Aleksandr\" ","Cc":"\"intel-wired-lan@lists.osuosl.org\" ,\n \"netdev@vger.kernel.org\" ,\n Corinna Vinschen ","Message-ID":"","Mail-Followup-To":"\"Loktionov, Aleksandr\" ,\n \"intel-wired-lan@lists.osuosl.org\" ,\n \"netdev@vger.kernel.org\" ","References":"<20260416084227.3787828-1-vinschen@redhat.com>\n ","MIME-Version":"1.0","In-Reply-To":"\n ","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","X-Mimecast-MFC-PROC-ID":"r7jWl5YpWjWJgu-mtREmnMc02IZrTJVuWvQHQeYC7DE_1776336130","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com;\n s=mimecast20190719; t=1776336133;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=YcHRMn2MX9rE+OcZPrjtF6d4B4T1aBhGiFRSbBkCQVE=;\n b=GSPL9eLt2ZlEdFRa0hKgogDiRP0xMVE0oFVbkzvPTyC3lJ8Dvoayt/21T0Hcz3eyOe+ABn\n tk2OR6jvX3FhGkw/YvSHG166o5LrEvsreQNSevGl8tbJE1qzGVRR+M5uwkWOy05O53UKyQ\n qZvFlq7SulO2r7ecmFUkw20A0Og5NK8=","X-Mailman-Original-Authentication-Results":["smtp3.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","smtp3.osuosl.org;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.a=rsa-sha256 header.s=mimecast20190719 header.b=GSPL9eLt"],"Subject":"Re: [Intel-wired-lan] [PATCH net] ixgbe: only access vfinfo and\n mv_list under RCU lock","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]